- 25 Sep, 2020 40 commits
-
-
Makoto Shimazu authored
Bug: 1129850 Change-Id: I1b1f7dbaa2f63fa7797cf9637a828e5379b7e39d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428302 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#810501}
-
My Nguyen authored
There is a bug in caching logic as since this file is evaluated before OWNERS file in os_settings_strings_grdp folder, thus presubmit failed. Making regex strings more specific to only apply to .grdp files. This doesn't affect other settings strings folders because they all have their OWNERS file. Bug: 1131197 Change-Id: I81abecaf2600756de12ed847fa8be5325c16d36c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430525Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810500}
-
Nidhi Jaju authored
The service worker codebase currently uses a lot of GURLs for origins. However, url::Origin should be used for origin instead of GURL where possible due to security decisions. This CL changes ServiceWorkerContextWrapper:: StopAllServiceWorkersForOrigin to use url::Origin instead of GURL. Some relevant callsites have also been modified accordingly. Bug: 1095896 Change-Id: I8571beeb38dc0dedc944e73521475bb518c8b9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410066Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com> Cr-Commit-Position: refs/heads/master@{#810499}
-
Kent Tamura authored
This CL fixes the following error: > ERROR at //third_party/blink/renderer/bindings/core/v8/serialization/serialized_script_value_fuzzer.cc:20:11: Can't include this header from here. > #include "third_party/blink/renderer/core/testing/dummy_page_holder.h" > ^---------------------------------------------------------- > The target: > //third_party/blink/renderer/bindings/core/v8:v8_serialized_script_value_fuzzer > is including a file from the target: > //third_party/blink/renderer/core:testing This CL has no behavior changes. Bug: 800764 Change-Id: I3a28e57876b52fba53a931c1b0bd0eaef99a0213 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428514 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#810498}
-
Keren Zhu authored
Bug: 772945 Change-Id: Ibfcd4c6fb74f39e95a5892573a30ff6ea9e200b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429534 Commit-Queue: Keren Zhu <kerenzhu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#810497}
-
Lei Zhang authored
Per base/containers/README.md, base::flat_map is a better choice for a small, fixed map. Change-Id: I9a64ce59aadcfc26d7f986030f1732507009cf96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427550 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Piotr Pawliczek <pawliczek@chromium.org> Cr-Commit-Position: refs/heads/master@{#810496}
-
Thanh Nguyen authored
This CL adds suggested content toggle for dinner for one. Bug: 1028373 Change-Id: Iafae0bceaaecfd72dec37f983b18a35f06b5fcb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426215 Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Rachel Wong <wrong@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#810495}
-
Darren Shen authored
As mentioned in: https://developers.google.com/closure/compiler/docs/limitations#implications-of-object-property-flattening 'this' should not be used outside of the constructor or prototype methods. Using 'this' in a static method will break under the --collapse_properties flag in Closure. --collapse_properties is a recommended flag in google3, hence fixing this makes it easier to use mojo lite bindings in google3. Bug: 1132142 Change-Id: I046615009d76f919cab6569285e9dfba6922b98e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428269Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#810494}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/4dcc12d1a441..bacaef3237c5 2020-09-25 greg@lunarg.com Update spirv-tools and spirv-headers known goods (#2401) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC syoussefi@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: syoussefi@google.com,radial-bots+chrome-roll@google.com Change-Id: Ic7998f6df4c3cf6e5edeb262ea501741543bd471 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430235Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810493}
-
Darren Shen authored
When the system PK feature flag is enabled, NativeInputMethodEngine will connect to the IME service. NativeInputMethodEngine is itself a Receiver that receives Mojo calls from the IME service. The IME service frequently calls ProcessMessage on the Mojo interface, but NativeInputMethodEngine doesn't handle it on purpose (ProcessMessage is only used by the IME extension). However, NativeInputMethodEngine:: ProcessMessage must invoke the callback, or else the connection will drop [1]. Hence, NativeInputMethodEngine::ProcessMessage should ignore all messages but still run the callback to avoid dropping the connection. [1] https://source.chromium.org/chromium/chromium/src/+/master:mojo/public/cpp/bindings/tests/receiver_callback_unittest.cc;l=292;drc=9c82b0a2f6742e35cb0368ba61568ce0522dd1ec Bug: 1019541 Change-Id: Ie66c32fde279c441513d99607db2f54c2fd4ef51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410102Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#810492}
-
Alex Keng authored
When TextFormatUpdate event was first introduced [1], ImeTextSpan was incomplete and we had to map underline thickness to underline style (which was incorrect). Now we have an updated ImeTextSpan [2], we can introduce new attributes, textColor and underlineThickness and correctly return the format info. Note textUnderlineStyle is renamed to underlineStyle for clarity, and textDecorationColor is renamed to suggestionHighlightColor since the value is mapped from ui::ImeTextSpan::suggestion_highlight_color [1] https://chromium-review.googlesource.com/c/chromium/src/+/1864318 [2] https://source.chromium.org/chromium/chromium/src/+/master:ui/base/ime/ime_text_span.h;l=18;dlc=65548a4764183b6d99b89678d592d49fe3038da5;bpv=1;bpt=0;drc=59cb62c60b608c5aba49542cd59ea95742f2f305 Change-Id: Ib0169931cad2c153565039370ab89b3d8d0b8d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425430 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#810491}
-
Andrew Comminos authored
Updates the API for isInputPending and associated tests to accept a dictionary object for parameterization directly, making it compliant with the updated spec. Bug: 910421 Change-Id: I39e569ee6215044a9b59a8834d19cac76915cb9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425138Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andrew Comminos <acomminos@fb.com> Cr-Commit-Position: refs/heads/master@{#810490}
-
Victor Costan authored
Bug: 1123353 Change-Id: I2e9f30e3b847d4c3592f40fae2053a8434b248df Tested: Manually, by making IsObsoleteCpu() always return true. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427631 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810489}
-
Charlene Yan authored
Add an enum for the origin of the toggle action. Add collapse for gestures. Modify closing mode to be on a timer for gestures. Bug: 2386555 Change-Id: I308a8e88c1c6b27e03be0783489d5c44686184a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429445 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Connie Wan <connily@chromium.org> Cr-Commit-Position: refs/heads/master@{#810488}
-
Wei Lee authored
Currently only Worker (DedicatedWorker) works on SWA but not SharedWorker since it will hit unknown scheme error due to its scheme (chrome://). The reason is that currently we don't put an WebUIUrlLoaderFactory when creating factory bundle in WorkerScriptFetchInitiator so it will try to fetch scripts with "chrome://" scheme through internet, and causes the unknown scheme error. Bug: 980846, 1127464 Test: Chrome camera app (SWA version) can use SharedWorker Change-Id: Ia57a18d75963fb3395a37d2ed3c70d21e7964282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406234 Commit-Queue: Wei Lee <wtlee@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
-
Eric Willigers authored
GetAppIdForTab() for BMO now returns nullopt if a web app is configured to open in a window, and a browser tab has a URL in the app's scope open. This matches existing behavior for bookmark apps. ShelfWebAppBrowserTest.WindowedHostedAndWebApps/WebApps was previously failing. (The test installs a web app configured to open in a tab by default. It navigates to launch the app URL in a tab and asserts the shelf status indicates the app is closed. This assert previously failed for BMO. The test then calls ActivateAppAndFlushMojoCallsForAppService and asserts there is an extra browser and the app is running. That assert also previously failed for BMO.) Bug: 1054116 Change-Id: I2a5cbb64b193874442deb093ecbbb1f2c7d6ead3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428293Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#810486}
-
Victor Fei authored
AXEventGenerator::Iterator iterates over the generated events in std::map<AXNode*, std::set<EventParams>> tree_events_. Often there could be entry with empty event sets (std::set<EventParams) in |tree_events_|, and if these empty event sets happen to be the first entry when we iterate over |tree_events_|, AXEventGenerator::Iterator ::operator++ would increment AXEventGenerator::Iterator::set_iter_ past its end, causing an exception. This CL fixes this issue by making AXEventGenerator::Iterator ::begin() to always point to a non-empty std::set<EventParams> entry in |tree_events_|. AX-Relnotes: n/a Bug: 1120281 Change-Id: I8fbdbbc92eb007d3ce01bfa5cb61730c9f38c115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399560 Commit-Queue: Victor Fei <vicfei@microsoft.com> Reviewed-by:
Ian Prest <iapres@microsoft.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#810485}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1600905490-fe209194e056a39e0ecce0cfbf9501bffc967720.profdata to chrome-win32-master-1600991906-65f7bfb49ebbe3e14bdc8eed995291d523852457.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ie71a5c46ac85a2f5f9b24b115ecfd6e0ac4a775e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430351Reviewed-by:
-
minch authored
Call sites of UnifiedSystemTrayView::CreateBackground have been removed at crrev.com/c/2015577. The background of system tray now is controlled inside TrayBubbleView by UnifiedSystemTrayView::GetBackgroundColor(). SwitchAccessBackButtonView doesn't inherit from TrayBubbleView, it should not use the related logic. And its color is actually controlled inside SwitchAccessBackButtonView::OnPaint. Bug: 1107056 Change-Id: I13a8ac764fa6fbaa1dede9bdc7b3f6fedfe95b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430323Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#810483}
-
chrome://flagsAnastasia Helfinstein authored
Also removes unused constants from previously removed flag enable-experimental-accessibility-switch-access. AX-Relnotes: n/a. Bug: None Change-Id: I5ee5aacf2f178c1e620e1c56c82e23349ee4da04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425343 Auto-Submit: Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#810482}
-
Roman Sorokin authored
This CL is a quick-fix for the ephemeral use-case. known_user does not persist the data for the ephemeral user. As a result on the lock screen users can't get their last login input method. Change-Id: I0722c741906ecfd35cb031ca6db337c3302e1b3d Bug: 1092884 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429067 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Auto-Submit: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#810481}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3eb2555a627b..c39ab997ba7a 2020-09-24 sokcevic@google.com Support main as default branch If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Id8eb940b19c37eec31ace1ca91c2739d247fe052 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429653Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68a5baeb5ba0..d59bccb5df72 2020-09-24 cclao@google.com Vulkan: updateRenderPassDesc may lose color attachment data 2020-09-24 jmadill@chromium.org Skip PBO test on TSAN. 2020-09-24 courtneygo@google.com Vulkan: Add mutex around queueSubmit related data 2020-09-24 jmadill@chromium.org Revert "Pass #pragma optimize setting down to compilation." 2020-09-24 sdefresne@chromium.org Explicitly filter assignments to sources variable If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1018739 Tbr: syoussefi@google.com Test: Test: Change-Id: I7d648d7e839a33400650efad3677ec784cf98a11 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430346Reviewed-by:
-
Peter Kotwicz authored
This CL removes the following targets: com.android.support:appcompat-v7 com.android.support:gridlayout-v7 com.android.support:mediarouter-v7 com.android.support:recyclerview-v7 com.android.support:cardview-v7 com.android.support:preference-v7 com.android.support:support-v13 com.android.support:preference-leanback-v17 com.android.support:support-annotations com.android.support:design BUG=None Change-Id: Ib18eddd8e5341150057127ad215a6fe3cc66e2ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425010 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#810478}
-
Lei Zhang authored
Use a raw array instead of a std::vector for a constant, so it can be constexpr and no longer has a static destructor. Change-Id: I05fac4e8ce88cdebd63cebc5a9e25ee99ada1082 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429611Reviewed-by:
Michael Spang <spang@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810477}
-
Charlene Yan authored
Bug: 1071685 Change-Id: I1d948dc47b416a01e9a4fc88d167dc69fca42143 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429248Reviewed-by:
-
Charles Zhao authored
LogAndMaybeSortLifecycleUnitWithTabRanker is not used and will not be used in any time soon. So remove it from TabManagerDelegate for now. Bug: 1131349 Change-Id: I614336b9ddfe4758d1a364a39195070dde237a79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423800Reviewed-by:
Charles . <charleszhao@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Charles . <charleszhao@chromium.org> Cr-Commit-Position: refs/heads/master@{#810475}
-
Meilin Wang authored
Bug:none. Change-Id: I6603e5f9b23d6175c3887f8f46351905e6f209a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430292Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#810474}
-
My Nguyen authored
Original UX plan is to remove this confusing option, but we don't have concrete data on its usage so we are adding this browser option in while waiting for concrete data to make a decision. UX point: http://go/cros-lang-settings-ux-slide#slide=11 Screenshot view: http://screen/BRqvnUwfPcZFyKS Bug: 1113439 Change-Id: I2c3d3e85558213f9e183045c8cd393d4e1e685c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428287Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#810473}
-
Charlene Yan authored
This weight is not yet supported on flex layout. Change-Id: I1feedb55eece8fa7b7a7d5a92d06021f051d2aaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429648 Auto-Submit: Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#810472}
-
Hidehiko Abe authored
Currently is_linux is set to true on Chrome OS build, but it is planned to set it false. This is the preparation to keep the current behavior for dav1d. BUG=1131947, 1110266 TEST=Built locally. Change-Id: I0e93a3d98f3587ea40ed704dfe87019e19b8e327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428265 Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Auto-Submit: Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#810471}
-
Mason Freed authored
Better for layout. Bug: 1131185 Change-Id: Icdbdab4906bd27afd30b0602f608939272e75aa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424980 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600970122-55543164fcb4253994646347c53b84b49193c16a.profdata to chrome-linux-master-1600991906-4a92707280f1746bc65f64969bacfc1c677580e0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I3ad40563709dca3ce45af444ee32613db89a01a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430237Reviewed-by:
-
Daniel Classon authored
Adds a string for "Copy build details" and loads that setting in the About page's search concepts. Bug: 1116553 Change-Id: Ib75e1c809fe146554a57a7a1a6dc9bf42ee6dce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429311Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1600981042-72ca27b946abaa6539d1e0700f216205b0fe946d.profdata to chrome-win64-master-1600991906-91a7adfbdc345922f7abfd948645ae0f618ee88b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I495883116dbc7d8f04f1d5918b4f4f0e04c99e81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430236Reviewed-by:
-
Sam McNally authored
BUG=b:160854398 Change-Id: Ie75213a865d608835f93506c7f2b21c264880bde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2417670Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#810466}
-
Mei Liang authored
This CL updates the two acquired thumbnail aspect ratio usages to use the cached value. Both of the usages has been gated by TabUiFeatureUtilities#isTabThumbnailAspectRatioNotOne which is already using the cached valued. Note: this CL is split from crrev.com/c/2427345 Change-Id: Ida6f5e1a4785896f4b9dd47ae81d4f2f74f92301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427149 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810465}
-
Andrey Kosyakov authored
This deprecates two of the three "boolean success" fields in the protocol. The errors are indicated through standard protocol means, in case the method returns a non-error result, success is always set to true. Change-Id: Iada79f5c50d08112a996dad192e1c3cfc86fe6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425305 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#810464}
-
Adam Rice authored
There was a race condition in the network service where if a disconnect on the writing or reading data pipes was detected before the disconnect on the mojo interfaces it would fail to send a close frame. To fix, stop resetting the connection when the data pipes are closed. Re-enable the SendCloseFrameWhenTabIsClosed browser test. It should no longer be flaky, and it's the only test we have for this behaviour. Also modify the SendCloseFrameWhenTabIsClosed test to no longer timeout on failure. BUG=1123349 Change-Id: Ib4aaa46cb1f9f97e09509f59ef421228d02c941d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398036 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#810463}
-
Bo Majewski authored
Part 2 of 2: Clean up mojo bound and call flow. reset() the pdf_thumbnailer_ when the server replies with a Bitmap to make the code robust to server errors (ignore disconnects) during post-processing of the Bitmap. Bug: 1129607 No-try: true Change-Id: I7dbbdecc667116c4d2a56e630b9f54162fb47279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426628 Commit-Queue: Bo Majewski <majewski@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#810462}
-
