- 06 Apr, 2020 40 commits
-
-
chrome://termsRoman Sorokin authored
To show "Google Chrome and Chrome OS Additional Terms of Service" Bug: 1058348 Change-Id: I1b37825fe6970bbc7cc59f0c1b26041e350c8fa4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132419Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756677}
-
Dominik Röttsches authored
Preparation for implementing from-font logic in text underline metrics computation and painting. Move member function to ComputeUnderlineOffsetRoman to ComputeUnderlineOffsetAuto helper function in anonymous namespace as it does not need to be exposed publicy. No functional change, as FontMetrics.UnderlinePosition() was never set to anything, only initialized to 0 (see SimpleFontData.cc) and the branch of actually computing an underline position from font metrics was never reached. Bug: 1067242 Change-Id: Ibc119a30de8f77f2f6388733ee291cc9fbd38980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134301Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#756676}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7fc37290..01e88bc1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I46d67039f8f88174addef01a0d95f10631a3c650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136250Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756675}
-
Friedrich Horschig authored
A resigning promo enables users to access their passwords again. The promo is shown if: - no user is logged in - a password field is focused - any user on this device opted into account-stored passwords before Since the promo button opens the DICE sign-in in a new tab, it will not assume a loading state (which would also be difficult to reset if the user doesn't sign in with a butter-opted-in account). Bug: 1060130 Change-Id: If35fd37a2b71f5ecbe6e9ed47b3c07ecb0975341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134014Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756674}
-
Katie D authored
Test LTR/RTL changes adjust layout by using the LocaleChangeObserver rather than asking for a layout directly. This adds coverage for AutoclickMenuBubbleController::OnLocaleChanged. Bug: 1067399 Relnotes: N/A Change-Id: I07c35470e6e53bd87be02f8736813cc4f86c55ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134860Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#756673}
-
Side Yilmaz authored
This CL update the profile passing to OfflinePageBridge and SuggestionsDependencyFactory from MostVisitedListCoordinator. Currently, it is always regular profile even when called in incognito mode. This CL uses tab model selector of the chrome activity to determine whether it is regular mode or incognito, and passes the proper profile (regular or off-the-record). Bug: 1041781 Change-Id: If3928158e93961d72e06dc5711653bbb7cb1c6b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134230Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#756672}
-
sandromaggi authored
This tests what happens when a new flow gets started in a new tab. It also fixes a bug where: Flow A started on Tab A, Flow B started on Tab B, switching from B to A, since B was attached, the |Attach| was not called and B was shown on Tab A. The CL also introduces some safety null checks. Bug: b/152967053 Change-Id: I9789e823fb4b1c129db35504484215ea50e1b7ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135746Reviewed-by:
Clemens Arbesser <arbesser@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#756671}
-
Vasiliy Telezhnikov authored
This CL converts resource_dirs to sources for android_resources in BUILD.gn files. Details: https://crbug.com/1026378 https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/KAFsfaoq7y4/OC4v5sb9BQAJ Bug: 1062263 Change-Id: I5726e7858e2dab3164b08a81151ab6a5d6fd6f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137479Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#756670}
-
Yaron Friedman authored
1) Move business logic tests to BrowsingDataBridgeTest. It focuses on deletion logic, not UI. 2) Make ClearBrowsingDataFragmentTest focus just on UI testing, mocking and setting expectations for backend calls. BUG=1062568 Binary-Size: VisibleForTesting whitelisting to increase visibility for tests Change-Id: I1d394394233b07a059681c73f6128df7bef86a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136047 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
-
Avi Drissman authored
The .pkg installer should always install Google Chrome into /Applications, rather than find an installation of Google Chrome located somewhere around the user's hard drive and update it. Mark the component package as non-relocatable so that this happens. Bug: 1067275 Change-Id: Idedb79e544f38e44661a545ee9dbc7000ee31d24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135051 Auto-Submit: Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#756668}
-
James Cook authored
SplitSettingsSync adds some text to the OOBE sync consent dialog. Update test expectations to match, otherwise the test will fail when we flip the flag. Bug: 1067212 Test: browser_tests --enable-features=SplitSettingsSync Change-Id: Iaed6053700c1cd2d5cbaadd29443cf564a7d60b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136881 Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Auto-Submit: James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#756667}
-
Aaron Leventhal authored
In CL:2055361 the last remaining use was removed for IsAttributeImportantForAccessibility(), as the return value of HandleAttributeChanged() was never used anyway. This removes code that is no longer necessary. Bug: None Change-Id: I023d96072d15b8550596ff579287fb511c36563f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133922Reviewed-by:
Adam Ettenberger <Adam.Ettenberger@microsoft.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#756666}
-
Tom McKee authored
This CL cleans up some TODO comments that have been completed. Specifically, since crrev.com/c/2007791, we're using the default-dictionary syntax. Bug: 996275 TBR: npm@chromium.org Change-Id: I55a77e1188fd78fadb9b83453a6bb65cef164449 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2059768Reviewed-by:
Tom McKee <tommckee@chromium.org> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#756665}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/04513752fd6e..9b56cea5fa35 git log 04513752fd6e..9b56cea5fa35 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 kjlubick@google.com [canvaskit] Add test and gm for 4x4 matrix Created with: gclient setdep -r src/third_party/skia@9b56cea5fa35 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: Ifcb3f6a1435350bb71d4b08d08c6ce1250e7d3f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137372Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756664}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f0445bf7abcf..acc90dc12f1b git log f0445bf7abcf..acc90dc12f1b --date=short --first-parent --format='%ad %ae %s' 2020-04-06 sugoi@google.com Delete Plane.cpp and Plane.hpp Created with: gclient setdep -r src/third_party/swiftshader@acc90dc12f1b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I53a80083a2febcc64bf2baf96d6d36c91f5d7289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137368Reviewed-by:
-
Alexandre Courbot authored
The frame splitter is set to report a partial frame even if we have not met any frame data so far. The VDA can accommodate this, but the VD code can be made simpler if we don't report these false positives. BUG=b:149663704 TEST=vdatest passing on Hana. Change-Id: I6a48ed0202386e8432243f0543b75779fa05312e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131168 Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756662}
-
Aaron Leventhal authored
Bug: None Change-Id: I184adee602370760564a3c6af3859f14417b904e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134785Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2e3e36312b10..b571ff48f8fe git log 2e3e36312b10..b571ff48f8fe --date=short --first-parent --format='%ad %ae %s' 2020-04-06 sprang@webrtc.org Fixes issue with non-paced audio send time in dynamic pacer. Created with: gclient setdep -r src/third_party/webrtc@b571ff48f8fe If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I72be95c4df8c3018dee91ba893f80add0158d6c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137366Reviewed-by:
-
Sebastien Lalancette authored
Includes empty: - Coordinator - Uses a UINavigationController to present VC. - View Controller Hooked up to the sharing action through BrowserCoordinator, which is hidden behind a flag. Tested on iPhone X 13.4 and iPad sim 12.4. Added unit tests for the view controller. Bug: 1064990 Change-Id: Ia23b83208cd0672372e2f53bcbc3dc4d6c1cf1fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130819 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#756659}
-
Victor Hugo Vianna Silva authored
MultiStorePasswordSaveManager now passes only matches in the account store to the PasswordGenerationManager API, causing matches in the profile store not to be taken into account, as specified in the b4p requirements. A pre-existing unit test checked that only the account form saver was exercised when triggering generation with the account store enabled. That test is extended to verify this is still true in the multiple possible conflict cases that can exist in each store. Bug: 1060131 Change-Id: I19092cf11603c1308172362b181dc505d91986cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132456 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#756658}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2a34dd3052e2..9d3fad03dfd0 Created with: gclient setdep -r src-internal@9d3fad03dfd0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ica0aa024ba6b3f18fe8b608d6fdefff59ae295ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137369Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756657}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/23b1ed62a107..35cca412717b git log 23b1ed62a107..35cca412717b --date=short --first-parent --format='%ad %ae %s' 2020-04-06 tvanderlippe@chromium.org Allow manage_node_deps to run custom npm commands 2020-04-06 wolfi@chromium.org Revert "Add infobar about issues panel to console" Created with: gclient setdep -r src/third_party/devtools-frontend/src@35cca412717b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iddb376aef5d92e9732bdd603d994b7e8a3d48774 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137370Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/1c95795f1fb3..d2de511efbdc git log 1c95795f1fb3..d2de511efbdc --date=short --first-parent --format='%ad %ae %s' 2020-04-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader f99302c4efe6..b8d47928094f (15 commits) 2020-04-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 7844b9b4e180..698d82e38b39 (1 commits) 2020-04-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 9a283ae3457f..dbd073615280 (4 commits) Created with: gclient setdep -r src/third_party/angle@d2de511efbdc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC jonahr@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: jonahr@google.com Change-Id: I94d3c4bcda43c5a21848499d33f6d467220011f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137367Reviewed-by:
-
Mikhail Khokhlov authored
CI bots pass some extra arguments to the script, which we just have to ignore, since this script is not a proper gtest test. Also we add data dependency on the necessary code from catapult and perfetto. Bug: b/148778752 Change-Id: If12959041f79b7c2585684b1a2600e32f3357c42 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129696Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Cr-Commit-Position: refs/heads/master@{#756654}
-
Owen Min authored
WallClockTimer is used by relaunch notification and enterprise reporting scheduler. It's a timer that is based on real work clock by observing power suspending and resuming. Bug: 1062410 Change-Id: I1a52634f48ac358286d84d9c7dc5c8deadc042c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107608Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756653}
-
Xi Han authored
The changes of the startup order in this CL are behind the feature flag "InstantStart". In this CL, we split setupCompositorContent() into - setupCompositorContentPreNative() and - setupCompositorContentPostNative(). The setupCompositorContentPreNative() creates the LayoutManager. When Instant start is on: 1) triggerLayoutInflation() is called before loading the native library. 2) setupCompositorContentPreNative() is called in performPostInflationStartup() before native is initialized. Besides, the value of field trial "tab_switcher_on_return_time_ms" of ChromeFeatureList.TAB_SWITCHER_ON_RETURN is cached now. In the follow up CL, we may move the creation of the LayoutManager into doLayoutInflation(). Bug: 1041865 Change-Id: Ib1039e152cece799ffed0f636a5e55fafbf4adb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110529 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#756652}
-
Gyuyoung Kim authored
This reverts commit 1c578227. Reason for revert: The original test has a Chrome specific's expected height value. It can't be moved to WPT now. Original change's description: > [css-flexbox] Move flex-flow-auto-margins-no-available-space-assert.html test to WPT > > This CL moves flex-flow-auto-margins-no-available-space-assert.html > test from css3/css-flexbox to external/wpt/css/css-flexbox with WPT > styles, adding links to the relevant specs, and test description. > > Bug: 1063749 > Change-Id: I6775022c3fc8572f78e7ec19ad88b91dfdcb7a23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120665 > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Reviewed-by: Robert Ma <robertma@chromium.org> > Reviewed-by: David Grogan <dgrogan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753900} TBR=dgrogan@chromium.org,robertma@chromium.org,gyuyoung@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1063749 Change-Id: I89037ea337838cd458917f708cd934e780ed126a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137166 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by:
Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#756651}
-
Boris Sazonov authored
This CL plumbs new consent-aware primary account API through JNI layer without any changes to the behavior. Bug: 1046746 Change-Id: Ibe7030f5fc5bea5d3b6c09a969ff499d9faeceab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132153Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#756650}
-
Tom McKee authored
This CL adds a chrome://flag for controlling whether or not we run code to track First Scroll Latency. This lets users and release management processes more easily disable this feature if it introduces stability or performance issues. Bug: 922980 Change-Id: I9a941890f8b5f5b26187b2b850f916e38eb325ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135869Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tom McKee <tommckee@chromium.org> Cr-Commit-Position: refs/heads/master@{#756649}
-
Greg Thompson authored
Registry value names must be expanded before use. BUG=698997,1059314 R=zmin@chromium.org Change-Id: I39bc0b31863f46fe2df9e3a873312b865771d3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137340 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756648}
-
Wanming Lin authored
The original CL has been reverted because the test external/wpt/shape-detection/idlharness.https.any.shareworker.html is flaky on Mac. This reland CL disables this test on Mac. Original change's description: > [shapedetection] Upstream TextDetection tests to WPT > > This CL upstreams the reset of shapedetection tests(mainly > TextDetection tests) to WPT. > > - Moves tests under > third_party/blink/web_tests/shapedetection/, > third_party/blink/web_tests/fast/shapedetection/, > third_party/blink/web_tests/http/tests/shapedetection/, > to third_party/blink/web_tests/external/wpt/shape-detection. > - Moves third_party/blink/web_tests/shapedetection/resources/mock-textdetection.js > to third_party/blink/web_tests/external/wpt/resources/chromium/. > - Removes third_party/blink/web_tests/fast/shapedetection/shapedetection-creation.html > as which should be covered in idlharness tests. > - Introduces simulateClosedPipe() to MockBarcodeDetectionProvider to simulate > 'no implementation available' case for > third_party/blink/web_tests/external/wpt/shape-detection/detection-getSupportedFormats.https.html > - Improves third_party/blink/web_tests/external/wpt/shape-detection/detection-options.https.html > by using assert_throws_js BTW. > > Bug: 932382 > Change-Id: I2f795e4fa4f23b33c49b7924cdbcbccde5ac6ed4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131154 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Wanming Lin <wanming.lin@intel.com> > Cr-Commit-Position: refs/heads/master@{#756131} Bug: 932382, 1067533 Change-Id: I85b5dcc841185e2edd20a76ed3aec8add7f08954 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134924Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Wanming Lin <wanming.lin@intel.com> Cr-Commit-Position: refs/heads/master@{#756647}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/74ac68ad26bc..04513752fd6e git log 74ac68ad26bc..04513752fd6e --date=short --first-parent --format='%ad %ae %s' 2020-04-06 jvanverth@google.com Remove D3D12X. Created with: gclient setdep -r src/third_party/skia@04513752fd6e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: csmartdalton@google.com Change-Id: I91567ec84e109b9fbd1d875a7b62ed82c03f9793 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137363Reviewed-by:
-
Javier Ernesto Flores Robles authored
Create credential provider extension objects from password forms. |recordIdentifier| is built in a similar way to how the logins DB identifies credentials. This way Chrome can remove and update entries in the credential provider store. This identifier is also used to identify indexed credentials in the system for password retrieval. The keychain identifier will come from the login database in a follow up CL. This is the attribute used to retrieve the unencrypted password from the keychain. Favicon and validationID are not related to the password store, and will also be implemented in a follow up CL. Bug: 1066803 Change-Id: I20d573301cc468e9984f9524239fd47a7826aa85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133982 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c90c562668d0..2b61b4444bc7 git log c90c562668d0..2b61b4444bc7 --date=short --first-parent --format='%ad %ae %s' 2020-04-06 fmayer@google.com Merge changes Ib6e9fa46,I0ee87597,I331a7375 2020-04-06 eseckler@google.com Merge "track event: Import legacy thread time/instructions as counters" Created with: gclient setdep -r src/third_party/perfetto@2b61b4444bc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I7ab6b4324f73df0666cfae505511199f709da923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137365Reviewed-by:
-
Friedrich Horschig authored
Adds a util that indicates when to show a re-signin promo for previous account-store users. It's true if: - no user is logged in - a password field is focused - any user on this device opted into account-stored passwords before Showing the actual promo button happens in https://crrev.com/c/2134014 Bug: 1060130 Change-Id: Ice3ae2b5c8a9995a9433a495404cdbf7f65a1172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133981 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
-
Alex Ilin authored
The feature is no longer used. The remote consent launch will be controlled by Gaia. Bug: 1026237 Change-Id: I33b3a3b7b4c8e8a8250af05b2199caf24194d1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134128 Auto-Submit: Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#756642}
-
Christos Froussios authored
TBR=rsorokin Bug: 1067461 Change-Id: I3375e0647c03ec0d313bf0b03c2df089c566ed43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135645Reviewed-by:
-
Armando Miraglia authored
Fixed: 1055405, 1055406 Change-Id: Icd3dab8badaed790cb781548624ae6ce71bec217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120305 Commit-Queue: Armando Miraglia <armax@chromium.org> Reviewed-by:
Armando Miraglia <armax@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#756640}
-
Gyuyoung Kim authored
Revert "fixup! [css-flexbox] Move flex-flow-auto-margins-no-available-space-assert.html test to WPT" This reverts commit 50bda8bb. Reason for revert: The original test has a Chrome specific's expected height. It can't be moved to WPT now. Original change's description: > fixup! [css-flexbox] Move flex-flow-auto-margins-no-available-space-assert.html test to WPT > > Change 'auto' with 'percentage the test title and file name. > And, the attribute of the bug link rel is changed to 'issue' > with a full bug link. > > Bug: 1063749 > Change-Id: I0a25c6caa3d3afd6c928bb8bc2b692037c0f57c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126329 > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> > Cr-Commit-Position: refs/heads/master@{#754778} TBR=cbiesinger@chromium.org,gyuyoung@igalia.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1063749 Change-Id: I72817e1d1c5e33d636d9035f5b65618d90b6aa86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135655Reviewed-by:
-
Mikel Astiz authored
This reverts commit 00eeaa2c. Reason for revert: was temporarily disabled for branch point. Original change's description: > Revert "Reland "Enable sync trusted vault support by default"" > > This reverts commit be06dabb. > > Reason for revert: the feature is not ready yet. > > Original change's description: > > Reland "Enable sync trusted vault support by default" > > > > This is a reland of f52179a5 > > > > The feature was disabled by default before branching because some > > implementation parts were missing on Android. > > > > Original change's description: > > > Enable sync trusted vault support by default > > > > > > The feature is in a working state can be enabled by default. > > > > > > Bug: 1000146 > > > Change-Id: I66ef6f65d97234f47eaa76d1daafb8d3637692ed > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2000702 > > > Reviewed-by: Marc Treib <treib@chromium.org> > > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#731898} > > > > Bug: 1000146 > > Change-Id: If2c11c87bbc021daaa6656f9e85b592302dd8327 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035966 > > Reviewed-by: Marc Treib <treib@chromium.org> > > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#738548} > > TBR=treib@chromium.org,mastiz@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 1000146 > Change-Id: I44607cf1822145fb8a98e4a72a1361dbae274b00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127091 > Commit-Queue: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755994} TBR=treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000146 Change-Id: I749d1b18772534611cf218d08f61587ec2a30b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134020Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#756638}
-
