- 14 Mar, 2018 40 commits
-
-
Siddhartha authored
The site_storage dumps do not have child categories and the graph processor is unable to group them by type of storage. So, group the dumps under correct child dumps to get metrics. Also enable missing MDP in background mode: FontCaches, BlobStorage. BUG=730783 Change-Id: I07d0cf8a98c53c4eaaceda3c05610bd765df6222 Reviewed-on: https://chromium-review.googlesource.com/961530 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#543109}
-
Doug Turner authored
It seems BrowserContextKeyedServiceFactory returns a null context if in incognito mode. This CL adds an overload to return a context when the policy blacklist is being requested from an incognito context. Bug: 821653 Change-Id: Iac2fab5c52bfb79fcee08d8e3ba9b05f4bef6c8b Reviewed-on: https://chromium-review.googlesource.com/961383 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#543108}
-
Harald Alvestrand authored
Rebases the WPT tests that are affected. Bug: chromium:589455 Change-Id: Ic7546a30e7640079e4bbcf3502b510221183562c Reviewed-on: https://chromium-review.googlesource.com/962123 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#543107}
-
Scott Violet authored
In mus-mode chrome/ash installs the EventRewriterChromeOS, so the Window Service shouldn't install it too. The Window Service installed it in such a way that sticky keys wasn't present, which meant the EventRewriterChromeOS in the WindowService would change the event so that when the EventRewriterChromeOS in chrome saw the event it didn't match. BUG=821592 TEST=covered by tests Change-Id: Ib5472243bdd0365cd0fc75b31f31faf2aca4e03a Reviewed-on: https://chromium-review.googlesource.com/962714Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#543106}
-
Yutaka Hirano authored
Despite its name, the test checks the mixed content check for sendBeacon. This CL moves it to wpt/mixed-content. Bug: 821294 Change-Id: Ifd264dae0fec5c4d821d61d37d61f4ebbc763516 Reviewed-on: https://chromium-review.googlesource.com/959982Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#543105}
-
Robert Liao authored
This type collides with chrome/browser/ui/view_ids.h. BUG=817419 Change-Id: I8550e19bf12b45ea4491c9daf192d9f75a9c30ff Reviewed-on: https://chromium-review.googlesource.com/961537Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#543104}
-
Miguel Casas authored
This CL adds an OWNERS file to //ui/display/util: git shortlog ui/display/util --numbered --summary 5 Miguel Casas-Sanchez 5 robert.bradford 2 Daniel Bratell 2 afakhry 2 thomasanderson [...] I was going to add dnicoara@ to it but he seems more a //ui/display OWNER: git shortlog ui/display/ --numbered --summary 51 kylechar 31 dnicoara 27 dnicoara@chromium.org 21 robliao 16 Christopher Cameron 16 oshima So I added him there. Also Component. Bug: 821393 Change-Id: I695ac3948355783f19d0f31096f5ca8e37aa9eab Reviewed-on: https://chromium-review.googlesource.com/960577Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#543103}
-
Aaron Leventhal authored
Make sure OnVisibilityChanged() is called for all codepaths that affect visibility. Bug: 821820 Change-Id: I3a98be29a619533c09d5963f33723f62e3304b74 Reviewed-on: https://chromium-review.googlesource.com/962681Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543102}
-
Theresa authored
Also adds a dummy FeedNewTabPage as the first example usage. BUG=803317 Change-Id: I6f4cccf6e903054b67b2550d6483d157bb3c43e0 Reviewed-on: https://chromium-review.googlesource.com/960963 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#543101}
-
Robert Ma authored
Now that the web font timing issue for WPT in Blink has been fixed (https://crbug.com/507054), these tests should no longer be flaky. Update FlagExpectations/disable-blink-features=RootLayerScrolling to match TestExpectations: 1. The three lines associated with crbug.com/553838 are removed in https://crrev.com/c/954044 2. The other lines associated with crbug.com/582836 are removed in https://crrev.com/c/962704 Bug: 582836, 507054 Change-Id: I8073e7ca86046a437b67e92a7e552e1666cd5983 Reviewed-on: https://chromium-review.googlesource.com/962705 Commit-Queue: Robert Ma <robertma@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#543100}
-
https://webrtc.googlesource.com/src.git/+log/31a12c557dcd..08c5cb075293 $ git log 31a12c557..08c5cb075 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ibffd3de60d7f9bb49bad6d293ad93756af334254 Reviewed-on: https://chromium-review.googlesource.com/962701Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543099}
-
Elad Alon authored
Add JS hooks for initiating WebRTC event logging, which would later be sent to a remote server. These hooks are only accessible by those who already have access to the private APIs from the Hangouts extensions. Bug: 775415 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I99ddd639bab2d64d466b4af37aad64faf2375f54 Reviewed-on: https://chromium-review.googlesource.com/931081 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#543098}
-
https://chromium.googlesource.com/angle/angle.git/+log/2bfe9f6b9366..d92d9dd18033 $ git log 2bfe9f6b9..d92d9dd18 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 lucferron Sort the Format_table_autogen.cpp switch case by gl format Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I8d93280ab3c657d8aa06d2a2a809af4fe95f0633 Reviewed-on: https://chromium-review.googlesource.com/962350 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543097}
-
Alex Clarke authored
Change-Id: Ic12f4c137c36b0fbc1c285b9ae1660ad606df844 Reviewed-on: https://chromium-review.googlesource.com/962261Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#543096}
-
Tatiana Gornak authored
This CL moves files related to the editing UI on the settings page in less payments related dirs. This CL is split of https://chromium-review.googlesource.com/c/chromium/src/+/842649 BUG=799905 TBR=rouslan@chromium.org Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ida1972ca3c698a29bd84fc3be1bf8248b80ddd3e Reviewed-on: https://chromium-review.googlesource.com/939961 Commit-Queue: Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#543095}
-
stkhapugin@chromium.org authored
Adds support for up/down arrows in the iOS omnibox. Allows highlighting suggestions from the list and choosing them with Enter. Bug: 267089 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Iedf4ad116b9033fcc2cfbab7bc69a9868db0fc1d Reviewed-on: https://chromium-review.googlesource.com/951487Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#543094}
-
Tibor Goldschwendt authored
Bug: 817169 Change-Id: I7ccf4c43d139f79d0a2be9a6f7a0ab964b222649 Reviewed-on: https://chromium-review.googlesource.com/960580Reviewed-by:
Amirhossein Simjour <asimjour@chromium.org> Reviewed-by:
Biao She <bshe@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#543093}
-
Jeremy Roman authored
This reverts commit ade1dc7a. Reason for revert: Further discussion on the bug (https://bugs.chromium.org/p/chromium/issues/detail?id=816447#c8); moving towards Chrome's previous behavior. Original change's description: > Throw a DataCloneError if a neutered ArrayBuffer occurs in the transfer list. > > Currently the exception is not thrown until after serialization. > This makes us consistent with Gecko and WebKit, which throw before serialization. > > This fixes the second test case in https://github.com/w3c/web-platform-tests/pull/9672 > (not yet pushed to upstream WPT). > > Bug: 816447 > Change-Id: I30b798b5d21dc8d6f2a40d049ced6aa7f60dd090 > Reviewed-on: https://chromium-review.googlesource.com/956254 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Commit-Queue: Jeremy Roman <jbroman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542484} TBR=jbroman@chromium.org,mek@chromium.org,haraken@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 816447 Change-Id: I79950f8ba97e5481a872cc4897d62506fb2381b0 Reviewed-on: https://chromium-review.googlesource.com/960926Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543092}
-
Patrick Monette authored
We explicitly allow all modules seemingly signed by the signer of the process's main exe to load into the process. Bug: 819793 Change-Id: I3636b8251cb82cd1d4a5f69f3899ea4516b1b00a Reviewed-on: https://chromium-review.googlesource.com/952074 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#543091}
-
Eugene But authored
This test verifies UIDocumentInteractionController presentation. Bug: 791806 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5f97d54edc3d6d18597b6278993957fe866c636e Reviewed-on: https://chromium-review.googlesource.com/960965Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#543090}
-
Jonathan Backer authored
Refactored QueryManager into QueryManager and GLES2QueryManager, where GLES2QueryManager is a subclass QueryManager that accesses a GLES2Decoder. Added unittests to test query on the service side. This is a copy of existing tests for GLES2. Moved all manual service side tests into raster_decoder_unittest.cc Bug: 789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8207b8f738e8d8cac921c333fb99d5bf9e574772 Reviewed-on: https://chromium-review.googlesource.com/956085 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#543089}
-
James Cook authored
Specify the coordinate system in variable names for points. Bug: 821471 Change-Id: I5368b85e6c1c36f5295eee10b96074e5d3b30403 Reviewed-on: https://chromium-review.googlesource.com/961663Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#543088}
-
Aaron Leventhal authored
This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Ic6426632f641ac2bfa83616684c7c61d01228e8c Reviewed-on: https://chromium-review.googlesource.com/961246Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543087}
-
Lei Zhang authored
Fix some nits too. Change-Id: Ida343bd53083015d9a4027e2fd85f559e65cde90 Reviewed-on: https://chromium-review.googlesource.com/959692Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#543086}
-
Patrick Monette authored
This is to avoid doing IO access on the UI thread. Bug: 819791 Change-Id: I0f92f316ebc29d0c4270af46b3a6ccc854adfded Reviewed-on: https://chromium-review.googlesource.com/955670 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#543085}
-
Lutz Justen authored
Both are 'external'-type policies, i.e. the images are not included in the policy, but downloaded separately. However, the mechanisms to download external user policies were not hooked up. This CL wires them up. Interestingly, DeviceWallpaperImage works fine. BUG=chromium:819561 TEST=out/Release/unit_tests --gtest_filter=ActiveDirectoryPolicyManagerTest.* Set UserAvatarImage and WallpaperImage on Windows Server and verified that it applies on a domain joined Chromebook. Change-Id: I8670a3e1ba0edcee31ed5753be92b021e9553bb0 Reviewed-on: https://chromium-review.googlesource.com/952903 Commit-Queue: Lutz Justen <ljusten@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#543084}
-
Alexandr Ilin authored
This CL adds the MAYBE_ prefix to the test name for disabling to come info effect. TBR=sergeyu@chromium.org Bug: 800465 Change-Id: I3120d549b0860d76f48d749305d64830d38fa606 Reviewed-on: https://chromium-review.googlesource.com/962447Reviewed-by:
Alexandr Ilin <alexilin@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543083}
-
Stephen Chenney authored
The object-fit: scale-down property requires that the image be sized to the smaller of "none" or "contain". When a srcset is used, the IntrinsicSize of the image is scaled such that the srcset fills the expected area. This causes scale-down to consider the intrinsic size to be bigger than the actual image, and size things too large. This change modifies the intrinsic size for content-fit: scale-down in LayoutReplaced::ComputeObjectFit to un-apply the ImageDevicePixelRatio, that is the scale that resized the src. Chrome's behavior now matches Firefox. BUG=818630 Change-Id: Ifbd63bbd6d905673e8058b49173b604cd9c8083e Reviewed-on: https://chromium-review.googlesource.com/957131 Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#543082}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9fe571c9..2239a88c Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I5519d637acb60a4db87304ce5f402f8ce23e0100 Reviewed-on: https://chromium-review.googlesource.com/962344Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543081}
-
Zhenyao Mo authored
BUG=817286 TEST=perf bot falls back to D3D9 R=geofflang@chromium.org Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Icd19277b6074178be8e26312be20ec02dd0b01c0 Reviewed-on: https://chromium-review.googlesource.com/961489Reviewed-by:
Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#543080}
-
Manuel Rego Casasnovas authored
There was a crash in debug if you use calc() mixing fixed and percentage values due to the wrong DCHECK in GapLength constructor. The patch fixes this assert. In addition LayoutGrid::GridGap() was also wrong and didn't consider calc() either. The fix is again easy just using the proper check. Regarding testing, the parsing tests have been updated to include this combination of fixed and percentage values in calc(). At the same time, the patch actually uses "grid-" prefixed properties in the tests that were supposed to test those. Last, two new tests are added to verify the proper behavior of calc() with mixed values on a grid layout container. BUG=816300 TEST=external/wpt/css/css-align/gaps/column-gap-parsing-001.html TEST=external/wpt/css/css-align/gaps/gap-parsing-001.html TEST=external/wpt/css/css-align/gaps/grid-column-gap-parsing-001.html TEST=external/wpt/css/css-align/gaps/grid-gap-parsing-001.html TEST=external/wpt/css/css-align/gaps/grid-row-gap-parsing-001.html TEST=external/wpt/css/css-align/gaps/row-gap-parsing-001.html TEST=external/wpt/css/css-grid/alignment/grid-gutters-011.html TEST=external/wpt/css/css-grid/alignment/grid-gutters-012.html Change-Id: I4c9fe6b2525a253c6bb00cbda727c2bf1ae6e90b Reviewed-on: https://chromium-review.googlesource.com/962148 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#543079}
-
Rob Buis authored
Fix errorprone StaticGuardedByInstance warnings and make sure it is treated as error after this CL. http://errorprone.info/bugpattern/StaticGuardedByInstance Bug: 803625 Change-Id: Ica786979670c8ec58c07691122e225acc56e62df Reviewed-on: https://chromium-review.googlesource.com/961041 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#543078}
-
Alexander Timin authored
Due to historical reasons scheduler uses Chromium code style instead of Blink one. Before patch 954622 it was enforced by scheduler using camel_case for file names. This patch restores the exception after the said patch started to apply webkit style checks to camel_case filenames. TBR=dcheng@chromium.org,tkent@chromium.org Change-Id: I7c81e7e1dfcca264f1491529c28659b6e90a3f37 Reviewed-on: https://chromium-review.googlesource.com/962422Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543077}
-
Batalov Vladislav authored
The 'sourceSets' block adds '{' symbol without any conditions. But related '}' symbol is added under some 'if' statement. So there is set of input params with which 'generate_gradle.py' doesn't closes 'sourceSets'. The solution is moving '}' under conditions. R=agrieve@chromium.org Change-Id: I82a3998cf9e4c06b43eefa43400d084fa3a6d833 Reviewed-on: https://chromium-review.googlesource.com/962445Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#543076}
-
Takuto Ikuta authored
This is mainly for taking performance improvement of jinja2. http://jinja.pocoo.org/docs/2.10/changelog/#version-2-10 Manually edited files: README.chromium get_jinja2.sh And I regenerate build/android/test_runner.pydeps * For the record, With Jinja 2.10, running time of idl_compiler for generate_bindings_core_v8_interfaces is like below on Z840 Linux. 5.050s 4.945s 5.077s With Jinja 2.8, running time of idl_compiler for generate_bindings_core_v8_interfaces is like below on Z840 Linux. 6.675s 6.575s 6.574s Bug: 821256 Change-Id: I127e3db94edb22e3ac22a3662872d99b4b91c2a8 Reviewed-on: https://chromium-review.googlesource.com/917930Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#543075}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7f9a64d3. With Chromium commits locally applied on WPT: ad9cc156 "Add WPT tests for feature policy frame policy" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13840 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: kojii@chromium.org: external/wpt/css/css-text/line-break TBR=leon.han@intel.com No-Export: true Change-Id: I75a7369414f6594b2fb3bb9cdd0a4a031d13391c Reviewed-on: https://chromium-review.googlesource.com/962343 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#543074}
-
Takuto Ikuta authored
mojom generator uses jinja2 template. If we update jinja2 library, jinja2 may update api/internal structure. In such case, all mojom generator using jinja2 may need to re-run. I added jinja2_sources for such case and use it as inputs dependency for mojom generator action. It is recommended by gn. https://chromium.googlesource.com/chromium/src/+/master/tools/gn/docs/reference.md#target-declarations-action_declare-a-target-that-runs-a-script-a-single-time-inputs * Minor fix Update README.chromium to pass current presubmit check. Change-Id: I8b7f126c3a807ac211db01c90437d584c9c39f85 Reviewed-on: https://chromium-review.googlesource.com/961763Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@google.com> Cr-Commit-Position: refs/heads/master@{#543073}
-
Antonio Gomes authored
Code in //ui/ozone/platform/wayland/fake_server.cc|h is quite convoluted today. This a 3/n of a series of patches that clean it up. Particularly, CL changes the wayland unittest's code to use the "bleh_" terminology rather than "bleh" for class member declaration, as per Chromium's coding style. BUG=None TBR=rjkroege@chromium.org Change-Id: I3534937d2ed842b0723e622f39668d4ac6c557c0 Reviewed-on: https://chromium-review.googlesource.com/961143 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#543072}
-
Jonathan Backer authored
Pass the flag to the renderer and have the renderer pass the setting down as a context attribute. This keeps the client and service side of the command buffer in sync (e.g. use RasterImplementation with RasterDecoder and GLES2Implementation with GLES2Decoder). I've kept the GpuPreference plumbing from browser to GPU process in place so that a compromised renderer cannot unilaterally turn on the RasterDecoder. Bug: 789238 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia8923f1adfe41495d818d83b3ff6c9c0e62f255c Reviewed-on: https://chromium-review.googlesource.com/952080 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#543071}
-
Matthew Cary authored
Change-Id: Idfb16f09178adcd7399601d035870b51bacef84c Reviewed-on: https://chromium-review.googlesource.com/962143Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#543070}
-