Commits · 5d3043f7db760517ac554931253fe7683a572c79 · eriksson monteiro / tangled

23 May, 2011 6 commits

Valgrind: Widen a suppression. · 5d3043f7

thestig@chromium.org authored May 23, 2011

BUG=52831
TEST=none
TBR=timurrrr
Review URL: http://codereview.chromium.org/7059004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86250 0039d316-1c4b-4281-b951-d872f2087c98

5d3043f7

Valgrind: Fix copy + paste error in r86197. · 5664ff93

thestig@chromium.org authored May 23, 2011

BUG=75023
TEST=CrOS UI valgrind 1 goes green.
TBR=jhawkins
Review URL: http://codereview.chromium.org/7019034

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86249 0039d316-1c4b-4281-b951-d872f2087c98

5664ff93

Revert 86246 - Fix assertion failure in range.mm while examining system dictionary popup. · 62532560

bashi@chromium.org authored May 23, 2011

Convert WTF::notFound to NSNotFound.

BUG=83158
TEST=chrome/browser/renderer_host/text_input_client_mac_unittest.mm

Review URL: http://codereview.chromium.org/7039054

TBR=bashi@chromium.org
Review URL: http://codereview.chromium.org/7019033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86248 0039d316-1c4b-4281-b951-d872f2087c98

62532560

WebUI: size the cookies list according to the window height. · 73e2c8cd

mdm@chromium.org authored May 23, 2011

BUG=75678
Review URL: http://codereview.chromium.org/6990030

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86247 0039d316-1c4b-4281-b951-d872f2087c98

73e2c8cd

Fix assertion failure in range.mm while examining system dictionary popup. · 76a74149

bashi@chromium.org authored May 23, 2011

Convert WTF::notFound to NSNotFound.

BUG=83158
TEST=chrome/browser/renderer_host/text_input_client_mac_unittest.mm

Review URL: http://codereview.chromium.org/7039054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86246 0039d316-1c4b-4281-b951-d872f2087c98

76a74149

WebKit Roll 84025:84047 · b5df0bee

ukai@chromium.org authored May 23, 2011

BUG=none
TEST=none
TBR=jschuh

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86245 0039d316-1c4b-4281-b951-d872f2087c98

b5df0bee

22 May, 2011 10 commits

Support clipboardRead and clipboardWrite permission for hosted apps. · eda42175

dcheng@chromium.org authored May 22, 2011

BUG=82024
TEST=none

Review URL: http://codereview.chromium.org/6976002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86244 0039d316-1c4b-4281-b951-d872f2087c98

eda42175

dom-ui sync: When hitting the 'Customize' button, retain 'keep everything sync'd state. · 0e3564a7

csilv@chromium.org authored May 22, 2011

BUG=81603
TEST=Verify that 'Sync everything' is selcted on toggle between 'Customize' and 'Use default settings'.
Review URL: http://codereview.chromium.org/6974006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86243 0039d316-1c4b-4281-b951-d872f2087c98

0e3564a7

Changes to not use the prerendered contents when window.opener needs to be set. · eacb080b

shishir@chromium.org authored May 22, 2011

BUG=79922
TEST=browser_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85394

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=85689

Review URL: http://codereview.chromium.org/6915019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86242 0039d316-1c4b-4281-b951-d872f2087c98

eacb080b

Kill URLRequestJobTracker. · 8523ba5f

willchan@chromium.org authored May 22, 2011

BUG=81160
TEST=none


Review URL: http://codereview.chromium.org/7043007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86241 0039d316-1c4b-4281-b951-d872f2087c98

8523ba5f

views: Split DownloadShelfContextMenuWin out to its own header file. · 653f4ec8

tfarina@chromium.org authored May 22, 2011

This moves the implementation of DownloadShelfContextMenuWin from download_item_view.cc
to download_shelf_context_menu_view.*

Renames DownloadShelfContextMenuWin to DownloadShelfContextMenuView.

BUG=28978
TEST=None

R=dmazzoni@chromium.org,rdsmith@chromium.org

Review URL: http://codereview.chromium.org/7056001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86237 0039d316-1c4b-4281-b951-d872f2087c98

653f4ec8

Modify settings page text when syncing. · 003be3bd

scr@chromium.org authored May 22, 2011

- Created new strings for syncing with and without profile.
- Altered sync service observation to check service's StatusSummary for SYNCING.
- use innerHTML to allow links in the status string.

BUG=80892
R=jhawkins@chromium.org
TEST=set up sync, view chrome://settings/personal, change, add, or delete a bookmark - see syncing briefly, then back to synced.


Review URL: http://codereview.chromium.org/6961014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86236 0039d316-1c4b-4281-b951-d872f2087c98

003be3bd

Roll WebKit to 87005:87025. · dad10c30

jschuh@chromium.org authored May 22, 2011

BUG=None
TEST=None
TBR=ukai
Review URL: http://codereview.chromium.org/6241002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86235 0039d316-1c4b-4281-b951-d872f2087c98

dad10c30

WebUI: properly internationalize the search cookies and search passwords placeholder text. · b82f47bb

mdm@chromium.org authored May 22, 2011

Review URL: http://codereview.chromium.org/7061003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86234 0039d316-1c4b-4281-b951-d872f2087c98

b82f47bb

WebUI: Add password manager search feature. Also add tooltips for the URLs. · 2a7f4df2

mdm@chromium.org authored May 22, 2011

BUG=9575,79690
Review URL: http://codereview.chromium.org/6990026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86230 0039d316-1c4b-4281-b951-d872f2087c98

2a7f4df2

WebUI: make cookies and site data column headers consistent with other table headers. · e17abdd5

mdm@chromium.org authored May 22, 2011

This also makes the text a little smaller, possibly helping to address issue 78059.
BUG=78059
Review URL: http://codereview.chromium.org/7059001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86229 0039d316-1c4b-4281-b951-d872f2087c98

e17abdd5

21 May, 2011 24 commits

Don't build googleurl_unittests in shlib builds. · f71d35b0

cmp@chromium.org authored May 21, 2011

BUG=82178

Review URL: http://codereview.chromium.org/7059003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86228 0039d316-1c4b-4281-b951-d872f2087c98

f71d35b0

Fix a possible crash on windows. · 74895f21

thakis@chromium.org authored May 21, 2011

Also see http://codereview.chromium.org/7057021

BUG=83236
TEST=none

Review URL: http://codereview.chromium.org/7055013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86227 0039d316-1c4b-4281-b951-d872f2087c98

74895f21

win: Let CalculateIdleState() deal better with GetTickCount() wrapping around. · b112e4c8

thakis@chromium.org authored May 21, 2011

BUG=83237
TEST=none

Review URL: http://codereview.chromium.org/7038042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86226 0039d316-1c4b-4281-b951-d872f2087c98

b112e4c8

Mac: Use cross-platform menu model for profile button. · 52b6a246

thakis@chromium.org authored May 21, 2011

Also move the SimpleMenuModel::Delegate back into ProfileButtonMenu

BUG=xxx
TEST=none

Review URL: http://codereview.chromium.org/7054031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86224 0039d316-1c4b-4281-b951-d872f2087c98

52b6a246

Whitespace to kick bots · 3a6e68ef

rsleevi@chromium.org authored May 21, 2011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86222 0039d316-1c4b-4281-b951-d872f2087c98

3a6e68ef

Add myself to the importer WATCHLIST. · 0f560e04

tfarina@chromium.org authored May 21, 2011

BUG=None
TEST=None

R=avi@chromium.org,mirandac@chromium.org

Review URL: http://codereview.chromium.org/6961045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86220 0039d316-1c4b-4281-b951-d872f2087c98

0f560e04

Add crypto_unittests to the list of tests run for heapcheck/valgrind · d2531ea2

rsleevi@chromium.org authored May 21, 2011

BUG=83183
TEST=none


Review URL: http://codereview.chromium.org/7039057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86218 0039d316-1c4b-4281-b951-d872f2087c98

d2531ea2

Update exclusions for crypto_unittests on TSAN/Win · 2c7bc273

rsleevi@chromium.org authored May 21, 2011

BUG=83183
TEST=None
TBR=timurrrr

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86217 0039d316-1c4b-4281-b951-d872f2087c98

2c7bc273

No-op change (fix alphabetic order in the OWNERS file) to trigger the build · 59090983

timurrrr@chromium.org authored May 21, 2011

TBR=glider
Review URL: http://codereview.chromium.org/6990027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86215 0039d316-1c4b-4281-b951-d872f2087c98

59090983

Updating trunk VERSION from 772.0 to 773.0 · 698deba8
chrome-release@google.com authored May 21, 2011
```
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86210 0039d316-1c4b-4281-b951-d872f2087c98
```
698deba8

Convert active labs into switches earlier. · 4ccb48be

toyoshim@chromium.org authored May 21, 2011

This change enables to check active labs in InitializeNetworkOptions().

BUG=42320
TEST=N/A


Review URL: http://codereview.chromium.org/6961015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86208 0039d316-1c4b-4281-b951-d872f2087c98

4ccb48be

Revert r75078 now that crbug.com/72007 is fixed. · 08e3745c

darin@chromium.org authored May 21, 2011

R=jamesr
BUG=71735
TEST=none
Review URL: http://codereview.chromium.org/6961039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86207 0039d316-1c4b-4281-b951-d872f2087c98

08e3745c

Fix a few browser tests for touchui: Count the renderer for the keyboard and update expectations. · 7422c976

sadrul@chromium.org authored May 21, 2011

BUG=none
TEST=RenderProcessHostTest.* tests pass on touchui

Review URL: http://codereview.chromium.org/6990022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86204 0039d316-1c4b-4281-b951-d872f2087c98

7422c976

WebKit roll 86955:87005 · 412e1174

jschuh@chromium.org authored May 21, 2011

BUG=None
TEST=None
TBR=ukai@chromium.org
Review URL: http://codereview.chromium.org/7038054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86203 0039d316-1c4b-4281-b951-d872f2087c98

412e1174

Linux: add a check for suspicious data in KWallet pickles and ignore it. · a3683e1f

mdm@chromium.org authored May 21, 2011

BUG=80728

Review URL: http://codereview.chromium.org/7054027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86200 0039d316-1c4b-4281-b951-d872f2087c98

a3683e1f

Valgrind: Update a suppression after r85969. · 1fc54ad4

thestig@chromium.org authored May 21, 2011

BUG=79671
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7057037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86199 0039d316-1c4b-4281-b951-d872f2087c98

1fc54ad4

Added 3 more functions in popups.py · 8de2f239

aocampo@chromium.org authored May 21, 2011

testUnblockedPopupShowsInHistory
testBlockedPopupNotShowInHistory
testUnblockedPopupAddedToOmnibox

removed GetOmniboxMatchesFor from omnibox.py and added to test_utils.py

Review URL: http://codereview.chromium.org/7043026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86198 0039d316-1c4b-4281-b951-d872f2087c98

8de2f239

Valgrind: Widen the bug 75023 suppression yet again. · e8aa5839

thestig@chromium.org authored May 21, 2011

BUG=75023
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/6961041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86197 0039d316-1c4b-4281-b951-d872f2087c98

e8aa5839

Print Preview: Delaying page range validation · 799332b7

dpapad@chromium.org authored May 21, 2011

Also 
1) adding border between printing controls and preview area. 
2) showing an error message when initiator tab is closed regardless of the state of the preview area.

BUG=83251, 83429, 83410
TEST=See bug description.


Review URL: http://codereview.chromium.org/7055018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86196 0039d316-1c4b-4281-b951-d872f2087c98

799332b7

Valgrind: Widen a suppression. · a02c61e7

thestig@chromium.org authored May 21, 2011

BUG=79933
TEST=none
TBR=jhawkins
Review URL: http://codereview.chromium.org/7004057

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86194 0039d316-1c4b-4281-b951-d872f2087c98

a02c61e7

gtk: Split DownloadShelfContextMenuGtk out to its own header file. · 249de731

tfarina@chromium.org authored May 21, 2011

This moves the implementation of DownloadShelfContextMenuGtk from download_item_gtk.cc to download_shelf_context_menu_gtk.*

BUG=28978
TEST=None

R=evan@chromium.org,rdsmith@chromium.org,asanka@chromium.org

Review URL: http://codereview.chromium.org/7051021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86193 0039d316-1c4b-4281-b951-d872f2087c98

249de731

Improve HQP Title Scoring · 278bd6a9

mrossetti@chromium.org authored May 21, 2011

I was not satisfied with how difficult it was to get reasonable scores for quite long page titles even when multiple words contained in the title were typed so I added a limit on how much of the title (and URL) string was required in order to have a decent match.

BUG=None
TITLE=Ran all unit tests.
Review URL: http://codereview.chromium.org/7040009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86192 0039d316-1c4b-4281-b951-d872f2087c98

278bd6a9

Linux: Add libcups2(-dev) to install-build-deps.sh. · a9259a58

thestig@chromium.org authored May 21, 2011

BUG=none
TEST=none
Review URL: http://codereview.chromium.org/6990023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86191 0039d316-1c4b-4281-b951-d872f2087c98

a9259a58

Update to valid US phone number to accomidate new phone verification for Autofill. · 2c57469f

dyu@chromium.org authored May 21, 2011

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/7057035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86190 0039d316-1c4b-4281-b951-d872f2087c98

2c57469f