GitLab

ARC provisioning can fail due to ARC instance abruptly stopping. This
can have three possible reasons however we show the same generic error
"Something went wrong" instead of a more useful error.

With this change, we're adding the ability to show a unique error for
each of the three reasons for ARC instance stopping.

BUG=b:166322619
TEST=force the arc stop error, deploy to dut, ensure new metric is
logged in chrome://histograms

Change-Id: I5d73fcf9f845237e6d4d52e52a24a6cfe7f34e74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518664Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826373}

All non-primitive types need explicit non/null modifier as per style guide.

chrome/test/data/webui/chromeos/diagnostics:closure_compile

Bug: 1125150
Test: autoninja
Change-Id: Ic1a6ff8c08cb1fb8770158c3154eb0bec8879712
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530191
Auto-Submit: Joon Ahn <joonbug@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Joon Ahn <joonbug@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826372}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=harringtond@chromium.org

Bug: 1145565
Change-Id: I00ea07dd484293ba9cc164f97838def2a4e15615
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532657
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826371}

Change-Id: Iece225a990448b954161d3286a1f595f60e6f04e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530262Reviewed-by: Peter Williamson <petewil@chromium.org>
Commit-Queue: Cathy Li <chili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826370}

ScopedObserver is being deprecated in favor of two new classes:
- base::ScopedObservation for observers that only ever observe
  a single source.
- base::ScopedMultiSourceObservation for observers that do or may
  observe more than a single source.

This CL was uploaded by git cl split.

R=msramek@chromium.org

Bug: 1145565
Change-Id: I10357ac1f5c2ae101b2a63a7e0841f890cf3134a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532717
Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826369}

- Current full battery capacity was moved to a different struct

Bug: 1125150
Test: browser_tests --gtest_filter=DiagnosticsApp*
Change-Id: I64e6c3ff810a38e53c4ea1bf95e58f56469d81de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531114
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826368}

The ActiveURL is now set via messages sent on the LocalFrame.
Hopefully this will help improve crash reports. This use to occur
in RenderFrameImpl::OnMessageReceived.

BUG=993189

Change-Id: I184ef2892b550fb79ced43c2c48315f68dd6c358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521078Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826367}

Bug: 1147858,1116601,1142017
Change-Id: I1611af0945f340f704055bedb3e1bffd5765c8f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533015
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826366}

ScriptExecutor is used to drive programmatic script execution by
extensions into different web frames. While it is reasonably tested
transitively through end-to-end tests for the tabs.executeScript()
method and friends, we should have more targetted testing for its
functionality as well.

Add a browser test with a simple test case of injecting script into
the main world and returning the result as a starting point.

Bug: None
Change-Id: I9a00a6b1141935d35cf1c0317c0ccda734c991e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528912
Auto-Submit: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: David Bertoni <dbertoni@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826365}

Move the duplicate implementation of these methods into the base class.

BUG=1097816

Change-Id: Ibc97bc14dbc246cbc7bdced0a53bb43afa96cfbf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526912
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826364}

TBR=robertma@chromium.org

Change-Id: I8c48c7408c5f91077bb07c7e73897fbdd1c9313f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533016Reviewed-by: Luke Z <lpz@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Commit-Queue: Luke Z <lpz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826363}

Bug: 1130482
Change-Id: I1ea101821632f331e37e2ea0eecc04716a93b41f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532261Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826362}

Change-Id: I18846c0f5e331678b7f0c9bd21a142e22c30c991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2520021
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826361}

https://chromium.googlesource.com/catapult.git/+log/994d3835f535..ac95abdb4b12

2020-11-11 gab@chromium.org [telemetry] Add "base" as a key low-overhead tracing category

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: oysteine@google.com
Change-Id: I4a4de4e1131d384d8adfaf93e3123699b4d4b317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533094Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826360}

Dark mode was not working correctly since layouts were being inflated
with the feed isolated split context and not the activity context. This
change pulls only the ClassLoader from the feed isolated split context,
and adds a util which can be used elsewhere.

Bug: 1126301
Change-Id: I9f1da598cb1df2a33c1095bc9afb8e451b518991
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531516
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826359}

This fixes an issue where textures sampling parameters are incorrect
when there is a concurrent read of the texture. For example when an
upscaled video texture is read back to draw to a canvas, the texture
will end up pixelated some frames and smooth in others.
GL_TEXTURE_MAG_FILTER is expected to be GL_LINEAR but it's changed to
GL_NEAREST for readback and not reset.

There is no way to know if a concurrent read happened in Chrome today so
we have to always reset GL texture parameters to avoid it. For
GLRenderer always resetting the sampling parameters when binding the
texture fixes the provided examples. With SkiaRenderer texture
parameters are reset right after BeginAccess() is called on the texture.

Bug: 1092080
Change-Id: I968202f3dfff8c3c300c7e98583c55aca8639f81
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431550Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Commit-Queue: kylechar <kylechar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826358}

I have ~2 more CLs to land before this feature is ready for release.
I suspect that this won't be before M88 branch point so I am disabling
the feature and will re-enable it once we can control it via the
registry in a follow-up CL.  This way, if the required CLs don't land
before branch point, the host is still in a releasable state w/o
requiring any merges.

Change-Id: I03ec977f563679d6b4b84fa6fbbdf849d185e36b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532924
Commit-Queue: Jamie Walch <jamiewalch@chromium.org>
Auto-Submit: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826357}

Bug: 1141674
Change-Id: I7c9e4854e7dd9d0c94500c61ccd45e0a1f1f6f27
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528164Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Commit-Queue: Charlene Yan <cyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826356}

The should let us deprecate waitForNavigation parameter to
Emulation.setVirtualTimePolicy and make its contract a bit
more sensible: instead of virtual time being set in advance
and waiting to kick-in after the navigation, we let the
navigation wait for the virtual time budget to be granted
before the document is actually loaded. This removes the
race between document resources loading (and, conditionally,
consuming 10ms each) and the client granting the budget.

Change-Id: Iffc794a450dbb8cb6ae1d37100386f00c7638abf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531363Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826355}

we are obsoleting the unnecessary `TpmIsBeingOwned()`.

BUG=b:172775884
TEST=build ok.

Change-Id: I593ae2c86994b997d4e1ac9d98e096f73f0375f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532156
Commit-Queue: Leo Lai <cylai@google.com>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826354}

This reverts commit 3aed6673.

Reason for revert: suspected in build failures on ios-simulator, ios-simulator-noncq

E.g. https://ci.chromium.org/p/chromium/builders/ci/ios-simulator/59564 and https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/13473

Original change's description:
> Reland "mac/ios: Use real response files instead of -filelist."
>
> This is a reland of 5e46febb
>
> Original change's description:
> > mac/ios: Use real response files instead of -filelist.
> >
> > Xcode 12 added support for real response files, so let's use them.
> > Allows making response file contents more like on other systems
> > (libs, solibs, frameworks, swiftmodules now go in the rsp file too),
> > and makes it theoretically possible to have object files with spaces
> > in their name.
> >
> > No intentional behavior change.
> >
> > Bug: none
> > Change-Id: I8c2d6ff1abd47261bf7674dc7bf4506814681ad4
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527621
> > Auto-Submit: Nico Weber <thakis@chromium.org>
> > Commit-Queue: Brett Wilson <brettw@chromium.org>
> > Reviewed-by: Brett Wilson <brettw@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#825480}
>
> Bug: none
> Change-Id: Ib355508d2d45ab3ddf9ece76b6e95106c784fde9
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530350
> Auto-Submit: Nico Weber <thakis@chromium.org>
> Reviewed-by: Tommy Martino <tmartino@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826282}

TBR=thakis@chromium.org,tmartino@chromium.org,mark@chromium.org

Change-Id: Ie98fc38610c34711ce14d4e76582c78d4e3280bb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533176Reviewed-by: James MacLean <wjmaclean@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826353}

This reverts commit 3c30ec0c.

Reason for revert: catapult fix has rolled in: crrev.com/c/2530627

Original change's description:
> Disable resultdb.result_sink experiment on all chromium try builders.
>
> Leading to many telemetry_unittest failures on mac-rel.
>
> TBR=gbeaty
>
> Bug: 1147657
> Change-Id: I6456649d1eff2e7f700b7ea37b2ff4da793cb374
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531295
> Reviewed-by: Ben Pastene <bpastene@chromium.org>
> Commit-Queue: Ben Pastene <bpastene@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#826052}

TBR=bpastene@chromium.org,gbeaty@chromium.org

Change-Id: Ic44cf6dc06d92a40eb64f5ddbe6d2dd68570d5d9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1147657
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532857Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Ben Pastene <bpastene@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826352}

This change will allow an admin to set a policy to prevent any UI
from being shown when a user connects to a non-curtained session.
This change is targeted at improving the user experience when the
machine is not physically accessible (i.e. we know that a local
user cannot interact with the machine) and we want to remove the
disconnect window and any other UI in that case.

Change-Id: I3ba89e7aaf7538ae5cce4385fb65256cb202ef5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527984
Commit-Queue: Joe Downing <joedow@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826351}

BUG=1029038

Change-Id: I81ccafffacc1188e485d9950ee84141143e7a8d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527627Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: Paul Jensen <pauljensen@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826350}

Note: Based on a few historical bugs that address a similar issue. Could not repro
on my personal test device, will coordinate verification with reporter.

Bug: 1145497
Change-Id: I3d1f9781037fad41cb1f7af578781eed9b7c1ec3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529971Reviewed-by: Jeffrey Cohen <jeffreycohen@chromium.org>
Commit-Queue: Travis Skare <skare@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826349}

This is the heart of the WebUI JS Error Reporting change. Have the
WebUIImpl::MainFrameNavigationObserver observe errors and, if
appropriate, send them off as error reports.

Since WebUIImpl::MainFrameNavigationObserver is gaining a sigificant
amount of functionality, split off into its own class,
WebUIMainFrameObserver, to aid unit testing. Also removed the word
'Navigation' from the name as it now observes console messages as well.

This is all hidden behind a flag at the moment, so no actual error
reports should be generated.

It's not complete. This is just 'step 4' in the design document. The
error reports still don't have a stack, and we don't handle subframes
properly, among other things.

Bug: chromium:1121816
Change-Id: I2640afe97ef3d8dd9f92e677844f59e1b08822e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2488345Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Reviewed-by: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Commit-Queue: Ian Barkley-Yeung <iby@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826348}

Custom margins break when the previewed content is rotated. Rotating is
also a very rare user action in print preview, and it is already
unavailable through a UI.

Remove the keyboard shortcuts and the context menu options.

Bug: 275471
Change-Id: Ia8e9e0efa0c2a676bd0e7a916e1fa848a4a21527
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527905Reviewed-by: Raymes Khoury <raymes@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826347}

This CL renames 'feature-policy-violation' report type to
'permissions-policy-violation'.

Note: [Feature policy reporting](https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/platform/runtime_enabled_features.json5;l=832?q=runtime_enabled_features.json5&ss=chromium) is currently experimental.

Bug: 1123116
Change-Id: I7c2c069ef47af4974337b9893f52b26af34dbbc7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505125Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Charlie Hu <chenleihu@google.com>
Cr-Commit-Position: refs/heads/master@{#826346}

TextField's child box can be taller than the intrinsic content height.
So we should center the child box if |ChildAvailableSize().block_size|
is not provided and the intrinsic block size is provided.

Bug: 1040826
Change-Id: If22091b06bf9b61a6e72eaca045c89fc58b07f0a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522801
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826345}

Presentation mode needs more work, as it's not supposed to be simply a
full screen version of the main content area of the PDF Viewer. Putting
it behind PdfViewerPresentationMode flag to facilitate further work on
that feature.

Fixed: 1147518
Change-Id: I7e81b7f3f26497c19ac490a82c90c2be2b647fe3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531896Reviewed-by: Daniel Hosseinian <dhoss@chromium.org>
Commit-Queue: Daniel Hosseinian <dhoss@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826344}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/184f98a6b7b4..3a4b8f58ae03

2020-11-11 aerotwist@chromium.org [Timeline] Fix blank traces when impacted_nodes is missing
2020-11-11 tvanderlippe@chromium.org Use TypeScript-authored files in media/
2020-11-11 me@heardanieljames.com Add 'Save' for images in frames displayed under the Application tab
2020-11-11 janscheffler@chromium.org [WebAuthn] Move newly added authenticator into view
2020-11-11 jacktfranklin@chromium.org Fix new data-grid empty state.
2020-11-11 petermarshall@chromium.org [tests] Re-export mocha functions properly in mocha-extensions
2020-11-11 tvanderlippe@chromium.org Redirect front_end/marked to third_party/marked
2020-11-11 tvanderlippe@chromium.org Use TypeScript-authored files in protocol_monitor/
2020-11-11 janscheffler@chromium.org Fix regression introduced by typescriptification
2020-11-11 janscheffler@chromium.org [WebAuthn] Add learn more link
2020-11-11 aerotwist@chromium.org TypeScriptify ChartViewport.js
2020-11-11 yiorsi@gmail.com Fix flex or grid adorner is not vertically centered in simplified Chinese version of Chrome
2020-11-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS.
2020-11-11 wolfi@chromium.org Disable flaky test
2020-11-11 janscheffler@chromium.org [WebAuthn] Fix flashing text when enabling the panel
2020-11-11 sigurds@chromium.org Display connection id '0' as empty cell in network log
2020-11-11 alexrudenko@chromium.org Add a method to calculate contrast according to APCA

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1011811,chromium:1101784,chromium:1121900,chromium:1125968,chromium:1145186,chromium:1147382,chromium:1147806
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I930f8257b1d5cdbf8106b8ab3cb07a13cfa8c301
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533093Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826343}

Change two strings to plural strings. e.g. "1 unread pages" to "1 unread
page".

Bug: 1133496
Change-Id: Iecccc6f87feaef3e1237e09f72d16f64d002bd42
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531494Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826342}

on wptrunner bots.

This is in preparation for triaging the test results. As part of the
triage, many of these tests will get more accurate metadata-based
expectations created for them.

Change-Id: Ia25b03d4cf26bdefd6012528ae21e450b630616b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502949
Auto-Submit: Luke Z <lpz@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826341}

Storing the price as a string does not scale to the use case where we
need to only show a price difference in the event of a decrease in
price. Storing as an int64 and storing in micros was chosen because
it enables price comparisons and scales to inflated currencies such
as yen and provides fractional digits as required.

Bug: 1145770
Change-Id: Ia5ced49146ff8dbf1140f2e96328ad58b108e68c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528168Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: David Maunder <davidjm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826340}

https://android.googlesource.com/platform/external/perfetto.git/+log/6835e1ab1918..0d4297e6b205

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Tbr: perfetto-bugs@google.com
Change-Id: If325d26d5046024f427c2282919125956aafd58d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532923Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826339}

Styling still WIP. This change enables the UI to show a prompt chip
when a composite command is selected.
- Selecting a composite command clears the input and shows a chip with
a prompt
- Backspace over the prompt when the input is empty informs the backend
that the prompt was cancelled, restores the previous user input, and
requeries

Bug: 1014639
Change-Id: I3fff2bf6cacab28b473c8ddee3a7a41fbb6df945
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530796Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826338}

TBR=mstensho

Bug: 1147315
Change-Id: I915e4a97e47e02a657fe67d4534694c59bf2552a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533017Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826337}

This CL adds exported deps for:
- org.checkerframework:checker-compat-qual
- org.codehaus.mojo:animal-sniffer-annotations

This is in preparation to switching to the maven version of guava in
order to avoid conflicts with the internal version of guava.

BUG=1144019

Change-Id: I4a2c49445f0ae389d508b7bcaac3da9b88935c11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527262Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#826336}

This is a reland of 73e9db73

Differs from the original CL by adding a
`DEFINE_EXPORTED_UI_CLASS_PROPERTY_TYPE` declaration needed
for linking.

Original change's description:
> Move DefaultFrameHeader to //chromeos/ui/frame/
>
> This header/class is directly used by BrowserNonClientFrameViewAsh.
> This steps goes one step closed to allow this class to be shared
> with Lacros.
>
> BUG=1113900
> R=jamescook@chromium.org, oshima@chromium.org
>
> Change-Id: I185560a34265e6ff13c48b48634faf6826f2236a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529570
> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#825896}

R=jamescook@chromium.org

Bug: 1113900
Change-Id: Ic0049f5024832104600d6b4e83cb86f1986db120
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2530292
Commit-Queue: James Cook <jamescook@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Auto-Submit: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#826335}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c6f52c21..48a46dd6

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I99064aad8bcae0e1279efbf0100d92258707cb13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532673Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#826334}