- 29 Sep, 2020 40 commits
-
-
Becca Hughes authored
Adds a policy so enterprise users can disable Kaleidoscope (media recommendations). Change-Id: I5ccd6aa99c77deb4ef91edcd8a3ea15c22f5bc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429463 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#811822}
-
Brandon Wylie authored
Bug: 1124434 Change-Id: I3f4252c3b69809ad6966202e7788b2368dc1385d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391612Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Brandon Wylie <wylieb@chromium.org> Cr-Commit-Position: refs/heads/master@{#811821}
-
David Bokan authored
The Viewport.MetaTagType UMA is broadly useful to get an understanding of what percentage of pages are "mobile optimized" so we extend it until M95. However, this CL removes the more specific Viewport.OverviewZoom histogram as it's no longer useful. Bug: 1089632 Change-Id: I0e4a06f043389bbc20e8d07a64263e2e9fccfba4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432770Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#811820}
-
Reilly Grant authored
Windows Update installs a custom composite device driver for Samsung Android devices. This driver appears to behave similarly to Microsoft's composite device driver except that it does not use the same instance ID format. This patch adds the driver to the list of recognized composite drivers and adds fallback logic to find the interface number in other hardware IDs. Bug: 1127206 Change-Id: Id48ed6673bf4a195f11a81f8284cc98730e99272 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436786 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#811819}
-
Maks Orlovich authored
This API is suspected to leak cross-site entropy about users. This instrumentation reports digests of the values read using this API to UKM to determine the available entropy of the API for identifying users across sites. Bug: 973801 Change-Id: I56a4002ae5ad4f1b0d56633a3ac74674b9f089be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434100Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#811818}
-
Becca Hughes authored
Add a histogram to collect aggregate watchtime for all media feeds so we can see the distribution of watchtimes. BUG=1110373 Change-Id: I472cff204e299efabe9f0b90949b14ca3d0fd912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432590Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#811817}
-
Peter Kotwicz authored
This CL removes the trailing slash - if there is one - from the --android-deps-dir command line parameter to //third_party/android_deps/fetch_all.py BUG=1132330 Change-Id: I8800cdc8ebc38150a47a52333646e86b24dd9b2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437021Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#811816}
-
Ian Kilpatrick authored
PaintLayer::PerspectiveOrigin didn't really require any information from PaintLayer, so moved it to LayoutBox. Additionally adds an additional optional parameter (the size) for when PerspectiveOrigin is called when the LayoutBox size in incorrect. This occurs with the new fragment overflow calculator as it calculates the layout-overflow *before* information is copied back to the LayoutBox. Bug: 1066616 Change-Id: Icb54306fe9804bb13de0fbb7e22b4657db3371ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412749 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#811815}
-
Viktor Semeniuk authored
This change removes margin for error message for all cr-inputs. For the username field it is added only if the input field is invalid. Bug: 377410 Change-Id: Ief394cf58ea3923e8ba25ffa8152be0b9cf7bd21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438390Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#811814}
-
Mohammad Refaat authored
This reverts commit 55996955. Reason for revert: Fixed the crash, which was caused by deleting the temp folder. Original change's description: > Revert "Add Crash Restoration support for multi-window" > > This reverts commit 64875586. > > Reason for revert: Speculatively reverting due to https://crbug.com/1132229. > > Original change's description: > > Add Crash Restoration support for multi-window > > > > After a crash info bar will be presented on all foreground scenes > > if the user choose to restore all foreground windows will be restored. > > if not all windows tabs for all windows which were opened on the last > > run will be added to the recent closed tabs. > > > > Bug: 1126311, 1114179 > > Change-Id: I80623012dc132e2702004d2dbc0bbcb410a7d91c > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2415929 > > Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> > > Reviewed-by: Mark Cogan <marq@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#810406} > > TBR=marq@chromium.org,mrefaat@chromium.org > > Change-Id: I4045617e7eb138e0212f8b1d1062df7ce0b45f74 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1126311 > Bug: 1114179 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428972 > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> > Cr-Commit-Position: refs/heads/master@{#810536} TBR=marq@chromium.org,mrefaat@chromium.org,jdoerrie@chromium.org Bug: 1126311, 1132229 Bug: 1114179 Change-Id: I911b88c3b57b54aff678648d2da7a6b03038610f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431454Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#811813}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fa4bfe45..0d81cd72 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iebe261137ce024d0fe60f11cffd24abe69e96fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436717Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811812}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/1075baee443c..ac160bd364cb 2020-09-29 bclayton@google.com System/Types: Add support for vec3 2020-09-29 bclayton@google.com Pipeline: Remove hack to disable spirv-opt when debugging If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I44a1204c02a272449058cde2fcec5433bff8d9a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438438Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811811}
-
David Maunder authored
We now enforce that Tab attributes cannot be acquired on an uninitialized Tab. If we don't bail out here we will attempt to pull the title or url off an uninitialized Tab leading to a crash. Bug: 1133038 Change-Id: Idd39105dc47ac208b5e9e33144996f3643fec25c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436326Reviewed-by:
Peter Williamson <petewil@chromium.org> Commit-Queue: David Maunder <davidjm@chromium.org> Cr-Commit-Position: refs/heads/master@{#811810}
-
Yang Guo authored
Fixed: chromium:1089720 Change-Id: I2844cc399d0a67cabf0df613ec4e2913dd01e364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438053 Auto-Submit: Yang Guo <yangguo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#811809}
-
David Dorwin authored
This test currently fails when run on Fuchsia's infrastructure because fuchsia.intl.PropertyProvider is not available in images used to run the tests on Fuchsia infrastructure and is not included by default in Fuchsia's hermetic test environment. fuchsia.sys.Loader is included in both. Bug: 1131669, fuchsia:53697 Change-Id: I7f3cc3386f16a82cc3865acdbd698759f076f284 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427000Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#811808}
-
Becca Hughes authored
Uses JS modules for the NTP module and updates closure so it can resolve chrome://kaleidoscope. Change-Id: I985b20a7faca215bd5194a4a21c790d5a4ff0262 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435441Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
Lambros Lambrou authored
This CL makes the RTC log data available in ConnectionToClient. For non-WebRTC client connections, nullptr is returned. Bug: 1122798 Change-Id: Ib613f304c6ebe9ec7af4496487eca5c12c5f03d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436282Reviewed-by:
Joe Downing <joedow@google.com> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#811806}
-
Stephen Martinis authored
These machines are using the main linux pool, which is overloaded. See bug for more details. No-Presubmit: true Bug: 1133410 Change-Id: I4b29e1d343c1dcbf46d185251db931199f06b322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438852 Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#811805}
-
Kevin McNee authored
A non-null BrowserPluginGuestManager is never set, so we remove the member variable. We also do a bit of polish on the ShellBrowserContext's constructor since we're in the area. Bug: 533069 Change-Id: I2bba2b59fa022c407803acb065df29b701d98d91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432756 Commit-Queue: Kevin McNee <mcnee@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#811804}
-
Avi Drissman authored
In https://ci.chromium.org/p/chrome/builders/official/mac64/1684: [44479/53271] CXX obj/chrome/browser/extensions/api/api_registration/generated_api_registration.o FAILED: obj/chrome/browser/extensions/api/api_registration/generated_api_registration.o ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/chrome/browser/extensions/api/api_registration/generated_api_registration.o.d obj/chrome/browser/extensions/api/api_registration/generated_api_registration.o In file included from gen/chrome/browser/extensions/api/generated_api_registration.cc:49: In file included from ../../chrome/browser/extensions/api/tabs/tabs_api.h:14: In file included from ../../components/translate/content/browser/content_translate_driver.h:14: gen/components/translate/content/common/translate.mojom.h:30:10: fatal error: 'components/translate/content/common/translate.mojom-shared.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. This fails because tabs_api is being included from outside, yet only declares the translation code as a deps and not a public_deps. Bug: 1130293 Change-Id: I86574e6a8688580d4ae8a465784e10b1bebae48d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436785Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#811803}
-
Muhammad Hasan Khan authored
BUG=b:149874690 TEST=deploy to dut, force backup codepath, verify the metric is logged in chrome://histograms Change-Id: I8f8d3c9c3708bbd7ac2ff014c37cd3ce25e2e131 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437011Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Cr-Commit-Position: refs/heads/master@{#811802}
-
Kuo-Hsin Yang authored
And remove these dead code path, these dead code paths make it harder to modify SystemMemoryPressureEvaluator. BUG=b:149833548 TEST=run chromeos_unittests Change-Id: I594009d05b39be43332708fd973e1a02031879a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421189Reviewed-by:
Brian Geffon <bgeffon@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Kuo-Hsin Yang <vovoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811801}
-
Maksim Moskvitin authored
StandaloneTrustedVaultClient is a plumbing class, that doesn't contain a lot of logic. Most of its test actually excersised StandaloneTrustedVaultBackend behavior (except ShouldPopulatePrimaryAccountChanges test). Incoming changes will make testing on the Client level more complicated and either requires extra changes in production code to allow mocking or making existing and future tests rather integration than unit. Since there are better ways to make integration tests and having unit tests on the Client level doesn't add much value, this CL: 1. Removes ShouldPopulatePrimaryAccountChanges, because it has no reasonable way for testing otherwise and exercises minor amount of logic. 2. Moves other tests to StandaloneTrustedVaultBackend level. Bug: 1102340 Change-Id: I707e9d04f8e536f1de07f0bd27e3a216a242bc52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436747 Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#811800}
-
Yuly Novikov authored
Including GPU, GPU.FYI and Dawn testers for trunk and M85. Also includes some small changes for consistency: - Don't specify GOMA backend for testers - Don't specify cores dimension on Mac (some are 4 and some 8 core) This is 2nd CL out of 3 moving these GCEs into luci.chromium.gpu.ci pool. 1. crrev.com/i/3295888 Allocate GCEs in luci.chromium.gpu.ci pool and increase chrome-gpu quota 2. This CL: Switch GPU CI testers to trigger tasks in luci.chromium.gpu.ci pool 3. crrev.com/i/3295890 Remove GCEs from luci.chomium.ci pool and decrease chrome-desktop quota Bug: 1132439 Change-Id: I385b625271b510816e322b0aa93e317634c59c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434087Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#811799}
-
Avi Drissman authored
In https://ci.chromium.org/p/chrome/builders/official/mac64/1623: chrome/browser/extensions/api/omnibox/omnibox_api.h includes components/omnibox/browser/autocomplete_match.h includes components/omnibox/browser/buildflags.h This fails due to three bad dependencies. 1. autocomplete_match.h includes buildflags.h, and is included from code outside of components/omnibox/browser so buildflags.h must be a public_deps 2. omnibox_api.h includes autocomplete_match.h so it must declare it in deps 3. because omnibox_api.h is further included outside of chrome/browser/extensions/api/omnibox, its inclusion of autocomplete_match.h means that autocomplete_match.h must be a public_deps (Thanks to rockot@ for the help.) Bug: 1130293 Change-Id: Ic08fbc648c9fed70e853b4c8ab1478fe4626a933 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436575Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
-
George Burgess IV authored
mac_address is a string16, so this assignment previously did `mac_address = (char16)3;`. That seems unintended. Bug: 1130867 Change-Id: I6cb4a5f86e1dfa0bc8eef68f7b81412006e6638f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426246 Commit-Queue: George Burgess <gbiv@chromium.org> Reviewed-by:
-
Mustaq Ahmed authored
Bug: 1103249 Change-Id: I31503d82a49f0104459e32be00776840705bfb7c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437480Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Cr-Commit-Position: refs/heads/master@{#811796}
-
Reilly Grant authored
This change enables the kUseSerialBusEnumerator feature by default, enabling an alternative method for performing the initial enumeration of serial ports which seems to include a few ports using older drivers that don't show up when using the more modern method. This still does not fix connection and disconnection events for such devices. If there are no reports of missing ports with this flag enabled it will be removed in M-89. Bug: 1119497 Change-Id: I42776a7edb737d69c52e9fb1f646a9ed60f1a668 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437490 Auto-Submit: Reilly Grant <reillyg@chromium.org> Commit-Queue: James Hollyer <jameshollyer@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#811795}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009290800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/5XZ2S6FH1ZMGrvfNVIJhAVxIJ3KGO-5PDM311qNGYwQC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: Idc8957b3a40d63f0f6c12c99f2148d9e54725089 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438437Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811794}
-
Daniel Rubery authored
This CL extends the expiring metrics under SBClientPhishing, since this feature is under active development, and all of the expiring metrics could plausibly be useful in investigating a regression. All histograms under SBClientMalware are marked as obsolete, since that feature is removed. Fixed: 1089451, 1089448, 1089450 Change-Id: I4df14afd924caf45f73daae051d0069263439c94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429425 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
-
Brian Sheedy authored
Adds a check before running a GPU Telemetry test for if the test device is an Android one, and if so, ensures that the screen is on. This is necessary to prevent flakes on the bots that occur if the screen is somehow accidentally turned off. Bug: 1132297 Change-Id: I08c0daaff92260c5c9fc1f52e7f0f7d22b448564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436779Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#811792}
-
Michael Hansen authored
Adds InvalidateFastInitiationAdvertising() to NearbySharingServiceImpl so that we can validate and update the Fast Init advertising state through a single idempotent flow. Bug: 1120082 Change-Id: I4aacc66acd1ddfe3c60caf1cf1b0c1d17da54743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437489Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Commit-Queue: Michael Hansen <hansenmichael@google.com> Cr-Commit-Position: refs/heads/master@{#811791}
-
Nela Kaczmarek authored
This change moves the implementation of MockAffiliationFetcherFactory from affiliation_service_impl_unittest.cc to mock_affiliation_fetcher_factory.h. This mock will be used in the well_known_change_password_state_unittest.cc. Bug: 1117045 Change-Id: I4938d4ca32d9baf2837f1769a86e44e5bc2fa642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434745Reviewed-by:
-
Maria Kazinova authored
Bug: 1075444, 1131038 Change-Id: I276aa7628088d810e422235f85564f0ac0930681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431428Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Maria Kazinova <kazinova@google.com> Cr-Commit-Position: refs/heads/master@{#811789}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009290800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/BJBtNPmOWXzOskdkiFU6S5dpkVPd-1G-Mq2BUPzToSUC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/161406194 Tbr: media-app@grotations.appspotmail.com Change-Id: Ic9e8c59c47099ae70c834e62db58105971c58d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438433Reviewed-by:
-
Peter Kasting authored
Bug: 772945 Change-Id: I466d0232ccdc0a621d7075bebbcb7adaca6bd767 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437610 Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#811787}
-
Russ Hamilton authored
This reverts commit f3134574. Reason for revert: WebUSB devices are too identifying to instrument per identifiability privacy study. Original change's description: > Instrument WebUSB.getDevices/requestDevice for Identifiability study. > > Bug: 973801 > Change-Id: Ia87925e48d9f0953b5f4e3a2d89472129e4ecee7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432424 > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Russ Hamilton <behamilton@google.com> > Cr-Commit-Position: refs/heads/master@{#811456} TBR=reillyg@chromium.org,behamilton@google.com Change-Id: I873fa51c11d3cd851ef6d8dc4bbf80cd33aa761a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437699Reviewed-by:
-
Torne (Richard Coles) authored
Remove the accidentally committed assert that caused test failures and reland: > When using a subdirectory of the Android cache dir (e.g. in WebView), > explicitly create the directory in PathUtils instead of relying on any > user of the directory creating it implicitly. > Set the directory mode to 02700 which is what it currently gets set to > when created implicitly. This reverts commit fbdad03f. Fixed: 963640 Fixed: 1132987 Change-Id: Ic94acaa1fd4dacb55839086699cc2974496e6bce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438469Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#811785}
-
Matt Jones authored
This patch switches the custom "add overlay" methods for a single unified "addSceneOverlay". This new method does insertion sort based on a predefined list determining the order of each overlay. Display order is no longer based exclusively on the order in which the overlays were added. If two overlays of the same type are added, the most recently added overlay will display above the others. Bug: 1070281, 1131536 Change-Id: I5764593debb13d30389f78303120ec4b4fcbb28f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392403 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#811784}
-
Mike Pinkerton authored
Adds the domain of the frontmost tab along with the number of tabs in the window to the UIScene's title, which gets displayed in the OS-level application switcher next to the application name. BUG=1132344 TEST=Will show only the domain for a single tab, and correctly pluralized strings of the number of other tabs when there are more than one. Change-Id: Iba8da572f8e042c8ab47092304a729b1b3de8bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435939 Commit-Queue: Mark Cogan <marq@chromium.org> Auto-Submit: Mike Pinkerton <pinkerton@chromium.org> Reviewed-by:
-
