GitLab

This change removes clock icon from site suggestions.

Bug: 994847
Change-Id: I1ac2e656bf4bdb955cf00662d737481f90634cf2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758630
Commit-Queue: Ender <ender@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688157}

Currently, if the user presses an End Key on an intranet URL with no
path, i.e. "https://foobar" elided to "foobar/", the cursor position
will not end up in the right place.

This is because the elided form is not a strict substring of the full
formatted URL.

This CL fixes this corner case and adds a test.

Bug: 883310
Change-Id: Id3bb4c24da05dc8de3b2703edc5b12c1f2e3cab4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759230
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688156}

This is a follow-up CL for addressing comments in crrev.com/c/1737993:
https://chromium-review.googlesource.com/c/chromium/src/+/1737993/14/third_party/blink/web_tests/external/wpt/resources/chromium/nfc-mock.js#276

BUG=520391

Change-Id: I92ac1229d59d1a76d830f2a1d58acf04c2846f3d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760596
Auto-Submit: Leon Han <leon.han@intel.com>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688155}

- Reverts the revert in http://crrev/c/1755004, i.e. instantiates the
  collection of persistent histograms.
- Registers a FileMetricsProvider to upload collected metrics.
- Added ios_chrome_metrics_service_client_unittest.mm, patterned after
  chrome_metrics_service_client_unittest.cc.

Bug: 994743
Change-Id: Id8e7ce79f0825eb1cd4c1fb7051709c1d3880cc5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752699
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688154}

https://skia.googlesource.com/skia.git/+log/f8221786d088..3f7932e73316

git log f8221786d088..3f7932e73316 --date=short --no-merges --format='%ad %ae %s'
2019-08-19 csmartdalton@google.com Add kRequiresManualMSAAResolve to GrInternalSurfaceFlags

Created with:
  gclient setdep -r src/third_party/skia@3f7932e73316

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=egdaniel@google.com

Bug: None
Change-Id: I74b45021250035c7ee7d84e8942ef9211eec5b17
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760022Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688153}

This cl marks a few fast/convas tests as slow on Mac and/or Debug builds.
Their virtual/gpu equivalents have already been marked as slow.

TBR=fserb@chromium.org
NOTRY=TRUE

Bug: 983642
Change-Id: I2c4ad66a9c073b8f8402710b7d0e87456dfc4e5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760142
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Reviewed-by: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688152}

Using wpt-import in Chromium 1e38d7c2.
With Chromium commits locally applied on WPT:
1da9cc73 "[LargestContentfulPaint] Add larger content tests"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
kojii@chromium.org:
  external/wpt/css/css-writing-modes

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa

No-Export: true
Change-Id: Ie3b512564ddceb1ab3658717de1c7a6a51c47c22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760415Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688151}

FrameSchedulerImpl relies on a "frame visible" state bit propagated
from LocalFrameView via RenderThrottlingStatusChanged(). However, it
is possible that the bit never gets propagated because the frame
doesn't actually transition throttling state. In that case,
FrameSchedulerImpl will not throttle timers as it should.

This patch ensures that the state bits are properly forwarded to
the scheduler, even if the LocalFrameView's throttling status doesn't
change.

BUG=971590
R=alexclarke@chromium.org

Change-Id: I5913a3d118479ccd84b77ef86f0582f4892a3c6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758224Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Commit-Queue: Stefan Zager <szager@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688150}

This change extracts shared functionality (related to recomputing
calculated timing) from AnimationEffect and WorkletAnimationEffect

Bug: 915344
Change-Id: Ia01f938d3589a79a6702bf3efbab8aa0654a6ed7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740867Reviewed-by: Robert Flack <flackr@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Jordan Taylor <jortaylo@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#688149}

AccountTracker in gcm get account_id from identity_manager. This account_id
should not be std::string so that it is not confused with gaia_id or email.

Bug: 959157
Change-Id: Ie5f861bf6632226d6105a5c47b51f0dd0edc1516
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739427
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688148}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/92433291..05137a76

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I78a3cf9d115deeb3befd8dd1438c03a17b0b0108
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760414Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688147}

This reverts commit 87dac882.

Reason for revert: Breaks UMA recording.

Original change's description:
> Add full system profiles in .pma file as part of metrics init.
> 
> Prior to this change, only an incomplete system profile, notably
> missing field trials and uma_default_state fields, was stored
> at this point. So unclean shut downs after this point in time,
> but before the initial metrics log was saved would not include
> that info. This change fixes that by running the code that
> populates all the system profile fields.
> 
> Since we're now calling ProvideSystemProfileMetrics() twice, the
> logic in FieldTrialsProvider was no longer correct in tracking
> the log creation time. Instead, this CL updates the API to have
> that be passed in.
> 
> Additionally, Chrome OS an Screen Info providers needed updates since
> their dependencies are not yet available this early, so they are not
> able to provide all the information this early.
> 
> Finally, webview unit tests needed updating to init mojo as they are
> now exercising the provider code which has a Mojo dependency.
> 
> Bug: 992538
> TBR: sky@chromium.org
> Change-Id: Iae54398065470e390b70507d5b3ac09d5a983c9f
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746909
> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Brian White <bcwhite@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#687000}

TBR=sky@chromium.org,rkaplow@chromium.org,asvitkine@chromium.org,torne@chromium.org,bcwhite@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 992538
Change-Id: I4a25324788960d2e61325c2a41812c5da18087f8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760869Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688146}

This is a preparation of replace cc::TransformNode::pre_local and
post_local with a simple Point3DF for transform origin.

Previously post_local was used in the following cases (other than for
transform origin):
- root layer: external transform (above root) and device scale factor
- page scale layer: for page scale

This CL removes the case of
- the same layer for root layer and page scale layer, and
- custom transform on the root layer,
so that we can use cc::Transform::local for external transform and
device scale factor in the transform node of the root layer, and for
page scale in the transform node of the page scale layer.

This is an intermediate step before we switch all impl-side cc unit
tests to layer list mode. After that, we no longer need dedicated
page scale layer.

Bug: 993937
Change-Id: I4b6b0340bd6b2421a2c29844989e3ffef078dcf7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756712
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688145}

Bug: 900581
Change-Id: Ib27f3df1a5aeb76ba8e24b5b1040a75efb7a1f6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760139Reviewed-by: Xida Chen <xidachen@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688144}

Bug: 965721
Test: manual end to end
Change-Id: I6dbf6081d1babde6f0476a93b66392864acf2898
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760858Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688143}

(second half of
 https://chromium-review.googlesource.com/c/chromium/src/+/1756247)

This is step #1 of the mass migration. Some of these will be
backported to SingleThreadTaskEnvironment in a later phase.

scoped_task_environment.h will also only move in a follow-up CL.

TBR=dcheng@chromium.org

Bug: 992483
Change-Id: Ie80f083eeeb209180ab3c2884f1b566f73549cc6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756248Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688142}

Architecture:
Superclass - scannerView
Subclasses - qrScannerView

- Shift the video preview view and preview overlay view to shared 'scanner' directory.

Bug: 990744
Change-Id: Ib81957f80d18b205865d9e4e6390c4ca56e4cf77
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736889
Commit-Queue: Tanisha Mandre <tanishamandre@google.com>
Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688141}

******************************Resource Sizes Diff******************************
Specifics:
       +77,824 bytes main lib size
      +626,344 bytes main dex size
    +1,028,222 bytes normalized apk size
InstallSize:
      +402,088 bytes APK size
    +1,134,911 bytes Estimated installed size (Android Go)
    +2,932,517 bytes Estimated installed size
InstallBreakdown (+2,929,368 bytes):
        +3,954 bytes Native resources (no l10n) size
        +2,139 bytes Non-compiled Android resources size
       +77,824 bytes Native code size
        +3,412 bytes PNG drawables size
          +603 bytes Package metadata size
    +2,813,504 bytes Java code size
       +27,932 bytes Compiled Android resources size
Dex:
        +2,938 entries fields
        +2,473 entries strings
        +3,989 entries unique methods
        +1,255 entries types
        +3,989 entries methods

Change-Id: I5a72a2c017cfdc16b56308d59e11ae205baaf6e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759928Reviewed-by: Sky Malice <skym@chromium.org>
Commit-Queue: Gang Wu <gangwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688140}

This is in preparation for requiring WARN_UNUSED_RESULT on
NavigateToURL() usage in tests.

Bug: 425335
Change-Id: I27391139d718457da50d9e96d7ffc958d1d4a11e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755544Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688139}

Change-Id: Ied8e0177399d514a26be17092f4dcdbbcf659574
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757989Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688138}

Split off from https://crrev.com/c/1751324

The ResourceLoadPriority tests send Priority and a Status result via
postMessage. Due to the way this is implemented the test is unnecesarially
sensitive to the loading order and can fail even when the thing it's
actually testing passes.  This patch changes the message to a key-value
pair which is more robust.

Bug: 971191
Change-Id: Ieb7d7d736c363b75a0b1e2e1f1a2ad95cfaddbff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760226
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688137}

components/crash/ supports multiple embedders (not just chrome) so
chrome specific crash configuration should live in its
CrashReporterClient implementation.

Change-Id: I6406f06e1a228c69bcaa4654a7743d039229fa3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756423Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688136}

This minimizes the readability cost for using custom frame colors.

Bug: 854738
Change-Id: Ifee3e07a6a1317c93c1e5bccdcce921008d7e58a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759223
Auto-Submit: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688135}

Bug: 966388
Change-Id: Ic07d37be9443516563817533c5bd2613b973c6b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760207
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688134}

Bug: 979201
Change-Id: Idfc2836db82f7f8ae68b580e84f2fbb65aba1337
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1759222Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688133}

All callers have been migrated to the new API, cleanup the old ones.

Bug: 983174
Change-Id: I28c851e363d74079e6a7f669726e24710d004c4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758592Reviewed-by: Sergey Poromov <poromov@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688132}

https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/2906c3c5b3bf..795a3ae59002

git log 2906c3c5b3bf..795a3ae59002 --date=short --no-merges --format='%ad %ae %s'
2019-08-19 rsmoore@google.com Merge branch 'release-candidate' into stable

Created with:
  gclient setdep -r src/ios/third_party/material_components_ios/src@795a3ae59002

The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc
TBR=bling-p10-rolls@google.com

Bug: None
Change-Id: I3ed99c4134f93a7d3f1d9e0b1beb525d6c96515a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760018Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688131}

WebPlatformTests (wpt.fyi) assumes that the product in test can
support mutliple windows such that one window can run as a test
runner, while we run the test on another window.
On top of multiple window support, we enable JavaScript, and
INTERNET is already enabled in system webview shell.

Bug: 992947
Change-Id: I4688040b828b7c40f67f3bc809065015909567d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747371Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688130}

sigtimedwait() is used by Crashpad clients to wait for crash dump
completion.
https://osscs.corp.google.com/chromium/chromium/src/+/master:third_party/crashpad/crashpad/util/linux/exception_handler_client.cc;l=143?q=exception_handler_client&ss=chromium

Bug: 942279
Change-Id: Id6f744c278a072dd495995b2040238661881c900
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760133Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Joshua Peraza <jperaza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688129}

Bug: dawn:154
Change-Id: I40c484f40c618a564c7f462aa21785ce85a68020
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758807Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Austin Eng <enga@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688128}

Bug: 986298
Change-Id: I9dfb009d49e8f287ca8fdd10c6b922a372b583c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758449
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688127}

Because there was a virtual call to one of its methods (factory_->Create...)
but the class was never instantiated, the UBSan build failed like this:

  FAILED: unit_tests
  ../../third_party/llvm-build/Release+Asserts/bin/c...
  ld.lld: error: undefined symbol: typeinfo for safe_browsing::MultipartUploadRequestFactory
  >>> referenced by multipart_uploader.cc
  >>>               safe_browsing/multipart_uploader.o:(.data..L__unnamed_37+0x18) in archive obj/chrome/browser/safe_browsing/libsafe_browsing.a
  clang-10: error: linker command failed with exit code 1 (use -v to see invocation)

It turns out factory_ is always NULL, and the class was never actually used.

Bug: 993693
Change-Id: If10eea4adb7bd99d826be4630d945cbf0643eab9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752850Reviewed-by: Daniel Rubery <drubery@chromium.org>
Commit-Queue: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688126}

When we've built the shadow tree for a <use>, we should not have set up
any new instance references, and the old one's should have been
invalidated when the element was marked for "shadow tree recreation".

Drop the InvalidateDependentShadowTrees() call in
SVGUseElement::BuildPendingResource() and also add a DCHECK in
Document::UpdateUseShadowTreesIfNeeded() for checking that the shadow
tree construction did not add any new entries to the set (which would
make the document state inconsistent).

This should pave the way for a future change that performs the instance
mapping as part of shadow tree building rather than during layout
attach.

Bug: 953263, 986114
Change-Id: I3474eea0d8face10b88315421aaa36ca782a6e3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757834Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#688125}

Adapt ScrollableShelfView's layout to new specs

Bug: 973481
Change-Id: I9990c86892c388e17657c6cc1347efc9877be197
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757429Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688124}

This patch implements basic float painting in
|NGBoxFragmentPainter| when children are not inline.
1. Change |PaintFloats| to work without |NGPaintFragment|.
2. Apply the |kFloat| paint phase logic in |PaintObject| to
   when |ChildrenInline| is false.

The block logic is very similar to the inline logic, but this
patch does little work to share because the inline logic will
need to revise by the NGFragmentItem work.

Fixes ~200 tests, failures is down to ~500. There are still
some floats failures and they seem complex, such as when
floats are under the engine boundaries. They need to be
investigated in future patches.

There should be no behavior changes unless NG painter is
enabled for block boxes.

Bug: 988015
Change-Id: I90a152ee31a6db5d69d611a097e28af0823a47a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757988
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688123}

Roll src/net/third_party/quiche/src/ 4abb566fb..fd3ee30e9 (16 commits)

https://quiche.googlesource.com/quiche.git/+log/4abb566fbbc6..fd3ee30e9b48

$ git log 4abb566fb..fd3ee30e9 --date=short --no-merges --format='%ad %ae %s'
2019-08-16 bnc Add QUIC_EXPORT_PRIVATE macros to qpack_index_conversions.h functions.
2019-08-15 bnc Remove SpdyString wrapper for std::string.
2019-08-15 dschinazi Do not queue coalesced undecryptable packets twice
2019-08-15 bnc Support blocked decoding in qpack_round_trip_fuzzer.cc.
2019-08-15 renjietang Prevent duplicate HTTP/3 control stream.
2019-08-15 zhongyi Re-arrange the order of the code to call OnConnectivityProbeReceived.
2019-08-15 fayang gfe-relnote: In QUIC, add probe timeout mode, which unifies TLP and RTO. Protected by gfe2_reloadable_flag_quic_enable_pto.
2019-08-15 bnc Check that every dynamic entry reference is acknowledged.
2019-08-15 bnc Add fuzzer data transmitters for header blocks and encoder/decoder stream data in qpack_round_trip_fuzzer.cc.
2019-08-14 fayang gfe-relnote: In QUIC, schedule RTO whenever there is bytes in flight (rather than pending retransmittable frames). When timer fires in RTO_MODE and there is no data to send, force to send PING. Protected by gfe2_reloadable_flag_quic_fix_rto_retransmission3 which replaces gfe2_reloadable_flag_quic_fix_rto_retransmission2.
2019-08-14 bnc Factor out QPACK absolute, relative, and post-base index conversion functions, and add new ones.
2019-08-14 bnc Fix QpackDecoder::EncoderStreamRelativeIndexToAbsoluteIndex(), simplify QpackProgressiveDecoder::RequestStreamRelativeIndexToAbsoluteIndex().
2019-08-14 dschinazi Add VersionNegotiationProbeEndToEnd test
2019-08-14 renjietang Update StreamIdManagerTest.
2019-08-14 bnc Refactor QPACK roundtrip fuzzer.
2019-08-14 quiche-dev gfe-relnote: Implement sending the MAX_PUSH_ID frame when the client sets a non-zero maximum push id.

Created with:
  roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src

R=rch@chromium.org

Change-Id: Ia98bffe41bc1f5e70ac501e6a78d104962a31ac0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757287
Commit-Queue: Ian Swett <ianswett@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688122}

Bookmarks Sync USS has been enabled by default in M77, but it turned
out that it's not yet ready for prime time.

The plan is to disable it, and merge the disable CL back to M77,
and enable it by default for M78.

Change-Id: I1031714f42830ddf3b81a44d4036f29b338d6bb1
Bug: 950869,516866
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760911
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Auto-Submit: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688121}

https://webrtc.googlesource.com/src.git/+log/f5e5d250bc85..185243b33522

git log f5e5d250bc85..185243b33522 --date=short --no-merges --format='%ad %ae %s'
2019-08-19 sprang@webrtc.org Remove most of PacedSenderUnittest
2019-08-19 artit@webrtc.org Roll chromium_revision c7f14188..afb0a631 (687843:688061)
2019-08-19 henrik.lundin@webrtc.org NetEq fuzzer: reduce max input size slightly to avoid timeout
2019-08-19 peah@webrtc.org Reland of Correct conversion between float and fixed formats
2019-08-19 sakal@webrtc.org Revert "Introduce ability to test echo in PC level test framework"
2019-08-19 sprang@webrtc.org Remove some usage of RtpRtcp::SetSSRC()
2019-08-19 gustaf@webrtc.org AEC3: Fix computation of audio buffer delay
2019-08-19 chxg@google.com Enable `VideoReceiveStreamTestWithFakeDecoder.RenderedFrameUpdatesGetSources` for iOS.
2019-08-19 titovartem@webrtc.org Introduce ability to test echo in PC level test framework
2019-08-19 titovartem@google.com Add steps logging into PC test framework
2019-08-19 danilchap@webrtc.org Delete deprecated RtpRtcp::CreateRtpRtcp factory
2019-08-19 artit@webrtc.org Roll chromium_revision d5a13ccb..c7f14188 (687732:687843)
2019-08-19 mbonadei@webrtc.org Remove rtcbot.
2019-08-19 hbos@webrtc.org Reland "[GetStats] Expose video codec implementation in standardized metrics."
2019-08-19 sprang@webrtc.org Extract most of PacedSender into PacedSendingController.
2019-08-19 jonaso@webrtc.org Update constributing source before publishing frame
2019-08-16 mellem@webrtc.org Only combine media transport and ICE states if used for media.
2019-08-16 kron@webrtc.org Remove deprecated constructors of RtpSource
2019-08-16 yinwa@webrtc.org Allowing 40ms audio frame length.
2019-08-16 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c7f850c7..d5a13ccb (687596:687732)

Created with:
  gclient setdep -r src/third_party/webrtc@185243b33522

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: chromium:None,chromium:988542,chromium:None,chromium:None,chromium:None,chromium:None
Change-Id: I5760e7b8cdf706345b79b3da36f520495fba9f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1760017Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#688120}

Keep the placeholder's virtualURL in sync with its URL.  Otherwise, a
previous page's virtualURL can still be used for a new page's URL.

Bug: 995066
Change-Id: I5314591e1605987317ee7964dadc2f4c5c699afa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758975Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688119}

Before this CL, DataTypeController::RegisterWithBackend got a callback
parameter, which (for USS types) was always synchronously called, and
for directory types was not called at all.
After this CL: DataTypeController::RegisterWithBackend directly returns
an enum value with the result. The enum includes an "ignored" value for
directory types.

Bug: 991907
Change-Id: I9f36ef69a4952c4869c55b8dfbff48c55a8de567
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751984
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#688118}