- 21 Jun, 2018 40 commits
-
-
Marc Treib authored
Previously, we cleared Sync data on most, but not all types of unrecoverable errors: Engine initialization failure was treated specially. Per the TODO removed in this CL, there was no reason for the special treatment anymore. Bug: 839834 Change-Id: I3b473c65b837c810e6fe8456defffe6ebe6e53a2 Reviewed-on: https://chromium-review.googlesource.com/1107991Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#569226}
-
Mikel Astiz authored
They are motivated by an ongoing investigation for test flakiness on iOS, with the suspicion that some of the codepaths (namely, where calls to OnSyncStopping() could be dropped) can cause issues (e.g. sync metadata being leaked). Bug: 854446 Change-Id: I6fe7da40c36d00e01afa176334f59f9dc66a74e1 Reviewed-on: https://chromium-review.googlesource.com/1108200Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#569225}
-
Vasilii Sukhanov authored
The UI needs the new password value. Thus, the method is needed in ChromePasswordManagerClient. Also it doesn't seem right to scatter all the generation events across two interfaces while autofill::mojom::PasswordManagerClient solely concentrates on generation. Bug: 851021 Change-Id: I6a6dcc59a934202bb0e2e336ff1324da131c6dfd Reviewed-on: https://chromium-review.googlesource.com/1104339Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#569224}
-
Morten Stenshorne authored
And that's how it's supposed to work, apparently. We're just supposed to mark such lines dirty when the objects get deleted, and the dangling pointers will be cleaned up "soon enough". When removing a FloatingObject, we need to mark the RootInlineBox object that points to it as dirty. The case we were missing was the one where we remove ALL floating objects. When removing just one, on the other hand, we use LayoutBlockFlow::RemoveFloatingObject(), which already takes care of this. Bug: 835613 Change-Id: I2b978f1bb4c9a496a5dad4b097ef598630059a9d Reviewed-on: https://chromium-review.googlesource.com/1108936 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#569223}
-
Philip Jägenstedt authored
SpeechGrammarList's addFromURI because it doesn't match the spec: https://github.com/w3c/speech-api/issues/26 SpeechRecognitionEvent's interpretation and emma attributes because they actually always return null and might be better to remove: https://chromium.googlesource.com/chromium/src/+/7ad6ea7c2583942e86017bdd6fd5df991f6a05af/third_party/blink/renderer/modules/speech/speech_recognition_event.h#55 SpeechSynthesis#speak() to measure real SpeechSynthesis usage, like the existing counter for SpeechRecognition#start(). Bug: 755287 Change-Id: I4f7fdcc5630887aaa051ac8ab13f72dab52c8dfb Reviewed-on: https://chromium-review.googlesource.com/1109510Reviewed-by:
-
Gyuyoung Kim authored
Although there have been the thresholds of cache usage limitations for the Android in /gpu/config/gpu_preferences.h, it would be good if we can give embedders the power to set the cache size for the ShaderDiskCache. Because there are many various embedded devices which have different sizes of disk. Bug: 854494 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie1ecb903a79e52ee79503df30fe1ae15b95739ea Reviewed-on: https://chromium-review.googlesource.com/1107517 Commit-Queue: Gyuyoung Kim <gyuyoung.kim@lge.com> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#569221}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f3c454475aee..44fc6f687b35 git log f3c454475aee..44fc6f687b35 --date=short --no-merges --format='%ad %ae %s' 2018-06-21 perezju@chromium.org [soundwave] Fix GetAlertData API call Created with: gclient setdep -r src/third_party/catapult@44fc6f687b35 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I3a63d4bb9a29fdf8634d1713085da7950a5563b9 Reviewed-on: https://chromium-review.googlesource.com/1109698Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569220}
-
Wez authored
The issues that this logging was introduced to diagnose are understood and/or resolved, so it can be removed. Also clean up some OS_POSIX && !OS_FUCHSIA preprocessor conditionals, and migrate TestLauncher to use the zx::job container from the SDK. Bug: 755282, 750370, 738275, 706592 Change-Id: Iedfaa62684a0b6e8524a456766186b4122e98ae0 Reviewed-on: https://chromium-review.googlesource.com/1108483 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#569219}
-
Igor authored
If the device is disabled, it can be brought back to life only by the admin of the domain. And to re-enable the device, admin needs the serial number which might not match the data displayed on the sticker. Or the sticker could be damaged. This change will provide the serial number on the disabled device screen. BUG=chromium:852284 TEST=Unit tests Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3fe38afc59d7c08ffc175c723b1a37660d8b1160 Reviewed-on: https://chromium-review.googlesource.com/1101209Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#569218}
-
Eero Häkkinen authored
This improves down sampling performance by 40 percent in all cases on x64 with AVX and up sampling performance by 50 percent in the case of large input block sizes (256 samples or more) on x64 with AVX. Up sampling performance in the case of normal input block sizes (128 samples) is not affected. Performance improvements on x64 with SSE but without AVX are even bigger than those on x64 with AVX. On Arm, the performance improvement is 270 percent. When FFT resampling is used for the WaveShaper, we need to account for some small round-off errors in the result compared with the previous direct convolver. Slightly adjust how the thresholds work and the threshold value for the tests. Thanks to Raymond Toy (rtoy@) for these layout test updates. Bug: 851941 Change-Id: I2dc4bb30ccc6d1314a3e779a61ffac210cf702a1 Reviewed-on: https://chromium-review.googlesource.com/1090841 Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#569217}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/c203a76fa400..ae8db279f88e git log c203a76fa400..ae8db279f88e --date=short --no-merges --format='%ad %ae %s' 2018-06-21 taylori@google.com Merge "trace_processor: Parse process and trace packets" 2018-06-21 taylori@google.com Merge "trace_processor: Assign utid and store thread info when processing sched event" 2018-06-20 taylori@google.com trace_processor: Parse process and trace packets 2018-06-20 taylori@google.com trace_processor: Assign utid and store thread info when processing sched event Created with: gclient setdep -r src/third_party/perfetto@ae8db279f88e The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:80416541,chromium:80416541 TBR=perfetto-bugs@google.com Change-Id: I7456bbaa350186324026a76a4e57062b364005f3 Reviewed-on: https://chromium-review.googlesource.com/1109699 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569216}
-
Juan Antonio Navarro Pérez authored
This reverts commit c6c7cdfc. Reason for revert: Wrong story was disabled. Original change's description: > Disable Flaky SystemHealthBenchmarkSmokeTest. > > BUG=852888 > > TBR=perezju@chromium.org > > Change-Id: I773594071fb0e9357af63d3024dd71125cad9723 > Reviewed-on: https://chromium-review.googlesource.com/1104880 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Steven Holte <holte@chromium.org> > Cr-Commit-Position: refs/heads/master@{#568140} TBR=holte@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. NOTRY=True Bug: 852888 Change-Id: Ibded1b8ca4185a53323dcd26e76501b25dfd6a54 Reviewed-on: https://chromium-review.googlesource.com/1109039 Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#569215}
-
Suneel Kota authored
This CL sets the alignment of the Anchor node in accordance, when vertical-rl writing-mode is set Bug: 844868 Change-Id: I8357bcccbc88ffcd3b5d01265737a5b60f1e59a8 Reviewed-on: https://chromium-review.googlesource.com/1075956 Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#569214}
-
Thomas Tangl authored
When the user is signed out of Chrome and the profile icon has not been explicitly changed, AvatarToolbarButton now uses the account icon of the first sync promo account. Screenshots: https://drive.google.com/file/d/1a7kr12KtA11Wt7MQ9MLnSf-M3D9nlLdg/view?usp=sharing https://drive.google.com/file/d/1nKLnoD1sbcZOvwGQY3YtHVTUv32DQNFn/view?usp=sharing Bug: 853363 Change-Id: I11ed80e2250bc4eb9202e4a1c4cabf242954f726 Reviewed-on: https://chromium-review.googlesource.com/1105772 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#569213}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/160d2815..2b67614b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id66e0898bb76dbdbb592239dde3dd0db2cbc0f66 Reviewed-on: https://chromium-review.googlesource.com/1108889Reviewed-by:
V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#569212}
-
Elad Alon authored
The feature of WebRTC event logging to a remote server, is now intended to be gated behind a Chrome policy. As such, it would make more sense to treat incognito mode as any other profile, which does not have the policy enabled. Bug: 775415 Change-Id: I14c0b5e14578fc8a5ae27d8921583728e8850282 Reviewed-on: https://chromium-review.googlesource.com/1105770 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#569211}
-
Matthew Cary authored
The Clank orderfile is being improved as part of an effort to improve Clank memory usage [1]. One step in this effort is to give telemetry benchmarks more control over instrumentation profiling. In this CL I extend the devtools RequestMemoryDump command to also tell instrumentation support to dump the current profile. This only happens if chrome is compiled with instrumentation turned on (use_order_profiling=true). The instrumentation dump is done at the same time as the memory dump is handled on the client side. [1] https://docs.google.com/document/d/1dAt_puAX4SyqXDOdglxe6ku9GwnyBiOMjHAsDNwN0HY/edit# Bug: 843561 Change-Id: I6d08e1cd24dc6f16ca12f8fa519ab9725d3ed914 Reviewed-on: https://chromium-review.googlesource.com/1087959 Commit-Queue: Matthew Cary <mattcary@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Primiano Tucci <primiano@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569210}
-
Matt Falkenhagen authored
It's sometimes useful for Blink to define features instead of putting them in //content. In this case, ServiceWorkerServicification. Follow-up to r568796 <https://chromium-review.googlesource.com/1107435>. Change-Id: Ia174481414f2ceeb2f463307436170628da84346 Reviewed-on: https://chromium-review.googlesource.com/1108237 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#569209}
-
Fergal Daly authored
The name was appropriate at the start but not it checks much more than this. Change-Id: Id9b01ae5f62cc2fbc834559e80f75dc6305e7d21 Reviewed-on: https://chromium-review.googlesource.com/1109670Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#569208}
-
Takuto Ikuta authored
v8_context_snapshot is not the target to be linked to other libraries. This improves build time of some targets by utilize parallelization. For example, build time of -j800 content_shell reduced from 316.8s to 254.5s on Z840 linux without goma backend cache. See the difference of build trace screenshots in https://bugs.chromium.org/p/chromium/issues/detail?id=725639#c20 Bug: 725639 Change-Id: I64d57241ff6b742db4ddcb31afc07a5e7c2e2eb1 Reviewed-on: https://chromium-review.googlesource.com/1107431Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Jay Civelli <jcivelli@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#569207}
-
Marcin Wiacek authored
Next cleanup after https://chromium-review.googlesource.com/c/chromium/src/+/1091753 * Using int const instead of String inside SiteSettingsCategory.java * Creating dynamically ContentSettingException array inside Website.java * Sharing preference keys from SiteSettingsPreferences.java with category keys in the SiteSettingsCategory.java * Other minor cleanups inside Android preferences/website directory Change-Id: I2e4a97e0f54f6e91aa47a931905e869988ad1858 Reviewed-on: https://chromium-review.googlesource.com/1097408Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#569206}
-
Ulan Degenbaev authored
The cu_id_web_contents_map_ can be mutated by observers and can make the iterator in NotifyObserversIfKnownCu invalid. See the comment of the regression test for the description of the scenario that can happen with tab discarding. Change-Id: I90a7f1710655573fa059bf3f12bf40013ebc7743 Reviewed-on: https://chromium-review.googlesource.com/1107798 Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#569205}
-
Rune Lillesveen authored
They are only used for storing an extra ComputedStyle for display:contents pseudo elements as the ComputedStyle for rendering uses a display:inline with only properties inherited for the parent element. Bug: 854563 Change-Id: I4dd3d99b0dee0b538645d005b36347b469799244 Reviewed-on: https://chromium-review.googlesource.com/1107802Reviewed-by:
Anders Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#569204}
-
Friedrich Horschig authored
Add the @RetryOnFailure annotations. These tests rely on the keyboard which seems to have massive troubles on some trybots only. I am still looking for a better way to ensure the keyboard is up and will try to replace this. If this doesn't improve the tests, the next, sad step is to disable them temporarily. Bug: 854326 Change-Id: I7d1bba9a5efa6213fc53c1d84e0fcf88ec3ba9dd Reviewed-on: https://chromium-review.googlesource.com/1109679Reviewed-by:
-
Friedrich Horschig authored
Another test that relies on the keyboard to work. Disabling it for now. (If more tests in this directory flake, feel free to disable them right away - they are not testing live code. A big rework for all of them is likely in a forseeable future.) TBR: bauerb@chromium.org Bug: 854224 Change-Id: I3b27fd0e500f282ef71d7206ee1ef774edcbe4a5 Reviewed-on: https://chromium-review.googlesource.com/1109682Reviewed-by:
Friedrich Horschig <fhorschig@chromium.org> Reviewed-by:
-
Colin Blundell authored
This CL adds IdentityTestEnvironment APIs to interact with the refresh token state of secondary accounts; these APIs will be needed in an upcoming CL. In this CL we also change all such test APIs that return the account ID of a newly-set account to instead return the AccountInfo; for the upcoming use case, this will be convenient. Bug: 798699 Change-Id: I9deceae9fb016147fce6206c263acf638d21ef6e Reviewed-on: https://chromium-review.googlesource.com/1107984 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#569201}
-
Robert Ma authored
Mainly for https://github.com/web-platform-tests/wpt/pull/11344 Rebaselined some affected infra tests. (Note: a SAB test in html/infrastructure is now failing instead of timing out because of the wptserve change. The failure is expected because SAB is currently disabled, so we change the expectation accordingly.) Bug: 854473 Change-Id: I0f3218328992141033a593be0882c436ec7ff7a6 Reviewed-on: https://chromium-review.googlesource.com/1108744 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#569200}
-
Yoshifumi Inoue authored
This patch inttroduces |MoveToParent()| and |MoveToPrevious()| in |NGPaintFragmentTraversal| class for the patch[1], which uses |MoveToPrevious()| to find text fragment in same line. This patch also utilize |MoveToParent()| in |MoveToNext()| to share code for improving code health. [1] http://crrev.com/c/1104082 [LayoutNG] Adapt accessibility module to LayoutNG; Bug: 774229 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: If65e3015b8f4ed768325c0e13df121c0bc378580 Reviewed-on: https://chromium-review.googlesource.com/1109609Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#569199}
-
Maksim Sisov authored
Remove accidentely added CHECK in the popup wrapper v6. added in https://chromium-review.googlesource.com/107530 TBR=rjkroege@chromium.org Bug: 578890 Change-Id: I375668380a91b71665873bd682c909dad9e7f50a Reviewed-on: https://chromium-review.googlesource.com/1109516Reviewed-by:
Maksim Sisov <msisov@igalia.com> Commit-Queue: Maksim Sisov <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#569198}
-
Christopher Lam authored
This CL fixes a clipping issue on the focus ring of a folder node in the MD Bookmark manager sidebar. Bug: 845736 Change-Id: I12fd4b6b01c11485d7d334c2567d76f750f568a7 Reviewed-on: https://chromium-review.googlesource.com/1107521 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#569197}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f4859e36. With Chromium commits locally applied on WPT: 03ef65db "Update existing WebUSB WPT to be multi-global" 89102421 "Reland "Multi-global WebUSB WPT for window and worker"" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/19944 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: ecobos@igalia.com: external/wpt/css/css-display TBR=robertma No-Export: true Change-Id: I20fdf09cac1c046629d6e1d009e42de75b256153 Reviewed-on: https://chromium-review.googlesource.com/1109504 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#569196}
-
Koji Ishii authored
LayoutBlockFlow::UpdateBlockLayout() has a specialized positioning for HTML <dialog> element when it is out-of-flow. This patch implements the logic by sharing the code in LayoutBlockFlow. Bug: 635619 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I16870f926dc0ad6fbb6bee4787f3f6d5e30b31c7 Reviewed-on: https://chromium-review.googlesource.com/1108240 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#569195}
-
Nicholas Verne authored
Also legacy supervised profiles. Bug: 853198 Change-Id: I8a42363f3f28476f4882605517eac9b1b3512200 Reviewed-on: https://chromium-review.googlesource.com/1103984 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#569194}
-
Alexander Hendrich authored
This CL implements the UI changes for blacklisted WiFi networks. DesignDoc: http://go/cros-blacklist-ssids Bug: 837205 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I2e830c5d25a756b7e20fcc9b75f79e8d24f7c6f3 Reviewed-on: https://chromium-review.googlesource.com/1101204 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#569193}
-
Blake O'Hare authored
Change-Id: I25c5dc28b1080804e569232790aebc2a132c7193 Reviewed-on: https://chromium-review.googlesource.com/1031990 Commit-Queue: Blake O'Hare <blakeo@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Cr-Commit-Position: refs/heads/master@{#569192}
-
Juan Antonio Navarro Perez authored
Story has been flaky in system_health.memory_mobile when running as smoke test on N5X. NOTRY=true TBR=nednguyen@google.com Bug: 852888 Change-Id: I8f82f42d50c6bf5f34bfda1cc42d147444921c05 Reviewed-on: https://chromium-review.googlesource.com/1109512Reviewed-by:
-
Hitoshi Yoshida authored
This reverts commit 448f72d0. Reason for revert: This CL may trigger sizes failing on chromium/Mac, and the failure prevents builds on Mac. So let me try to revert this. Bug: 854896 Original change's description: > Add the about flags for the TabManager/RC features. > > Change-Id: Id68cad067bb35f3b11bd8828806860110e8aaf79 > Reviewed-on: https://chromium-review.googlesource.com/1103304 > Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Cr-Commit-Position: refs/heads/master@{#569094} TBR=chrisha@chromium.org,fdoray@chromium.org,sebmarchand@chromium.org Change-Id: I3aa871436e096af1fb4583634b338a139d32c31f No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1109321Reviewed-by:
-
Eugene But authored
This test is the same as testSucessfullDownload, but downloads in Incognito. Also renamed DownloadManagerEGTest to DownloadManagerTestCase. Bug: 854232 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I873ec4ccad2911702a26b09028ef4e1478731bb2 Reviewed-on: https://chromium-review.googlesource.com/1108935 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#569189}
-
Kent Tamura authored
TBR=hayato@chromium.org NOTRY=true Bug: 854599 Change-Id: I11a7f53c65992274b9a4f0ce832749a76421b049 Reviewed-on: https://chromium-review.googlesource.com/1109665 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
Sylvain Defresne authored
Fixing "gn check" errors can be frustrating after a coding session as it only reports the first #include violation in each file. Change HeaderChecker to instead record all errors that are found when checking a file and report all of them. Bug: none Change-Id: I2e077090ad176300c570583acecbf34192a9963e Reviewed-on: https://chromium-review.googlesource.com/1107992Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#569187}
-
