- 20 Nov, 2020 40 commits
-
-
Ian Struiksma authored
We need behavior triggered by the presence of a "--force-fieldtrials" but we also want to remove the deprecated flag connected to AutofillFieldMetadata. Putting in a stub to unblock that deprecation work while keeping the tests up and running. Bug: 1151207 Change-Id: I790cef05abd7d8a436627a438d665bffaa8158d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552281 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#829622}
-
Corentin Wallez authored
Change-Id: Ia2a06b75e46b6cd295d647c19d2965e0468a2e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550673 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#829621}
-
Ye Kuang authored
Bug: 1143567 Change-Id: I37f738d40c7a424440bf892405a0cca1ca2742cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551867Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ye Kuang <yekuang@google.com> Auto-Submit: Ye Kuang <yekuang@google.com> Cr-Commit-Position: refs/heads/master@{#829620}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a3b434580dbf..2477097c7892 2020-11-20 aerotwist@chromium.org TypeScriptify main.ts 2020-11-20 alexrudenko@chromium.org Display flex containers in the Layout panel 2020-11-20 bmeurer@chromium.org [sources] Remove CallFrame.sourceScopeChain. 2020-11-20 szuend@chromium.org TypeScript-ify ui/Tooltip.js 2020-11-20 bmeurer@chromium.org [sources] Remove redundant evaluate logic in popover. 2020-11-20 aerotwist@chromium.org TypeScriptify TimelineUIUtils.js (Part 2) 2020-11-20 petermarshall@chromium.org [typescript] TypeScript-ify source_frame/SourcesTextEditor.js 1/N 2020-11-20 bmeurer@chromium.org [sdk][bindings] Introduce DebuggerModel._evaluateOnCallFrameCallback. 2020-11-20 janscheffler@chromium.org Fix "Inspect Element" not working If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1042636,chromium:1127915,chromium:1150029,chromium:1150294 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I382ab33be975fcc69f8f9319430afc548ae59218 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552148Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829619}
-
Nazerke authored
This CL adds the functionality to the add-new-tab-button to add the new tab via Mediator. Bug: 1128249,1134132 Change-Id: I4a33befc0bf5c81c2726a7183120d489b7115d9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2542904 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#829618}
-
Rainhard Findling authored
The SafetyCheck::PasswordStatus |FEATURE_UNAVAILABLE| value was listed in the C++ enum, but was missing in the corresponding enum in enums.xml. This CL fixes that. Bug: 1015841 Change-Id: Ib1f67b876f5252f98f2ce5994b04635b775a0cbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547703Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Commit-Queue: Rainhard Findling <rainhard@chromium.org> Cr-Commit-Position: refs/heads/master@{#829617}
-
Maksim Moskvitin authored
This reverts commit 6e751ac6. Reason for revert: likely the culprit for test flakiness. Almost certainly (great timing match and touched by this CL): crbug.com/1151237, crbug.com/1151190 Maybe (great timing match, but not directly touched by this CL): crbug.com/1151160 There seems to be no other suspicious CLs in the matching time range. Original change's description: > Introduce BaseActivityTestRule to handle Activity starting/finishing > > Introduces a BaseActivityTestRule that allows tests to control whether > or not the Activity is finished after the test runs. > > Also fixes some issues with Android's ActivityTestRule, like it not > handling LauncherActivities, and unnecessarily inheriting > UiThreadTestRule. > > Bug: 1146574 > Change-Id: I40ab917effb9d2fb53f58733f8dc75e292016aa4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523418 > Reviewed-by: Sahel Sharify <sahel@chromium.org> > Reviewed-by: Yaron Friedman <yfriedman@chromium.org> > Commit-Queue: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829386} TBR=yfriedman@chromium.org,mthiesse@chromium.org,sahel@chromium.org Change-Id: I03f1fc15026740ea01631b019a73738e706f9ac7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1146574, 1151237, 1151190, 1151160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550810Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#829616}
-
Maksim Moskvitin authored
This reverts commit 433d1a41. Reason for revert: new test is failing on linux-chromeos-chrome builder. Original change's description: > BackForwardCache: Allow WebFilesystem with a flag > > WebFilesystem doesn't have notions of handlers or connections, then it > should be safe to allow pages with WebFilesystem to be put into the > BFcache. Let's allow WebFilesystem for BFcache in order to improve the > BFcache hit rate. > > This is implemented behind a flag and the feature is disabled by > default. This means that this CL doesn't change the behavior by default. > We might enable the feature later. > > Bug: 1144133 > Change-Id: Idf5d9cfb8a4365ae65743c2becc7a4ef8ec66999 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2531155 > Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#829149} TBR=kinuko@chromium.org,mek@chromium.org,hajimehoshi@chromium.org,haraken@chromium.org,altimin@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1144133, 1151235 Change-Id: I37344a9763d5b592fc1c2a60c1b480a5cc18e177 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551117Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#829615}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: If4b88bb68972bc6707ad02654df02d1be16a1823 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552164Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829614}
-
Sigurd Schneider authored
This CL reports the IP address space of the initiator in the requestWillBeSentExtraInfo event as well as the applied PrivateNetworkRequestPolicy. This is one CL in a series that allows DevTools to surface relevant information for debugging RFC-1918 violations. Bug: chromium:1128885 Change-Id: I93d93ad00ac4e4705eeef6bd9f49224782fd30a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494944 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#829613}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/1a14e7e02441..75a1f5234e4b 2020-11-20 ivan.murashov@lge.com Remove storage class specifier for the explicit template specialization 2020-11-20 jiawei.shao@intel.com D3D12: Search the default path of Windows SDK for DXC DLLs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC kainino@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: kainino@google.com Change-Id: Ife9f4247f71b2563e0ef2b8a387b89a4bdac0520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552244Reviewed-by:
-
Alex Rudenko authored
This CL adds a new parameter to HighlightConfig to indicate what kind of contrast ratio the overlay needs to compute. Previously, it was computing the contrast ratio according to the AA threshold. With this change, it is possible to show the contrast according to AAA and APCA thresholds. Frontend CL: https://crrev.com/c/2546705 Bug: 1121900 Change-Id: I319eb472e513d3ccc2ba0c2d90a6bdd60ba6d94e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2545509 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Cr-Commit-Position: refs/heads/master@{#829611}
-
Mihai Sardarescu authored
Even though X-Chrome-Connected was designed for the Mirror protocol, we have not confirmation that it is used by Google Drive to auto-enable offline mode on desktop when the use has opted in to sync. This CL does the following clean-up: * account consistency disabled: stop sending X-Chrome-Connected as the user would not be able to sign in to Chrome * account consistency DICE: only send the X-Chrome-Connected header to Google drive (stop sending the header to accounts.google.com) * account consistency Mirror: no change Bug: 1149943 Change-Id: I0b683b2ba741f871b0e7d424d6fe017433bc33af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2544703 Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#829610}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9ac93dfb7d8b..6f300a38617e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mmoskvitin@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mmoskvitin@google.com Change-Id: Id978c316cb4cb144389d8b8d7f0d53a7cbcbca5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2552341Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829609}
-
Leo Lai authored
This is the preparation of the direct communication with tpm manager daemon. As patterns commonly adopted in other dbus clients, we also leave `TestInterface` class for future extension. To test the CL, a test-only CL is introduced to check if we can get TPM status using the introduced classes. BUG=b:172748724 TEST=build ok. TEST=See above. Change-Id: I94f2d37b4e03c0219e0463ad58bd05a581233a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2537731 Commit-Queue: Leo Lai <cylai@google.com> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#829608}
-
Maksim Moskvitin authored
Test is failing on linux-chromeos-rel builder. Tbr: qjw@chromium.org Bug: 1151227 Change-Id: I00548b9d023cf1f79db3af96b347678a33cc4190 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550672Reviewed-by:
-
Benoit Lize authored
When PartitionAlloc is malloc(), the thread cache is used by malloc(), otherwise by the FastMalloc partition. Record its size in UMA for both cases. Bug: 998048 Change-Id: I9072890b76c2c125409ae44e956913ef5bfe26e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549964Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829606}
-
Gauthier Ambard authored
This CL changes the update of the item's URL when the WebView URL is changed. If the new WebView URL is different from the URL of the item but is the URL associated with the session restoration of this URL, the URL of the item is no longer updated. Fixed: 1139289 Change-Id: Id3b31bfedeb6e84bc0527f642fa424e7f81381dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549620Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#829605}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c55cbc12. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I4e0fac974dfb7b276b33ffe57699a380fa3a6bfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551514Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#829604}
-
Amr Aboelkher authored
As the PSM switch kEnterpriseEnablePrivateSetMembership is going to be enabled by default. The tests should force disable it whenever the param of PSM state is disabled. BUG=chromium:1150878 Change-Id: If2a1d939f5c282e68a1bbfdcadf4293722568148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550074 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Roland Bock <rbock@google.com> Cr-Commit-Position: refs/heads/master@{#829603}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/511da9af8056..a3b434580dbf 2020-11-20 bmeurer@chromium.org [sdk] Break another cycle between sdk/ and bindings/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1083146,chromium:1150029 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib97e79a1deff43193c89548504556e49e7d4d077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551230Reviewed-by:
-
Wez authored
The MetricsRecorder is requested once during web.Context startup, and the request is routed to one of the running CastComponents. Now that the Context may be launched on-demand, to serve FrameHost requests, update the CastRunner to allow the FrameHostComponent to be used to route the MetricsRecorder capability. Bug: 1150776, 1120914 Change-Id: I6d5d336ef7d7af6d0c664e85e8b05f9b6813a5d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550543 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#829601}
-
Asami Doi authored
This CL just updates a WPT (clim-worker-fetch.https.html) to use async/await instead of Promise/then(). This doesn't add a test nor change the test result. Change-Id: I042d0947b4593825fc58fb00dc9537cc0e102c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550101 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#829600}
-
Rahul Goyal authored
Did client changes to set a11y strings from backend for AssistantChipViewHolder.java Bug: b/171963823 Change-Id: Id3a5d80cb08f065423db52c0bf66ac8af71415b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2532079 Commit-Queue: Rahul Goyal <goyalrahul@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#829599}
-
Pavel Yatsuk authored
SavePasswordMessageDelegate::DisplaySavePasswordPrompt accesses member field web_contents_ before assigning it, causing null pointer dereference. The function is the only one not covered by unittest which made the issue committed unnoticed. BUG=1123947 R=vasilii@chromium.org Change-Id: Iac6c4e2c0d5b4b348883812c14a8c541e91fd238 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550608 Auto-Submit: Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#829598}
-
Mirko Bonadei authored
Bug: webrtc:12212 Change-Id: Ib845403ce4c83597f7304829b7f978eee7025074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550670Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8930f18245df..777749aafaac 2020-11-20 b.schade@samsung.com Vulkan: Fix image copies with renderbuffers 2020-11-20 cnorthrop@google.com Capture/Replay: Limit GL_MAX_IMAGE_UNITS during capture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cnorthrop@google.com Test: Test: LEGO MECTest: Test: dEQP-GLES31.functional.copy_image.*renderbuffer* Change-Id: Ief33c3f6274490f6a0be694310e2f904dbce2e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551977Reviewed-by:
-
Miriam Polzer authored
ChromeOsReleaseChannel is only honored if ChromeOsReleaseChannelDelegated is False and the release channel on devices can only be switched if ChromeOsReleaseChannel is set to True. Update comments and policy description to match the behavior. Bug: 1147003 Change-Id: I72436eb3d50df9755c88aeec17b099e2a3d26b23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549923Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Miriam Polzer <mpolzer@google.com> Cr-Commit-Position: refs/heads/master@{#829595}
-
Amr Aboelkher authored
This CL includes all PSM UMA histogram unit tests. That's also including the comparison between PSM and Hash dance UMA tests. BUG=chromium:1136866 Change-Id: I67614870c3355853e8aa29b49499f1897cbd877d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546012 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Reviewed-by:
-
Devlin Cronin authored
Add support for specifying specific frame IDs (one or multiple) in the chrome.scripting APIs (scripting.executeScript and scripting.insertCSS). Add tests for the same. Bug: 1148878 Change-Id: Idae2940c9bfe1d7b9d456799da941083eac2df0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2547432 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#829593}
-
Bao-Duy Tran authored
This enum is only applicable to InputMethod.ID2 [1], a sparse histogram (not an enum histogram). Its reverse mappings from numerical values to string labels aren't exhaustive by nature. In particular, there are only mappings for 1P input methods of Chrome OS. No mappings for open-source Chromium OS nor third-party IME extensions. At some point, the numerical values corresponding to Chrome OS input method IDs were changed (due to [3]) and thus the mappings had to be adjusted [4], with many marked as obsolete (with a suffix "_old") but not removed (likely to facilitate analyses of data recorded prior to [3] in the transitional period back in 2017, circa M60). Now that more than three years have passed, it's unlikely we'd need to analyse pre-M60 data, all "_old" ones can be cleaned up. These removals are effectively the same as adjusting the labels to 'unknown', which is permitted by UMA guidelines. In the highly unlikely event that we need to interpret pre-M60 data, the mappings can always be resurrected from Git repo history, or derived manually again in the same way as when analysing data from open-source Chromium and 3P IME extensions. [1] https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/chromeos/input_method/input_method_manager_impl.cc;l=1004;drc=f395ddcfc286124a44d175c2d48113ee75244234 [2] https://source.chromium.org/chromium/chromium/src/+/master:tools/metrics/histograms/histograms_xml/obsolete_histograms.xml;l=27595;drc=3e63c87eac95d1fc8405443ebfabd70e666bf83f [3] https://chromium.googlesource.com/chromium/src/+/df82c2f1f609cfe5cead26794eeb85320594c904 [4] https://crrev.com/c/1124212 Bug: 1150183 Change-Id: Ia9af662db2c7e5d71f71f5dd1b45af5576c43da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546385 Commit-Queue: Bao-Duy Tran <tranbaoduy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#829592}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1605830203-b886e962da8895514d6a5d81640dc11fdcd7ef55.profdata to chrome-linux-master-1605851942-6f480177b4524c7e895c150a8dd7d9195900edb6.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6b6876a47bb3a001adc07abfa7e0f2ad3e9294ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551959Reviewed-by:
-
Egor Pasko authored
Remove the workaround for a bug that was fixed in the NDK in 2013. Bug: None Change-Id: I6b1e25c53c9b6d86604c3ae796d36ca5e2e50937 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550801 Commit-Queue: Albert J. Wong <ajwong@chromium.org> Auto-Submit: Egor Pasko <pasko@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Cr-Commit-Position: refs/heads/master@{#829590}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7ab0cbf6d83f..9ac93dfb7d8b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC shimazu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: shimazu@google.com Change-Id: I7a7290269199734001c9849c02da1f42e10af68d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551508Reviewed-by:
-
Nick Diego Yamane authored
R=oshima@chromium.org Bug: None Change-Id: I156235abba5234e964260d40f07547d86fa7e8b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546960 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Nick Yamane <nickdiego@igalia.com> Cr-Commit-Position: refs/heads/master@{#829588}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: Id2b4f554a1eafc7400a7ec49b5fe5b0eac1b17df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551545Reviewed-by:
-
Ankit Kumar 🌪️ authored
Add AccessibilityPageInfo in pdf/ to replace usage of PP_PrivateAccessibilityPageInfo. PP_PrivateAccessibilityPageInfo is a Pepper struct. The new struct ensures that PP_PrivateAccessibilityPageInfo is scoped to parts specific to Pepper implementation. Bug: 1144444 Change-Id: Id0cf87848a5e7fa936647475e8e204ead4dbe084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2546661 Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Reviewed-by:K. Moon <kmoon@chromium.org> Cr-Commit-Position: refs/heads/master@{#829586}
-
Matthew Denton authored
GCC seems to have a bug with constexpr when this flag is present: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97913 So enable it only on clang for now. Bug: 1139129 Change-Id: If657d5e3fac1621adf57c266cfd64ce628dc7b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551494 Commit-Queue: Matthew Denton <mpdenton@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#829585}
-
Makoto Shimazu authored
TBR=michaelpg@chromium.org No-Try: true Bug: 1150349 Change-Id: Ib27007ecf4929f227fa9e7925fefa4bfed903c74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551885Reviewed-by:
-
Ian Struiksma authored
Tests have been stable after changes were made in crrev.com/c/2490868, removing debug logging. Also enabling test 'FillChangeSecondFieldRefillSecondFieldClearFirst' which was disabled under same bug. Bug: 967588 Change-Id: I7da6b5c24424d6763d59ea93c9cd067139fc641e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550609 Commit-Queue: Dominic Battré <battre@chromium.org> Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#829583}
-
