- 06 Aug, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ae523ca9..f870c336 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7248052bf1505bb8a1ae4768e99ffdd99ae63ebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339002Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795469}
-
Mark Cogan authored
The Clear Browsing Data flow uses the ChromeActivityOverlayCoordinator to block user interactions in the window in which it was triggered. To extend this to multiple windows, this CL adds an option to the activity coordinator to block all windows, implemented by triggering the blocking UI. that the blocking UI is shown in the other window. TEST: Opened two windows, opened History, chose Clear Browsing Data, saw Bug: 1045580 Change-Id: I8466cd8e67ddedce13c6db6580cd0d57b76b120d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339963Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#795468}
-
Liviu Tinta authored
action.pointerMove requires integers as arguments. Change-Id: I6abacedba07090038aff38e9788eec5b0445d4f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332330 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#795467}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/b3545b42a10a..99f48c74ab76 2020-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Loader from bfe4f378aee6 to ef36eedb0d09 (1 revision) 2020-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from 8bc27a1cfbc1 to 5fd92a7e0c84 (5 revisions) 2020-08-06 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from a4505d37ffe7 to a1c21580f50b (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ibd5d730810955fb1fd9307a904a1c1263f59238b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341107Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795466}
-
Ted Meyer authored
There is an upload warning for use of std::vector, with an attached note saying that it's acceptable at the blink/chromium layer, which I think this falls under. This CL should only be merged after the devtools frontend CL here: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2336204 This also adds a "Chapters" type to the enum used in TextTrackConfig because apparently that is a thing blink supports. Bug: 1090022 Change-Id: I19cd27b2c926bef1c36fed19efe8599c9d168386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337402Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Ted Meyer <tmathmeyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#795465}
-
Danila Kuzmin authored
Bug: 1113377 Change-Id: If0db3269c944955649caa486964dfcbdb1d2d329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339965Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Danila Kuzmin <dkuzmin@google.com> Cr-Commit-Position: refs/heads/master@{#795464}
-
Greg Thompson authored
This metric provides a generally useful signal relating to enterprise report uploads. BUG=1097917 R=chromium-metrics-reviews@google.com, pastarmovj@chromium.org Change-Id: I010d212f97527e163180e85166bb3c94c44994f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339344Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#795463}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/20d9bb09b493..fa830b464d9f 2020-08-06 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-06 jacktfranklin@chromium.org Tidy up type reference look-ups in bridges 2020-08-06 sigurds@chromium.org More comprehensive initiator tracking for developer resource loads If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:974543 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I71e7012b90defa0086b4518ea77c7e5b85df8056 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341113Reviewed-by:
-
Ewann authored
This CL prevents the Page Info view to be dismissed on device rotation. Fixed: 1112322 Change-Id: I11d5d4be1a5e3fbfedd94466c4dd5b1e9f3e1469 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335286Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Cr-Commit-Position: refs/heads/master@{#795461}
-
Fabio Tirelo authored
TBR=agl@chromium.org Bug: 1104847 Change-Id: I661686203f8a652bde3c6094c6adff16675a877a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341142Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#795460}
-
Andreea Costinas authored
This CL starts the System-proxy worker which tunnels ARC++ traffic according to the |ArcEnabled| policy and forwards the address of the local proxy to ARC++ through the |ArcSettingsService|. It also introduces a new user preference that keeps track of the address of the local proxy worker and syncs with ARC when the address changes or System-proxy is disabled by policy. Bug: 1042639 Test: unit tests, browser test, manual test on DUT Change-Id: Ibe84d74353d5f75376393e7cd8745f63db073de7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323521Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Omar Morsi <omorsi@google.com> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Andreea-Elena Costinas <acostinas@google.com> Cr-Commit-Position: refs/heads/master@{#795459}
-
Marc Treib authored
With password_manager::features::kEnablePasswordsAccountStorage enabled, there will be two PasswordStore instances, a profile-scoped one and an account-scoped one. This CL updates the setup of a few unit tests so they instantiate the account-scoped store in addition to the profile-scoped one. Without this change, the tests were hitting some DCHECKs when run with kEnablePasswordsAccountStorage enabled. Bug: 1098677 Change-Id: Ic31b5ff593139788b7ffbf8fd67a1d8edb401ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332602Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#795458}
-
Clovis PJ authored
Bug: 1109123 Change-Id: Ifa755c1d1a0325558f499ba0fc462559c9f47c30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316209Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: Clovis PJ <clovispj@google.com> Cr-Commit-Position: refs/heads/master@{#795457}
-
Robbie Gibson authored
This reverts commit 6e145aaa. Reason for revert: Incorrect behavior when flag is enabled. Original change's description: > [iOS] Decouple Text Zoom flag from Dynamic Text size as default zoom > > Before, this happened by default. However, this was confusing, so now > there are two separate flags, so zoom can be enabled without changing > the default zoom level. > > Bug: 1113270 > Change-Id: I34e340c585c5ccccdfd278d96c21a53510b6a234 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339482 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#795408} TBR=rohitrao@chromium.org,rkgibson@google.com Change-Id: I557c9410d721b27472bdb200f58462fa428fd8d4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1113270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339987Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#795456}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dcb6f8084e45..5d9552ef6987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Icf82c3db86623988ccded4161790fa89b677df89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340639Reviewed-by:
-
Nela Kaczmarek authored
Bug: 1108279 Change-Id: I4984ea492a3274f02bca3b251cca1ff9014e36c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339661Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Nela Kaczmarek <nelakaczmarek@google.com> Cr-Commit-Position: refs/heads/master@{#795454}
-
Sergey Ulanov authored
After crrev.com/791485 GetSupportedFormatsMediaFoundation() was called with a null ComPtr<>, so the formats were not enumerated. As result DirectShow API was used instead of MediaFoundation. Fixed the call to make sure formats are enumerated properly. Bug: 1112947 Change-Id: I1beb0ee4c1d66826225efe8a27cb45eeb850d41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337635 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#795453}
-
Monica Basta authored
This CL does the following: - Adds text for the 'Add Space' button. - Unifies fonts based on mocks ~= 15px. - Fix ripple not visible for 'Add Space' button in dark mode. Screenshot: https://drive.google.com/file/d/1qY6jBrfHcAmj8wKBKqAxpo2roq0WcxDx/view?usp=sharing Bug: 1063856 Change-Id: Idfa836796975a4e9f8f1260173df9c2f266165ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339488 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#795452}
-
Ewann authored
This Cl reoders custom actions according to the Design Doc. === 1. All Open Actions 2. All Actions that are unique to the feature (e.g. Mark as Read, Search for Image) 3. All Copy Actions 4. All Edit Actions (Edit and Move) 5. Share... 6. Delete (and in Red) === see: http://doc/18YOOXHNEYjiXMqVxC7mLKY54zopziHkpJovcIKB5Dp0 Bug: 1093302 Change-Id: Ib0e62dd6a5df1b81740a116861120caa8f7f5c6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336833 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Jun Kokatsu authored
This change removes chrome://discards from NoTrustedTypesViolation test due to it being flaky. Bug: 1113446 Change-Id: Ie43141f203951d937f9aab105345a189eb181327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340782 Commit-Queue: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Auto-Submit: Jun Kokatsu <Jun.Kokatsu@microsoft.com> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#795450}
-
Clemens Arbesser authored
See also linked bug for more information. Bug: b/163024900 Change-Id: I608a35d636808f125c4f07c58c6b6a63ed1eaae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339468 Commit-Queue: Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Clemens Arbesser <arbesser@google.com> Reviewed-by:
-
nancylingwang authored
BUG=1083331 Change-Id: I91aa539a469d25dc283305def73287fdd34c114c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308624 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#795448}
-
Randy Rossi authored
Focus should only be set if the child tree is found. Otherwise, leave the focus set by the super method alone. This was causing the reader to lose focus on cast and webviews embedded in the display assistant's main tree. Bug: NONE Test: display assistant with youtube/weather app/page Change-Id: If82855ada00fa679806987e8f78332799d0e7015 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339497Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Randy Rossi <rmrossi@chromium.org> Cr-Commit-Position: refs/heads/master@{#795447}
-
Liquan (Max) Gu authored
Before: * PRImpl keeps the observer NativeObserverForTest as a local member, but the observer is set inconveniently with ComponentPaymentRequestDelegate. After: * PRImpl references the observer from ComponentPaymentRequestDelegate directly, no longer keeping it as PRImpl's own member. ComponentPaymentRequestDelegate does not need to help with setting the observer any more. Bug: 1102522 Change-Id: I2d35e498452441fbc696f12f76dcbd0e69eb31c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340227Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#795446}
-
Xi Han authored
enabled. Without the check, it will trigger InstantStart code path and shows the overview list layout. A crash would happen since the overview list layout is null. Bug: 1110791 Change-Id: If8dfd07118effe71a001286fcf9cb0e7279c8f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336306 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#795445}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/7a171cca0ca4..34949e35f006 2020-08-06 robertphillips@google.com Pull ShapeData into its own header file and rename to GrSmallPathShapeData If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: herb@google.com Change-Id: I76913bc8661bc4effe28893bb10500b7376bb5eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341108Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5d9552ef6987..76488e6d8e63 2020-08-06 fmayer@google.com Merge "Do not download t2t for --print-config." 2020-08-06 primiano@google.com Merge "Client Library: retry connections if traced is not running" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4fef4144b8cf7ef1e960932a15ecc851c91fb3d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341104Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I9bc0a13644ebc38a0f825389d6cd9db0ce7d4440 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341109Reviewed-by:
-
Oleg Davydov authored
Event-based reporting is a way to gather more feedback from managed profiles by sending data about status of force-installed extensions. This CL adds extension type (browser extension, chrome app, theme etc) to the reports. Bug: b:161368099 Change-Id: Ia463a5df1287174b62212783872cde5adb915665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329633 Commit-Queue: Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#795441}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3a560b36ad16..de2a1c51379f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC fernandex@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: fernandex@google.com Change-Id: I42c50fbd7238ee1fc0c998dbc7652aa30ea053ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341024Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#795440}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dcb6f8084e45..5d9552ef6987 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iac957a29c4b38391f9146e23391c42a78845b9f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340638Reviewed-by:
-
Victor Hugo Vianna Silva authored
If the password of the primary signed-in account is stored locally (i.e. in the profile store), the bubble that offers moving it into the account should not be shown, since storing the password for an account within that same account doesn't make sense. Moving other Google account passwords is still valid. Bug: 1110894 Change-Id: I2be5b30ecb121e5db91e3ff33b98cba51af6430b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339980 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Renato Silva authored
Remove the submit button on the pin pad shown on the login/lock screen. Change LoginPinView construction to only show the submit button on the pinpad when the |on_submit| callback is valid. Verified locally that it removes the memory leak LoginPinView from: https://crbug.com/1099306#c1 Bug: 1075994, 1101326, 1099306 Change-Id: Ib7de615c9f5c6faec168e1205e44a981f739f9a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339524 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#795437}
-
Kateryna Prokopenko authored
Addressing post-commit comments to CL: https://chromium-review.googlesource.com/c/chromium/src/+/2289841 Bug: chromium:1082628 Change-Id: I22ae9d66d9940f95a8faea654418e8aa9859e2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338796Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Kateryna Prokopenko <kprokopenko@google.com> Cr-Commit-Position: refs/heads/master@{#795436}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4d2e095852b7..20d9bb09b493 2020-08-06 aerotwist@chromium.org Update copy paths to be absolute If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1113321 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4c5baa1ca75bb95da7b65208ce6dd48c28f54dde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341103Reviewed-by:
-
Matt Jones authored
This patch moves the responsibility of tracking which tints are used in a frame to the ResourceManager. When a tinted resource is requested the ResourceManager tracks it instead of the TabListSceneLayer. When a frame is finalized, the CompositorView passes a signal to the ResourceManager to clear out any tinted resources that were not used in that frame. Bug: 1111772 Change-Id: I6f71aca94f1f05d413a4b3d0e83c39f11c4b7594 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334992Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#795434}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/351fdfe7..ae523ca9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7105310cd287bfe864986b17a1a6351ede5fb838 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340183Reviewed-by:
-
Viktor Semeniuk authored
This change adds new entry point from Password Breach dialog to Passwords screen. Password Check will automatically start when page is opened. Mock: https://docs.google.com/presentation/d/1B_Cr6KlWXtjfG7pA1xk5r9vDNtszICNfN3KqH-T30Q0/edit#slide=id.g853bc68e3a_3_598 Bug: 1075494, 1113170 Change-Id: I5693b53c05078961df83f519d3a0175240f8db97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320170 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#795432}
-
Mariam Ali authored
A feature and flag is added to control the menu item for creating an incognito desktop shortcut on Windows. Bug: 1113162 Change-Id: I76e77e018434f4116e09ae8199e7a16a648872c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338775 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#795431}
-
Jonathan Mengedoht authored
Bug: 1086141 Change-Id: Ied9a69a6cb27e0f6c966075d6cfe2c07f4f45c57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2287471 Commit-Queue: Jonathan Mengedoht <mengedoht@google.com> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
-
