- 29 Nov, 2019 40 commits
-
-
Omar Morsi authored
Network state should be reported in three conditions. 1- Primary user signed in is affiliated. 2- Managed device is in kiosk mode. 3- Managed guest session is running. Bug: 1027086 Test: browser_tests --gtest_filter=DeviceStatusCollectorNetwork* Change-Id: I29aaad9f5e442ea164bd1afd28a3bca72c66e459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928702 Commit-Queue: Omar Morsi <omorsi@google.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#720225}
-
Ian Clelland authored
Bug: 993790 Change-Id: Id1c780e43964ac0e8e2cc0abf49a19fb04c780ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934780 Commit-Queue: Ian Clelland <iclelland@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Auto-Submit: Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#720224}
-
Jasper Chapman-Black authored
This logic broke for non-empty group paths (group-by-component, etc) when GroupedPath was added, and tests weren't checking the displayed shortname on the class node. Change-Id: I6961a140329bdbb455f441b12fdca24971aa114d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943110 Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#720223}
-
Richard Knoll authored
This adds a new regex based on Androids TextClassifier to improve the phone number detection on selected text. Bug: 1001033 Change-Id: I759de1d14e0d9439a709dbdc8db62b7ca7fc70b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940246Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#720222}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/d4f9c249893a..4270e9f32430 git log d4f9c249893a..4270e9f32430 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 drott@chromium.org Avoid more nullptr offset UBSan warnings (#57316). Created with: gclient setdep -r src/third_party/freetype/src@4270e9f32430 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/freetype-chromium Please CC bungeman@google.com,drott@google.com,thestig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel Bug: None Tbr: bungeman@google.com,drott@google.com,thestig@google.com Change-Id: Ie351f35cdba5c8ab7591f1606f01d3cbc02516e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944010Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#720221}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/79685304182c..2d02c943b288 git log 79685304182c..2d02c943b288 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 alessiob@webrtc.org NetEQ: fix initial decoder frame length. 2019-11-29 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 26d09951..a9c1e4af (720053:720171) 2019-11-29 danilchap@webrtc.org In RtpDepacketizerAV1 use aggregation header to detect key frames 2019-11-29 mbonadei@webrtc.org Prefix ENABLE_RTC_EVENT_LOG with WEBRTC_. 2019-11-28 mbonadei@webrtc.org Remove WebRTC-Bwe-CongestionWindowDownlinkDelay. 2019-11-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8955e0d3..26d09951 (719771:720053) 2019-11-28 mbonadei@webrtc.org Fix ErrorProne MultiVariableDeclaration. 2019-11-28 danilchap@webrtc.org Use AV1 packetizer/depacketizer for AV1 bitstreams 2019-11-28 titovartem@webrtc.org Add ability to disable detailed error message in RTC_CHECKs 2019-11-28 peah@webrtc.org AEC3:Turning off default downmix in surround alignment 2019-11-28 jonaso@webrtc.org Add new Stun utility functions 2019-11-28 doudouk@google.com Add directive to make TRACE_EVENT macros optional. 2019-11-28 kron@webrtc.org Remove temporary 8-bit H264 HDR fix 2019-11-28 danilchap@webrtc.org Implement AV1 RtpPacketizer class 2019-11-28 sprang@webrtc.org Implements a task-queue based PacedSender, wires it up for field trials 2019-11-28 danilchap@webrtc.org Fix undefined-shift in RtpDepacketizerAv1::AssembleFrame 2019-11-28 jonaso@webrtc.org Add rtt estimate EventBasedExponentialMovingAverage to Connection 2019-11-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 2b82941a..8955e0d3 (719656:719771) 2019-11-27 steveanton@webrtc.org Replace template_util.h with C++14 STL methods 2019-11-27 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 65c32b57..2b82941a (719106:719656) 2019-11-27 yvesg@google.com Revert "Remove temporary workaround for generate_licenses." 2019-11-27 kuddai@webrtc.org Propagate absolute capture time through video receiving side. Created with: gclient setdep -r src/third_party/webrtc@2d02c943b288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:None,chromium:None,chromium:None,chromium:956468,chromium:1028348,chromium:None,chromium:None,chromium:None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4466ea8dfa6b3e207082b4a119cba563f651283f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943613Reviewed-by:
-
Juan Antonio Navarro Perez authored
To verify whether this fixes recent flakiness on Windows. Also re-enable on Android. TBR=crouleau@chromium.org Bug: 971998 Change-Id: I5ad768b722524d518bcc85c826923eb4317c805e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941312Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#720219}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/f145c8234627..4a339a15d536 git log f145c8234627..4a339a15d536 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 chrome-bot@chromium.org Update config settings by config-updater. 2019-11-29 vapier@chromium.org cros_chrome_sdk/deploy_chrome: use encoding=utf-8 with commands 2019-11-29 chrome-bot@chromium.org Update config settings by config-updater. 2019-11-29 vapier@chromium.org cbuildbot: lkgm_manager_unittest: fix encoding when writing Created with: gclient setdep -r src/third_party/chromite@4a339a15d536 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel Bug: None Tbr: chrome-os-gardeners@google.com Change-Id: Id49d89594d43c7d6888b86d2f9705177fea67024 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943510Reviewed-by:
-
Mikel Astiz authored
Server-side data can theoretically contain duplicate GUIDs, and the end result today is a crash. It is hard to deal with this case or even reason about what a reasonable behavior is, so this patch instead detects and resolves the issue in a preprocessing stage, such that offending GUIDs are ignored. Doing so allows further refactorings to simplify the merge logic. Bug: 978430 Change-Id: I4926bfe88aee2724633a447b0ed9ce086358b439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939974 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720217}
-
henrika authored
Creates log sequences where we can track that audio input devices are opened and closed correctly and what parameters are used. Example (grep for AIDM): AIDM::Open({session_id=45CE96DFC9576CDABE2524A89B6E5ADE}, {device=[type: DEVICE_AUDIO_CAPTURE, id: default, group_id: input, name: Default, parameters: [format: 4, channel_layout: 3, channels: 2, sample_rate: 44100, frames_per_buffer: 441, effects: 0, mic_positions: ]]}) AIDM::Opened({session_id=45CE96DFC9576CDABE2524A89B6E5ADE}) AIDM::Close({session_id=45CE96DFC9576CDABE2524A89B6E5ADE}) AIDM::Closed({session_id=45CE96DFC9576CDABE2524A89B6E5ADE}) No-Try: True Bug: 1017219 Change-Id: Iad328af521f2d95d1a0d1893c23d1bc79928b22e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899872 Auto-Submit: Henrik Andreasson <henrika@chromium.org> Reviewed-by:Guido Urdaneta <guidou@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#720216}
-
Finnur Thorarinsson authored
Bug: 1027019, 860467. Change-Id: I60f74c73bdcd7c071bf21ecdd8eeb5e9909d5ce1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943144Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#720215}
-
Guido Urdaneta authored
It has been timing out flakily and causing some CQ false rejections. Bug: 1027436 Change-Id: I093ef6e1aeed38d36488825dbea1181e9afafcae No-Try: True TBR: petermarshall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944353Reviewed-by:
-
Thomas Tangl authored
Bug: 1021587, 993752 Change-Id: Id0b9adcfa72c5c9567a315dc7bada293a2bdbe52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899880 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Auto-Submit: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#720213}
-
danakj authored
R=blundell@chromium.org, clamy@chromium.org TBR=reillyg@chromium.org Bug: 1007763 Change-Id: Id5aba2a6a9d0bd01a738704b844cc429c0132650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942939 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720212}
-
Jeremy Roman authored
In response to https://chromium-review.googlesource.com/c/chromium/src/+/1943108. Change-Id: I06e99b465b52aa6710d6f747277c375b86be5b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943334 Commit-Queue: Jeremy Roman <jbroman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Auto-Submit: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#720211}
-
chrome://media-internalsSamuel Huang authored
This moves ~19 kB of gzipped resources to the DFM. The resources are split from content_resources.grd, so extra work is needed compare to other DevUI DFM page movement tasks: * Generate media_internals_resources_map.{cc, h}, and have these read by SharedResourcesDataSource. * Repack media_internals_resources.pak into content_shell.pak. Bug: 927131 Change-Id: Ic10fadb3eff4d519b7eacf430d75e1be3dcba122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937850Reviewed-by:Jochen Eisinger <jochen@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
After inspecting the AOSP code and talking to a member of the Android Contacts team, it looks like there is no code path that would result in an image being handed to our Contact Picker, without Android Contacts first decoding it in the same way we do. Bug: 860467 Change-Id: Ifb1c75cf0048c843644506e6d0fe4f9b886b6095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943181Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a44c3e3b3615..9544832a076e Created with: gclient setdep -r src-internal@9544832a076e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1022981,chromium:1029449,chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: If8220a471e4634744d92c467c25ae3f6aa3a8ee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943612Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720208}
-
Denis Kuznetsov authored
Explicitly shut down LoginDisplayHost in OOBEConfigurationTests It should remove flakiness upon shutdown. Also Fix race condition in setting up demo mode (reason for previous revert). Reland of https://chromium-review.googlesource.com/c/chromium/src/+/1934342 Bug: 997685 Change-Id: I0cb8f084484395a13bc3b29e8f1b7150cada8403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942339 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720207}
-
Marc Treib authored
This CL adds a pref that stores which accounts have opted in to use the Google account storage for passwords. While this pref is false, passwords can not be saved to the account, and passwords in the account are not downloaded. It also adds an entry to the password autofill dropdown that lets the user set the opt-in. Bug: 1024332 Change-Id: Iac552c310d0e9f19ee2bb1893e217e60b1114d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1645294 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
danakj authored
Use OnceCallback where possible, and use BindRepeating() where it is meant to be a RepeatingCallback. Majority of this change is a few typedefs that are very widely used: - LoadedCallback - ValidateTokenCallback - ValidateRegistrationCallback - GotDataCallback** ** Especially this one. R=blundell@chromium.org, clamy@chromium.org, marq@chromium.org TBR=clamy Bug: 1007760 Change-Id: I3e6b2bfbc1ff5d36a96628da1163f6a37fb2b204 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943327 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/0a58befe..44b794ef Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic16dd7bb18ca29088fd4221e347f8215aa63932b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944371Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720204}
-
Finnur Thorarinsson authored
Bug: 1029056, 656015 Change-Id: Ib206c718ba4984d67209c708b4baa75e5f77816d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940186Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#720203}
-
Tomasz Dobrowolski authored
Added KerberosCredentialsManagerFactory and promoted KerberosCredentialsManager to KeyedService to provide a way to control initialization order with other keyed services that may depend on it. Bug: 1027087 Change-Id: I157c5aba8e1efc604ee4978d382469650a62a1dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928790 Commit-Queue: Tomasz Dobrowolski <tomdobro@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Auto-Submit: Tomasz Dobrowolski <tomdobro@chromium.org> Cr-Commit-Position: refs/heads/master@{#720202}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fb7ca1d5aca5..9d128947de8c git log fb7ca1d5aca5..9d128947de8c --date=short --first-parent --format='%ad %ae %s' 2019-11-29 swiftshader.regress@gmail.com Regres: Update test lists @ fb7ca1d5 Created with: gclient setdep -r src/third_party/swiftshader@9d128947de8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I6985b0c54a6582a8dcb80f2509d7f6fc7c43b8f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943384Reviewed-by:
-
Javier Ernesto Flores Robles authored
This naming is more consistent with the rest of the sibling folders. Bug: 959739 Change-Id: Ief587f052449c9d2bdfbf184ba0f4f996c897406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943136Reviewed-by:
-
Olya Kalitova authored
If during Crostini installation default Crostini container is failed to be configured, removes Crostini at all so that "Retry" button installs Crostini from the very beginning and Terminal app icon is not available in a Chrome OS launcher. Test: unit_tests --gtest_filter="Crostini*" Bug: 1022784 Change-Id: I8d8c45cf6c39593657963786c117d384a6cecf9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917202 Commit-Queue: Olya Kalitova <okalitova@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Cr-Commit-Position: refs/heads/master@{#720199}
-
Gauthier Ambard authored
This CL freezes the Safari version in the Mobile User Agent, aligning with https://blog.chromium.org/2019/05/improving-privacy-and-security-on-web.html. It will also increase compatibility with WebKit, as it is frozen in WebKit mobile User Agent. The iOS 12 version was introduced in http://crrev.com/c/1102485. This CL was made during the beta version of iOS 12, my guess is that the version was frozen in WebKit before the Stable version was released, so we released a wrong version by mistake. Bug: 1026615 Change-Id: I7641bc54327f3d135501dc47c365c4458ca8dace Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926488 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Aaron Tagliaboschi <aarontag@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#720198}
-
Stephen McGruer authored
After https://crrev.com/e90092dea, the --force-prefers-reduced-motion flag could be accidentally ignored if the system-level setting was changed after the browser had started. This CL restores the behavior so that the flag always wins, and adds a test to ensure that. Bug: None Change-Id: I46927e3821f1118f38f4896d07755b3eaebe48b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921553Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#720197}
-
Chris Sharp authored
TBR=xhwang Bug: 1029355 Change-Id: I42665ef9025a00ced5c33c88fc74781b0cec1c56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943031Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#720196}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/31b0a5681dea..8df9e6a2d570 git log 31b0a5681dea..8df9e6a2d570 --date=short --first-parent --format='%ad %ae %s' 2019-11-29 ilkos@google.com Merge "trace_processor: fix span outer join when one of the tables is empty" Created with: gclient setdep -r src/third_party/perfetto@8df9e6a2d570 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id055921f56529d4f4902b67e951af3fb161372c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943609Reviewed-by:
-
Marc Treib authored
The old (Tango-based) implementation of invalidations has been (mostly) replaced by a new (FCM-based) one. The old one can not quite be deleted yet, so this CL marks all the old classes/files with a TODO for removal. It also removes a few unnecessary includes of the to-be-removed files. Bug: 1029481 Change-Id: Ic10da302ba20731487fc4784971c923bec07a88d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943177 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Tim Schumann <tschumann@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720194}
-
David Roger authored
Pre-Dice promos are no longer used. This CL removes the code and the resources. TBR=jsaul Change-Id: Ia38bd805e69aa5d3890fef8d77582d4525189447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944387 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#720193}
-
Balazs Engedy authored
The production code has also been updated in two regards: -- CrowdDenySafeBrowsingRequest::SafeBrowsingClient no longer assumes that CheckApiBlacklistUrl never invokes the callback synchronously if it returns false, as this can actually happen if the full hashes are already available on the client. -- DeleteOnIOThread is replaced with a manual call to DeleteSoon, as the former made testing difficult. Bug: 1028642 Change-Id: Id939dd25e7ddabf6ed3529209eaa4ec2a2d7609e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942429Reviewed-by:Andy Paicu <andypaicu@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720192}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5a792c5fb9e..a44c3e3b3615 Created with: gclient setdep -r src-internal@a44c3e3b3615 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: Id87a2bb9131d1d3087e7fb8a09525851d2d4bb92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943383Reviewed-by:
-
Kevin Ellis authored
This patch adds ref tests for play controls and enables these tests to run as part of a virtual test suite with the compositor enabled. The tests are designed to catch regression that break animation play controls. Tests were added for syncing the compositor start time as well as updating the playback rate. The test for zero playback rate exposed a bug where it should have been disabled on the compositor but wasn't. This bug is also fixed in the patch. Bug: 1029123 Change-Id: I0304d80b93ef273dd2f1dbcd58e2371bc046941e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943367Reviewed-by:
-
Marc Treib authored
invalidation_util.h/cc contained a few functions to convert between InvalidationObjectId and string that were unused, so this CL removes them. Bug: none Change-Id: I4b90fb78eaf4a1b4c43f193715ed9d67da4642f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943134 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Marc Treib authored
The flags (cmdline switches) kInvalidationUseGCMChannel and kSyncNotificationHostPort were obsolete (never set or checked anymore), so this CL removes them. Bug: none Change-Id: Id11dd81bae8fcb49b0b8b2f2eae4013cfd2a06f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944348 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Jan Scheffler authored
This cl prepares for crrev.com/c/1934213 Bug: chromium:1016772 Change-Id: I3ed38174fce88373bb205a2e0fc3a63f8d7901cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936491 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#720187}
-
Marc Treib authored
Bug: none Change-Id: I0bce94804ed7d9877ca2189a56e139e75eb47550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943178 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
