GitLab

Some inspector LayoutTests were using ConsoleViewMessage.toString() to check
that a message included a substring. Most of the function logic was not
necessary and some cases could be replaced with the .text getter.

BUG=

Review-Url: https://codereview.chromium.org/2348583004
Cr-Commit-Position: refs/heads/master@{#419910}

Chrome may end up using ScreenDimmer in such a way that the ScreenDimmer is destroyed after the shell. This change makes ~ScreenDimmer deal with the shell having been destroyed so that it doesn't crash.

BUG=648723
TEST=covered by test
R=jamescook@chromium.org

Review-Url: https://codereview.chromium.org/2359633003
Cr-Commit-Position: refs/heads/master@{#419909}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/acf3233d..f9a47d47

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2352133002
Cr-Commit-Position: refs/heads/master@{#419908}

https://chromium.googlesource.com/skia.git/+log/65b8cb05a756..e918417dc34c

$ git log 65b8cb05a..e918417dc --date=short --no-merges --format='%ad %ae %s'
2016-09-20 fmalita Revert of Stop closing filled paths in GrShape (patchset #1 id:1 of https://codereview.chromium.org/2355833002/ )
2016-09-20 borenet Revert of [SVGDom] Opacity optimization (patchset #4 id:60001 of https://codereview.chromium.org/2353503005/ )
2016-09-20 mtklein GN: add skia_use_mesa for OSMesa in tools.
2016-09-20 borenet Attempt to fix nanobench upload
2016-09-20 stani Revert of Clear stencil buffer before using it for drawing (patchset #2 id:20001 of https://codereview.chromium.org/2342873004/ )

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=borenet@google.com

Review-Url: https://codereview.chromium.org/2354873005
Cr-Commit-Position: refs/heads/master@{#419907}

BUG=645522

Review-Url: https://codereview.chromium.org/2352073003
Cr-Commit-Position: refs/heads/master@{#419906}

  In order to roll GN 6a1c8d41..65f3a42b (r419720:r419871) and pick up
  the following changes:

  385a310b Fix an issue in `gn analyze` when building all.

TBR=brettw@chromium.org

Review-Url: https://codereview.chromium.org/2354123002
Cr-Commit-Position: refs/heads/master@{#419905}

https://chromium.googlesource.com/external/github.com/sctplab/usrsctp/+log/4ce5badc8..7f9228152

Includes a fix for a possible cause of a WebRTC crash.

$ git log 4ce5badc8..7f9228152 --date=short --no-merges --format='%ad %ae %s'
2016-08-26 tuexen Sync with sctp-idata.
2016-08-24 tuexen Sync FBSDID.
2016-08-23 tuexen When aborting, send the ABORT before the notif.
2016-08-23 tuexen Try to silence a warning.
2016-08-22 tuexen Sync with SCTP El Capitan.
2016-08-22 tuexen Sync with sctp-idata.
2016-08-20 tuexen Sync with ElCaptian.
2016-08-15 tuexen Ensure that sctp_it_ctl.cur_it does not point to a free object (during a small time window). Thanks to Byron Campen for reporting the issue and suggesting a fix. It is managed in https://bugzilla.mozilla.org/show_bug.cgi?id=1293347

BUG=b/29509732

Review-Url: https://codereview.chromium.org/2352673005
Cr-Commit-Position: refs/heads/master@{#419904}

BUG=406277

Review-Url: https://codereview.chromium.org/2349563002
Cr-Commit-Position: refs/heads/master@{#419903}

BUG=641390
TBR= follow-up to change in the API.

Review-Url: https://codereview.chromium.org/2356883002
Cr-Commit-Position: refs/heads/master@{#419902}

BUG=646612

Review-Url: https://codereview.chromium.org/2348983002
Cr-Commit-Position: refs/heads/master@{#419901}

to prevent the disambig window from being shown when it shouldn't be.

BUG=640393
TEST=see repro steps in b/31043273
TEST=try

Review-Url: https://codereview.chromium.org/2277533002
Cr-Commit-Position: refs/heads/master@{#419900}

The intent of the fallback to top()->document().url() in
GetOriginOrURL() is to support file path matching for content setting
exceptions in pages loaded from a file: scheme.  This fallback can
cause crashes in OOPIF modes when the top frame is remote, even in
cases that have nothing to do with file: exceptions, such as a
sandboxed main frame (which has a "null" origin) embedding an
OOPIF.

Longer-term, local and remote frames should be treated the same way
for content settings exceptions for the file: scheme; and content
settings will be refactored to be based on origins rather than GURLs
in issue 621724.  In the short term though, avoid the crash by falling
back to document->url() only for local top frames.  This shouldn't
actually affect file exceptions, as --isolate-extensions, which is the
only OOPIF mode currently enabled by default on trunk, won't put
subframes inside file: pages into a separate process.

BUG=628759, 466297

Review-Url: https://codereview.chromium.org/2354083002
Cr-Commit-Position: refs/heads/master@{#419899}

BUG=None

Review-Url: https://codereview.chromium.org/2349353004
Cr-Commit-Position: refs/heads/master@{#419898}

Previously blink's trace_event was implemented in the way to make
blink a standalone library:
   TRACE_EVENT macros
-> TRACE_EVENT internal macros
-> EventTracer
-> Chromium's trace event C++ API

Now blink is no longer a standalone library, so we can use chromium's
trace_event macros directly.

This CL
- removes blink's trace_event implementation
- lets blink's TraceEvent.h include chromium's trace_event.h,
- lets blink's TracedValue implement ConvertableToTraceFormat,
- keeps support of blink CString type as trace values.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2341333003
Cr-Commit-Position: refs/heads/master@{#419897}

CL containing tests is at https://codereview.chromium.org/2335643002/

BUG=

Review-Url: https://codereview.chromium.org/2356983002
Cr-Commit-Position: refs/heads/master@{#419896}

Ensure container is attached to Window when acquiring
an anchor view.

BUG=646320

Review-Url: https://codereview.chromium.org/2346183002
Cr-Commit-Position: refs/heads/master@{#419895}

This file is actually used in the Windows build (it is where the cursors come from) so the comment about that it should be removed was incorrect. This patch deletes that comment.

R=sky@chromium.org

Review-Url: https://codereview.chromium.org/2353463003
Cr-Commit-Position: refs/heads/master@{#419894}

Updates unit tests for FieldTrial (which were misspelled FieldTrail).

BUG=

Review-Url: https://codereview.chromium.org/2351903004
Cr-Commit-Position: refs/heads/master@{#419893}

BUG=634388

Review-Url: https://codereview.chromium.org/2342353004
Cr-Commit-Position: refs/heads/master@{#419892}

Turn on sandbox for mojo apps by default. Apps that need to run
without a sandbox need to include 'shell:unsandboxed' in their
capabilities in manifest for mojo:shell.

Update manifests for mojo:ui, mojo:font_service, mojo:file_system,
and mojo:leveldb services to include 'shell:unsandboxed'.

BUG=645602, 646376

Review-Url: https://codereview.chromium.org/2338793003
Cr-Commit-Position: refs/heads/master@{#419891}

https://chromium.googlesource.com/chromium/src/+/f5ff44ae7

BUG=644059
TBR=bsep@chromium.org

Review URL: https://codereview.chromium.org/2355973003 .

Cr-Commit-Position: refs/heads/master@{#419890}

BUG=648185

Review-Url: https://codereview.chromium.org/2351533004
Cr-Commit-Position: refs/heads/master@{#419889}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cc78bd596aa7..87d7635e7c15

$ git log cc78bd596..87d7635e7 --date=short --no-merges --format='%ad %ae %s'
2016-09-20 alexandermont Add in power metric for video playback.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2352113003
Cr-Commit-Position: refs/heads/master@{#419888}

The |category| sent down will never be ALL_SITES, but it should also be
notified of changes.

BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2351153002
Cr-Commit-Position: refs/heads/master@{#419887}

BUG=634568, 637174

Review-Url: https://codereview.chromium.org/2217813003
Cr-Commit-Position: refs/heads/master@{#419886}

Adds a builder for FakeDisplaySnapshot to allow us to easily construct
the display snapshots. Will update more tests to use this functionality
in a follow up CL.

Update platform_screen_ozone_unittests.cc to use FakeDisplaySnapshot
instead of DisplaySnapshotVirtual.

Update --screen-config to take display DPI and able to start without any
initial displays.

BUG=611475

Review-Url: https://codereview.chromium.org/2340383002
Cr-Commit-Position: refs/heads/master@{#419885}

BUG=644758

Review-Url: https://codereview.chromium.org/2352213002
Cr-Commit-Position: refs/heads/master@{#419884}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/cee7475ca3ab8eba9c9760cdf086cc7c703df15c [Bisect] Account for tir_label-level summaries in parse_metric (eakuefner@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=644865

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2354113002
Cr-Commit-Position: refs/heads/master@{#419883}

This DCHECK is very easy to trigger by developers, googlers specifically, without actually violating the intent of the DCHECK.

BUG=648594

Review-Url: https://codereview.chromium.org/2353133003
Cr-Commit-Position: refs/heads/master@{#419882}

We can't have chrome.exe depending on browser code since doing so can
unexpectedly cause the size of chrome.exe to bloat. This change
accomplishes the breakage by passing the main exe entry TimeTicks
through to chrome.dll directly by way of ChromeMain and
ChromeMainDelegate rather than via an environment variable.

BUG=647223
R=brucedawson@chromium.org

Review-Url: https://codereview.chromium.org/2345933002
Cr-Commit-Position: refs/heads/master@{#419881}

https://pdfium.googlesource.com/pdfium.git/+log/5a399de2945d..60e903c33480

$ git log 5a399de29..60e903c33 --date=short --no-merges --format='%ad %ae %s'
2016-09-20 npm Change protected to private in CPDF_CID2UnicodeMap and CPDF_ToUnicodeMap
2016-09-20 npm Delete unused methods and variables in CPDF_CMapManager and in CPDF_CMapParser
2016-09-20 npm Delete unused GetBitMap() in fx_agg_driver

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2359633002
Cr-Commit-Position: refs/heads/master@{#419880}

BUG=648749
TBR=bengr@chromium.org

Review-Url: https://codereview.chromium.org/2354103002
Cr-Commit-Position: refs/heads/master@{#419879}

Specced as part of the WebVR API to associate Gamepad devices with a headset
when applicable. See: https://w3c.github.io/webvr/#interface-gamepad

BUG=389343

Review-Url: https://codereview.chromium.org/2352713004
Cr-Commit-Position: refs/heads/master@{#419878}

Currently Bookmarks bubble is anchored to center-top, so its right part
may be displayed offscreen. Regression happened after this CL:
https://codereview.chromium.org/1759453002/patch/240001/250007
which defer anchoring to LocationBarBubbleDelegateView (which in it's
turn uses NONE arrow, and makes center-top anchoring).

bookmark_bubble_view.cc was the only bubble that lost its explicit TOP_RIGHT.
So other bubbles don't need a similar update. Regression affects MacViews,
but not other platforms, because other platforms infer a TOP_RIGHT in
location_bar_bubble_delegate_view.cc. MacViews does not, because it's
anchored to a point, not a View.

This change restores anchoring to top right and does not impact other platforms
(tested on Windows). The change makes MacViews version worse in RTL, because
omnibox is not mirrored on mac. Since omnibox will be mirrored eventually,
leaving it as it is.

BUG=600209

Review-Url: https://codereview.chromium.org/2351593002
Cr-Commit-Position: refs/heads/master@{#419877}

This is an automated CL created by the recipe roller. This CL rolls recipe
changes from upstream projects (e.g. depot_tools) into downstream projects
(e.g. tools/build).

More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug
(or complain)

build:
  https://crrev.com/9672983b7e4143ea26754935e0132a0838f2b326 Add flutter_services (abarth@chromium.org)

TBR=martiniss@chromium.org,phajdan.jr@chromium.org
BUG=

Recipe-Tryjob-Bypass-Reason: Autoroller
Bugdroid-Send-Email: False
Review-Url: https://codereview.chromium.org/2356033002
Cr-Commit-Position: refs/heads/master@{#419876}

Where possible, use the "standard" message for read-only objects from
ExceptionMessages. Move the setup of the ExceptionState with this
message to SVGPropertyTearOffBase and reuse. It also saves a small chunk
of code-space.

Also drop a bunch of vspace, reorder checks in
SVGPreserveAspectRatioTearOff to check for immutability first and do
less work on error in SVGMatrixTearOff.

Review-Url: https://codereview.chromium.org/2357463002
Cr-Commit-Position: refs/heads/master@{#419875}

Currently, we do not flush our GL contexts after cleaning up
LayerTreeHostImpl (LTHI) resources. This delays the time it takes for
these deletes to reach the GPU process, and can allow driver caches to
grow unnecessarily.

This CL does a ShallowFlushCHROMIUM after freeing LTHI resources, which
reduces cache growth on some platforms (observed on N9).

R=vmpstr
BUG=643251
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Review-Url: https://codereview.chromium.org/2358593002
Cr-Commit-Position: refs/heads/master@{#419874}

When run with tsan and ubsan, the net_unittests take many hours to
complete and waste build machine resources.

The tests can be re-enabled once the source of the slowdown is found.

BUG= internal b/31279943

Review-Url: https://codereview.chromium.org/2349373003
Cr-Commit-Position: refs/heads/master@{#419873}

The affected function are TabInsertedAt() and TabPinnedStateChanged().

This change includes no functional changes and it will be used in a
subsequent CL.

Review-Url: https://codereview.chromium.org/2354673004
Cr-Commit-Position: refs/heads/master@{#419872}

Revert of Add work-around to symlink.gni to avoid "not up-to-date" ninja errors (patchset #1 id:1 of https://codereview.chromium.org/2344243002/ )

Reason for revert:
Breaks iOS build with failure:

FAILED: gen/linked_src/third_party/objective_c/google_toolbox_for_mac
python ../../build/symlink.py --update-target-mtimes -f ../../../../../../third_party/google_toolbox_for_mac/src gen/linked_src/third_party/objective_c/google_toolbox_for_mac
Traceback (most recent call last):
  File "../../build/symlink.py", line 65, in <module>
    sys.exit(Main(sys.argv))
  File "../../build/symlink.py", line 56, in Main
    os.utime(s, None)
OSError: [Errno 2] No such file or directory: '../../../../../../third_party/google_toolbox_for_mac/src'

Original issue's description:
> Add work-around to symlink.gni to avoid "not up-to-date" ninja errors
>
> Ninja bug: https://github.com/ninja-build/ninja/issues/1186
>
> BUG=646165
>
> Committed: https://crrev.com/80f464d5151c3eec102604faf5fa36d9369b64aa
> Cr-Commit-Position: refs/heads/master@{#419751}

TBR=dpranke@chromium.org,agrieve@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=646165

Review-Url: https://codereview.chromium.org/2356973002
Cr-Commit-Position: refs/heads/master@{#419871}