- 25 Mar, 2020 40 commits
-
-
Moe Ahmadi authored
Cleans up existing variations and adds new ones to enable proactive ZPS in NTP Omnibox/Realbox to chrome://flags/#omnibox-on-focus-suggestions Bug: 1046547 Change-Id: Id2bc53aa997c7f4e4181e89ab16f8e9dc84dab9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121080Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753372}
-
Francois Doray authored
All MessagePumps now use DoSomeWork. In a future, CL: - DoSomeWork will be renamed to DoWork - Complexity of ThreadControllerWithMessagePump and SequenceManager can be reduced. For example, WorkDeduplicator can be simplified. These changes will be done separately to minimize the size of this CL. Bug: 885371 Change-Id: I3c557e19bf8da6dc21c655202d3572a71a23c0a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070716 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#753371}
-
Donn Denman authored
Updates the ResolvedSearchTerm java class to use a builder pattern. This class has long been immutable, but that's made it hard to work with due to all the private members. Now with a builder we can specify what we want. Change-Id: I79477f5d768871dba21881025ea328fc629d7a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119878 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#753370}
-
Andrey Kosyakov authored
This ensures that the devtools_page URL has correct scheme and host, both when loading the manifest and when pushing data to DevTools front-end. Bug: 1059577 Change-Id: I69a7ccdccfae31781ead371a85d23df36f108665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118894 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753369}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ia81fac584909e836752a1b6f7f3624c2697b1cb3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121072Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#753368}
-
Roman Sorokin authored
The WebviewLoginTest.BackButton became flaky after CL:2002869. It tries to go back before loadingFrameContents_ set to false. Don't think we should restrict going back by this flag. We check isWhitelistErrorShown_ and authCompleted_ anyway. Fixed: 1043661 Change-Id: Ia114136d688dceed1f8f4ca40d412eb874286394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120357Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753367}
-
alanlxl authored
Previously we post the whole UpdateSmartDimMlAgent to a new thread and post some of the following work back to UI thread manually. This CL uses PostTaskAndReplyWithResult to post only I/O (reading files from components) to a new thread and switch back to UI thread automatically. This way we can lock all functions of download_worker.cc to UI thread as well as simplify the code. Bug: 1049886 Test: Pass the unit tests and tested on the DUT Change-Id: Iaf70a3d37d49c33a6332293711b25697eefa8df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116168Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Xinglong Luan <alanlxl@chromium.org> Cr-Commit-Position: refs/heads/master@{#753366}
-
Dana Fried authored
FlexRule by default doesn't know the orientation of the layout it's in, so the existing pre-baked rules you get from calling: FlexSpecification(MinimumFlexSizeRule, MaximumFlexSizeRule, bool) apply the same logic on both axes. This is typically not the desired behavior, however. For example, if you have a FlexLayout with cross axis alignment = center and the default flex rule uses kPreferredSnapToZero, then if a child view is slightly too large on the cross axis, instead of being clipped at the top and bottom, it drops out entirely. This resulted in several kinds of yucky bugs (see below for examples). What we really want is the ability to easily provide a flex rule that applies only on the main axis; possibly with a different cross-axis rule that would default to using the view's preferred size. This CL adds a constructor of the form: FlexSpecification( orientation, main_axis_min_size, main_axis_max_size = preferred, use_height_for_width = false, cross_axis_min_size = preferred) The order of arguments is chosen so that those with defaults least likely to be overridden are last. This new constructor would be used in 95% of the cases where we currently call the three-argument FlexSpecification constructor mentioned above, and can still replace the other constructor in the other 5% of cases at the cost of a little verbosity. The old constructor is not removed but a note is placed on it suggesting the new constructor be used in most cases. Bug: 1061869, 1063275, 1063455 Change-Id: Id8a85f9d80bfe393344ce25f3ed885f18b48d29f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113690Reviewed-by:Caroline Rising <corising@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#753365}
-
Ryan Sleevi authored
Currently, ShouldRequireCTForTesting is implemented as a tristate, with values of false, true, and nullptr. true and nullptr work as expected, while false causes CT to be required in some cases where it is otherwise not required (such as official builds, for locally trusted certs). This simplifies the implementation by making it bi-state, and renames the method and enums to better reflect that true is forcing CT on absolutely, while false is... not forcing CT on absolutely. Bug: 1064391 Change-Id: I1f85a70d32e5c9a0772d877f8217009e6ccddf49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118577Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753364}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/46fdad4eca63..b172d257d938 git log 46fdad4eca63..b172d257d938 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 miu@chromium.org Cast Streaming apps: Limit FFMPEG decode threads to 8. Created with: gclient setdep -r src/third_party/openscreen/src@b172d257d938 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I542f255382185a19fe230c666ec5f89468f1c282 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120905Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753363}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/ae5e8fb6311c..449349092a72 git log ae5e8fb6311c..449349092a72 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 brgoddar@microsoft.com Network: Fix blue focus ring on Network Log Area when Learn More Clicked 2020-03-25 aerotwist@chromium.org Skips flaky multple-worker test 2020-03-25 bmeurer@chromium.org Disable popover eager evaluation on Wasm frames. Created with: gclient setdep -r src/third_party/devtools-frontend/src@449349092a72 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1056138,chromium:1063875,chromium:1064581 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia75a2ea68cfa24c9208d6f65d114105d148c46d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120906Reviewed-by:
-
Peter Kasting authored
Bug: none Change-Id: I5b95f74395d05e0c26a53c7d9419ec0cb1938ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121039 Commit-Queue: Peter Kasting <pkasting@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#753361}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/1aff54a5..754d46b1 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibbb6152a21d4d6fdfd55ce6572b607de7d53c781 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119311Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753360}
-
Omer Katz authored
This reverts commit 2f69de56. Reason for revert: quick resolution to issue 1059655 Original change's description: > heap: Enable concurrent marking for HashTable based collections > > All known data races in HashTable based collections have been resolved. > > Bug: 986235 > Change-Id: Ia7a22d707aaaea1ab3ebc70c47da0876fc426aa9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078617 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Commit-Queue: Omer Katz <omerkatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746694} TBR=haraken@chromium.org,mlippautz@chromium.org,omerkatz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 986235 Change-Id: Ia3e3f4ef5dd20c4826b3a8a96adc33c3401e5eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120477Reviewed-by:
Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#753359}
-
Brian Sheedy authored
Increases the sharding values for chrome_public_test_vr_apk-ddready-ddview and chrome_public_test_vr_apk-ddready-cardboard. The tests are currently taking about 54 and 21 minutes to run, respectively, so the sharding values are increased to get the per-shard runtime down to the 10-15 minute range. Change-Id: I34fd76dc643e06d166559496016ae530000e9f57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118697 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#753358}
-
Jarryd authored
This histogram tracks whether or not the user even uses the installed app warning dialog. This metric will make it easier for us to see if it's worth keeping this extra dialog, which is extra friction in the clear browsing data flow. Bug: 997258 Change-Id: I8e4235ca901a0b44ded4f62efe29388b03e1d2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116310Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#753357}
-
Antonio Gomes authored
Original patch: https://bugs.webkit.org/show_bug.cgi?id=92667 BUG=1063749 R=dgrogan@chromium.org, robertma@chromium.org Change-Id: Ie6d3152184e6c944e0657df1b9ed5fd2364cfa2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120853 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#753356}
-
Ted Choc authored
BUG= Change-Id: Ic4dd009f130a46c39af547d7e045783f061f18ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113791Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#753355}
-
Lukasz Anforowicz authored
This CL deletes CrossOriginXHR.AllURLs and replaces it with a new CrossOriginReadBlockingExtensionAllowlistingTest FromProgrammaticContentScript_PermissionToAllUrls test. Notes: *) The <all_urls> aspect is the only difference between the new test and the old test at FromProgrammaticContentScript_NoSniffXml. Still, it seems worthwhile to preserve test coverage of the <all_urls> aspect even though this aspect is also covered somewhat by the unit tests that were tweaked by https://codereview.chromium.org/8138004/ *) The old/deleted test was introduced in https://codereview.chromium.org/8138004/ which was fixing https://crbug.com/98418. Initially the manifest.json of the test had a "plugins" entry, but this aspect of the test was removed by r521122. *) I don't really understand why there were 2 test cases in the deleted test (domainOne and domainTwo). I also don't understand the navigate-and-then-retest aspect (mentioned in the repro steps of https://crbug.com/98418 but not really covered by the deleted test). Bug: 1061567 Change-Id: Idcbd4a0908aeb094391deaafc941ee482e7abb03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2106448 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#753354}
-
David Tseng authored
Unfortunately, to resolve base::Location for each api call, we cannot support chaining. However, shortening the variable name for |speech_monitor_| to |sm_| and not having to indent, we actually save some indent space. Also, this change now includes all pending utterances (for understanding the state when the test is waiting). Sample output: [158567:158567:0325/082550.588956:ERROR:speech_monitor.cc(276)] Still waiting for expectation(s). Unsatisfied expectations... ExpectSpeech("Fail!Rate 19 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:931 Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:933 ExpectSpeech("Pitch 50 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:934 Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:936 ExpectSpeech("Reset text to speech settings to default values") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:938 Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:941 ExpectSpeech("Rate 19 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:942 Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:943 ExpectSpeech("Pitch 50 percent") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:944 pending speech utterances... Volume 100 percent Rate 19 percent Satisfied expectations... Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:926 ExpectSpeech("Reset text to speech settings to default values") RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:928 Call() RunTestOnMainThread@../../chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc:930 Change-Id: If1bdbfb517014e681cb233800eab3f62f608188f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120741Reviewed-by:Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#753353}
-
Camillo Bruni authored
The ParametrizedModuleHelper can be used to parametrize existing tests to run both with kTopLevelAwait enabled and disabled. Additionally ParamatrizedModuleTestParamName is provided for better better test names when using the INSTANTIATE_TEST_SUITE_P macro. Bug: 1022182, v8:9344 Change-Id: Ib263ebe46d523ef7967bd3392546bcf31b4da287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105378 Commit-Queue: Camillo Bruni <cbruni@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#753352}
-
Peng Huang authored
This reverts commit 3bb52934. Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1064732 Original change's description: > Fix use of invalid DisplaySnapshot pointer while updating HDCP > > HDCP updates are asynchronous. Do not pass display state pointers > between async calls since display configuration may have changed. > > Instead query the display state and validate that the requested > displays are valid. > > BUG=1058030 > TEST=display_unittest > > Change-Id: I7e037a44f06156b5b1da3f2672330ba8a18ca950 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118771 > Reviewed-by: Mitsuru Oshima <oshima@chromium.org> > Commit-Queue: Daniel Nicoara <dnicoara@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753203} TBR=oshima@chromium.org,dnicoara@chromium.org Change-Id: I57fd6ee3708900914c15e8b844dc8ad772ec35e1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1058030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121084Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#753351}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0eff2a2b463f..046389926f10 git log 0eff2a2b463f..046389926f10 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 bryan.bernhart@intel.com D3D12: Add end2end tests for small shader-visible heaps. Created with: gclient setdep -r src/third_party/dawn@046389926f10 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Id5fd4a298854aa8449fdc06fb11283071dfdc3ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120904Reviewed-by:
-
Xiaocheng Hu authored
SVG use elements with data URI may carry arbitrary content. Hence, we also sanitize it before pasting it into document. Bug: 1040755 Change-Id: Iad8701174c7c0f13dc5affb9e011d645990ef754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119198 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#753349}
-
Dana Fried authored
Convenience method for debugging and testing, similar to most other geometry and small data structs in Chrome. Change-Id: Ic5ad787f8b361c5b5a25b71dce2db6dbae4b8731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116555Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#753348}
-
Jeremy Apthorp authored
This allows customizing the prototype of the constructed object. Change-Id: Id302d6f3202468963f6659e6df64726bb6bdc9d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119183 Commit-Queue: Jeremy Apthorp <jeremya@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#753347}
-
Kyle Milka authored
Record a metric that tracks the time from a share being initiated until the user selects a share target. Bug: 1009124 Change-Id: If32a3f36ed27f4224b2352c4e9348d89b43e3a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117315 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#753346}
-
Chris Hamilton authored
Since M69 it has been possible for tabs to restore and not be loaded for an indefinite period of time. This new tab state was not reflected in the tabs extension API. Concretely, this adds a third "unloaded" state to the "status" enum, which previously was one of "loading" or "complete". BUG=1061209 Change-Id: Icadb41fe033ae47630affeabffb38fa5b3e9d79e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105564 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
-
Alexander Cooper authored
Moves the XrConsentHelper and XrConsentPromptLevel interfaces to content/public and moves the windows-specific implementation out of chrome/browser/vr/service. Creates a wrapper method for the windows- specific singleton to better fit the pattern of the other consent helpers. Note that the XrConsentHelpers are currently disabled by default and intended to be removed once the switch to use permissions has shipped, but due to the current release changes, this is looking further out. Thus, these methods are moved temporarily to enable VRService to move. Bug: 1031622 Change-Id: I54b0ee16d27e0cf95dbe562e064e0f24b7ac30e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118579 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#753344}
-
Ahmed authored
This CL adds a flag to enable users, who prefer, to limit the windows in Alt-Tab to the ones in the current active desk. The flag is disabled by default. BUG=1023445 TEST=Manually, Added a new test. Change-Id: I343e724eb5d01e3ec3521af446e4669178acbb76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118830 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#753343}
-
Caleb Rouleau authored
tools/perf/OWNERS: John is now TL and primary reviewer. update_wpr: John will review these. media_cases: John and I aren't on this team anymore. Change-Id: I95a11c1bb62e74670142a2b30def3884e4f9acbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120749 Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#753342}
-
Robbie McElrath authored
This CL removes the ANDROID_SITE_SETTINGS_UI_REFRESH feature, which has been enabled by default since April 2019. This removes a dependency on //chrome from site settings, which will help componentize it for WebLayer. Bug: 1058597, 1057950 Change-Id: I85d34ef3f46fb59490f07d35def2a15084714809 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103395 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#753341}
-
Matt Menke authored
It's no longer used. Also remove the net/ callback methods used to invoke it. Bug: None Change-Id: I0fe0dea935c1ea36257275a9d1449e951d37f414 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116892Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#753340}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f11e33152460..988ce0490a11 git log f11e33152460..988ce0490a11 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 kjlubick@google.com remove localmatrix parameter from Blend and Lerp compose shaders 2020-03-25 csmartdalton@google.com Properly detect integer support on WebGL 2.0 2020-03-25 csmartdalton@google.com Bootstrap a very simple viewer implementation in CanvasKit 2020-03-25 csmartdalton@google.com Don't add offsets to nullptr in GrGLOpsRenderPass Created with: gclient setdep -r src/third_party/skia@988ce0490a11 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ifc188c636f91ea3f2adad39fff76df14ccf8cebb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120903Reviewed-by:
-
Theresa Wellington authored
Add FLAG_ACTIVITY_NEW_TASK to intents used to launch new activities in TabModelMergintTest, and reenable #testMergeOnColdStartIntoChromeTabbedActivity2 on Pie. BUG=1036551 Change-Id: I995f1f4e5aeeb0c533e55fc9b8000e534613e9aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120748 Auto-Submit: Theresa <twellington@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#753338}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0eb6932a. With Chromium commits locally applied on WPT: bb6643e9 "Simplify image-loading-subpixel-clip.html." d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I31d07fd5ba99d9a0cb7a9714fccba99f778ec728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120793Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#753337}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4504b6a42842..21a3f16268e9 git log 4504b6a42842..21a3f16268e9 --date=short --first-parent --format='%ad %ae %s' 2020-03-25 treehugger-gerrit@google.com Merge "Include progname in malloc hook logs." 2020-03-25 treehugger-gerrit@google.com Merge "Acknowledge flushes / stop with unknown data sources." Created with: gclient setdep -r src/third_party/perfetto@21a3f16268e9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie8afd80901cbd6ac93be83b7f4d27f6be2ee6ca9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120902Reviewed-by:
-
Brian Cui authored
This small CL disables the elements-tab-stops test in order to land DevTools Settings discoverability improvements [1]. [1] adds a new Settings button to the top-level toolbar, which appears as a tab-stop in this test. [2] fixes the test so that the new tab stop is in the expectations file. [1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2049183 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2118870 Bug: 1050855 Change-Id: I6fd5386f84220f22d00e54255a7bdcfe8b4cb9e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117328 Commit-Queue: Brian Cui <brcui@microsoft.com> Auto-Submit: Brian Cui <brcui@microsoft.com> Reviewed-by:
John Emau <John.Emau@microsoft.com> Cr-Commit-Position: refs/heads/master@{#753335}
-
Kevin Ellis authored
Disabling the tests pending a more thorough investigation into the underlying causes. Bug: 1064065, 1064127, 1064463 Change-Id: I1748cd23f1509bbc8ea4b7b37a1cac27f8b74dab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120745 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#753334}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/540bdf92531d..8cef397d7dec git log 540bdf92531d..8cef397d7dec --date=short --first-parent --format='%ad %ae %s' 2020-03-25 bclayton@google.com CMake: Don't export LLVM_INCLUDE_DIR to PARENT_SCOPE 2020-03-25 bclayton@google.com CMake: Move LLVM rules out to third_party/llvm-7.0 2020-03-25 bclayton@google.com Add missing copyright header to CMakeLists.txt Created with: gclient setdep -r src/third_party/swiftshader@8cef397d7dec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3504ce618e05eaa4c9bc9904ae74001e18259b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120901Reviewed-by:
-
