- 26 Aug, 2020 40 commits
-
-
Kalvin Lee authored
This change brings the variants of the metadata type enum (internal to the PpdMetadataManager class) in line with the style guide's guidance. Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataManagerTest.*' Change-Id: I9b87932b187c95f600db4caa3f945f9a9d6af5ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340634 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#801972}
-
David Tseng authored
R=akihiroota@chromium.org Bug: 111985 AX-Relnotes: ChromeVox provides feedback when entering or leaving an audio or video tag. Test: browser_tests --gtest_filter=ChromeVox*.AudioVideo Change-Id: Ia0b38a5dde6f7554ad476dc61ccf910fd11d5658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377110Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801971}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0fdfdcf61cd4..14a9bffb3e9e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ia95f3c88911f272c8172b55997b99b88a9fe3523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377663Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801970}
-
danakj authored
Disable flaky external/wpt/webvtt/rendering/cues-with-video/processing-model/dom_override_remove_cue_while_paused.html TBR=mlamouri@google.com Bug: 1084378 Change-Id: I9846988c3f3c065dc89962552ea11b6d621fb30b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377661Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#801969}
-
Sahel Sharify authored
The test is flaky on multiple platforms. TBR=jiakl@google.com,mcrouse@chromium.org Bug: 1122160 Change-Id: I0d6a7354fc5969a9e01efefb17c7c6fd1c67b018 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378396Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#801968}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7c5a76596198c2b33442cf8092dfcdbaad442615 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378218Reviewed-by:
-
Ben Kelly authored
The trial showed that this is neutral in top level metrics like FCP. This is somewhat expected as the throttling is intended as an additional protection against a site contending with itself. The trial also showed that install takes longer. At the median installs are ~10ms slower and at P99 are 2 to 5 seconds slower. The P99 for install is still less than 30 seconds, however, which places it well under the 5 minute timeout threshold. UMA also showed that while timeouts increased slightly they still only occurred around ~0.1% of the time. Bug: 1035448 Change-Id: I40dbe69e363997725b29a282041e9e27aee9c712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376368 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#801966}
-
Haiyang Pan authored
This reverts commit f160a626. Reason for revert: Very likely the cause for the test failure android.webkit.cts.WebViewTest#testPauseResumeTimers in the following builders: * https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/1975 * Android Webview dbg builders like * https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20L%20(dbg)/14498 * https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20M%20(dbg)/12523 Verified on local emulator builder Original change's description: > [scheduling] Removing QueueClass. > > QueueClass is currently used for high-level policy decisions in the > main thread. For the most part, the policies applied to each queue > class are largely the same. This change removes QueueClass entirely > and adds bits on the policy for pausing and deferring task queues as > well as whether or not virtual time is enabled. > > > Change-Id: Iae28c5d7d2ad4c9deb7dad2e1c3294e7ac6b9470 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365315 > Commit-Queue: Katie Dillon <kdillon@chromium.org> > Reviewed-by: Scott Haseley <shaseley@chromium.org> > Reviewed-by: Alexander Timin <altimin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801591} TBR=altimin@chromium.org,kdillon@chromium.org,shaseley@chromium.org Change-Id: Ibb78ad6245a2f28c1d8b60c6abbad32669213911 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377890Reviewed-by:
Haiyang Pan <hypan@google.com> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#801965}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/983698bb34ec..517f39eee46f 2020-08-26 johnkslang@users.noreply.github.com Merge pull request #2380 from null77/suppress-override-warnings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC courtneygo@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: courtneygo@google.com,radial-bots+chrome-roll@google.com Change-Id: I67d304e2cd3d61b71439807203e39866df669909 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378215Reviewed-by:
-
Marijn Kruisselbrink authored
This API isn't supported and doesn't ship on android. Bug: 1122082 Change-Id: Ia26074459d9cff45b6f0201303607f7c21f6a9d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378385 Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801963}
-
Jeffrey Young authored
Add new histogram "Ash.AmbientMode.Activation" to record number of times Ambient Mode activates. BUG=b:163529319 Change-Id: I056a607e061f305fd225ce52568d007ccc369c67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362440 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Cr-Commit-Position: refs/heads/master@{#801962}
-
danakj authored
R=mek@chromium.org Bug: 1092048 Change-Id: I4274397d965468cab0e1277ea1382e4215035b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377660Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#801961}
-
Lei Zhang authored
These performance metrics should remain stable over time and alert should fire if they deviate significantly. As such, set them to never expire. Also add a secondary owner. Bug: 1109836,1109875 Change-Id: Id1e31973f40d38ef54c5229df789a1c7258062ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376318Reviewed-by:
-
Martin Kreichgauer authored
Enumerate the relevant fields in MakeCredentialRequestHandler::Options rather than pass in the entire AuthenticatorSelectionCriteria to simplify things a little. No functional changes intended. Bug: 1117630 Change-Id: I252d6a091b5b8f68d2558489ce1d528f5e5d5416 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2365134 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#801959}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b8e8ad564da3..661b3a4411c6 2020-08-26 petermueller@chromium.org Device preview: replace PNG icons with SVGs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I87b998f4040395ecc952211943b02a5eca3a234f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377363Reviewed-by:
-
Arthur Wang authored
R=bsheedy@chromium.org Context: to make sure those wprarchive files are downloaded properly. Bug: 1096656 Change-Id: Id0197c39f1a260bf9356269f41c12a46deecbf17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378386Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#801957}
-
Adam Langley authored
This reverts commit 9e3a51f1. I believe that 087d4503 fixes the underlying issues in the code that this change originally surfaced. Thus this is a simple revert of the original change. The only updates are to reflect the use of a std::vector for the QR data. Original change's description: > qr: add support for selecting the mask. > > The QR standard says that the mask should be auto-selected, not fixed to > three, and specifies a fitness function for choosing the best mask for > each QR code. > > This change adds support for that and lets the caller specify a mask if > it really wants … say if it wanted to cycle through a series of QR codes > for the same data with a dancing dinosaur on top. Change-Id: I1f247baad727648be1f070c11753758edde47512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377611 Auto-Submit: Adam Langley <agl@chromium.org> Commit-Queue: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#801956}
-
Dave Tapuska authored
Previously the scrolled focused_node_into_view would request the view's focused frame's local root's frame widget. Just call ScrollFocusedEditableElementIntoView on the FrameWidget. BUG=1097816 Change-Id: I9d0b0c465d8449ed4f656b80018e39384dd7761b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364659 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801955}
-
Yuly Novikov authored
To prevent CQ flakiness like in crbug.com/1122044. Expecting 1 more build a day on average. Bug: 1122044 Change-Id: I03e97d18db63e75e966994234fbeceabc674cd4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378614Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#801954}
-
Kenneth Russell authored
Renderer process is intermittently hanging; minidumps do not show why. Bug: 1121476 Change-Id: If24d8618d7053061a51dc6acadec0c943b846a9f Tbr: sunnyps@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377653Reviewed-by:
-
Nnamdi Theodore Johnson-Kanu authored
Bug: 1111477 Change-Id: I4604ea00cd12cead7dcff72e2c4f615355320d07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375599 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#801952}
-
Kalvin Lee authored
This change implements ParseUsbVendorIdMap(). Bug: chromium:888189 Test: chromeos_unittests --gtest_filter='PpdMetadataParserTest.*' Change-Id: I9606deaba47bac0e9359cbbe5bb2813e6febe6bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340925 Commit-Queue: Kalvin Lee <kdlee@chromium.org> Reviewed-by:
-
David Black authored
This is a reland of 57e175db Original change's description: > Remove HoldingSpacePresenter. > > No longer needed given evolution of feature requirements. > > Bug: 1112469 > Change-Id: Ic31d2a02fcc624ddc101447f68089cfff9bd2660 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377535 > Reviewed-by: Toni Baržić <tbarzic@chromium.org> > Commit-Queue: David Black <dmblack@google.com> > Cr-Commit-Position: refs/heads/master@{#801857} Bug: 1112469 Change-Id: Ic42f50fa1a8738020813d246ea7789ebfbdc78db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378451Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#801950}
-
Elaine Chien authored
Bug: 938501 Change-Id: If9ff42d2d74d62bb031dc8a878212d853deaac7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378390 Commit-Queue: Elaine Chien <elainec@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Auto-Submit: Elaine Chien <elainec@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#801949}
-
adamta authored
Removes border with animation for Discover feed header, as per new UX suggestions. Adds new animation to ease in the "- Off" part of the title label. Video of the animation: http://shortn/_F1ALPqpuET. Bug: 1085419, 1122094 Change-Id: I65ee3894e1f1105c096115e48f41d30568b8ff94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377990Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#801948}
-
Anastasia Helfinstein authored
AX-Relnotes: Launch Switch Access on Chrome OS. Bug: 1016200,1121357 Change-Id: I464abbeaeb50c8c40adbac4ce51d7d9f038430fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373368 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#801947}
-
Ian Kilpatrick authored
Per: https://www.chromestatus.com/feature/5680142707851264 In M85 we switched -webkit-line-clamp over to LayoutNG which had the (indended) side-effect of removing support for: -webkit-box-flex -webkit-box-ordinal-group -webkit-box-align -webkit-box-pack -webkit-box-direction When used with -webkit-line-clamp. This patch removes the -webkit-box-align, and -webkit-box-pack from LayoutDeprecatedFlexibleBox Bug: 305376 Change-Id: I24a86ae3db854c80e6fa9a5a768bb6594ad253d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375732 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#801946}
-
Collin Baker authored
After refactors and the introduction of FeaturePromoController, tab groups IPH logic no longer needs a dedicated class. This moves the remaining logic to BrowserTabStripController. Bug: 1106523 Change-Id: I3528da8b4c0d4d60ca033dfebb10c5a61564f036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369620 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#801945}
-
Jeroen Dhollander authored
This makes it easier to use these constants in the public code. Bug: b/165356952 Change-Id: I3eda2f175e99536de3958451c88a6d78bc84fedd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378613 Commit-Queue: Jeroen Dhollander <jeroendh@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Auto-Submit: Jeroen Dhollander <jeroendh@chromium.org> Reviewed-by:
-
edchin authored
Updates the expiry of these histograms, which are still useful to keep around. IOS.EnterTabSwitcherSnapshotResult IOS.PageLoadedSnapshotResult Bug: 1097826 Change-Id: I13380744d114f17e3cabf947b166ca049a84800d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376416 Auto-Submit: edchin <edchin@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#801943}
-
danakj authored
Once they are swapped in, we can track and use them as the main frame. R=avi@chromium.org Bug: 1114382 Change-Id: I8f0b8c906a9dd5dd106dc1dc444aa24af4721347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378447 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#801942}
-
Etienne Bergeron authored
see: https://bugs.chromium.org/p/chromium/issues/detail?id=973868#c41 Noticed in crash: 86abdd946339513d R=joenotcharles@google.com, martinkr@google.com Bug: 973868 Change-Id: Ifc4cae4458c5cbdb2aebaf852ffbaf280b2751fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376878Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Reviewed-by:
-
Ryan Hansberry authored
Keep BluetoothDevices discovered by BluetoothClassicMedium distinct from BlePeripherals discovered by BleMedium. Bug: b:154849033 Change-Id: I4f77a21b6a0f5fec29131cbc2c2d4e39d247baed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2370093 Commit-Queue: Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#801940}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic8ab815342749d2bddc4479c4d57e2d494abf746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377315Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#801939}
-
Marc Treib authored
Bug: 1109939 Change-Id: I3df1be760041a456214e8a8b4289db759d3f6b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376846 Commit-Queue: Brian White <bcwhite@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
-
Findit authored
This reverts commit 68d3758b. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 801909 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzY4ZDM3NThiMDEwZGMzZGIxN2NkNWU1MzdmMDAxNGE0N2Y0MDI5MDYM Sample Failed Build: https://ci.chromium.org/b/8870873385800887712 Sample Failed Step: compile Original change's description: > [base] Use getrandom on Linux. > > Fall back to reading from urandom only when that fails. > > Bug: 995996 > Change-Id: Id503ca2dc412a392d5a7e252fcfff65b61d0c20e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1762604 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Julien Tinnes <jln@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Robert Sesek <rsesek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801909} Change-Id: If682cc741bd401fc6ab2a3e9e8173ac8e20d6e75 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 995996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377418 Cr-Commit-Position: refs/heads/master@{#801937}
-
Ben Mason authored
This reverts commit 16e049fa. Reason for revert: No longer need this configuration. Original change's description: > Return WebView to 32-bit by default. > > Bug: 1119325 > Change-Id: I04727f349d0012a4a89ab93032530ccecf53e767 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364210 > Reviewed-by: Richard Coles <torne@chromium.org> > Commit-Queue: Ben Mason <benmason@chromium.org> > Cr-Commit-Position: refs/heads/master@{#799739} TBR=torne@chromium.org,benmason@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1119325 Change-Id: Ib9b6182502b549a5b4e81aceb8b1370080419fc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375647Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
danakj authored
Instead of crashing, which upsets clusterfuzz, deal with it more gracefully and just don't bind the gamepadController into the javascript window object. If this happens in the wild, we would have the test fail and retry, but it is probably an artifact of running clusterfuzz MSAN builds. R=avi@chromium.org Bug: 1108899 Change-Id: I2f14f6e75dcd182dbdc9a46d26892f548121054f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377655 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
-
Gavin Williams authored
Using getPrinterTypeForDestination to always get the correct printer type allows us to remove the standalone PDF check in NativeLayer.getPrinterCapabilities. It is safe to use Destination and RecentDestination as arguments to getPrinterTypeForDestination because objects have |id| and |origin|. Bug: 1112416 Change-Id: Ic94d1834485fab72c941cfc914701c26b58752c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376383Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#801934}
-
Justin Cohen authored
This reverts commit c88fabeb. Reason for revert: Still failing in beta 6 on the bots: https://chromium-swarm.appspot.com/task?id=4e4543820c675010 Original change's description: > Revert "ios: Disable RemoveCookie test on iOS14." > > This reverts commit 163b6034. > > Reason for revert: Speculative revert for beta 6 > > Original change's description: > > ios: Disable RemoveCookie test on iOS14. > > > > TBR=mrefaat > > > > Bug: 1121425 > > Change-Id: I77602b224fe06577aa7d2a7da50df17b036b54e3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373705 > > Reviewed-by: Justin Cohen <justincohen@chromium.org> > > Commit-Queue: Justin Cohen <justincohen@chromium.org> > > Auto-Submit: Justin Cohen <justincohen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#801345} > > TBR=justincohen@chromium.org,mrefaat@chromium.org > > Change-Id: Ideb21ea26cee61249444139f7a0c59735f1e5754 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1121425 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2376314 > Reviewed-by: Mohammad Refaat <mrefaat@chromium.org> > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#801908} TBR=justincohen@chromium.org,mrefaat@chromium.org No-Try: true Bug: 1121425 Change-Id: I07719c7d73c83b5d288136ae4df9d57845b162d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2378534 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#801933}
-
