GitLab

This avoids allocating a v8::Function to wrap Blink microtask callbacks, which
allows us to avoid entering a v8::Context to enqueue tasks.

ScriptRegexp is now the only use of the v8::Context stored in V8PerIsolateData.

Review URL: https://codereview.chromium.org/319753004

git-svn-id: svn://svn.chromium.org/blink/trunk@175676 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381730
TBR=abarth@chromium.org

Review URL: https://codereview.chromium.org/322553002

git-svn-id: svn://svn.chromium.org/blink/trunk@175675 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/318753008

git-svn-id: svn://svn.chromium.org/blink/trunk@175674 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Generalize and refactor DeviceSensorEvent* architecture to support multi-event type targets. (https://codereview.chromium.org/315573002/)

Reason for revert:
Triggers assert in 
fast/dom/Window/property-access-on-cached-window-after-frame-navigated.html

Original issue's description:
> Generalize and refactor DeviceSensorEvent* architecture to support
> multi-event type targets.
> 
> This patch performs a significant refactoring of the
> DeviceSensorEvent{Controller,Dispatcher} and related classes.
> It provides new Base classes to allow simple implementation of
> APIs involving multi-event type non-window targets (e.g. Battery
> Status API). Additionally it makes the implementation of existing
> event-based APIs (device_orientation, device_light) simpler and
> more compact.
> 
> In particular the following new classes have been added:
> * DeviceEventControllerBase and DeviceEventDispatcherBase
> (derived from by the Battery Status API).
> * DeviceSingleWindowEventController is more specific and
> contains functionality necessary for single-event type window
> target APIs (used by Device Motion/Orientation and Device Light
> APIs).
> 
> BUG=122593, 360068
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175661

TBR=ch.dumez@samsung.com,abarth@chromium.org,jochen@chromium.org,tkent@chromium.org,timvolodine@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=122593, 360068

Review URL: https://codereview.chromium.org/315023006

git-svn-id: svn://svn.chromium.org/blink/trunk@175673 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=350394
TBR=peter@chromium.org,dominicc@chromium.org,jochen@chromium.org,michaeln@chromium.org,kinuko@chromium.org

Review URL: https://codereview.chromium.org/320503005

git-svn-id: svn://svn.chromium.org/blink/trunk@175672 bbb929c8-8fbe-4397-9dbb-9b2b20218538

I think we need to bite the bullet and change the semantics of our
weak collections. These leaks are really hard to notice when you are
programming. See crbug.com/381629 which is the bug report I have
filed for tracking that.

R=erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, sigbjornf@opera.com
BUG=381629

Review URL: https://codereview.chromium.org/317203005

git-svn-id: svn://svn.chromium.org/blink/trunk@175670 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=dgozman
BUG=381184

Review URL: https://codereview.chromium.org/322483004

git-svn-id: svn://svn.chromium.org/blink/trunk@175669 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=378778

Review URL: https://codereview.chromium.org/313083005

git-svn-id: svn://svn.chromium.org/blink/trunk@175668 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none
TBR=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/314303005

git-svn-id: svn://svn.chromium.org/blink/trunk@175667 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No change in behavior, no new tests.

BUG=258324

Review URL: https://codereview.chromium.org/18099004

git-svn-id: svn://svn.chromium.org/blink/trunk@175666 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/310463003

git-svn-id: svn://svn.chromium.org/blink/trunk@175665 bbb929c8-8fbe-4397-9dbb-9b2b20218538

otherwise compiler includes the old version of the file from gen/blink instead of gen/blink/core

BUG=

Review URL: https://codereview.chromium.org/322463005

git-svn-id: svn://svn.chromium.org/blink/trunk@175664 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This also made toolbar expandable to accomodate controls for rarely used features.

BUG=327641

Review URL: https://codereview.chromium.org/317153002

git-svn-id: svn://svn.chromium.org/blink/trunk@175663 bbb929c8-8fbe-4397-9dbb-9b2b20218538

InspectorDOMAgent::m_documentNodeToIdMap needs to be switched from a part object
to OwnPtr/Persistent because we have some addres comparisons of
NodeToIdMap(HeapHashMap) and we have no ways to get a HeapHashMap pointer from a
PersistentHeapHashMap.

BUG=357163

Review URL: https://codereview.chromium.org/315213006

git-svn-id: svn://svn.chromium.org/blink/trunk@175662 bbb929c8-8fbe-4397-9dbb-9b2b20218538

multi-event type targets.

This patch performs a significant refactoring of the
DeviceSensorEvent{Controller,Dispatcher} and related classes.
It provides new Base classes to allow simple implementation of
APIs involving multi-event type non-window targets (e.g. Battery
Status API). Additionally it makes the implementation of existing
event-based APIs (device_orientation, device_light) simpler and
more compact.

In particular the following new classes have been added:
* DeviceEventControllerBase and DeviceEventDispatcherBase
(derived from by the Battery Status API).
* DeviceSingleWindowEventController is more specific and
contains functionality necessary for single-event type window
target APIs (used by Device Motion/Orientation and Device Light
APIs).

BUG=122593, 360068
NOTRY=true

Review URL: https://codereview.chromium.org/315573002

git-svn-id: svn://svn.chromium.org/blink/trunk@175661 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch makes isEditablePosition to work with Position objects other than
PositionIsOffsetInAnchor by using Position::parentAnchoredEquivalent() to
use right Node object for checking editability.

BUG=348973
TEST=LayoutTests/editing/execCommand/format-block-with-uneditable-crash.html

Review URL: https://codereview.chromium.org/309993002

git-svn-id: svn://svn.chromium.org/blink/trunk@175660 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Turns out no-one needs this.

BUG=359566

Review URL: https://codereview.chromium.org/311903002

git-svn-id: svn://svn.chromium.org/blink/trunk@175659 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/319043004

git-svn-id: svn://svn.chromium.org/blink/trunk@175658 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This exposes the WebCore::parseAlgorithm function through  blink::WebScriptBindings.

This will allow reusing the normalization in the implementation of the Chrome extension API enterprise.platformKeys.

To keep the exposure of types minimal, the dependency of parseAlgorithm on CryptoResult was removed.
On the way, renames parseAlgorithm to normalizeAlgorithm in order to match the WebCrypto spec and the filename.

BUG=364435

Review URL: https://codereview.chromium.org/295423004

git-svn-id: svn://svn.chromium.org/blink/trunk@175657 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey
NOTRY=true

Review URL: https://codereview.chromium.org/315253002

git-svn-id: svn://svn.chromium.org/blink/trunk@175656 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL removes the setting of the default accept header in
FrameFetchContext::addAdditionalRequestHeaders for main resources.
https://chromiumcodereview.appspot.com/313313002/ sets it in
RenderFrameImpl::willSendRequest.

BUG=376025

Review URL: https://codereview.chromium.org/315073005

git-svn-id: svn://svn.chromium.org/blink/trunk@175655 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Push API: define push event on Service Worker. (https://codereview.chromium.org/285403002/)

Reason for revert:
Broke all builds: http://build.chromium.org/p/chromium.webkit/console

e.g.
http://build.chromium.org/p/chromium.webkit/builders/Linux%20ChromiumOS%20Builder/builds/51757/steps/compile/logs/stdio

TBR=jochen@chromium.org
NOTREECHECKS=true
NOTRY=true

Original issue's description:
> Push API: define push event on Service Worker.
> 
> BUG=350394
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175652

Review URL: https://codereview.chromium.org/319973002

git-svn-id: svn://svn.chromium.org/blink/trunk@175653 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=350394

Review URL: https://codereview.chromium.org/285403002

git-svn-id: svn://svn.chromium.org/blink/trunk@175652 bbb929c8-8fbe-4397-9dbb-9b2b20218538

start/stop recording logic for trace events moved into TracingTimelineModel.

BUG=361045
R=caseq@chromium.org

Review URL: https://codereview.chromium.org/317273004

git-svn-id: svn://svn.chromium.org/blink/trunk@175649 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=aandrey, sergeyv
NOTRY=true

Review URL: https://codereview.chromium.org/319733002

git-svn-id: svn://svn.chromium.org/blink/trunk@175648 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Sice UndoManager doesn't manage DOM mutations outside of execCommand, the Undo command sometimes set broken VisibleSelection which is valid when it was recorded to the Undo steps but selection.deleteFromDocument broke that in this test case.

This CL validates VisibleSelection when it is used to restore Selection at Undo.
The main target VisibleSelection to be validate is that has any VisiblePosition which is not in the document already or which offset violates its nodes length because of "Unmagaed" DOM mutations.

BUG=369759

Review URL: https://codereview.chromium.org/315493004

git-svn-id: svn://svn.chromium.org/blink/trunk@175647 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Tidy up the definition of some stack objects and have them refer to
Element or Node references by way of Members rather than raw pointers.

R=tkent@chromium.org,haraken@chromium.org
BUG=357163

Review URL: https://codereview.chromium.org/319083004

git-svn-id: svn://svn.chromium.org/blink/trunk@175646 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=n/a
TEST=n/a
NOTRY=true

Review URL: https://codereview.chromium.org/321503003

git-svn-id: svn://svn.chromium.org/blink/trunk@175645 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'd like TimelineFrameModel to be independent from TimelineModel,
since we may build the former based on row trace events.
As a drive by, fix "no live updates" experiment which was broken
in a couple of places, especially WRT displaying frames.

BUG=361045
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/319743002

git-svn-id: svn://svn.chromium.org/blink/trunk@175644 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Updated gdb script to use range instead of range.

R=hayato, jochen
BUG=380618

Review URL: https://codereview.chromium.org/313833003

git-svn-id: svn://svn.chromium.org/blink/trunk@175643 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We never look up mirror object by its id. To avoid possible memory leaks caused by mirrors stuck in the cache we disable mirror cache completely.

This change depends on the ToggleMirrorCache added in V8 in https://code.google.com/p/v8/source/detail?r=21644

BUG=376534

Review URL: https://codereview.chromium.org/317963003

git-svn-id: svn://svn.chromium.org/blink/trunk@175642 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=337065

Review URL: https://codereview.chromium.org/313043002

git-svn-id: svn://svn.chromium.org/blink/trunk@175640 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This function should be unsupported on Workers, since it needs user interaction.

BUG=381528

Review URL: https://codereview.chromium.org/319053003

git-svn-id: svn://svn.chromium.org/blink/trunk@175639 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is the final bit of the work to remove "current" methods from the code base. I manually grepped all "current" methods from the code base and addressed the remaining ones in this CL.

BUG=357144

Review URL: https://codereview.chromium.org/310423002

git-svn-id: svn://svn.chromium.org/blink/trunk@175638 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=364398,364390,364417,376188
TBR=kouhei@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/315403005

git-svn-id: svn://svn.chromium.org/blink/trunk@175637 bbb929c8-8fbe-4397-9dbb-9b2b20218538

At insertion points, we schedule style recalcs for inserted nodes when we
have a StyleRecalcChange at the insertion point's parent. One of the reasons
is that :host-context selectors which affect inserted nodes may rely on
matching nodes which are not ascendants of the inserted nodes in the dom
used for selector matching.

We did use a LocalStyleChange for the inserted nodes, but these selectors
may affect any node in the inserted node's subtree. Hence, we start using
SubtreeStyleChange instead.

R=esprehn@chromium.org,dglazkov@chromium.org
BUG=381020

Review URL: https://codereview.chromium.org/317953002

git-svn-id: svn://svn.chromium.org/blink/trunk@175636 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/315293003

git-svn-id: svn://svn.chromium.org/blink/trunk@175635 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change introduces a UI that appears when the last roll
is getting old. The UI is not shown by default to avoid
visual clutter and its visual attribute matches the urgency
(currently 2 levels: warning / urgent).

Review URL: https://codereview.chromium.org/316033002

git-svn-id: svn://svn.chromium.org/blink/trunk@175634 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It doesn't need to get host echoed back. Just use the simple echo
handler.

Some unnecessary div elements are removed.

BUG=none

Review URL: https://codereview.chromium.org/317113002

git-svn-id: svn://svn.chromium.org/blink/trunk@175633 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Simplify CSSSelector::isAttributeSelector() by not checking each Match type
explicitly and reordering the Match enum instead so that the attribute
selector match type are contiguous and at the end of the enum. This way, the
check can become (m_match >= FirstAttributeSelectorMatch).

This optimization is similar to the one we already use in CollectionType.h
for collection types. isAttributeSelector() is called from
SelectorChecker::checkOne() which is hot code.

I see a ~2% progression on Dromaeo's cssquery-jquery:
http://dromaeo.com/?id=222514,222518

Review URL: https://codereview.chromium.org/315043005

git-svn-id: svn://svn.chromium.org/blink/trunk@175632 bbb929c8-8fbe-4397-9dbb-9b2b20218538