- 03 Feb, 2020 22 commits
-
-
Joshua Bell authored
The external/wpt/IndexedDB/parallel-cursors-upgrade.html test exercises 10k cursors in parallel, which an implementation should support. The test was historically flaky, although it hasn't timed out on the bots lately. But it is still slow - requiring multiple seconds on many platforms, and 20-40 seconds on debug builds. Drop the maximum number of parallel cursors to stop being such a drain on the commons. Local tests: the time for --iterations=40 dropped from 23s to 5s. Bug: 869364 Change-Id: I5a0b9de3b37650917e40cc0c34e7473a3870b21f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033814 Auto-Submit: Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#737669}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c4f7c3fc916..250c550f9220 Created with: gclient setdep -r src-internal@250c550f9220 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib8ffa66e73e1d9c480b3d2a218704eb0b22c4e9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035081Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737668}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7b296d06. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I87946b074f272535440b3f6327b8c3d60dbf1bd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033728Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737667}
-
Hirokazu Honda authored
Bug: 1044452 Test: compile image_processor_test Change-Id: I474c94707f16ef44a495868a8ef8e380fbbb0a52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024391 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#737666}
-
Anqing Zhao authored
Following methods are extracted to remove duplicated code. - ShowNotificationsIfNeeded - MaybeLaunchSettings Bug: 977489 Change-Id: I072d8bf31d2eddf808657f07b2eabc302072cece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033248 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#737665}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ib30f6c346e840f1d2d8aee244fe482b2a1659f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034050Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737664}
-
Jay Harris authored
Note: There seems to be a problem with how origin trials interact with the content security policy in system web apps (the origin trial API is not visible to {Exec,Eval}Js), so the file handling tests were updated to use ExecuteScript instead of EvalJs. Bug: 1028448 Change-Id: I6444b309d19c4a2fbde7537c5587acdda9ec8d65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016985Reviewed-by:Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#737663}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: Ie4597e5bbaf5b4bb9042ae6bf091b6069a78e33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033727Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737662}
-
Hirokazu Honda authored
This add libgav1 [1] in chromium third_party. The plan is to use OBU parser for AV1 HW decoder in chromium. That said, the sw decoder is not used in chromium immediately after this CL. [1] https://chromium.googlesource.com/codecs/libgav1/ Bug: 1000988, b:142835450 Test: compile chrome Change-Id: I14e42ca0108f96f5931adb7bcad93a1df735f437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880887 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#737661}
-
Hirokazu Honda authored
EncodedDataHelper should return scoped_refptr<DecoderBuffer> rather than std::string as this is the input format required by VideoDecoder::Decode(). Bug: 1044816 Test: video.DecodeAccel.* on eve Change-Id: Iac47f4e710954efa1dbb7f8d48cdd56bc0f9c963 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032543 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
-
Kent Tamura authored
Rename |internals| to |i| to avoid lint errors. This is a preparation to ship the feature. Bug: 1012098 Change-Id: I789f44c072b57f05e1ec8ddfbf0855872e144996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032632Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#737659}
-
Joe DeBlasio authored
This CL enables printing of a console message on all mixed content downloads. Previously, the message was only printed when the flag was enabled. Now that this plan is approved for launch, M-81 needs this message full time. Part of go/mixed-content-downloads Bug: 960819 Change-Id: I2fddee3c26c77a7a8eb4f680a0f16e13d5f9abdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033438 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#737658}
-
Anqing Zhao authored
Following methods are extracted to remove duplicated code. - InitializePrimaryProfileServices - NotifyUserProfileLoaded - StartTetherServiceIfPossible Bug: 977489 Change-Id: Iad19b0e23f3d9e11273468890a5d21a2168ff2e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030959 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 47c98e94. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I4f025fdfdc88911465e8d161c15c99594a899d77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033726Reviewed-by:
-
jessing authored
Currently chrome:// URLs are not allowed to embed chrome-untrusted:// URLs because we never grant request access to chrome-untrusted:// URLs. To allow for this, this CL makes a couple of changes (Note that this is only fixes the issue on the browser side. The renderer still has some checks that stop us from loading chrome-untrusted:// iframes.): 1. Make the set of requestable schemes part of content::WebUI. This way clients of WebUI can control which additional schemes they want their WebUI to be able to request. The function to add a scheme is added as a webUI API because it is expected to be used by chrome/ WebUIControllers that use chrome-untrusted://. 2. When creating a WebUI in RenderFrameHostImpl::CreateWebUI(), grant request access to the schemes the WebUI specified. 3. Decouple granting access to chrome:// and file:// from ChildProcessSecurityPolicy::GrantWebUIBindings(). Instead add this to the list of schemes in content::WebUIImpl. Long term, we should be able to remove these schemes from content::WebUIImpl and instead have each client specify the schemes they want access to, similarly to how clients will call EnableMojoJsBindings()[1]. [1] https://cs.chromium.org/chromium/src/content/browser/process_internals/process_internals_ui.cc?l=53&rcl=0ab24b983b19f971f40b2f1e3f5a5b95c7a1ad9a Bug: 1043548 Change-Id: I71d31f86e7c21da253df4f32634d945b45d071cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2009589 Commit-Queue: Jessica Huang <jessing@google.com> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#737655}
-
Rachel Sugrono authored
The delete key or the alt+backspace key (which maps to delete) should delete the currently selected entry. Bug: 803259 Change-Id: Ia3943893d256150a2b1bff7a4f6c4a718039bdcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026555 Commit-Queue: Rachel Sugrono <rsugrono@google.com> Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#737654}
-
David Black authored
Assistant UI modes kMainUi, kMiniUi, and kWebUi were used exclusively for standalone Assistant UI and can now be removed. Bug: b:148080975 Change-Id: Ia9592f208684e7f527463db30fda44eed0bcc95d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033701 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#737653}
-
Kent Tamura authored
When UpdateFromElement() is called, textContent of the shadow element should be updated as well as the text in the anonymous block. Exceptions: * In DidStyleRecalc() and AttachLayoutTree(), we must not update DOM at all. * Instead, we should update the textContent - when the UA shadow tree is created, or - even if the SELECT has no LayoutObject This CL has no user-visible behavior changes because the shadow element has display:none. Bug: 1040828 Change-Id: I55f0bfd0399ca50a8aa99c64a8fdf89ef5c42e68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032656Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#737652}
-
Anand K. Mistry authored
This allows TempFileManager to be removed from SmbService and simplifies setup. Bug: 939235 Change-Id: I5baed5d85318b67acc0d0c7e1e6600f2a039e582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030926 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Cr-Commit-Position: refs/heads/master@{#737651}
-
Chris Blume authored
There was previously a .IsHDR() but no .IsWide(). This CL adds a .IsWide() function and updates a unit test that wanted to use it. Bug: 955158 Change-Id: I11cee5888a653acb337d2bb78ffbf316fd39c660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033003 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#737650}
-
David Black authored
Removes logic pertaining to standalone Assistant UI. Bug: b:148080975, b:141947227 Change-Id: I276c3270cf28c0639230067cea08a101c90fce78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033666 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/72ac56b34ac5..9c4f7c3fc916 Created with: gclient setdep -r src-internal@9c4f7c3fc916 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9dd8315411910fb2d7277d3a7fc473df01be85c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034626Reviewed-by:
-
- 02 Feb, 2020 18 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/488c2e0a7abc..72ac56b34ac5 Created with: gclient setdep -r src-internal@72ac56b34ac5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ic6746e03a481c0f6f97e47acc200d9c5184cd648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034624Reviewed-by:
-
Kenichi Ishibashi authored
To investigate crashes which started happening again. Bug: 1045818 Change-Id: I2e8aa5f70bd285576dd354a734b924570eaf3f3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029390Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#737646}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b37c2a7ea95e..488c2e0a7abc Created with: gclient setdep -r src-internal@488c2e0a7abc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I140f3bc3daabab3098749ad0ee78b3a218cac0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034623Reviewed-by:
-
Anqing Zhao authored
Consider that the crash collection in local device doesn't promise the reports are uploaded in a specific duration, we have to add a new field into proto to let DM server know the upload status. The corresponding detailed crash reports cannot be found in crash servers if their status are not 'uploaded'. Bug: 1040078 Change-Id: I36ba510bc7ddffa840539eee096d320e7bd5aec2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020766 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#737644}
-
Anqing Zhao authored
Considering UserSessionManager::InitializeChildUserServices has already provided right implementation, it can be shared by ChromeSessionManager to avoid duplicated code. Bug: 977489 Change-Id: If12697b0454d02e093fef6f903454d26cbbba557 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032113 Commit-Queue: Anqing Zhao <anqing@google.com> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/de80ff6e5cf0..b37c2a7ea95e Created with: gclient setdep -r src-internal@b37c2a7ea95e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6584f4b48c8704123f4e258eb95fa91142061ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034617Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: I605c7ab93cbe793fe1da5f1ce04ec6b622442d2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034893Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b242cac6..2b9bdb1d Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Id60349635ea2082e6244f510a0e8af00f46cf490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033725Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737640}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/79b9bdba83ee..de80ff6e5cf0 Created with: gclient setdep -r src-internal@de80ff6e5cf0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I9ae9294d48796eae7e8f7112d4370cad0706ffc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034616Reviewed-by:
-
Maks Orlovich authored
More precisely, re-set it to the value wanted by the client rather than value we use internally, when giving up on caching due to no-store. Bug: 902273, 700197, 984851 Change-Id: I28ac3155372df317d8e70cc86aaf6f067b33a9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1384904 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737638}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a4dcd39d..b242cac6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I5d695c042a5a2ae714df77618d938fc96e474b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034775Reviewed-by:
-
Monica Basta authored
As part of friendly settings, this CL implements changing |sync everything| from check box to radio button. The motivation behind this work is to clarify to users the difference between |Sync everything| checked and |Sync everything| unchecked but all single data types checked. Bug: 1035421 Change-Id: I3c4aa283c2166c92e93fb793ed4f14b28e08c8e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2011928Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#737636}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cca2964cef1e..f1e316ff39e7 git log cca2964cef1e..f1e316ff39e7 --date=short --first-parent --format='%ad %ae %s' 2020-02-02 bsalomon@google.com Make lines in texel_subset GM be at half pixel offsets Created with: gclient setdep -r src/third_party/skia@f1e316ff39e7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: If78aa71d8c3b5d27ce849d7cb3a6d014205acf7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034830Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737635}
-
Liquan (Max) Gu authored
Before change: * With Expandable PH UI enabled, if merchant pages call complete("fail"), the screen would be covered under scrim and Clank would crash on refresh. * With CCT PH UI enabled, if merchant pages call complete("fail"), it would open Error View after closing PH UI. After change: The Error View is no longer shown on complete("fail"). Changes: * remove Error View from Android Payment Request UI. * Tests * add a test to ensure http would be rejected for openWindow(url) * add a test to cover complete ("unknown"). Bug: 1044077, 1047237, 1042892, 1045474 Change-Id: I0123e163d4cd0a97d1536d5c4baefa0e646c50d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019922Reviewed-by:Ted Choc <tedchoc@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#737634}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cd07bf9b005e..79b9bdba83ee Created with: gclient setdep -r src-internal@79b9bdba83ee If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ie474fdbb55d4ac50455a2201719098af6d72ee4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034215Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1946a1a809c4..cd07bf9b005e Created with: gclient setdep -r src-internal@cd07bf9b005e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I0ade9dd807a9620ec119ba8af01549028a175915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034213Reviewed-by:
-
Alex Keng authored
This change reverts the light gray background color (#f3f3f3) added by [1] for hover state. The reason is that the select control could have a customized foreground/background color (ex chrome://flags has white text on blue background) and the fixed #f3f3f3 color could break the style. Note ideally we want to just remove the css rule for hover state, but for some reason the test fast/forms/select-popup/popup-menu-touch-operations.html would fail if the rule is removed [2], so instead we use background-color:initial for the hover state and created a bug [3] to track the follow up investigation. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1747855 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2032582/4 [3] https://bugs.chromium.org/p/chromium/issues/detail?id=1047991 Bug: 1046657 Change-Id: I39cbbb18c0541bae5f624707db6bc02a2fe469d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032582 Commit-Queue: Alex Keng <shihken@microsoft.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#737631}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a8c23031a62..1946a1a809c4 Created with: gclient setdep -r src-internal@1946a1a809c4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Id8d6360f54770ae4ce6752ce091c425111a8b0c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2034212Reviewed-by:
-
