- 18 Jun, 2019 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b9b4c88672fd..a07feb5445f0 Created with: gclient setdep -r src-internal@a07feb5445f0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I49871516b3c79a80404bbebd75a8347a77423c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663826Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669991}
-
Sam McNally authored
Change-Id: I00b15eff07ec1867bf2c2fa5bcf27c363ac076e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662982Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#669990}
-
Kouhei Ueno authored
Bug: 972960, 961674 Change-Id: Iff5c464dcc5227f211462f0e1b70c938fab452c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654370 Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#669989}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2935638a1b16..f1dd7a174af8 git log 2935638a1b16..f1dd7a174af8 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8c12f564113c..9283b2559c05 (14 commits) 2019-06-18 herb@google.com Remove all global mutexes 2019-06-18 mtklein@google.com enable SkVM JIT testing on x86-64 Linux bots 2019-06-18 mtklein@google.com centralize and force-inline unaligned_{load,store} 2019-06-17 csmartdalton@google.com Add a "preferredInternalSampleCount" cap 2019-06-17 reed@google.com add motion blur params to skottie2movie 2019-06-17 brianosman@google.com Add some precision back to timestamps when using --trace 2019-06-17 brianosman@google.com Shuffle SkSL sources around so compiler and bytecode can be used w/o GPU 2019-06-17 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). 2019-06-17 benjaminwagner@google.com Omit build number for LenovoYogaC630 os dimension Created with: gclient setdep -r src/third_party/skia@f1dd7a174af8 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:974542 TBR=bsalomon@google.com Change-Id: I9ddd27b313a8eb5fc3e590c8fa1e55891b883cbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663822Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669988}
-
Alan Cutter authored
This reverts commit 8fa57643. Reason for revert: Broke MSAN build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests/13546 AccessibilityFocusRingControllerTest.SetFocusRingCorrectRingGroup ==677==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x55ee18481b14 in ash::AccessibilityFocusRingGroup::UpdateFocusRingsFromInfo(ash::AccessibilityLayerDelegate*) Original change's description: > mash cleanup: Remove accessibility_focus_ring_controller.mojom > > Replace mojom with an abstract singleton controller, c++ struct & enums. > Update impl & tests, expose a protected static helper for simplicity. > Remove an unnecessary test subclass, unit test passes without this. > > Bug: 958129 > Test: Automated; no accessibility focus ring regressions. > Change-Id: I34acd91fa9e093309a89edf74e2395d5de5ec2c2 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660107 > Auto-Submit: Michael Wasserman <msw@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Michael Wasserman <msw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669869} TBR=sky@chromium.org,msw@chromium.org,tsepez@chromium.org Change-Id: I8a566ffc0cef5bd828c8be3ce1ce5dd1624d8b33 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662985Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#669987}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/f6c289da452c..0c9a952c8f7d git log f6c289da452c..0c9a952c8f7d --date=short --no-merges --format='%ad %ae %s' 2019-06-18 a-v-y@yandex-team.ru Fixed symbolize of win traces with breakpad syms performed on linux Created with: gclient setdep -r src/third_party/catapult@0c9a952c8f7d The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:797843 TBR=eyaich@google.com Change-Id: Idef6eb6f006a1c663062d63d342d9561092e9cac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663827Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/83ce6ba1..2edb1963 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic6c88c4611d2e6f62704f39fefb75539e91818cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663041Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#669985}
-
Nicholas Hollingum authored
We originally created the wayland aux dir to store the tools used to interface with wayland, however later on we moved to Jinja which made it more convenient to keep the wayland tools closer to the source. This CL replicates the historic functionality of wayland_aux under the fuzzer/ directory and removes the old aux tools. Bug: 961564 Change-Id: I60394f66fb6399fd1e2bd3dfe2d6d051006f3409 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662091 Commit-Queue: Nic Hollingum <hollingum@google.com> Reviewed-by:
Nic Hollingum <hollingum@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#669984}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/9db72785beb3..d579c0a7d45a git log 9db72785beb3..d579c0a7d45a --date=short --no-merges --format='%ad %ae %s' 2019-06-18 cepheus@frii.com Bump revision. Created with: gclient setdep -r src/third_party/glslang/src@d579c0a7d45a The AutoRoll server is located here: https://autoroll.skia.org/r/glslang-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,jonahr@google.com Change-Id: Ib9577bd05b682250467055f29b77b4af3abe95df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663821Reviewed-by:
-
Jérôme Lebel authored
Removing the deprecated API to open Account Settings Manager. Related to: crrev.com/c/1349969 (Adding new API in ChromeIdentityService) crrev.com/i/721689 (Implementation in ChromeIdentityServiceImpl) crrev.com/c/1350630 (Switching to the new API) crrev.com/i/721693 (Removing old implementation in ChromeIdentityServiceImpl) Bug: 905680 Change-Id: Id3d95331035290a80f32fd139c499430e53243c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1350185 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#669982}
-
Joel Einbinder authored
select elements were incorrectly relying on chromeSelect.svg, which doesn't exist yet. Simimlarly, code folding was relying on the png version of treeoutline triangles. Change-Id: Id2f27a1800a5070e5eaa607260328f14cb06c582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663322Reviewed-by:
Erik Luo <luoe@chromium.org> Commit-Queue: Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#669981}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c211c2f5b59d..b1c8dbf3fad8 git log c211c2f5b59d..b1c8dbf3fad8 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 syoussefi@chromium.org Vulkan: Correct synchronization for buffer readback Created with: gclient setdep -r src/third_party/angle@b1c8dbf3fad8 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I5a5bb3ab00d4c069894ad4315a3a624a3be2ed30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663820Reviewed-by:
-
Gayane Petrosyan authored
This CL also adds add placeholder for the text. example: https://screenshot.googleplex.com/6V9VX9WBywe.png https://screenshot.googleplex.com/U1MUKZJcFeO.png Bug: 960982 Change-Id: I88b5f6410590219282952593c1ba5060d67dc972 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662637Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#669979}
-
Nikita Podguzov authored
Bug: 848942 Change-Id: Ibfb613229cc004c64d98ccf58d37c34d566a0be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662453Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Cr-Commit-Position: refs/heads/master@{#669978}
-
Antonio Gomes authored
... as it is not specific to webrtc. BUG=577874,704136 R=guidou@chromium.org, haraken@chromium.org Change-Id: I4357d66c198acb2911a6ea3ec1e65bb443ca23c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661609 Auto-Submit: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#669977}
-
Alex Danilo authored
This CL implements a summary panel that shows progress of any progress panel items being hosted by the display panel. The display panel can host any number of child panel items, so the summary panel shows the number of hosted panel items, and the average progress of them in it's summary progress indicator. The summary panel is created and destroyed as a result of adding or removing progress panel items. This CL also adds a listener to allow the panel items to be hidden or expanded into view, and stores the parent display panel reference as 'parent' in each panel item when it's instantiated. Bug: 947388 Change-Id: I90105415d5171063a970631d7f9208564a12a47f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657081Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#669976}
-
Khushal authored
This reverts commit bf62d746. Reason for revert: Failing build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-rel/13861 Original change's description: > [ChromeDriver] Element Send Keys: support content editable; fix text input type > > The email input type being considered a text input caused bugs and crashes. > In this commit it is removed from textControlTypes and thus no longer > considered a text input. > > Also added support for content editable > elements in compliance with the following W3C procedure: > "Set the text insertion caret after any child content." > Added test to run_py_test to test correct functionality. > > R=crouleau@chromium.org, johnchen@chromium.org > > Bug: chromedriver:2704 > Change-Id: I95bb9ff2396aa0e6bdfa35dde33f338be83607b7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658966 > Commit-Queue: Julian Kung <juliankung@google.com> > Reviewed-by: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669828} TBR=crouleau@chromium.org,johnchen@chromium.org,juliankung@google.com Change-Id: I170529bb765a3a7f8c2c2290ac9fcf2052199077 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromedriver:2704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663207Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#669975}
-
Christopher Cameron authored
Serialization of blink::WebInputEvent failed to take into account needs_wheel_event. It also appears to drop a bunch of other information on the floor as well. There is a comment in web_gesture_event.h that // Note that for the pinch event types, |needs_wheel_event| and // |zoom_disabled| are browser side implementation details for // touchpad pinch zoom. From the renderer's perspective, both // are always false. Implementing this renderer assumption by not faithfully serializing the events seems inappropriate. Bug: 957334 Change-Id: I4095bc4d4cff9dedf752fc0a09b391f5aa4ed72f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657079Reviewed-by:Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#669974}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/99a2bf5facef..b9b4c88672fd Created with: gclient setdep -r src-internal@b9b4c88672fd The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I77a613bc7d669d3375dc4496681b85b3a41049a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663873Reviewed-by:
-
Christopher Cameron authored
A number of bugs have come out of the fact that content::NativeWebKeyboardEvent appears to provide a mechanism to pass an NSEvent across processes via NSEvent -> content::NativeWebKeyboardEvent -> (mojo) -> content::NativeWebKeyboardEvent -> NSEvent In practice, the NSEvent reconstructed after the content::NativeWebKeyboardEvent was passed over mojo is not even remotely accurate. Add helper functions to serialize NSEvents using the OS-provided CGEventCreateData and CGEventCreateFromData functions. When passing a content::NativeWebKeyboardEvent over mojo, pass the serialization alongside it, and replace the result's os_event. Use this approach instead of updating the mojo serialization for content::NativeWebKeyboardEvent because we don't want to be calling CGEventCreateFromData on data sent from the renderer process. Remove the accumulated workarounds for these issues. R=dominickn TBR=avi (content/ OWNERship) Bug: 919167, 943197, 964052, 942690 Change-Id: Ie7321229daf34629ddc9037ab733b40828bc62c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1659662 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:ccameron <ccameron@chromium.org> Reviewed-by:
-
Christopher Lam authored
This CL adds code to migrate the Settings internal app's app list and launcher positions to the Settings System Web App. TBR=jamescook@chromium.org Bug: 836128 Change-Id: I5be900672689c80dd243bd5d30699c1039a13d94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1644881Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#669971}
-
Alan Cutter authored
This CL makes AppBannerManagerDesktop listen for web app installs to determine whether to fire the appinstalled event to the renderer. Previously it depended on every install UI flow to call OnInstall because we didn't have this event to listen to internally. Bug: 956810 Change-Id: If78c86c8c407a8777f59236685c388276ef0f724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1657083 Commit-Queue: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
-
Dominic Farolino authored
cache When a blink::Resource is put into the preload cache by a link preload request, its `link_preload_` member is set to true. Before this CL, when a blink::Resource in the preload cache is matched with a request that itself is not a link preload, we reset the `link_preload_` member to false, obscuring the fact that the Resource was served from the preload cache to the consumer. After this CL, we stop resetting this member, so that when a non-link-preload request is matched with a blink::Resource from the preload cache, it can determine whether it was originally a preloaded resource or not. This is a preparation CL for implementing Preload + SRI to work with each other. The reason that a non-link-preload benefits from knowing whether it was served from the preload cache can be found here [1]. [1]: https://docs.google.com/document/d/1l8y_T3z-nb0smR9EVoZ3TeEI6rGzLw74vvzWzODsnDQ/edit#heading=h.rocm6cm98uhw R=kouhei@chromium.org, yhirano@chromium.org Bug: 677022 Change-Id: I890ee44cdd650b8459e5220f10a48d1d1192210b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661314 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#669969}
-
Koji Ishii authored
This patch fixes a DCHECK failure when table cell width calculation quirk logic[1] found an out-of-flow image. The logic was in |BreakLine| because it may need to change |can_break_after| of the last item. By calling |HandleAtomicInline| in trailing item phase, the logic can be moved to |HandleAtomicInline|. With this change, |HandleAtomicInline| may choose to break before the item, similar to |HandleText|. [1] https://quirks.spec.whatwg.org/#the-table-cell-width-calculation-quirk Bug: 968317 Change-Id: Ib4a71ca62107d2601449ba589bb2771b378ab38b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660296Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#669968}
-
Wei Lee authored
This CL enables DMA-buf encoding on V4L2 JEA to optimize the performance and reduce the CPU consumption. Bug: 944705, b/130850474, b/123057922 Test: Manually Test: ./jpeg_encode_accelerator_unittest Change-Id: Ic6a9929014db5422bfc07c832dc9b402a8a465d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1534592Reviewed-by:
Ricky Liang <jcliang@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#669967}
-
Shik Chen authored
Quote form the presubmit checks of std::to_string [1]: > std::to_string is locale dependent and slower than alternatives. For > locale-independent strings, e.g. writing numbers to and from disk > profiles, use base::NumberToString(). For user-visible strings, use > base::FormatNumber() and the related functions in > base/i18n/number_formatting.h. [1] https://cs.chromium.org/chromium/src/PRESUBMIT.py?l=719&rcl=fdd20c8546766e53c8369523080e79b9e60cac7b Bug: None Test: Passes capture_unittests. Change-Id: Iaad9cfdedd5efb55c0a2f411ca505be127dedffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660389Reviewed-by:
Wei Lee <wtlee@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#669966}
-
Darwin Huang authored
This reverts commit 76c3585f. Reason for revert: The clang roll is causing a lot of test failures from interactions with Skia, and causing reduced test coverage/red bots. Original change's description: > Roll clang 362913:363450. > > Ran `tools/clang/scripts/upload_revision.py 49b965079b18f8aa485dd1156dd088d40b7ee465`. > > TBR=hans > > Bug: 974267 > Change-Id: If292a3e2317da54558f02275a84aefead03aad9d > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660964 > Commit-Queue: Nico Weber <thakis@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#669515} TBR=thakis@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 974542 Change-Id: I0feae2b830dfada03388d77f366934825497516a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663740Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#669965}
-
David Staessens authored
The VideoFrameFileWriter can be used in tests to dump decoded frames to disk in various formats. CL crrev.com/c/1573311 introduced a small bug breaking the VideoFrameFileWriter, which this CL fixes. TEST=ran VDA tests on eve BUG=None Change-Id: I116cd683f9f5b0777160009343b0826fc141dcea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663772Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#669964}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1d05fadfb4fa..99a2bf5facef Created with: gclient setdep -r src-internal@99a2bf5facef The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=huangdarwin@google.com,sdy@google.com,alancutter@google.com,tschumann@google.com Change-Id: I91f4899ccc669aa1da72fe7f3c39a3dadf4896ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663584Reviewed-by:
-
Chih-Hsuan Kuo authored
BUG: internal b/135083912 TEST: Make a Duo call on Nest Hub Change-Id: I57ea17e68fcfc185f417dbb837379b5465353b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1654740 Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Cr-Commit-Position: refs/heads/master@{#669962}
-
Sam McNally authored
FUSE doesn't cope well with attempting to freeze while an operation is in flight. Avoid this by unmounting on suspend and remounting after resuming. Bug: b:134792837 Change-Id: I4fa836b33f8a5b486e458f10228ae111d9dd1d32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662208 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
-
Miyoung Shin authored
This CL replaces the use of std::vector of std containers with Blink::WebVector in security_context.h and related codes. Bug: 952716 Change-Id: I82ee19f4ea79ea81dd7f187a8cd618c89945dc50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661323Reviewed-by:
-
Miyoung Shin authored
This CL replaces the use of std::vector with WTF::Vector and access a blink:WebVector member of struct directly in third_party/blink/renderer/core/frame/csp/. Bug: 952716 Change-Id: Ia94053b4f29b2637ef8a4a6fcac09306a96f05f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661326Reviewed-by:
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/79b2847f611f..f0f9a8f1fd94 git log 79b2847f611f..f0f9a8f1fd94 --date=short --no-merges --format='%ad %ae %s' 2019-06-18 chinsenj@google.com Split PDF_DataDecode() in two 2019-06-17 tsepez@chromium.org Remove CFX_FontMgr::InitFTLibrary. 2019-06-17 thestig@chromium.org Roll third_party/libjpeg_turbo/ 2a34770be..e1669e370 (3 commits) 2019-06-17 thestig@chromium.org Simplify font code. 2019-06-17 tsepez@chromium.org Introduce enum CFX_FontMapper::StandardFont. 2019-06-17 tsepez@chromium.org Speculative follow-up for bug_974091. 2019-06-17 tsepez@chromium.org Remove unimplemented CFX_FontMgr::ReleaseFace(). Created with: gclient setdep -r src/third_party/pdfium@f0f9a8f1fd94 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:922430,chromium:974091 TBR=pdfium-deps-rolls@chromium.org Change-Id: I0d2299f2f36d81551ed3a2e81689923b6fe2bc66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663583Reviewed-by:
-
Lei Zhang authored
Enums in Mojo have |kMaxValue| automatically defined. Switch PdfCompositor UMAs to use the 2-parameter UMA_HISTOGRAM_ENUMERATION macro, which uses |kMaxValue|, and avoid the need for static_casts with the 3-parameter UMA_HISTOGRAM_ENUMERATION variant. Along the way, switch the PdfCompositor enum to kFoo style, and fix a typo to stop referring to composting. BUG=742517 Change-Id: Id9664371d3b2d7b0fe1203069d96c37b3e4b41de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1661490Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#669957}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3f8975e121c5..c211c2f5b59d git log 3f8975e121c5..c211c2f5b59d --date=short --no-merges --format='%ad %ae %s' 2019-06-17 clemendeng@google.com Make proc table autogen use gl.xml data Created with: gclient setdep -r src/third_party/angle@c211c2f5b59d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jonahr@google.com Change-Id: I246104397b81e9be519f2f3e70f1966959eddc5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663044Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=kariah@chromium.org Change-Id: Ic19b7821cc8db661dfd576dc5032277e87faf919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663832Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#669955}
-
Ian Kilpatrick authored
We had a few issues related to quirky body elements. We were stretching the body when it was OOF-positioned, float, or an atomic inline when we weren't supposed to. Bug: 967215 Change-Id: I640b1a2f6c2ab30d071e04c245a34dd1e30b19fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662839Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#669954}
-
Takuto Ikuta authored
xenial bots are added in https://chrome-internal-review.googlesource.com/c/infradata/config/+/1397331 Bug: 954450 Change-Id: Ia283aed3263b9d15b8cf1881fb811c117e191a97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1662250Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#669953}
-
Kyle Milka authored
Bug: 975412 Change-Id: I399fd91b8f5cb0e7bb8822bcf0a1869ffafdc512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1663309Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#669952}
-
