- 28 Oct, 2019 40 commits
-
-
Reilly Grant authored
This change adds special handling for read and write errors for which recovery is impossible (i.e. disconnection). In this case the readable and writeable attribute are not initialized with new streams on demand. Bug: 1013763 Change-Id: Ibd03cb684cb34cf9a8b22848f7b9ebc50f4d6621 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884357Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#710088}
-
Charlene Yan authored
The fixed insets makes it crash on the DCHECK with certain sizes. Updating this to be managed by layout manager fixes this issue while developing and fiddling with the final sizes. The insets might need to be updated later on for the first and last elements. Bug: 1015634 Change-Id: I947c1e6b01013fd353602e8e96739a21b5f4e7b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884351 Commit-Queue: Charlene Yan <cyan@chromium.org> Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#710087}
-
DongJun Kim authored
Currently, PasswordManagerClient and PasswordManagerClientHelperDelegate defined a GetPasswordManager(). In case of ChromePMC and IOSChromePMC also both inherit above classes, so they need to define the override each GetPasswordManager(). This patch merge PasswordManagerClientHelperDelegate into PasswordManagerClient for removing unnecessary functions. Bug: 777861 Change-Id: I7c912408bd9704c5a8abbca4c205f89c46ff6cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880781 Commit-Queue: DongJun Kim <djmix.kim@samsung.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#710086}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/d039ea0c1799..28ef213de9e5 git log d039ea0c1799..28ef213de9e5 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 samans@chromium.org Allow filtering flow events 2019-10-28 perezju@chromium.org [Telemetry] Remove telemetry.value.summary 2019-10-28 khokhlov@google.com [Telemetry] New intermediate file format Created with: gclient setdep -r src/third_party/catapult@28ef213de9e5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:992427,chromium:981349 Change-Id: I0777cc08826bfb2407fb97e92b198806ec70314e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884442Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710085}
-
Roberto Carrillo authored
This is a builder that will build instrumented versions of chromium gtests on Mac, run them on Mac 10.13 no-gpu bots and upload code coverage reports to the coverage dashboard. Later changes will include non-gtest tests and tweak sharding parameters for this configuration. R=sajjadm,nodir,liaoyuke Bug: 1017486 Change-Id: Ie2168653ede5e37498ac9cf62e54a29883173b1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877604Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#710084}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a1991f5e3b58..620154a7dc5c git log a1991f5e3b58..620154a7dc5c --date=short --no-merges --format='%ad %ae %s' 2019-10-28 bsalomon@google.com Make GrFillInData use SkRasterPipeline 2019-10-28 egdaniel@google.com Reland "Revert "Rename gl_SampleMask to sk_SampleMask"" 2019-10-28 michaelludwig@google.com Reland "Add variety of bulk API benchmarks" 2019-10-28 ethannicholas@google.com Revert "Revert "Rename gl_SampleMask to sk_SampleMask"" 2019-10-28 bsalomon@google.com Remove legacy async read pixels APIs. Created with: gclient setdep -r src/third_party/skia@620154a7dc5c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jcgregorio@google.com Bug: None Change-Id: If5063597acc7f0ab8fe28bc32590a0f9d47d114b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884441Reviewed-by:
-
Peter Kotwicz authored
BUG=None Change-Id: I3acd459cddc8bfdeae25b0f6fa9c99e431fa7f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884516Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710082}
-
Andrew Grieve authored
Java is required to run "bundletool", which our test runners currently use to deploy Android App Bundles. TBR=jbudorick Bug: 1018706 Change-Id: I5dd75bbe35431e1fd8dd1de32ad4e7ed66ce3d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884760Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#710081}
-
James Vecore authored
Bug: 1007361 Change-Id: Ie4a54f11775559638e28b56dd251eb1dd1558848 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879868Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#710080}
-
Oksana Zhuravlova authored
This change converts DateTimeChooser mojom interface client in blink to use BrowserInterfaceBroker. Since DateTimeChooserAndroid is a WebContentsObserver, a static helper function is used to register its binder. Bug: 936482,1006361 Change-Id: I3742b3c1c0ab2812308a9956ee69691b35c6848b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863853Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#710079}
-
Takashi Toyoshima authored
Tests are already running on Android WebView P OOR-CORS FYI (rel) and linux-oor-cors-rel fyi bots. But this testing flag flip is also the best practices that is good to follow. Bug: 905971, 1001450 Change-Id: I75ccebb1466be8b516f96774ceabb377951d3160 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1882770 Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#710078}
-
Connie Wan authored
Opening from an external link (target=_blank or window.open) eagerly creates a group, similar to ctrl+click on a regular link. Opening with ctrl+forward/back does not eagerly create a group, but it adds the new tab to the same group as the source tab. Bug: 1013532, 1013537 Change-Id: I5823f572f9727c810a67333091cc294df5ec65e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879762 Commit-Queue: Connie Wan <connily@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710077}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/27eb01c35517..4ba192e7a9c8 git log 27eb01c35517..4ba192e7a9c8 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 ehmaldonado@chromium.org Reland "gerrit_util: Refactor ReadHttpResponse and add more tests." Created with: gclient setdep -r src/third_party/depot_tools@4ba192e7a9c8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:1016601 Change-Id: I31921ad18ed7dc1924ecc31439872ffe75c2f80f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884443Reviewed-by:
-
Garrett Beaty authored
This reverts commit d52f1ff6. Reason for revert: Goma builders broke Original change's description: > Move goma builders to their own bucket. > > Change-Id: I35ca4a7fe3a7a446c71be80ca9e029a382036ba5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867391 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Aaron Gable <agable@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710021} TBR=agable@chromium.org,jbudorick@chromium.org,gbeaty@chromium.org Change-Id: I6422916eebc3bcf82723624501f687ac47d290b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884582 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#710075}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Iebe500d5e8ca864a8ac8c8a693a23b30e7509dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884526Reviewed-by:
-
Gil Dekel authored
Currently, all VA-API related unit tests are executed via chromeos_camera's jpeg_decode_accelerator_unittest test binary. This CL adds a test target for VA-API unit tests to set the ground for the separation of VA-API related unit tests from chromeos_camera. I am also using this opportunity to remove code duplication that exists in vaapi_*_decoder_unittest.cc by introducing vaapi_image_decoter_test_common.*. However this change is not crucial for the separation mentioned above. Bug: 986074 Test: Run and passes locally on an Eve board. Change-Id: I17a27ad7f57b22dd7704293b798531d38fc72bf8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881631 Commit-Queue: Gil Dekel <gildekel@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Cr-Commit-Position: refs/heads/master@{#710073}
-
Tom Anderson authored
If XGetWindowAttributes() fails in X11SoftwareBitmapPresenter(), |shm_pool_| will never be constructed. However, we assumed in several places that |shm_pool_| was non-null, which can cause a crash. For example ~X11SoftwareBitmapPresenter() calls shm_pool_->Teardown() without a check. This CL adds null checks in the appropriate places. BUG=1015124 R=rjkroege Change-Id: I19eabf89961632f5573a4f0020748012aa0d6c8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879502 Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#710072}
-
evliu authored
Bug: 997813 Change-Id: I88dfa13db52d2968f846d72015e99c84e9808c01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815543 Commit-Queue: Evan Liu <evliu@google.com> Auto-Submit: Evan Liu <evliu@google.com> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#710071}
-
Carlos IL authored
Android Webview Safe Browsing interstitials will require the same logic desktop and android use for showing interstitials triggered by a bad subresource. This CL moves that logic to //components. Bug: 1016581 Change-Id: Ia1f5fd52cdff3c7bf7ea7d38b6329b8adf316718 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884811 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Auto-Submit: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#710070}
-
Alex Cooper authored
While the runtime is stopping if the current sensor presence state is anything other than "NotPresent", a visibility state change event comes in. This event gets unsubscribed in StopRuntime, but it's possible that the change comes in before the render loop knows that it needs to tear down the runtime, so simply unsubscribing earlier is insufficient to fix this. The fix is to just simply check whether or not holographic_space_ is valid before running the rest of the logic. Fixed: 1018822 Change-Id: I05298c6f20419cbad30cda3107924d0e207aaa2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884288 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#710069}
-
Chris Mumford authored
The "initialization done" callbacks for both media::remoting::StreamProvider and media::remoting::MediaStream both used implicitly repeating closures, but only ever ran the callbacks once. Switching to base::OnceClosure. Bug: 1007810 Change-Id: I9431a6cca138e3e095b98d625bc94fcf97f7ce19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881985Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#710068}
-
Chris Mumford authored
This change switches from using testing::CreateFunctor when calling testing::Invoke() to a C++ lambda. This improves test readibility and makes easier an upcoming changes to gmock_mutant.h (switch away from base::Bind()). Bug: 1007833, 806952 Change-Id: I267d0681e833a36c245a4529a2a7c0faef6f9693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874485 Commit-Queue: Chris Mumford <cmumford@google.com> Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Cr-Commit-Position: refs/heads/master@{#710067}
-
Mikel Astiz authored
LoopbackServer doesn't need to deal with strings in its API, since it deals with protos. It can be trivially refactored without behavioral changes (relevant for local sync, i.e. enterprise). This allows various simplifications in FakeServer. Bug: None Change-Id: Iffebffae9af844d27df53fe46a6b5f61c4016ce7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883516 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#710066}
-
Etienne Bergeron authored
The font fallback is returning a specific typeface. The specific typeface should be used when available to avoid a font family match (which may leads to a different font being used). As an example, on Fuchsia the script Bengali is using the 'Mukti Narrow' which is not getting match correctly. That makes the script being broken. We are not seeing a regression since the expensive fallbacks algorithm is catching the broken cases. see: https://chromium-review.googlesource.com/c/chromium/src/+/1824104 http://crbug.com/1003829 Bug: 1008407, 1018321 Change-Id: I668382707e24ecc267a82531ad2a77c23283b2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884657Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710065}
-
Manas Verma authored
On the settings page, if user opts-in, then opts-out through the toggle switch, the browser crashes because a non-existing dialog is being attempted to close. Bug: 949269 Change-Id: I10d50695db65976799510960ae3230b355b3f698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884829 Commit-Queue: Manas Verma <manasverma@google.com> Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#710064}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4f3e0042. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: Id9c81fd050db3919f9a6a9392d684422a790a921 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884481Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710063}
-
chrome://tab-stripdpapad authored
Fixed: 1015632 Change-Id: I657fb15a63132ce53e2f64e7e4a5b2d1c1302074 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881808 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#710062}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/70770accb3e4..77b752951550 git log 70770accb3e4..77b752951550 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 sprang@webrtc.org Reland "Use RtpSenderEgress directly instead of via RTPSender" 2019-10-28 ivoc@webrtc.org Apply bitrate boosting depending on field-trial. 2019-10-28 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d68d92fb..9109135d (709806:709913) Created with: gclient setdep -r src/third_party/webrtc@77b752951550 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ia4337f9562c415711f2ad0f3ec63b790594bc8f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884514Reviewed-by:
-
Ted Choc authored
This aims to determine if the search engine is null or some actual value. BUG=944767 Change-Id: I7145903f77c0722fe1846f4b17a0ea9ea36f3a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881969Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#710060}
-
Xiyuan Xia authored
Fix a regression that sends primary user session too early, which breaks the assumption for callers of IsActiveUserSessionStarted and causes SessionObserver::OnActiveUserPrefServiceChanged not fired. Bug: 968825, 848230 Change-Id: I18b042a2ee5801b66e175897c0704d8dde989113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1660772Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#710059}
-
Daniel Rubery authored
The binary_upload_service_ pointer can sometimes hold uninitialized data, which leads to calling IsAuthorized() on an invalid object. In my case this was due to a turned-off feature flag. Change-Id: I1db50db3350c43f48b45b0b7a310ac83608147b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884994 Auto-Submit: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#710058}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=estade@chromium.org Bug: 1018887 Change-Id: I29b84b7807d2d1b87cea6db9967986ac3aba900a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884998 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#710057}
-
Martin Kreichgauer authored
This adds a use counter for calls to PublicKeyCredential.isUserVerifyingPlatformAuthenticatorAvailable(). The counter's name is prefixed with `kCredentialManager` for consistency with other WebAuthn related metrics. Fixed: 1018318 Change-Id: I2ba0e96a37405b7774259c09eb34c534ee43f640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880319 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Martin Kreichgauer <martinkr@google.com> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#710056}
-
Andrii Shyshkalov authored
R=vadimsh No-Try: True Change-Id: If4d921cc6ca9ca35128c0b4e44771bf8e0ed94b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885091 Commit-Queue: Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Vadim Shtayura <vadimsh@chromium.org> Auto-Submit: Andrii Shyshkalov <tandrii@google.com> Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710055}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=garykac@chromium.org Bug: 1018887 Change-Id: I4b920ec60b5a24237396d7cf14a47c8fcac7d786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884954 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#710054}
-
Robbie McElrath authored
This creates the lib build file, adds any missing dependencies, and moves a crashpad dependency that that was incorrectly placed in the old lib rule. Test: gn check out/aw 'android_webview/*' Bug: 934152 Change-Id: Ic9a03e5a8f105364f9c61e08b35a5889cabfea3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880070Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#710053}
-
John Rummell authored
When running unit_tests there is no system_network_context_manager available, so provisioning can't take place. If that is the case then don't attempt to provision an origin ID. Tested this with an Android emulator. Without this change 9 of the OptimizationGuideHintsManagerTest unit_tests failed, and all pass after this change applied. Bug: 1018052 Test: see above Change-Id: Ic3733014c00fc48d1b6860142f08daffcf3d8391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881950Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#710052}
-
Henrique Ferreiro authored
Convert the implementation and all users of the ui::ozone::mojom::DrmDevice interface. Bug: 955171 Change-Id: I330afef5a15856e9632ee441e95d255bd6d7b502 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862455 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
-
Sergio Collazos authored
This reverts commit 959cddb1. Reason for revert: The just enabled testKeyboardHideState test keeps failing: https://ci.chromium.org/p/chromium/builders/try/ios-simulator/403589 https://ci.chromium.org/p/chromium/builders/try/ios-simulator/403581 Original change's description: > [iOS][MF][EG2] Migrate keyboard observer test > > Remove deprecate test that would require new code to be migrated. > Update and enable keyboard disappear test. > Create app interface to interact with a shared instance of the observer > in the app. > Remove OCMock usage in the test. > > TBR=eugenebut@chromium.org > > Change-Id: Iaa5384f241e63b95ee516d4666b2e2adf65b7da6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881566 > Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Javier Ernesto Flores Robles <javierrobles@chromium.org> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709939} TBR=eugenebut@chromium.org,stkhapugin@chromium.org,javierrobles@chromium.org Change-Id: I40a1bfece2a1b3eb03aec11d58c1ab0496b420d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885252Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#710050}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=nharper@chromium.org Bug: 1018887 Change-Id: Id2d23759b383b43fea02bfba279ec96286da5eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884997 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#710049}
-
