- 07 Nov, 2018 40 commits
-
-
Gabriel Charette authored
This helps identify sections of a trace event that were blocked on external dependencies and shed some light on the "descheduled" portion of an event. This CL is non-trivial for 3 reasons: 1) This new TRACE_EVENT kicks off tracing earlier than before in some configurations. This means that main() of basic utilities all of a sudden needed AtExitManagers (first patch set of this CL). But that then spread out to many main()'s and was painful. Since the Singleton is only required in tracing to know whether it's enabled : this CL specializes Singleton/TraceEventETWExport to avoid instantiating the instance only to notice it's not enabled (guaranteed default state). 2) We do not want tracing events while a thread is idle (i.e. when it's sleeping on its own WaitableEvent/ConditionVariable while waiting for more tasks). Ideally we simply wouldn't record the trace event when it's not nested within another event but tracing doesn't have a notion of "current event depth". As such this CL opts for a declarative model where owners of the few WaitableEvents/ConditionVariables used to sleep-while-idle can flag those as irrelevant for tracing. 3) Possibility of reentrancy if the trace event macros perform a blocking call themselves. Added DCHECKs to confirm this doesn't occur (was initial suspected cause of CrOS+amd64 only failures but it kept failing despite that and this feature had to be disabled there..) Bonus: * Singleton::GetIfExists() avoids instantiating TraceEventETWExport when switches::kTraceExportEventsToETW isn't present. * The declarative model brought forth by (2) also enables not instantiating debug::ScopedEventWaitActivity objects while a thread is merely sleeping. This will avoid polluting crash metadata with wait-acitvity for sleeping threads. * In a follow-up CL we will be able to remove base::internal::ScopedClearBlockingObserverForTesting which was previously necessary specifically to avoid a situation in TaskScheduler unit tests where WaitableEvents used for the test logic would instantiate ScopedBlockingCalls and interfere with the very logic under test. (not done in this one as it's large enough on its own) Bug: 899897, 902514 Change-Id: I93b63e83ac6bd9e5e9d4e29a9b86c62c73738835 Reviewed-on: https://chromium-review.googlesource.com/c/1305891 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:danakj <danakj@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#605966}
-
Koji Ishii authored
When in quirks mode and there are no text siblings; e.g.: <div><img><span>text</span></div> and 'vertical-align: text-top' applied to <img> hits DCHECK failure and results in incorrect position. The test ensures that results are the same with the standard mode. Bug: 901123 Change-Id: I30564c66d5847f09caf3672ba3d456c0eb798d3e Reviewed-on: https://chromium-review.googlesource.com/c/1320529 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#605965}
-
tzik authored
This CL replaces all usage of v8::Isolate::GetEnteredContext in Blink with GetEnteredOrMicrotaskContext. GetEnteredOrMicrotaskContext should be the better fit here as the EnteredContext may be unrelated to the currently running script's context when it's in the microtask queue. chromium: 887920 Change-Id: I9da9777fb3b365fa181d2d9660c36a071734acf3 Reviewed-on: https://chromium-review.googlesource.com/c/1319220Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#605964}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/6d6e0a8009f2..52a091f41950 git log 6d6e0a8009f2..52a091f41950 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 jbudorick@chromium.org Add android_internal fetch spec. Created with: gclient setdep -r src/third_party/depot_tools@52a091f41950 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:856278 TBR=agable@chromium.org Change-Id: I2400a341ad58d48e71ed2d088d17e3aed5db282b Reviewed-on: https://chromium-review.googlesource.com/c/1321951Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605963}
-
Koji Ishii authored
Following bot results are included. 11477 11478 11487 11492 11495 11499 11504 11505 11513 11525 11531 11536 3 lines were removed and 1 lines were deflaked by consecutive results since 11477. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I6147002491e6cfd011b6b5a121625db5181fec6a Reviewed-on: https://chromium-review.googlesource.com/c/1318509 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#605962}
-
Ingvar Stepanyan authored
Switches custom string splitting to URLSearchParams, which both makes code simpler and fixes parsing of percent-encoded URL params. Change-Id: I839689382cf6b3a7f55be3b08e03f35c8f81c520 Reviewed-on: https://chromium-review.googlesource.com/c/1318533 Commit-Queue: Ingvar Stepanyan <ingvar@cloudflare.com> Reviewed-by:
Joel Einbinder <einbinder@chromium.org> Cr-Commit-Position: refs/heads/master@{#605961}
-
Hajime Hoshi authored
V8 should not be executed on per-thread task runner. Use per-frame task runner instead. Bug: 870606 Change-Id: I29754c8a085dfe0ec7b4d9e9f6b57ecdf75e1dae Reviewed-on: https://chromium-review.googlesource.com/c/1319406Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#605960}
-
Yoshifumi Inoue authored
This patch marks middleClickAutoscroll-{drag,event-fired}.html on Windows: * fast/events/middleClickAutoscroll-event-fired.html * virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-drag.html * virtual/mouseevent_fractional/fast/events/middleClickAutoscroll-event-fired.html * virtual/scroll_customization/fast/events/touch/gesture/gesture-scrollbar-touchpad-fling.html * virtual/user-activation-v2/fast/events/middleClickAutoscroll-nested-divs-forbidden.html NOTRY=true TBR=sahel@chromium.org Bug: 891155 Change-Id: Iaa6d1054921f3298af37a5023992826b541c82f5 Reviewed-on: https://chromium-review.googlesource.com/c/1322250Reviewed-by:Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#605959}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/48e9f6ccddbf..b076c5fff9c9 Created with: gclient setdep -r src-internal@b076c5fff9c9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I88f8dc2dd243cd6b60be9d5dcef87c13893d6eea Reviewed-on: https://chromium-review.googlesource.com/c/1321932Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605958}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: Id965ae49f617e6c0ec25428b28cde7e3a68ffdb8 Reviewed-on: https://chromium-review.googlesource.com/c/1321780Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#605957}
-
Justin Cohen authored
When navigating back to an error page -loadErrorPageForNavigationItem will immediately begin loading and _documentURL may not match the lastCommittedURL. Instead, set this in -didFailProvisionalNavigation. Bug: 898339 Change-Id: I32bff4cce27c97adde395a3e64ddb58b18bd0593 Reviewed-on: https://chromium-review.googlesource.com/c/1319173 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#605956}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5597b278..ef413aaa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I80fe69f95cc675f18408ab7294e00d0d7bb1e257 Reviewed-on: https://chromium-review.googlesource.com/c/1319930Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605955}
-
Yoshifumi Inoue authored
This patch marks xmlhttprequest-recursive-sync-event.html as [ Crash Pass] on Windows debug build. NOTRY=true TBR=yhirano@chromium.org Bug: 902632 Change-Id: I47494bad3b9314edef8a4043cc2ae2711b6f7e7b Reviewed-on: https://chromium-review.googlesource.com/c/1322173 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Hiroki Nakagawa authored
blink::mojom::ScriptType was introduced for ES Modules on Service Workers. To avoid duplicate enums, this CL replaces blink::ScriptType with blink::mojom::ScriptType. In addition to replacement, this CL adds a new directory and a mojom file blink/public/mojom/script/script_type.mojom, and moves blink::mojom::ScriptType from service_worker_registration.mojom to script_type.mojom. Bug: n/a Change-Id: I5b4a17b0b1ff15112c2675219cd69a6be6a2b051 Reviewed-on: https://chromium-review.googlesource.com/c/1321710Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#605953}
-
Stuart Langley authored
This brings across the changes made inside chromeos to the mojom that is defined in chromium. Bug: 884020 Change-Id: Iab4d789cf153fabbf8d243fd346e2188e9c4153b Reviewed-on: https://chromium-review.googlesource.com/c/1321652Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#605952}
-
Giovanni Ortuño Urquidi authored
Changes UnifiedBluetoothDetailedViewController to update the device list every 500ms while a scan is active. Also adds a new observer method specifically for when Bluetooth State changes and changes UnifiedBluetoothDetailedViewController to use this method to update the list of devices as well. Bug: 882346 Change-Id: I13ef2555e6c4c451213afb5d405f707d5f4f19a7 Reviewed-on: https://chromium-review.googlesource.com/c/1314069Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605951}
-
Danan S authored
The previous (now reverted) version of this CL failed to build in debug mode (and therefore broke the continuous build), because apparently static constexpr class members, which must be initialized in the class definition, are then not available at link time when is_debug=true. I didn't catch this before landing the CL because I was building with is_debug=false. The fix involved declaring the members as static const (not constexpr), and defining them in demo_mode_detector.cc. Revert "Revert "Disable Demo app launch when device is in Dev mode"" This reverts commit 225590d4. Bug: 877655 Change-Id: Id8c15012e4bfa33230feda38ec8a94ea5c809741 Reviewed-on: https://chromium-review.googlesource.com/c/1318741 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#605950}
-
Anand K. Mistry authored
BUG=900749 Change-Id: Id2da44c92c3e53aa08c60e7ae7de6eac6cd32b44 Reviewed-on: https://chromium-review.googlesource.com/c/1322169Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#605949}
-
mark a. foltz authored
This replaces custom origin formatting code with the standard formatting routine for permissions dialogs (geolocation, usb, etc.) Bug: 830177 Change-Id: I9bee4636a3095b561a1041d0228f9dc87e4504da Reviewed-on: https://chromium-review.googlesource.com/c/1321049Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#605948}
-
Emircan Uysaler authored
Some delegates called from this method may try accessing |current_frame_| which can cause deadlocks. Therefore perform these checks right after |current_frame_| is set and lock is released. Bug: 901744 Change-Id: I56605cca8bad81a498a177ff8230598abfdd03fd Reviewed-on: https://chromium-review.googlesource.com/c/1321092Reviewed-by:
CJ DiMeglio <lethalantidote@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#605947}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 20c48bd4. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." d2f6756a "Window onerror is not triggered bug fix" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: emircan@chromium.org: external/wpt/screen-capture guidou@chromium.org: external/wpt/mediacapture-streams hbos@chromium.org, hta@chromium.org: external/wpt/webrtc mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=markdittmer No-Export: true Change-Id: If22c34613b3639294eb69c38e7a78c8564f853ad Reviewed-on: https://chromium-review.googlesource.com/c/1321857 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605946}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0e50a38dcaee..5c8d3e17aba1 git log 0e50a38dcaee..5c8d3e17aba1 --date=short --no-merges --format='%ad %ae %s' 2018-11-07 mtklein@google.com clean up SK_LEGACY_OP_COLOR_AS_BYTES 2018-11-07 mtklein@google.com make SkColorShader RP-only 2018-11-06 mtklein@google.com remove Gauss option from SkGaussFilter Created with: gclient setdep -r src/third_party/skia@5c8d3e17aba1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I66a88c39325369eae6a6b8ffeb563816239d3733 Reviewed-on: https://chromium-review.googlesource.com/c/1321950Reviewed-by:
-
Noel Gordon authored
The Chrome OS ASAN bots now have longer test time-outs limits and maybe enough to run the zip file tests to completion. Let's see. Bug: 867738 Change-Id: Ibda0a13ccb13095d14504c19d48d619cee5d5cd8 Reviewed-on: https://chromium-review.googlesource.com/c/1321653Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605944}
-
BUG=762641 TBR=stevenjb@chromium.org Change-Id: Ie029f7e41a1add755c6f87f7db24ecc36b00346f Reviewed-on: https://chromium-review.googlesource.com/c/1322049Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#605943}
-
Bryce Thomas authored
This CL factors CPU profiling code out of chrome/ and into content/ to support CPU profiling Headless Chromium. headless_content_main_delegate.cc has been modified to honor CPU profiling flags à la chrome_main_delegate.cc. Bug: 890456 Change-Id: I76842c5936de82d6bd42354c461aff9e0d273248 Reviewed-on: https://chromium-review.googlesource.com/c/1312157 Commit-Queue: Bryce Thomas <bryct@amazon.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#605942}
-
Anand K. Mistry authored
2.6.0 has broken AES encryption support. Also, add a unit test to ensure this keeps working. BUG=902586 Change-Id: I3554150e6eb4b5597a473df332d043f6294eb1b3 Reviewed-on: https://chromium-review.googlesource.com/c/1321651Reviewed-by:
-
Richard Townsend authored
This fixes a problem when using run_web_tests.py with --copy-baselines when the original test expectation does not exist for some reason. Change-Id: I43fafb982936173639d213a0fa560ef976e13fe8 Reviewed-on: https://chromium-review.googlesource.com/c/1311929 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#605940}
-
Jonathan Metzman authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/a305a5eb85ed..2a53098584c4 $ git log a305a5eb8..2a5309858 --date=short --no-merges --format='%ad %ae %s' 2018-11-06 metzman [fuzzer] Read files as binary 2018-11-06 kamil Follow Windows' approach for NetBSD in AlarmCallback() 2018-11-02 phosek [compiler-rt][Fuzzer] Fix the fuzzer test build 2018-10-31 phosek [compiler-rt][Fuzzer] Use the new C++ ABI namespace CMake support 2018-10-14 metzman [libfuzzer][Windows] Silence linker warning in unittest 2018-10-10 george.karpenkov [libFuzzer] Generalize the code for getting the previous offset for different architectures 2018-10-02 phosek [lib/fuzzer] Fix logging for Fuchsia Created with: roll-dep src/third_party/libFuzzer/src Bug: 902460 Change-Id: I82ef4e6e9b35371bb82d7b5d7ae3ae7080553965 Reviewed-on: https://chromium-review.googlesource.com/c/1321583Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Jonathan Metzman <metzman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605939}
-
Alexei Filippov authored
BUG=901165 Change-Id: Ib29619563845f9f4002d8a01269f74b56ec478c2 Reviewed-on: https://chromium-review.googlesource.com/c/1315993 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#605938}
-
Hao Zhang authored
Bug: 899057 Change-Id: I622240f7ca81f2d6227f15121509aca66256a68c Reviewed-on: https://chromium-review.googlesource.com/c/1309298 Commit-Queue: Hao Zhang <hozhng@google.com> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Cr-Commit-Position: refs/heads/master@{#605937}
-
Erik Luo authored
Fixes 2 stick to bottom cases - Prompt has text, but is scrolled out of view. User presses 'Enter'. Browsers usually scroll an field into view on input events, but Console preventsDefault to avoid adding a newline. Now, we will emulate the scroll. - Page logs a ton of messages, Console opened for the first time. CodeMirror asynchronously resized prompt height on load, which broke stick to bottom. This CL changes layout so that prompt height does not grow on editor load. Bug: 863664 Change-Id: Ia25a71100d9a895d4c8c710b36ba1d8b76d76990 Reviewed-on: https://chromium-review.googlesource.com/c/1321575Reviewed-by:
-
Christopher Cameron authored
Simplify BrowserCompositorMac::TransitionToState, now that we no longer have a "detached" state. The new version has 3 steps - detect no-op changes and early-out - detach from the current compositor, if there is one - attach to the new compositor, if there is one This allows the code the common code between the "parent ui layer" compositor and the "has attached compositor" state. Update the comments about the states to reflect the simpler reality. Fix a bug wherein transitioning between HasOwnCompositor and UseParentLayerCompositor would briefly hide the DelegatedFrameHost and allow the frame to be inappropriately evicted. Bug: 897156 Change-Id: If6d772a8d605568c3cdab9be0843919ded5ac5e3 Reviewed-on: https://chromium-review.googlesource.com/c/1317147 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#605935}
-
David Benjamin authored
This is "health check" histogram without a particular expiration. It's so we notice if the Android system trust store isn't accessible for some reason. (It only is recorded once on startup so it's hopefully not particularly expensive.) While I'm here, give it a better enum name. Bug: none Change-Id: I7303d7f8f1f4309d92b91ca4eaee4fa8d8cde8ea Reviewed-on: https://chromium-review.googlesource.com/c/1320649Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#605934}
-
bsheedy authored
Updates the golden image for a VR JS dialog test that was failing due to the image mismatch and re-enables the test. TBR=mthiesse@chromium.org Bug: 902319 Change-Id: I039935b788dde5b52cdf750e005fe57f9520f745 Reviewed-on: https://chromium-review.googlesource.com/c/1321794Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#605933}
-
Luciano Pacheco authored
Bug: 873539 Change-Id: Ieb7e53fac5dc0386c552148d43fb36c48a0586ac Reviewed-on: https://chromium-review.googlesource.com/c/1322010Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#605932}
-
Shu Chen authored
1. Reset the rulebased engine correctly when processing keys like Enter, ArrowLeft, etc. 2. Determine invalid match when the match start position is in the middle of (ambi + ch) for history state. Bug: 859432 Change-Id: I5b48490443c0d9ba4ee7528d7e155c816f376c09 Reviewed-on: https://chromium-review.googlesource.com/c/1319227 Commit-Queue: Shu Chen <shuchen@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#605931}
-
Shakti Sahu authored
This CL fixes the issue of long backstack for download home filters. With this fix, we would always exit download home when back pressed. While we are on download home, selecting filters will only update the current navigation entry instead of creating a new entry. Bug: 899938 Change-Id: Ia532d1441ff096a78fdc4cb509b4a99ee413ee3f Reviewed-on: https://chromium-review.googlesource.com/c/1309428 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#605930}
-
Alexey Baskakov authored
Use UpdateWebAppInfoFromManifest to merge the manifest into info. In next CLs: 1) Add scope and theme_color into WebApp. 2) Download icons and write them to disk. Bug: 901226 Change-Id: I3439983ef06c8c1bed5223ba2127a8620f1e4b55 Reviewed-on: https://chromium-review.googlesource.com/c/1319391 Commit-Queue: Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#605929}
-
Adrienne Walker authored
Instead of storing and hashing the color space on every DrawImage, instead store the color space on the image decode cache itself. Bug: 902022 Change-Id: Icac6e4702f21c2bd276e8941a15ba5d96a890f04 Reviewed-on: https://chromium-review.googlesource.com/c/1318734 Commit-Queue: enne <enne@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#605928}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ab40518b6d4..48e9f6ccddbf Created with: gclient setdep -r src-internal@48e9f6ccddbf The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Id3e2d68c26216e0b0a03f6e34cc4ecc8e78ea2b0 Reviewed-on: https://chromium-review.googlesource.com/c/1321177Reviewed-by:
-
