- 10 Nov, 2020 40 commits
-
-
Jinho Bang authored
When switching dark mode, the application context is changed. Therefore, existing cached object might not work. So, this patch removes the cache related code and recreate the bridge object whenever TouchToFillViewImpl::Show() is called. Bug: 1146969 Change-Id: I386550b8008dc6289a0d6d2ea367e59c975fb508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525804Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Cr-Commit-Position: refs/heads/master@{#825852}
-
Filip Gorski authored
Removes the OmniboxSuggestionsDropdown interface. Renames: * OSRecyclerView to OmniboxSuggestionsDropdown * OSRecyclerViewAdapter to OmniboxSuggestionsDropdownAdapter Bug: 1075602 Change-Id: Ib6ba333ee36b65899db63d7fc9fedbc2de544548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523467Reviewed-by:
Tomasz Wiszkowski <ender@google.com> Cr-Commit-Position: refs/heads/master@{#825851}
-
Filip Gorski authored
Removes the OmniboxSuggestionsDropdown interface. Bug: 1075602 Change-Id: I87cd6c72581984b6a86403fb4b19b7c81d87d4d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521445Reviewed-by:
-
Tommy Martino authored
Bug: 1061949 Change-Id: I3603ac27ef98f6c4ea88069049b12fab4616b6a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522001Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#825849}
-
Mohamed Adel authored
This adds tests for the different methods in the bridge, and the different scenarios that can happen when displaying a notification. It also tests features specific to the API. Change-Id: Id58fe2a63c19baf2b1cb6a83cc488d3c060692cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517466Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mohamed Adel <adelm@google.com> Cr-Commit-Position: refs/heads/master@{#825848}
-
Francois Doray authored
Fixed: 1088709 Change-Id: If79d2cfe4fa188e2b3bfd86b9ed6c7a7f0b8e69c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526906 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#825847}
-
Ryan Daum authored
* Rounded corners were mistakenly being applied on all classes of devices * This puts them behind a flag so they can be toggled per device. Bug: internal b/165638935 Test: manual on device Change-Id: Ic380d45ba9b2ad53789dbad2acf3860bdea57be5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515039Reviewed-by:Luke Halliwell (slow) <halliwell@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#825846}
-
Eric Orth authored
This covers both the case where HTTPS is the qtype (and thus additional records means the resolver is HTTPS-aware and doing followup queries for us), and the case where HTTPS is not the qtype (and thus the record was unsolicited). Bug: 1138620 Change-Id: I532a29dac47bd2beaf479855b395e720ec54f16e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523425Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Commit-Queue: Eric Orth <ericorth@chromium.org> Cr-Commit-Position: refs/heads/master@{#825845}
-
Xianzhu Wang authored
Bug: 1142725 Change-Id: I804ec0ae9c3f35649aed04a17af3645a01c32e2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527886Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#825844}
-
Quinten Yearsley authored
This changes the tricium config to trigger the new wrapper recipe instead of individually triggering the legacy analyzers. This should be done after landing the recipe and the builder: https://crrev.com/c/2477246 https://crrev.com/c/2521848 Bug: 1105239 Change-Id: I0446a8fa9547d989aec29884455febe46aa042bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2522171Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Cr-Commit-Position: refs/heads/master@{#825843}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/090c3b6d15c4..1eb165cc6c39 2020-11-10 aerotwist@chromium.org [unit test] Switch inline_editor imports to using the entrypoint 2020-11-10 tvanderlippe@chromium.org Use TypeScript-authored files in lighthouse/ If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib4cc56267ed18fea09f887aca4936c5b92f1a5d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528210Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825842}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ee0ce9858cbc..0c0884991d53 2020-11-10 robertphillips@google.com Update DDL testing harness to support drawing DDL w/ integer offsets 2020-11-10 johnstiles@google.com Add unit test demonstrating array function param bug. 2020-11-10 tdenniston@google.com [svg] Implement feComposite, basic filter result storage 2020-11-10 robertphillips@google.com Change UnrefDDLTask to just be the DDLTask 2020-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from d4439824c554 to 72001c7d85ba (15 revisions) 2020-11-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Dawn from 3e17e33724b4 to c04a0132be6c (3 revisions) 2020-11-10 herb@google.com use initial device coordinates as subrun positions 2020-11-10 martin@scenegroup.co [skshaper] Fix CoreText segfault and convert UTF16 indices to UTF8 2020-11-10 csmartdalton@google.com Fix GrPathUtils::convertLineToCubic 2020-11-10 bsalomon@google.com Simplify promise image callbacks. 2020-11-09 mtklein@google.com refactor Sk[S]TArray methods 2020-11-09 johnstiles@google.com Report an SkSL error if an `in` var has an initializer expression. 2020-11-09 kjlubick@google.com [canvaskit] Add config key and manual mode to unit test harness. 2020-11-09 mtklein@google.com align SkAlignedSTStorage<N,T> to T 2020-11-09 jvanverth@google.com Update code-signing script to have better error messages. 2020-11-09 mtklein@google.com re-enable tests on GCC (and Clang o_O) 2020-11-09 johnstiles@google.com Add unit test for fuzzer-detected error with in vars. 2020-11-09 mtklein@google.com init SkSTArray storage before passing to SkTArray 2020-11-09 rmistry@google.com [bugs-central] Add documentation for sheriffs 2020-11-09 kjlubick@google.com [canvaskit] Disable GrTextBlobMoveAround 2020-11-09 herb@google.com rename Gr*Subrun to *Subrun in .cpp 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from a4f272b3 to 083976a7 (536 revisions) 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 612ded0654a0 to 4ed9d3498dcf (2 revisions) 2020-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ANGLE from 3dfaeeb00271 to d4439824c554 (28 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jlavrova@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jlavrova@google.com Test: Test: Test: Capture Clash of ClansTest: Test: angle_end2end_tests.exeTest: Test: angle_perftests --gtest_filter="*clash_of_clans*"Test: Test: Test: ImageTest.Source2DTarget2DTargetTextureRespecify*Test: Test: angle_end2end_tests.exe Change-Id: I56543416e4a0ee205de5f615fe1a7e36c34eb36a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529182Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/38f3d771bd8e..952ef3e06472 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5d45d38dc3c5e4526c0d1727b6737350b3e754e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528643Reviewed-by:
-
Roman Aleksandrov authored
Bug: 1082670 Change-Id: I0b2562f75fcb3eb549683322719d8106546afaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2521515 Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#825839}
-
Toby Huang authored
Add comment explaining that test is disabled due to flaky failures. Bug: 1144651 Change-Id: I6ec2f1e100ae833b1ef4324058144204d196ce67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527775 Auto-Submit: Toby Huang <tobyhuang@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#825838}
-
Andy Paicu authored
This will help support the future new selector for CPSS: go/permissions-suggestions-client-doc Also split the existing selector into a crowd deny and a pref selector. Bug: 1138595 Change-Id: I460d979cc6746586a8c25a85c549d487a52908d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485213 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#825837}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/7a74e09cab5e..a1662b3f0e92 $ git log 7a74e09ca..a1662b3f0 --date=short --no-merges --format='%ad %ae %s' 2020-11-09 wub Let QuicBandwidth::FromBytesAndTimeDelta return 1 bit per second if the result is less than that but not zero. 2020-11-09 bnc Deprecate gfe2_reloadable_flag_quic_http3_new_default_urgency_value. 2020-11-09 danzh export --gfe2_reloadable_flag_http2_use_fast_huffman_encoder to QUICHE Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src Switch to use QUICHE flags R=rch@chromium.org Change-Id: Ib90a5122ccc1f020cdc8ea78549c6a17397222b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528276 Commit-Queue: Bence Béky <bnc@chromium.org> Reviewed-by:
Bence Béky <bnc@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#825836}
-
Mohamed Amir Yosef authored
Linux users have been migrated to user PasswordStoreDefault. It's time to delete PasswordStoreX Bug: 950269 Change-Id: I3ffc20130c93720d589f2063d0de0220b74a61c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527202 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#825835}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aee5f31f..17ac33b5 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iffcc24774201a8cd517d27b50e55c43bc60d7b50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528642Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#825834}
-
Stepan Khapugin authored
Expose connected agents for features to find the associated agent. Bug: none Change-Id: Id8ec1e86897ea72b8b61bbf24281b6c7e90cd06c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523179 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#825833}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a89c6b9a5c5b..9828732beeee 2020-11-10 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Tools from bd0ebb680792 to df1edd1738a6 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: Ibf0d3f70b2ea63ff01f75be8dd88d70733f44bb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529176Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/952ef3e06472..8da8bcdf92fb 2020-11-10 fmayer@google.com Get rid of useless log. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5d0917f945c1bde89f77fc483f940758bb803813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529174Reviewed-by:
-
Ioana Pandele authored
The toggle should be shown whenever the key icon is shown on sites which are blocked from saving passwords, but contain password forms. Bug: 1145173, 1044930 Change-Id: I1da5eca94d4118962f9c29b43f4caf1c8c56c538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526301 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
-
Jordan Demeulenaere authored
This CL adds a new can_match_multiple_elements flag to UploadDomProto to allow it to return the DOM of multiple elements matching the same selector. This CL also removes the ProcessedActionProto.html_source field and replaces it by a UploadDomProto::Result field. This means that newly built client won't work for scripts that use UploadDom until the associated backend code is implemented (which will be done in cl/341416176). Bug: b/166564516 Change-Id: I20f4e6f12fdf5106f4bbe297c4ecb16bcdc9205b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2523035Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Cr-Commit-Position: refs/heads/master@{#825829}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/38f3d771bd8e..952ef3e06472 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Id0248168e1ffc644f4be36844e5eca6067884947 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528641Reviewed-by:
-
Claude van der Merwe authored
The RecordTotalCount metric is incorrectly logged as 0 during OOBE since the networks have not had a chance to merge. This CL 1. Adds a pref to avoid the incorrect log of 0 networks during OOBE. 2. Adds a Teardown in the unittests to temporarily fix flaky tests. Bug: 1135854 Change-Id: I03328caae2753b0331a9c5ed43d7b79de64dac44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519327Reviewed-by:
Jon Mann <jonmann@chromium.org> Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Cr-Commit-Position: refs/heads/master@{#825827}
-
cfredric authored
This fixes the test flake. Bug: 1147062 Change-Id: Iacfa443eb74420e79ffb56d770d59388cabe94b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2525767Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Lily Chen <chlily@chromium.org> Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Chris Fredrickson <cfredric@chromium.org> Cr-Commit-Position: refs/heads/master@{#825826}
-
Stephane Zermatten authored
With this change, it becomes possible, when building a selector, to require the matched element to have a nonempty bounding box. This is useful on its own, as setting an empty height or width is a strategy that's sometimes used to keep an element, such as a menu, on the DOM tree than can be revealed at the appropriate time by resizing it. Without this change, selectors would think that an element hidden in that way is visible. Bug: b/171464032 Change-Id: I1de9150a794d56e9bfb1ebdd95e86c724592380a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503736 Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#825825}
-
Sigurdur Asgeirsson authored
ScopedObserver is being deprecated in favor of two new classes: - base::ScopedObservation for observers that only ever observe a single source. - base::ScopedMultiSourceObservation for observers that do or may observe more than a single source. This CL was uploaded by git cl split. R=nhiroki@chromium.org Bug: 1145565 Change-Id: Id873d944e6e92d743bba116816b1c3f7c0bcabf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526168 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Auto-Submit: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#825824}
-
Matt Jones authored
This patch migrates the TopToolbarOverlay to use the new layouts module rather than the LayoutManagerImpl class. The old observer in the mediator has been replaced with the LayoutStateObserver and a new supplier has been added to the coordinator's constructor for the ResourceManager. Bug: 1070281, 1100332 Change-Id: I061ee98a3e7bb8db8f2a23d75573077bac0c271c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527010 Commit-Queue: Matthew Jones <mdjones@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#825823}
-
Stephen Chenney authored
The various Blink.MainFrame Ratio metrics are essentially unused. The same data can be gathered from UKM using totals for time spent in BeginMainFrame. This change removes the Ratio UMA metrics and updates the UKM event to report BeginMainFrame times rather than percentages. Also clean up some now obsolete metrics that had not been marked as such. The privacy doc has been updated but privacy review is not required because we are reporting the same data in a different form (the values reported now could have been computed from the former values). Bug: 1138397 Change-Id: I6769c29a56a739e030e85262a33a79fd4d7471f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527581Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#825822}
-
Swapnil authored
We store error codes and number of fetch tries if the extension installation fails due to MANIFEST_FETCH_FAILED or CRX_FETCH_FAILED. We want to add these fields to the existing events for the event based reporting for force installed extensions so that detailed reason can be reported. Bug: 1048640 Change-Id: I124615d0a8ffa4b7f9991149054947a5cf391e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505983 Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Reviewed-by:
Oleg Davydov <burunduk@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#825821}
-
Findit authored
This reverts commit 45fe0314. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 825789 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQ1ZmUwMzE0NTc4MGE4M2RmODM2YmNiMDNjNGE3MzNkNWFmNTkzYjQM Sample Failed Build: https://ci.chromium.org/b/8864008846435386704 Sample Failed Step: compile Original change's description: > a11y insepct reorg: move PropertyNode class to ui/accessibility > > Bug: 1133330 > Change-Id: I9103d0116c5822a0f9dc291a7a87bd5f902a4efa > AX-Relnotes: n/a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2519755 > Commit-Queue: Alexander Surkov <asurkov@igalia.com> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825789} Change-Id: If5cefe8ce9b3efa19009c7b68d3e8e9c618b01a2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1133330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528647 Cr-Commit-Position: refs/heads/master@{#825820}
-
Tommy Martino authored
This reverts commit 5e46febb. Reason for revert: Speculative revert based on Mac Builder clang segfaults Sample bad build: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8864006321936062752/+/steps/compile/0/stdout Original change's description: > mac/ios: Use real response files instead of -filelist. > > Xcode 12 added support for real response files, so let's use them. > Allows making response file contents more like on other systems > (libs, solibs, frameworks, swiftmodules now go in the rsp file too), > and makes it theoretically possible to have object files with spaces > in their name. > > No intentional behavior change. > > Bug: none > Change-Id: I8c2d6ff1abd47261bf7674dc7bf4506814681ad4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527621 > Auto-Submit: Nico Weber <thakis@chromium.org> > Commit-Queue: Brett Wilson <brettw@chromium.org> > Reviewed-by: Brett Wilson <brettw@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825480} TBR=thakis@chromium.org,brettw@chromium.org,mark@chromium.org Change-Id: I128e1fd1d69c56374629202935e6a12614fdc03e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1147447 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529609 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#825819}
-
Henrik Boström authored
This reverts commit 46b6fd15. Reason for revert: camera.CCAUISmoke.fake is failing on chromeos-eve-chrome and camera.CCAUI* is listed as test coverage for this CL, so I am speculating that it is the cause. See: https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/11136 Original change's description: > [CCA] Run CCA as SWA by default > > Bug: b/172345161 > Test: tast run [DUT] camera.CCAUI* > Change-Id: I10484c9263f3e4c560028aef272cd3db88c47b31 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509834 > Commit-Queue: Wei Lee <wtlee@chromium.org> > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Auto-Submit: Wei Lee <wtlee@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#825657} TBR=ortuno@chromium.org,wtlee@chromium.org Change-Id: I5464fbcd7f1a03cd157122ad66c6ee13ad111630 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/172345161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2529360Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#825818}
-
Alex Turner authored
This metric will break out the activation state of frames that inherit their activation from their opener. This should help illuminate the impact from the recent change to allow inheritance from same-origin openers for certain mainframes (see crrev.com/c/2219104). Bug: 1055558 Change-Id: I5efbf94e90fa3953880d64f9934a770855aaa72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515181Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#825817}
-
Viktor Semeniuk authored
This change fixes the crash when username was changed to the empty one. Bug: 1147046 Change-Id: I0c9e24bce474639499865c06f1d9007776bc5c6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2526323 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#825816}
-
Khushal Sagar authored
After the change in [1], we no longer ensure that the SkCanvas lifetime is tied to CanvasImageProvider. [1] : https://chromium-review.googlesource.com/c/chromium/src/+/2450842 R=aaronhk@chromium.org Bug: 1143229 Change-Id: If99ff121c221b6560da58596fc9faf11fe28dfeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528615 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Cr-Commit-Position: refs/heads/master@{#825815}
-
Vladimir Levin authored
This patch ensures devtools doesn't try to generate grid information on locked containers, since the contents are not necessarily laid out or generated. R=chrishtr@chromium.org Fixed: 1139642 Change-Id: I5b279196cf147407abefa7ffa2264484fc698b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2527941Reviewed-by:
-
Kent Tamura authored
For a historical reason, some form controls always clip the content, and should ignore the 'overflow' property. File upload control NG had a regression that it accepts overflow:visible. This CL disables it again. The new behavior is compatible with Safari and Firefox. Bug: 1139629 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng_disabled Change-Id: I6b0b5a715a2c859f195bbf2473ead67cd22bd14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2528812Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#825813}
-
