GitLab

Disable benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop.browse:social:twitter

It is flaky. See bug

TBRing a contributor to the test file.

BUG=725386
TBR=nednguyen

Review-Url: https://codereview.chromium.org/2896293002
Cr-Commit-Position: refs/heads/master@{#473910}

Use ids instead in case objects disappear before we have a chance
to fire the events.

BUG=725203

Review-Url: https://codereview.chromium.org/2900893003
Cr-Commit-Position: refs/heads/master@{#473909}

Previously there were many PNGs for the cards in Payment Request. Now
this code uses the Autofill assets, which are vector drawables.

Additionally:
* MIR, JCB and Diners cards are now a drawable in Autofill
(previously PNG or generic icon on Android)
* Fixed a few other drawables.
* Removing the border from the PR icons because it's now built-in the asset
* Using setImageDrawable because it appears to be more efficient

BUG=722651
TEST=visual

Review-Url: https://codereview.chromium.org/2888803003
Cr-Commit-Position: refs/heads/master@{#473908}

Only Android native payment apps accept schemeless origin for history reason.
Service worker based payment apps request full origin.

BUG=720027

Review-Url: https://codereview.chromium.org/2894153003
Cr-Commit-Position: refs/heads/master@{#473907}

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892

Review-Url: https://codereview.chromium.org/2883273002
Cr-Commit-Position: refs/heads/master@{#473906}

We were previously skipping all symbols when calling GetOwnPropertyNames()
due to https://github.com/heycam/webidl/issues/294 being unresolved at the
time the code was written, as well as to maintain compatibility with Gecko,
which did the same at the time.

That GitHub issue has since been resolved: enumerable symbols should not be
skipped but rather just throw a TypeError when a string conversion function
is called on it. Gecko is also being updated, and this CL adjusts our code
accordingly.

The new tests being added to headers-record.html come from Boris Zbarsky
<bzbarsky@mit.edu> and were originally written in
https://bugzilla.mozilla.org/show_bug.cgi?id=1366032. They are being
included here mostly to both help test the CL, as I believe they will be
landed in Gecko and synced to web-platform-tests before this CL lands and we
end up upstreaming the changes.

While here, remove a duplicate test case in NativeValueTraitsImplTest.

BUG=724481
R=bashi@chromium.org,haraken@chromium.org,yukishiino@chromium.org

Review-Url: https://codereview.chromium.org/2900743002
Cr-Commit-Position: refs/heads/master@{#473905}

Make sure to return resources of a surface immediately once it's
destroyed. Currently we have to wait until surface aggregation time.
This caused memory leak in webview after a recent change. In this CL
we notify cc::Display to release the resources through the
SurfaceObserver interface.

BUG=719379
TBR=piman@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2897673002
Cr-Commit-Position: refs/heads/master@{#473904}

BUG=none
R=bauerb@chromium.org

Change-Id: Ia241e571e4e48290c9c612253a00156b44d92b0e
Bug: 725510
Reviewed-on: https://chromium-review.googlesource.com/512823
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473903}

Link to original CL: https://codereview.chromium.org/2867213004/

PatchSet 1 is the state as reviewed previously.
PatchSet 2 fixes the reasons for the revert.

Description of issues
---------------------
1.) Webkit Android bots for blink_heap_unittests and webkit_unit_tests fail with
OSError: [Errno 2] No such file or directory: '/b/c/b/WebKit_Android__Nexus4_/src/out/Release/gen/services/video_capture/manifest.json'
2.) MSan tests fail when running VideoCaptureBrowserTest.ReceiveFramesFromFakeCaptureDevice/22

Description of fixes
--------------------
For 1.: Removed an unnecessary data_dep on on the service manifest. Even though
  unclear why the particular tests would want to use the manifest file and why
  it was not copied, this is likely to fix the issue.
For 2.: It appears that this is an existing issue that was triggered by the
  new test cases added in this CL. I am disabling these test cases for now, and
  added https://crbug.com/725271 to track the issue.

Original CL description
-----------------------

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"
TBR=mcasas@chromium.org,rockot@chromium.org,piman@chromium.org,tsepez@chromium.org

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2896913002
Cr-Commit-Position: refs/heads/master@{#473902}

https://skia.googlesource.com/skia.git/+log/9f85d68887a6..92de631edd3e

$ git log 9f85d6888..92de631ed --date=short --no-merges --format='%ad %ae %s'
2017-05-23 robertphillips Remove compressed (ETC1) texture support from Ganesh (take 2)
2017-05-23 mtklein remove min from repeat and mirror generally

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Ibabe967f315107fd15af425415277cd057e87c23
Reviewed-on: https://chromium-review.googlesource.com/512363Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473901}

tools\metrics\histograms/pretty_print.py fails to parse
tools/metrics/histograms/histograms.xml due to
1) ERROR:root:Unknown enum DnsProbe.obsoleteProbeResult
2) ERROR:root:Unrecognized tag "obselete"

The failure of running pretty_print.py blocks uploading any CL
containing histograms.xml!

This CL removes DnsProbe.obsoleteProbeResult in three obsolete
histograms, and fixes "obselete" to "obsolete".

Running tools\metrics\histograms/pretty_print.py formats a few other
lines of code. This CL keeps this change.

BUG=725310

Review-Url: https://codereview.chromium.org/2896953002
Cr-Commit-Position: refs/heads/master@{#473900}

Stop using "setAutoCancel()". The docs say that this triggers the
"delete" intent, and we don't want to do that because that intent is
used to watch for dismissal. As it happens, the docs are wrong
(https://b.corp.google.com/issues/36961721), but one day Android might
fix that bug.

Guard all calls to recordCachedActionMetric() with
removeActiveNotification(). This should ensure that we only get one
action per notification. This already should have been the case (you
shouldn't be able to tap after dismissal), but might in theory be more
robust.

BUG=724081

Change-Id: I5f121bdaf07dee1988468e345634fe9d32e6fe34
Reviewed-on: https://chromium-review.googlesource.com/509615
Commit-Queue: Chris Pickel <sfiera@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473899}

Revert of Attempt #3 at registry outage: ShellExecute reg delete (patchset #1 id:1 of https://codereview.chromium.org/2897483003/ )

Reason for revert:
Nuclear cleanup no longer needed (and having reg.exe run in parallel with the browser_tests that are starting can cause flakiness in itself).

Original issue's description:
> Attempt #3 at registry outage: ShellExecute reg delete
>
> Nuclear option to be reverted after the bots heal up.
>
> BUG=721245
> R=thakis@chromium.org
>
> Review-Url: https://codereview.chromium.org/2897483003 .
> Cr-Commit-Position: refs/heads/master@{#472945}
> Committed: https://chromium.googlesource.com/chromium/src/+/f26f6233d2d8be69c638ddac047db13fd6f14062

TBR=thakis@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=721245

Review-Url: https://codereview.chromium.org/2902683003
Cr-Commit-Position: refs/heads/master@{#473898}

Currently one BackgroundServiceManager is created per batch of browser_tests.
This ends up leaving the UI and Ash process running between tests.

This is especially problematic for tests with PRE_test where state is expected
to not be preserved into the following test.

This change delays the initialization of a BackgroundServiceManager until the
child test process has connected to the MojoTestState. Subsequent tests will
tear down the previous BackgroundServiceManager before creating the new one.

This also tears down the UI and Ash processes as desired.

TEST=mash_browser_tests
BUG=678687

Review-Url: https://codereview.chromium.org/2858103002
Cr-Commit-Position: refs/heads/master@{#473897}

This CL cleans-up an obsolete pref entry in BookmarkSuggestionsProvider.
As a result, PrefService is not needed anymore in this provider.

As a slightly unrelated cleanup, this CL removes anything bookmarks-
related from the iOS factory which does not create the provider any
more.

BUG=none

Review-Url: https://codereview.chromium.org/2895943002
Cr-Commit-Position: refs/heads/master@{#473896}

Wait to show the toolbar buttons until the sheet offset is less
than 45%. 45% is used rather than 50% so that the buttons
aren't shown in the half height state if the user is dragging the
sheet down slowly and releases at exactly the half way point.

BUG=725000,695157

Review-Url: https://codereview.chromium.org/2898093002
Cr-Commit-Position: refs/heads/master@{#473895}

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
TBR=hirono@chromium.org, kinuko@chromium.org,

Review-Url: https://codereview.chromium.org/2887933002
Cr-Commit-Position: refs/heads/master@{#473894}

BUG=653259

Review-Url: https://codereview.chromium.org/2902523002
Cr-Commit-Position: refs/heads/master@{#473893}

As the -dealloc is called at a later time with ARC, move the cleanup
from -dealloc to -browserStateDestroyed to ensure it is determinically
called even if ARC decide to -autorelease TabModel.

Cleanup some of Tab ivar when the WebState is destroyed so that the
corresponding Tab helpers -dealloc is called sooner.

BUG=None

Review-Url: https://codereview.chromium.org/2885803002
Cr-Commit-Position: refs/heads/master@{#473892}

We now keep all of:

- load:chrome:blank
- browse:chrome:newtab
- browse:chrome:omnibox

on the same chrome_stories.py

Also move and rename search:portal:google to replace the older
browse:search:google.

BUG=725094

Review-Url: https://codereview.chromium.org/2902513002
Cr-Commit-Position: refs/heads/master@{#473891}

We assume that very long tasks (> 30 seconds) are a result of
measurement errors such as system falling asleep in the middle of a
task.

R=skyostil@chromium.org,isherman@chromium.org

Review-Url: https://codereview.chromium.org/2891393002
Cr-Commit-Position: refs/heads/master@{#473890}

This will help to avoid doing manual parsing and verification of the
inbound messages in multiple places.

BUG=679789

Review-Url: https://codereview.chromium.org/2888763006
Cr-Commit-Position: refs/heads/master@{#473889}

BUG=715459
TEST=existing tests
TBR=achuith@chromium.org

Change-Id: Ib52ef795f5b7cfab49a0d156679653b00c4c8db9
Reviewed-on: https://chromium-review.googlesource.com/512722Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Commit-Queue: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473888}

The Most Visited tiles presented to the user should only changes when the user
interacts with them: deletion or undo deletion.

BUG=712632

Review-Url: https://codereview.chromium.org/2887383003
Cr-Commit-Position: refs/heads/master@{#473887}

The WebStateList deserialisation function DeserializeWebStateList takes
a factory function that can makes arbitrary change to the WebState after
it has been created.

Move the code setting the WebUsageEnabled flag to the factory function
instead of passing it as an extra flag to the deserialization function.

Rename TabModel ivar from webUsageEnabled_ to _webUsageEnabled
for consistency with the other ivars that use the new convention.

BUG=724282

Review-Url: https://codereview.chromium.org/2900643003
Cr-Commit-Position: refs/heads/master@{#473886}

This adds a Delegate to Reporting that can eventually be plumbed to
check whether sites are allowed to store data (reports and clients).

BUG=704259,676324

Review-Url: https://codereview.chromium.org/2889193002
Cr-Commit-Position: refs/heads/master@{#473885}

Things are in good hands now. :-)

Bug: none
Change-Id: I76363ab6d89b8328ff1ea3d05b5f47781aa6ff9f
Reviewed-on: https://chromium-review.googlesource.com/512042Reviewed-by: Min Qin <qinmin@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473884}

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
R=droger@chromium.org

Review-Url: https://codereview.chromium.org/2875423002
Cr-Commit-Position: refs/heads/master@{#473883}

SequencedWorkerPool is being deprecated in favor of TaskScheduler.

BUG=667892
R=droger@chromium.org

Review-Url: https://codereview.chromium.org/2875353005
Cr-Commit-Position: refs/heads/master@{#473882}

BUG=725090,443374

Review-Url: https://codereview.chromium.org/2903523002
Cr-Commit-Position: refs/heads/master@{#473881}

replace all attribute with DOMMatrix in cssMatrixComponent.

https://drafts.css-houdini.org/css-typed-om-1/#cssmatrixcomponent

BUG=545318

Review-Url: https://codereview.chromium.org/2888403004
Cr-Commit-Position: refs/heads/master@{#473880}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/51b8af19..213c7195

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2902713002
Cr-Commit-Position: refs/heads/master@{#473879}

https://skia.googlesource.com/skia.git/+log/eee762104c75..9f85d68887a6

$ git log eee762104..9f85d6888 --date=short --no-merges --format='%ad %ae %s'
2017-05-23 mtklein retry tilers against 1

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: I3279c862f2a7db2426f8f7e07ec9813c84551a01
Reviewed-on: https://chromium-review.googlesource.com/512603Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473878}

They are failing with timeout on linux.

TBRing the most recent author

BUG=725455
TBR=shalamov
NOTRY=TRUE

Review-Url: https://codereview.chromium.org/2896253002
Cr-Commit-Position: refs/heads/master@{#473877}

This CL builds upon the previous refactorings to implement support for
the latest drafts (which is WGLC) of the Web Push Encryption scheme.

Support is not yet enabled for incoming messages - since the message
format changed slightly as well, a more trivial update to
GCMEncryptionProvider is necessary as well.

BUG=679789

Review-Url: https://codereview.chromium.org/2716443002
Cr-Commit-Position: refs/heads/master@{#473876}

BUG=569158
R=sdefresne@chromium.org
CC=thakis@chromium.org

Review-Url: https://codereview.chromium.org/2897013002
Cr-Commit-Position: refs/heads/master@{#473875}

Network traffic annotation tags are stored in url_request.

BUG=656607

Review-Url: https://codereview.chromium.org/2890293005
Cr-Commit-Position: refs/heads/master@{#473874}

There is a check in the tracker to ignore processes with a create-
time greater or equal than the current time in order to not mistake
a currently-running process that has reused a PID for an exited
one.

BUG=723060

Review-Url: https://codereview.chromium.org/2894933002
Cr-Commit-Position: refs/heads/master@{#473873}

Since |selection_start| is always before |selection_end|(L322),
 we don't need to switch back traversing.

Patch[1] introduced the backward traversal to support CSS Region.
Since, Blink doesn't support CSS Region, we can remove it safely.

[1] https://chromiumcodereview.appspot.com/23674007 [CSSRegions] Not possible to
clear the selection when mixing content from different FlowThreads

BUG=708453

Review-Url: https://codereview.chromium.org/2895193002
Cr-Commit-Position: refs/heads/master@{#473872}

In MultiProcess mode the WebView renderer process can crash without
bringing down the browser process.
Such a crash causes a minidump to be generated - with this CL that
minidump is handled (copied, later to be uploaded) quickly after the
renderer process crash instead of during the next WebView startup.

BUG=674145

Review-Url: https://codereview.chromium.org/2833893002
Cr-Commit-Position: refs/heads/master@{#473871}