- 28 Nov, 2018 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4274496685fe..cdbaaa244432 git log 4274496685fe..cdbaaa244432 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 yueherngl@google.com octopus: fix version string generated by firmware builder 2018-11-28 chrome-bot@chromium.org Update config settings by config-updater. Created with: gclient setdep -r src/third_party/chromite@cdbaaa244432 The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: I246e468d9c0216d141c2934febe0640905e0fd9a Reviewed-on: https://chromium-review.googlesource.com/c/1354304Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611913}
-
Ben Kelly authored
Currently there are a number of histograms that are recorded for each "operation" that is scheduled. All operations are aggregated into a single bucket. This makes it hard to tell if one operation type is having a problem. Also, some operation types are much more frequent than others which further skews the metrics. This CL breaks out these operation histograms by the type of the operation. The aggregated histograms are still preserved for detecting infrastructure level changes and comparing to historical data. This CL also migrates the OperationDuration and QueueDuration to the LONG_TIMES histogram type. We have top level metrics that greatly exceed the default 10 seconds and we expect some of the specific operations will need to measure very long values on some platforms. TBR=jkarlin cannot be easily further reduced. Bug 909894 has been filed as a follow-on to reduce the code bloat further. Binary-Size: Increase is due to a large number of new UMA histograms which Bug: 908851 Change-Id: Iee607ae8f9f15384058af4977fffcffe027e0dbc Reviewed-on: https://chromium-review.googlesource.com/c/1352479 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:Victor Costan <pwnall@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#611912}
-
Giovanni Ortuño Urquidi authored
AdapterPoweredChanged gets called right after AdapterPresentChanged when an adapter is added or removed. This causes us to call Observer::OnBluetoothStateChanged() a second time without the state actually changing. To avoid this, we cache the state whenever AdapterPresentChanged and AdapterPoweredChanged get called and only notify if the new state is different than the cached state. Bug: 908879 Change-Id: I7ca48b20678b5336346955fd2254bc68f2a09b75 Reviewed-on: https://chromium-review.googlesource.com/c/1352123 Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#611911}
-
Zhenyao Mo authored
These changes are generated simply by running build_gles2_cmd_buffer.py Get this out of the way so CLs can focus on real changes. BUG= TEST=bots TBR=piman@chromium.org Change-Id: I4922a493881d8bd8abfc006f680c049fe3689d8a Reviewed-on: https://chromium-review.googlesource.com/c/1354134Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#611910}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/596d6fe00db7..ac71e34d4ad1 git log 596d6fe00db7..ac71e34d4ad1 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 brandon1.jones@intel.com Change Copy Operation Interfaces to Match WebGPU IDL 2018-11-28 enga@chromium.org Factor SerialQueue into SerialQueue and SerialMap 2018-11-28 cwallez@chromium.org WireCmd: require opt-in to treat ID 0 as nullptr instead of error. 2018-11-28 cwallez@chromium.org Roll SPIRV-Tools and temporarily use Vulkan SPIRV validation Created with: gclient setdep -r src/third_party/dawn@ac71e34d4ad1 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:905273,chromium:906418,chromium:908678 TBR=cwallez@chromium.org Change-Id: I4979c5123a026fa468c660f45dce4fcf4f1903ae Reviewed-on: https://chromium-review.googlesource.com/c/1354240Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611909}
-
Garrett Beaty authored
Bug: 889992 Change-Id: I3cc9b095ecd19acda49e1d1d34b5b064668d7e26 Reviewed-on: https://chromium-review.googlesource.com/c/1343367Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#611908}
-
Yusuke Sato authored
The #include is needed for std::max. BUG=None TEST=git cl lint Change-Id: Ib0a0de3191b180c7f0c9774505feecad7e248a7f Reviewed-on: https://chromium-review.googlesource.com/c/1354401Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#611907}
-
Rebekah Potter authored
This reverts commit 42c0440f. Reason for revert: This causes https://crbug.com/908775, and the Blink changes that were the reason for the change have been rolled back for now. Original change's description: > Settings WebUI: Add tabindex -1 in scrolling container to prevent tabstop. > > This is necessary because of recent Blink changes at r608013. > > Bug: 905999 > Change-Id: I111e3631e4d832afb48a4161552fc27a1bbb9630 > Reviewed-on: https://chromium-review.googlesource.com/c/1343197 > Reviewed-by: Rebekah Potter <rbpotter@chromium.org> > Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> > Cr-Commit-Position: refs/heads/master@{#609546} TBR=dpapad@chromium.org,rbpotter@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 905999, 908775 Change-Id: Ie14d8cbea36dcb91d03e8e7ab7b2fdd5010fcc10 Reviewed-on: https://chromium-review.googlesource.com/c/1354235Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#611906}
-
Kyle Milka authored
If a custom background is set clear the theme attribution url. Bug: 908798 Change-Id: I2c612fa2fffaff04925a1f8d04d6b5962b0ccc4c Reviewed-on: https://chromium-review.googlesource.com/c/1354007Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#611905}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/029a56af584c..eee0f6ad0df5 git log 029a56af584c..eee0f6ad0df5 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 pcc@google.com Add crosshatch and blueline to the special root device list. Created with: gclient setdep -r src/third_party/catapult@eee0f6ad0df5 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie201d2cf5cb443d4e011ed107f93dbc96d67750b Reviewed-on: https://chromium-review.googlesource.com/c/1351263Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611904}
-
Darren Shen authored
In ChromeOS, each input method has its own settings, which are currently stored in the extension local storage. This is not good for several reasons, so we want to move it to the ChromeOS prefs service: - Putting it in prefs allows us to eventually sync these settings across machines. - When we eventually deprecate the VK extension, there will be no more local storage. - With the work in 895886, Chrome OS need to access these settings anyway. It is much easier for the extension to query Chrome OS than the other way around, due to how extension APIs work. We add a new prefs entry for all the input method settings. Each input method has a dictionary of key/value pairs to use. For the input method to get/set these settings, we add private APIs in chrome.inputMethodPrivate to get/set these values. Bug: 895886 Change-Id: If1366ead35a8274eadae97c7e4cc37a95526d777 Reviewed-on: https://chromium-review.googlesource.com/c/1343471 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Shu Chen <shuchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611903}
-
Doug Arnett authored
Adds HTTPS and HTTP scheme specific histograms for NavigationToInteraction and NavigationStartedInForeground. Bug: 903912 Change-Id: I1ef870ed5cc83c6c83a703d363b85f14812942fe Reviewed-on: https://chromium-review.googlesource.com/c/1354104Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#611902}
-
Luciano Pacheco authored
Change the FileManagerPrivate API to use MyFiles path to check for disk space for StartCopy method. The net result for this change is 0,because the implementation actually uses statvfs [1] to check the spaceavailable which checks the space used by the whole volume, so the result is literally the same with Downloads or MyFiles path, however this is more correct. Note that when MyFilesVolume flag is disabled it'll still use Downloads path because the function GetMyFilesFolderForProfile handles that accordingly. [1] - http://man7.org/linux/man-pages/man2/statvfs.2.html Bug: 873539 Change-Id: I44cafdb35ee4f8825c45fa85793ccdac80d9e14c Reviewed-on: https://chromium-review.googlesource.com/c/1352127Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#611901}
-
Jonathan Backer authored
We maintain the invariant that context is current when ScheduleGrContextCleanup is called. We mark the context as lost if we fail MakeCurrent in PurgeGrCache. Change-Id: Ie901056816b23d0076586f8e3bd4794c9e4e2c73 Reviewed-on: https://chromium-review.googlesource.com/c/1354120Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#611900}
-
Scott Violet authored
This got lost in the refactoring. Added test coverage. BUG=756085,875111 TEST=covered by test Change-Id: I1b9bbc78b2657a1378b55542786b88f8911a4b9e Reviewed-on: https://chromium-review.googlesource.com/c/1351144Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#611899}
-
Clark DuVall authored
This fixes all of content_browsertests and some of the main failures in browser_tests. Bug: 908993 Change-Id: Ic77481ef0a5e05110878a9610172863fb9ee6994 Reviewed-on: https://chromium-review.googlesource.com/c/1352411Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#611898}
-
Luigi Santivetti authored
This change gives the IMG gpu process access to its own device node /dev/pvr_sync for Chrome OS platform only. BUG=b:117489304 TEST=Build Chrome, deploy it, boot a PowerVR based device, verify that the UI starts and the sandbox is enabled R=bhthompson@chromium.org, djkurtz@chromium.org, drinkcat@chromium.org Signed-off-by:
Luigi Santivetti <luigi.santivetti@imagination.corp-partner.google.com> Change-Id: Ifb89cab0b0d372d4e2fe9d882fa3767c1827bb17 Reviewed-on: https://chromium-review.googlesource.com/c/1299077 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611897}
-
Evan Stade authored
This simplifies the test and allows it to pass in single process mash due to extra setup in the test fixture. (Technically, it also passes in single process mash without this change, but would cease to do so after AuraTestSuite stops creating an InputDeviceClient, which will soon happen.) Bug: 905430 Change-Id: I0f9f630fdfd68e72bae1e652bad07bc18ec39d51 Reviewed-on: https://chromium-review.googlesource.com/c/1343348Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#611896}
-
Alex Clarke authored
This is necessary because we want content::TestBrowserThreadBundle to own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment and you can't have two SequenceManagers on the same thread. This patch allows ScopedTaskEnvironment to optionally work with an externally owned SequenceManager solving the problem. This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, We now have the ability to mock time on the UI thread. TBR=asvitkine@chromium.org,miu@chromium.org Bug: 863341, 891670, 708584 Change-Id: I96aa34c5cc8832c263621c2d9c228a8da4372c68 Reviewed-on: https://chromium-review.googlesource.com/c/1324391 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#611895}
-
Anastasia Helfinstein authored
This is a reland of 3a16d8d9 Original change's description: > Ignore virtual KeyEvents in SwitchAccess > > Switch access should only use KeyEvents from physical keyboards as > switches; virtual keyboard events should be ignored. > > Added a browser test for SwitchAccess > > BUG=864802 > > Change-Id: Ia50bacafe0c0740b4eea6c9f290c8679b61d79bc > Reviewed-on: https://chromium-review.googlesource.com/1114069 > Reviewed-by: David Tseng <dtseng@chromium.org> > Reviewed-by: Katie Dektar <katie@chromium.org> > Commit-Queue: Zach Helfinstein <zhelfins@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580321} Bug: 864802 Change-Id: I653c8965a0361d46fc701d6b9b648006d035b82e Reviewed-on: https://chromium-review.googlesource.com/c/1347689 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#611894}
-
Jay Harris authored
This stops the LocationIconView InkDrop from getting reset if LocationIconView::Update is called while the InkDrop is animating. Note: This issue doesn't seem to affect the LocationBarView, only the CustomTabBar being introduced in CL: 1328084 Bug: 853593 Change-Id: I3ab4045c7a8d0db88a069f1d35d9763c9c8594f1 Reviewed-on: https://chromium-review.googlesource.com/c/1338579Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#611893}
-
Jonathan Ross authored
TestRunnerBindings::SetBackingScaleFactor allows our test suites to simulate device scale factor changes. Currently it caps the scale factor at 100x, based on previous crashes seen in https://crbug.com/899482 However we hit similar crashes for lower scale factors when working with larger initial sizes. In this fuzz case 800x600 size, but a scale request of 1x10^17. There are a few different potential crashes as a result: - 100x = gfx::Size::GetCheckedArea overflows int (80000x60000) - 50x = GLES2DecoderImpl::TexStorageImpl fails with "dimensions out of range" - 20x = GL ERROR :GL_OUT_OF_MEMORY - 19x = no error I've elected to go with 15x. However there is nothing explicit in this API to prevent similar crashes when using larger sized surfaces. No displays currently use scale factors this large, so there is no issue to be concerned of in production. Bug: 900271 Change-Id: Icd0f75813b07f98bc51c56535000f2513cbceaa1 Reviewed-on: https://chromium-review.googlesource.com/c/1352612Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#611892}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8061053b73e2..1a2476d29456 git log 8061053b73e2..1a2476d29456 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 michaelludwig@google.com Revert "Initial definition of fill rect op" 2018-11-28 scroggo@google.com Build Android Framework host library on Mac 2018-11-28 michaelludwig@google.com Initial definition of fill rect op 2018-11-28 kjlubick@google.com [canvaskit] support globalAlpha and dashed strokes 2018-11-28 bsalomon@google.com Remove SkCanvas::ImageSetEntry constructors 2018-11-28 herb@google.com Remove unneeded inline declarations 2018-11-28 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 3b003a51bc9a..79d0e565b001 (1 commits) Created with: gclient setdep -r src/third_party/skia@1a2476d29456 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/118742766 TBR=borenet@chromium.org Change-Id: I16c7f3b1a0e171c9c787fd592844698d1a6614e9 Reviewed-on: https://chromium-review.googlesource.com/c/1354242Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611891}
-
siyua authored
Previously was blocking web contents. Bug: 897998 Change-Id: Ic55d445d396c2ae172c8fff8baec9dba84a663be Reviewed-on: https://chromium-review.googlesource.com/c/1351260Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Siyu An <siyua@chromium.org> Cr-Commit-Position: refs/heads/master@{#611890}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/dad75d09..6acd03c9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7411c73a9357b69d3661e71c560a794726c6dbc7 Reviewed-on: https://chromium-review.googlesource.com/c/1354234Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611889}
-
Peter Wen authored
Create styleguide_python and add myself. Bug: None Change-Id: Idb174184d4b4f5214423a0d1f5bea88dacb34505 Reviewed-on: https://chromium-review.googlesource.com/c/1354325Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#611888}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fd13c06f14de..c959e1230546 git log fd13c06f14de..c959e1230546 --date=short --no-merges --format='%ad %ae %s' 2018-11-28 hjd@google.com Merge "perfetto-ui: Update events in record page" Created with: gclient setdep -r src/third_party/perfetto@c959e1230546 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: If00050bbb8048d81aedf4b7d1fc20489eb88f48d Reviewed-on: https://chromium-review.googlesource.com/c/1354241Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#611887}
-
Kayce Basques authored
Bug: 909808 Change-Id: I6c93692b6700dd54331df4c22323f5a581ddd264 Reviewed-on: https://chromium-review.googlesource.com/c/1353951 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611886}
-
Zhongyi Shi authored
Change MigrationBeforeHandshake2 to track explicitly labeled retried connection. ConnectionOnNonDefaultNetwork will track those connection that started on the default network but network change is encountered during connection setup. Additionally, add two more histograms - MigrationBeforeHandshakeFailedReason will track the net error code returned when an error is encountered by the new connection on the alternate network; - NetworkChangeDuringMigrationBeforeHandshake will track how often the default network is changed during migration before handshake. Bug: 790547 Change-Id: I3ebd0e6a05a1a56d45326917f341095594333564 Reviewed-on: https://chromium-review.googlesource.com/c/1352749Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#611885}
-
Karandeep Bhatia authored
This CL changes GeneratedBackgroundPageJob to not suspend file url requests when the system suspends. There is no reason to suspend requests which don't require network activity. This helps solve bugs where extension event listeners are not registered as the request for extension background pages are aborted on system suspend. BUG=898494 Change-Id: I12c267322e28aee573c14160a91868b1cbec0a1b Reviewed-on: https://chromium-review.googlesource.com/c/1352443 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Cr-Commit-Position: refs/heads/master@{#611884}
-
Michael Spang authored
This enables GPU process VulkanSurfaces to present to Scenic views. Each surface sends a message to the browser over mojo asking to export a node to attach the surface resources to. Once this export occurs, the surface contents will be visible in the global scene. Bug: 861853 Test: run_content_shell \ --enable-features=VizDisplayCompositor,UseSkiaRenderer,UseSkiaDeferredDisplayList,UiGpuRasterization,OzoneDrmMojo --enable-oop-rasterization --enable-vulkan --enable-gpu-rasterization \ --enable-raster-to-sk-image --use-raster-context-provider \ --force-gpu-rasterization --use-gl=swiftshader --no-sandbox \ --disable-gpu-sandbox Change-Id: Ib39c7f2a6bcb833fbd2cd3e0718229efb69ca940 Reviewed-on: https://chromium-review.googlesource.com/c/1343277Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#611883}
-
Kayce Basques authored
Bug: 907621 Change-Id: I543e58a273ab502f3526a7ac03d049c51cb4e50c Reviewed-on: https://chromium-review.googlesource.com/c/1347448Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Hayato Ito <hayato@chromium.org> Commit-Queue: Kayce Basques <kayce@chromium.org> Cr-Commit-Position: refs/heads/master@{#611882}
-
Dave Tapuska authored
Add state to support pausing a web audio device such that it can be restarted when the frame is returned to be visible. BUG=907125 Change-Id: I01aef9c19c81e35e68ee1e299e16cd6c9946ebde Reviewed-on: https://chromium-review.googlesource.com/c/1344265Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Rick Byers <rbyers@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#611881}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I862c7162f8ce785e3533bb5869050b9047ffd317 Reviewed-on: https://chromium-review.googlesource.com/c/1352753 Commit-Queue: mark a. foltz <mfoltz@chromium.org> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#611880}
-
Ken Rockot authored
This reverts commit 17b07c4c. Reason for revert: Breaking chromeos_unittests, see https://crbug.com/909883 Original change's description: > [CrOS MultiDevice] Fix crash in BleConnectionManagerImpl. > > When a SecureChannel disconnects due to authentication failures, > BleConnectionManagerImpl invokes the relevant failure callback, which > then causes ConnectionAttemptBase to cancel the connection attempt. > > When the attempt is cancelled, the SecureChannel object is deleted via > BleConnectionManagerImpl::ProcessPotentialLingeringChannel(), but > BleConnectionManagerImpl::HandleSecureChannelDisconnection() assumed > that the object was still valid and tried to to remove itself as an > observer, causing a segfault. > > The fix is to check whether the object has been deleted before > attempting to call RemoveObserver(). > > Bug: 905904 > Change-Id: Ic593ef4047ff481e218c89028324eb0863131cdc > Reviewed-on: https://chromium-review.googlesource.com/c/1352855 > Reviewed-by: Ryan Hansberry <hansberry@chromium.org> > Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611781} TBR=khorimoto@chromium.org,hansberry@chromium.org Change-Id: I575b604a98318f778cd1f7d93c31e14806da2e3f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 905904 Reviewed-on: https://chromium-review.googlesource.com/c/1354327Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#611879}
-
Troy Hildebrandt authored
Adds a ProtoDatabaseProvider(Factory) to provide ProtoDatabases with the user directory, with ProtoDatabaseProvider as a BrowserContextKeyedService. Since ProtoDatabase is just an interface, and the underlying implementation of it can vary from client to client, a ProtoDatabaseWrapper that contains a pointer to a ProtoDatabase is created, also built off ProtoDatabase. Modifies the Feature Engagement Tracker to use the new provider for its two databases. Bug: 870813 Change-Id: I26376a14e8280605b7e3431862e5fe3ad6b9c8db Reviewed-on: https://chromium-review.googlesource.com/c/1318053Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Troy Hildebrandt <thildebr@chromium.org> Cr-Commit-Position: refs/heads/master@{#611878}
-
Ethan Xu authored
This is the second CL for web share target V2. The goal of this CL is to implement the new web share target launcher according to the new web share target spec. https://pr-preview.s3.amazonaws.com/ewilligers/web-share-target/pull/53.html#launching-the-web-share-target There're three main parts of this CL that are put together: 1) Parse the fields received from the android manifest on the server-side 2) Perform the files-matching, which involves matching the share files with with share target files entries that accept the same mime type. 3) Launch the web share target. Specifically, this involves the additional step of generating the POST request. There're two possible encoding types for the POST request: Multipart/form-data encoding and application/x-www-form-urlencoded, both of which are implemented inside a new file named webapk_post_share_target_navigator.cc. It performs all the encoding/escaping needed for the two encoding methods. One additional function is added to mime_util.cc in order to support the multipart/form-data POST request. Change-Id: I719af0dc33fe64561963ae9aecc9d01192f1c17a Reviewed-on: https://chromium-review.googlesource.com/c/1271776 Commit-Queue: Ethan Xu <xuethan@google.com> Reviewed-by:
Bence Béky <bnc@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#611877}
-
Ted Choc authored
The underlying problem is how Chrome determines what action mode should be shown on long press. If you long press on whitespace, then just the paste popup is shown. If you long press on text, then cut/copy/paste is shown. On these test devices, it simply happened to touch on whitespace where other devices would touch on the text based on the offsets calculated. This changes the bulk of the tests to not have whitespace at all to avoid this. For testLongPressInputWhileComposingText, it just makes the first portion of the text very long to avoid the mismatch (not fool proof, but better). BUG=907573 Change-Id: I87fabd8d6fcc8a532976e2abe028e60664e3c7f5 Reviewed-on: https://chromium-review.googlesource.com/c/1353953Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#611876}
-
Drew Davenport authored
Disabling this prevents drawing the UI in the corner of an external display at the internal display's size when closing the lid. This makes the transition in this use case smoother, and also avoids displaying uninitialized framebuffer contents on some gpus. BUG=898524 Change-Id: Id23ef472ad7d7504c74644bd11186a4380e36f13 Reviewed-on: https://chromium-review.googlesource.com/c/1352709Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: Drew Davenport <ddavenport@chromium.org> Cr-Commit-Position: refs/heads/master@{#611875}
-
Eric Roman authored
After I changed the bypass policy for localhost, this test stopped routing through proxy. Bug: 901896 Change-Id: I5f604865b60837143e7b2bc00c3dcbc9971c70c3 Reviewed-on: https://chromium-review.googlesource.com/c/1351145Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#611874}
-