- 03 Nov, 2020 40 commits
-
-
Joel Hockey authored
FileManager UITests fail when native HTML Imports are disabled. Serve the test files from the embedded test server to make the HTML imports polyfill on the UITest test.html page work. The tests now pass when HTML imports are disabled. All console errors about Polymer not working are gone. The Visual Signals xf* files 404 off the embedded test server but the UITests still PASS. Test: browser_tests --gtest_filter="FileManagerUITest*" Bug: 1111393 Change-Id: Iec0133c61b7296ced6bb01fb740e1667b9aa8d0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515379 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823401}
-
Hiroki Nakagawa authored
Reland "NoStatePrefetch: Rename chrome/browser/prerender/ to chrome/browesr/prefetch/no_state_prefetch/" This is a reland of 8436de62 The previous CL was reverted because unluckily conflicting CL that refers to a pre-moved header file was landed before the CL. This reland CL fixes it. Original change's description: > NoStatePrefetch: Rename chrome/browser/prerender/ to chrome/browesr/prefetch/no_state_prefetch/ > > This is mechanical rename other than changes in OWNERS and > flag-metadata.json. > > Change-Id: I9020d87a81ccad25aaa1ac5881f8cfdb52cce25f > Bug: 1144577 > Tbr: fgorski@chromium.org > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512486 > Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> > Reviewed-by: Robert Ogden <robertogden@chromium.org> > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823349} Bug: 1144577 Change-Id: I82417260cfcf0ecda944d31e1901d25e542f4a2f Tbr: fgorski@chromium.org, robertogden@chromium.org, ryansturm@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515420Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#823400}
-
Lan Wei authored
When we are using Chromedriver ExecutePerformActions to simulate three mouse click, it should set the mouse click count to 3, but if we keep clicking, the click count should keep increasing on Windows and Mac, reset to 1 otherwise. It should keep the mouse click count and decide if we should increase the count or set to 1 when we have a mouse press based on the interval of two mouse presses and difference between the current mouse positions and the last one. I added three more tests to verify these cases. Bug: 1119679 Change-Id: I6f628e625e680870a77e18495eb0b4fab024fbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508987Reviewed-by:
Shengfa Lin <shengfa@google.com> Commit-Queue: Lan Wei <lanwei@chromium.org> Cr-Commit-Position: refs/heads/master@{#823399}
-
Ian Struiksma authored
Test cc had date of 10/2020, which means it expired. Setting exp year to use test::NextYear() so test can proceed. Bug: 1144598 Change-Id: I018787f8003f3d48a0d56715a613163ae7c3158d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515263Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#823398}
-
dpapad authored
- Remove |deps| field from js_modulizer() definition. - Spit js_modulizer() targets with deps to two separate targets, one js_modulizer() and one group() target. - Change js_library() targets to only depend on "modulize_local" targets. Bug: None Change-Id: Ifb0ed2344f3ecc9e6699f88fc0676d339b2d3424 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514071 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#823397}
-
Clark DuVall authored
This also prints the parent ClassLoaders, to see if there is differences there too. Bug: 1142589 Change-Id: Ib8933bba6ce6bc66883a2bc88bee208383e41dcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514591 Auto-Submit: Clark DuVall <cduvall@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823396}
-
Nicolas Ouellet-Payeur authored
Bug: 1144907 Change-Id: I5c66ef7b869ada7603fbc7e15c20007c078bb0d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515044 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Yao Xiao <yaoxia@chromium.org> Auto-Submit: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Yao Xiao <yaoxia@chromium.org> Cr-Commit-Position: refs/heads/master@{#823395}
-
Shik Chen authored
The size limit optimization only applies for fragemented MP4. Chrome needs the whole file of a non-fragemented MP4 to be able to play it. Bug: 1140852 Test: Record a video and check the thumbnail manually. Change-Id: I3f4d6d7c317c21203761372265b7283bac4734f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513415 Auto-Submit: Shik Chen <shik@chromium.org> Commit-Queue: Inker Kuo <inker@chromium.org> Reviewed-by:
Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#823394}
-
Mike Wittman authored
This reverts commit 440bbbe7. Reason for revert: causing crashes seen in https://crbug.com/1144621 Original change's description: > [Sampling profiler] Restore callee-save registers in V8 unwind > > Restore the callee-save registers now provided in the V8 API when > unwinding. This is a necessary condition to support unwinds of > functions that use dynamic stack allocation, which is failure mode > 1 in the corresponding bug. > > Bug: 1122124 > Change-Id: Ifb30bbdd9df343251a7c215e5a5fc140754ac216 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500453 > Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org> > Commit-Queue: Mike Wittman <wittman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#822204} TBR=wittman@chromium.org,etiennep@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1122124, 1144621 Change-Id: I0e998ab210537a513cfc9a67d5e632b2aa73d9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515202Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#823393}
-
Nancy Wang authored
AppServiceAppIconLoader could call LoadIcon multiple times, because the icon image is updated for each scale. Waiting icon update once might cause the AppServiceAppIconLoader is destroyed before the icon loading process is finish, so it might cause below error: [app_service.mojom.cc(1174)] Check failed: !connected. AppService::LoadIconCallback was destroyed... This CL modifies the expected icon update count to wait the icon loading process finish to avoid AppServiceAppIconLoader to be destroyed early. BUG=1124972 Change-Id: Id7efc80d14ac1a0f6e4cfbe77223256922898599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2494215 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#823392}
-
David Jacobo authored
Previous CLs got rid of this flag in code as it was expired, this CL only removes said flag from the flag-metadata file that keeps track of flags and their milestones. Bug: None Test: build. Change-Id: I476bf49ad50b189d05c919883052202f80327b56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515180 Commit-Queue: David Jacobo <djacobo@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: David Jacobo <djacobo@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#823391}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: I68f4d928659f3366732c12dd45fc36200a714130 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514374Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823390}
-
Will Cassella authored
This CL extends the expiration of the 'turn-off-streaming-media-caching-always' and 'turn-off-streaming-media-caching-on-battery' flags to m89 in order to support the run of the corresponding finch trial. Bug: 984851 Change-Id: Ib2f2e43b292cbf0d333558f8f47ecbb1db4a3928 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514804Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#823389}
-
Scott Violet authored
This removes adding the qualifier PageTransition.FROM_API for TabLaunchTypes of FROM_LINK and FROM_RESTORE. I believe this was unintentional, and doesn't make sense to use FROM_API with. This also removes FROM_API for intents that came from chrome and launched chrome. Again, seems like we shouldn't use FROM_API for this scenario either. I came across this while doing the other patches. AFAIK nothing depends upon this, just seems worth cleaning up. BUG=none TEST=none Change-Id: Id89fbc0e70fb52a662ac33a55d269460677ee152 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511853 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#823388}
-
Leo Zhang authored
Let user enable IME mojo decoder from chrome://flags. BUG=b/171846787 Change-Id: Ie101b36d3b8bf64695039992b2aac108be6c69cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2509150Reviewed-by:
Darren Shen <shend@chromium.org> Reviewed-by:
Leo Zhang <googleo@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#823387}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/eaf1c53544a7..959f41988a18 2020-11-02 capn@google.com Set the LLVM module's target triple If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I90dc4e63d9b30f25f3c32c44f2dc9d43b71bdd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514641Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823386}
-
Joon Ahn authored
This CL focuses on separating out the suites and setting up unified testing, without any optimization to tests themselves. Obvious unused headers were removed. Bug: 1059779 Test: browser_tests --gtest_filter=Scanning* Change-Id: I4898564e15777fa0bc1d1d0fa5d8581ea5eb235d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514080 Commit-Queue: Joon Ahn <joonbug@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#823385}
-
Evan Stade authored
CastOptionsProvider is moved back into //chrome and Chrome's base java module. A copy is also made for WebLayer shell. Bug: 1144240 Change-Id: Ieed443a573ef8c2361f48dd4915a92569dd5a9e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512808 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#823384}
-
Daniel Rubery authored
The previous metric in this space, SafeBrowsingBinaryUploadRequest.AdvancedProtectionScanVerdict was removed by https://crrev.com/c/2505943, so take this opportunity to re-implement it in a slightly more robust way, based on the trigger rather than inspection of the Request. Change-Id: Ib5418d3cba4eadb110503ca48d81aff7fe2e78aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506572Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#823383}
-
Tibor Goldschwendt authored
Fixed: 1140261 Change-Id: I3048004ebe36c0562028f2034d94bf4245736e8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510715 Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#823382}
-
chrome://downloadsJames Cook authored
Clicking on an item in the download shelf or in chrome://downloads attempts to open it in the OS-native application for that file type. For example, it might open a video player or image viewer. This needs to be handled by ash, so wire it through the crosapi::mojom::FileManager API. In the future we will need to show error messages for files that fail to open. The new methods return a result enum. We also need this for the existing ShowItemInFolder method, so deprecate the old one and introduce an updated version. This implementation isn't perfect. In some cases the file should be routed back to the browser for display in a tab. Right now some files that can't be opened in an app end up opening in an ash-chrome tab. In the future we will need to wire up the ash file_manager code to make "open in browser" redirect back to lacros-chrome. Bug: 1141616 Test: added to lacros_browser_tests Change-Id: I8cd4166bc594bf83a3ce9458d7c1d767bbb8c041 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511589 Auto-Submit: James Cook <jamescook@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823381}
-
Zhaoyang Li authored
Move some private methods of Xcode(11)LogParser to public, and call these at tear down of test_runner module for GTests running as XCTests. To avoid duplicate logic where touched, this change also: - Added using_xcode_11_or_higher() to xcode_util module. - Added get_parser() to xcode_log_parser module. - Renamed coverage_util to file_util and added in an archiving utility. Bug: 1047704 Change-Id: Id66ebd7a4ca1b2f7ea494eda66c015240f581c13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496345 Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#823380}
-
Meredith Lane authored
This reverts commit 530c8fd2. Reason for revert: caused tree closer due to missing mojom file: https://ci.chromium.org/p/chromium/builders/ci/chromeos-arm-generic-rel/39820? Original change's description: > [Media Session] Convert interface from mojo to CPP > > Context: https://crrev.com/c/2485850 > > This converts the MSS interface to CPP since it does > not need to be mojo. > > BUG=1140215 > > Change-Id: I595bef21cddf755bc0fb423f87db9e620227d3e6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503393 > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823358} TBR=avi@chromium.org,xiyuan@chromium.org,dcheng@chromium.org,beccahughes@chromium.org Change-Id: I729b898ef30c220c779be615b0b6eb6abf8cfed5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1140215 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515502Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#823379}
-
Renjie Tang authored
This is part of the base::Callback migration. Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40 Bug: 1007792 Change-Id: I16c66d31f3c95b179288d2586682d981d0b4f7a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505946 Commit-Queue: Renjie Tang <renjietang@chromium.org> Auto-Submit: Renjie Tang <renjietang@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#823378}
-
Meilin Wang authored
Previously if user revokes the notification access they granted earlier from the phone, notification set up UI cannot show up again unless you close and reopen the bubble. This CL fixes this by observing the change of notification access and update the view's visibility accordingly. BUG=1141610, 1106937 TEST=unittested. Change-Id: Ife8f19e7e5b8c2ec9ea12a7cc9e0e2cc739af72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508398 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#823377}
-
Joel Hockey authored
*.trashinfo files require 2 async operation to first create the file, and then write to it. This can cause issues if removeOldFiles_() is running concurrently. Hopefully this fixes test flakes. Bug: 953310 Change-Id: Ib6d192122a97f956ba79ec11a8f5e099f4d418c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515499 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#823376}
-
Liquan (Max) Gu authored
Context: Before, we planned to remove ChromePaymentRequestService completely, so we created PaymentRequestLifecycleObserver in order for PaymentRequestService to call into PaymentUiService directly. Now that we believe that ChromePaymentRequestService will keep existing as a glue between the UI service and the PRService, the observer becomes unnecessary. Changes: * Removed PaymentRequestLifecycleObserver as a middle man between PaymentRequestService and PaymentUiService; changed to use ChromePaymentRequestService as a middle man instead. * Created PaymentUiService#close() to encapsulate the closing logic. Bug: 1144527 Change-Id: Ib87234e6d2ed98d68586983da9779ba74a62abaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514481 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823375}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dffd20efe95c..753c1b336802 2020-11-02 csmartdalton@google.com Add helpers to GrPathUtils for converting lines and quads to cubics 2020-11-02 robertphillips@google.com Fill in the GrTriangulatingPathRenderer::onPrePrepareDraws 2020-11-02 johnstiles@google.com Replace ProgramElement dehydrated count with an elements-done command. 2020-11-02 csmartdalton@google.com Add GrVx.h 2020-11-02 johnstiles@google.com Add test cases to function-prototype golden outputs. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: bsalomon@google.com Change-Id: I8f2049007d8d2202d4e7a2e8214c2bddf2db2f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514239Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823374}
-
Danan S authored
It wasn't shown because the online screen is the default currentScreen value. Bug: 1123218,1143409 Change-Id: I6f881115a0ae9e9f38c8cd17bd9fbad8c4ed0cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505942 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#823373}
-
Meredith Lane authored
This reverts commit df9e203b. Reason for revert: Suspected culprit of tree closer on win-asan: https://ci.chromium.org/p/chromium/builders/ci/win32-archive-rel/17873? Original change's description: > Only pass executable sections to OnDllLoaded for patching > > On recent Windows insider builds GetModuleHandleExW loads sections for > inspection as non-executable images, rather than as files. This leads > to our hooks detecting the SEC_IMAGE attribute and potentially patching > functions (e.g. for user32.dll). > > This caused content_browsertests to fail as it pinned user32.dll in some > processes. With this change, the tests run again. > > See crbug.com/1143397 for a full discussion. > > Bug: 1143397 > Change-Id: I3b75464d0442160a417e4cb7084306841aaf76f7 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511531 > Reviewed-by: Will Harris <wfh@chromium.org> > Commit-Queue: Alex Gough <ajgo@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823354} TBR=wfh@chromium.org,ajgo@chromium.org Change-Id: Ia164ea218daf7771f025dfa57a3a4bf25c41eac2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1143397 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515501Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#823372}
-
Adam Rice authored
The web platform test xhr/responsexml-document-properties.htm is flaky. Mark it as such in TestExpectations. BUG=1144537 Change-Id: Ic7de8bb61f7646127c4094a9f88c066895189b6a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515419 Commit-Queue: Adam Rice <ricea@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#823371}
-
Max Curran authored
state of Translate. At the beginning of a page load, Translate looks at many different signals to determine if: 1) the page should automatically be translated, 2) the translate UI should be shown, or 3) nothing should be done related to translate. These new metrics record which signal caused the initial state (called trigger decision). In the event that multiple signals were true, only the first value is recorded. Full design doc: https://docs.google.com/document/d/1dyWh1Xw5VgUA00VA-5PTgKQ6ItziPBnSyeDR8saJ9vM/edit?usp=sharing More details on trigger decision: https://docs.google.com/document/d/11TJqU_YyJoxJE1huEqKECBa_OZ05O4WESXMJ2WeT4F0/edit?usp=sharing Bug: 1114868 Change-Id: I48d296cacc157741124db09db166a253a95b37be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490676Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Scott Little <sclittle@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Max Curran <curranmax@chromium.org> Cr-Commit-Position: refs/heads/master@{#823370}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fcca1a51..037ccdfb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3f9f1d348ec888e1910effc13383b68a2acd81e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514621Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#823369}
-
Peter Kasting authored
Bug: 772945 Change-Id: I310fd814ff948e30d433de28fe83df206d7ecbd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508177 Commit-Queue: Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#823368}
-
Tommy Martino authored
This CL rolls DEPS to the latest version of text-fragments-polyfill, which fixes a few known issues: - Link generation should fail if the range includes a block boundary. - No highlight should be shown if the fragment is ambiguous (i.e., if it could correspond to multiple different places on the page). This version changes the return type of a util function we are using, so a small update to the Chromium-side JS is needed. (The function now returns a list of ranges, rather than a list of <mark>s, and Chromium is responsible for invoking the code to wrap these in <mark> tags.) Bug: 1136043 Change-Id: Icf9c79dc0d9b9fca23f2826438e3c17c07340bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511429Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#823367}
-
Eugene But authored
App used to crash because BreadcrumbPersistentStorageManager did not exist during synthetic crash report generation. This CL moves BreadcrumbPersistentStorageManager creation from ApplicationContextImpl::OnAppEnterForeground to ApplicationContextImpl::PreMainMessageLoopRun, so that Storage Manager is available in MobileSessionShutdownMetricsProvider::ProvidePreviousSessionData Bug: 1143779 Change-Id: I2673cdc0383a52b87b2e041d4413c9348f2f8b47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508636 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#823366}
-
Ana Salazar authored
Bug: 1123585 Change-Id: Ib78099d248720689054bb4d24c81bf2022af36bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510691Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#823365}
-
Chris Cunningham authored
We don't really care about the exact thread, so SingleThreadTaskRunner is too specific. The specific files migrated here are all in the tree of dependencies under webcodecs audio|video_decoder_broker. This allows a follow up CL to grab a random *offloading* SequencedTaskRunner from the pool in cases where the media thread is not available via GpuFactories(). Bug: 1095786, 1144329 Change-Id: I29332418fd11054b6b2fa63feb26e93401aeb0ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500424Reviewed-by:
Dan Sanders <sandersd@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Eugene Zemtsov <eugene@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#823364}
-
Yuchen Liu authored
This reverts commit 1eef2a38. Reason for revert: This causes screen flickering. We'll make a platform fix to handle the playback stall. Original change's description: > [Chromecast] Disable SurfaceControl and AImageReader for Android build > > For Q+ devices, SurfaceControl and AImageReader may cause some video > playback stall. Temporarily disable them. > > Bug: internal b/162803423 > Test: Bug is not repro > Change-Id: I4ce7e42fd87433464dfe4a6b29b816cb41ce7138 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493091 > Reviewed-by: Sean Topping <seantopping@chromium.org> > Reviewed-by: Frank Liberato <liberato@chromium.org> > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Commit-Queue: Yuchen Liu <yucliu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#820070} TBR=zmo@chromium.org,liberato@chromium.org,seantopping@chromium.org,yucliu@chromium.org,csbubbles@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: internal b/162803423 Change-Id: Icdf7b5ede25bdd9b3ae0062d23ee6b43b5c30c38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511752Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#823363}
-
My Nguyen authored
Adding flag to extension so we can direct users correctly when opening edit dictionary page. Bug: 1144084 Change-Id: I6b8993f5d5e466c57aa0cead209139c631f9c17b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513305 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#823362}
-