GitLab

In Chrome, it turns out that every Notification has a unique id. In the Ash implementation we need to track and update that id when an existing Bubble is updated.

This also ensures that the UI is safely created initially (in case the initial asynchronous Update is delayed) to prevent crashes and to make Layout more consistent.

Also includes some cleanup of the WebNotificationTray API.

BUG=141285


Review URL: https://chromiumcodereview.appspot.com/10855079

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150979 0039d316-1c4b-4281-b951-d872f2087c98

BUG=125846
TBR=ben@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10828247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150976 0039d316-1c4b-4281-b951-d872f2087c98

On Mac OS 10.8, opening a page on external monitor would cause the page to be rendered at the scale factor of the primary display.

The problem is in RenderViewHostImpl::CreateRenderView. It uses the view to calculate the display scale factor but this doesn't work because the view hasn't been added to a window yet.

My fix is to update the scale factor when -[RenderWidgetHostViewCocoa viewDidMoveToWindow:] is called. This CL also caches the scale factor.

Note, for some reason I can't reproduce the bug on 10.7. On 10.7 the scale factor is also incorrect but for some reason the page is displayed correctly. I'm not sure what's going on.

BUG=138039
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10837154

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96459


Review URL: https://chromiumcodereview.appspot.com/10827189

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150970 0039d316-1c4b-4281-b951-d872f2087c98

Store the histogram name in the local variable for debugging purposes when we crash.

R=jar
TBR=jam
BUG=140688
TEST=base (histogram unit tests) and unit_tests.
Review URL: https://chromiumcodereview.appspot.com/10831247

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150969 0039d316-1c4b-4281-b951-d872f2087c98

Maybe due to hans de-inlining functions:
http://codereview.chromium.org/user/hans

TBR=tonyg,cmp
BUG=141783

Review URL: https://chromiumcodereview.appspot.com/10824249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150967 0039d316-1c4b-4281-b951-d872f2087c98

BUG=94925
TBR=cmp

Review URL: https://chromiumcodereview.appspot.com/10827269

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150966 0039d316-1c4b-4281-b951-d872f2087c98

R=gbillock@chromium.org
NOTRY=True

Review URL: https://chromiumcodereview.appspot.com/10834174

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150965 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140828


Review URL: https://chromiumcodereview.appspot.com/10827264

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150963 0039d316-1c4b-4281-b951-d872f2087c98

BUG=141386

Review URL: https://chromiumcodereview.appspot.com/10855090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140828


Review URL: https://chromiumcodereview.appspot.com/10832231

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150960 0039d316-1c4b-4281-b951-d872f2087c98

This should fix test failures on windows bots caused by crrev.com/150946

TBR=dmichael@chromium.org

Review URL: https://chromiumcodereview.appspot.com/10825289

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150959 0039d316-1c4b-4281-b951-d872f2087c98

BUG=6944
TEST=sbox_integration_tests
Review URL: https://chromiumcodereview.appspot.com/10837151

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150957 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140306
Tested: Added new browser tests!

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=150654

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150863

Review URL: https://chromiumcodereview.appspot.com/10830072

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150956 0039d316-1c4b-4281-b951-d872f2087c98

Eliminate some memory leaks.

BUG=139709
TEST=ran layout tests.


Review URL: https://chromiumcodereview.appspot.com/10824101

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150955 0039d316-1c4b-4281-b951-d872f2087c98

This change makes HitTest more general by allowing hit tests on rects. Hit testing on a point can be done by calling View::HitTestPoint, which calls View::HitTestRect with a rect of width and height 1.
Since gesture events can now store a bounding box to represent the area of the gesture
rather than just a single point, this change is needed for the implementation of 
gesture target fuzzing in views (https://chromiumcodereview.appspot.com/10790019/).

BUG=129794

Review URL: https://chromiumcodereview.appspot.com/10827198

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150954 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jennyz@chromium.org
BUG=141744

Review URL: https://chromiumcodereview.appspot.com/10832238

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150953 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org

BUG=none

Review URL: https://chromiumcodereview.appspot.com/10831250

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150951 0039d316-1c4b-4281-b951-d872f2087c98

Over the last week (or so) a couple of CLs had to be reverted because developers had not tested win_aura, specifically:
 1. The default trybot rules don't include win_aura in enough cases
 2. The CQ did not build win_aura

BUG=141701
TBR=sky

Review URL: https://chromiumcodereview.appspot.com/10831242

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150950 0039d316-1c4b-4281-b951-d872f2087c98

Includes a unit test to exercise this functionality.

BUG=138384
TEST=Ensure that Chrome makes an HTTP request to the Variations server when it receives an auto update.


Review URL: https://chromiumcodereview.appspot.com/10790116

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150949 0039d316-1c4b-4281-b951-d872f2087c98

in the gpu process crashes.

BUG=none
R=apatrick
Review URL: https://chromiumcodereview.appspot.com/10837196

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150947 0039d316-1c4b-4281-b951-d872f2087c98

BUG=139965

Review URL: https://chromiumcodereview.appspot.com/10823187

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150946 0039d316-1c4b-4281-b951-d872f2087c98

Add --local-server-port option that allows CNS to serve files from different server port.
This allows us to serve files from an available local Apache port.


BUG=140594


Review URL: https://chromiumcodereview.appspot.com/10824173

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150944 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chrome-os-partner:11070

Review URL: https://chromiumcodereview.appspot.com/10834249

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150943 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150942 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://chromiumcodereview.appspot.com/10855089
Patch from Armand Navabi <navabi@chromium.org>.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150940 0039d316-1c4b-4281-b951-d872f2087c98

BUG=138775
TEST=Visual


Review URL: https://chromiumcodereview.appspot.com/10827253

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150939 0039d316-1c4b-4281-b951-d872f2087c98

Refactor CPM events to have a single JSON event for all extension-related
events; change EVENT_UNLOAD to EVENT_DISABLE (easier to understand, inline with
EVENT_ENABLE); clean up PerformanceMonitor::Observe.

BUG=130212

Review URL: https://chromiumcodereview.appspot.com/10837003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150938 0039d316-1c4b-4281-b951-d872f2087c98

BUG=140417
TEST=units, out/Debug/chrome --disable-seccomp-sandbox --parallel-auth --login-manager --login-profile=user --log-level=0 --enable-logging=stderr --no-first-run --user-data-dir=/tmp/user --in-chrome-auth --scroll-pixels=3 --enable-smooth-scrolling --force-compositing-mode --force-device-scale-factor=2 --load-2x-resources

Review URL: https://chromiumcodereview.appspot.com/10829166

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150937 0039d316-1c4b-4281-b951-d872f2087c98

This affect startup sequences only. 

BUG=134430
TEST=The dialog on win8 should appear without the main window.  If the user chooses not to make Chrome default, it should continue to desktop Chrome. 


Review URL: https://chromiumcodereview.appspot.com/10696093

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150936 0039d316-1c4b-4281-b951-d872f2087c98

This resolves an issue where we were calling GetEntropySource too early before MetricsService::Start was called. Instead of checking the reporting_active member in MetricsService, we instead just check if the criteria for metrics reporting is allowed or not, ahead of time.

BUG=141628


Review URL: https://chromiumcodereview.appspot.com/10830241

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150934 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://chromiumcodereview.appspot.com/10855038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150931 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110228

Review URL: https://chromiumcodereview.appspot.com/10825280

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150930 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/10827263

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150929 0039d316-1c4b-4281-b951-d872f2087c98

related to how a flag was persisted.

BUG=141081,141643


Review URL: https://chromiumcodereview.appspot.com/10854069

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150928 0039d316-1c4b-4281-b951-d872f2087c98

BUG=127323
TEST=New test


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150420

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=150725

Review URL: https://chromiumcodereview.appspot.com/10825210

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150927 0039d316-1c4b-4281-b951-d872f2087c98

The NaCL SDK builds this code with -Wswitch-enum -Werror so
this is failing to build.

Perhaps in light if this its best to just remove the default
case?

BUG=


Review URL: https://chromiumcodereview.appspot.com/10855056

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150926 0039d316-1c4b-4281-b951-d872f2087c98

Changes to the annotator required launching the script differently.

BUG=none
TEST=nacl mono buildbots

Review URL: https://chromiumcodereview.appspot.com/10829266

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150925 0039d316-1c4b-4281-b951-d872f2087c98

The UI string should reflect the true nature of the date. The date is in fact when the Chrome OS image is built, not when it is installed on the device.

BUG=132561
TEST=locally verified on lumpy.


Review URL: https://chromiumcodereview.appspot.com/10824214

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150924 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ben@chromium.org
BUG=none

Review URL: https://chromiumcodereview.appspot.com/10826237

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@150923 0039d316-1c4b-4281-b951-d872f2087c98