GitLab

Fix a suppression and remove one that duplicates it.
Widen a suppression
Add a bunch of new suppressions.

BUG=11333,21137,21279,21280,20580,21286
TEST=More green on the Mac valgrind bots.

Review URL: http://codereview.chromium.org/197043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25645 0039d316-1c4b-4281-b951-d872f2087c98

* Uses the awesome ChromeUILocalizer infrastructure.
* Also solves the issue of hard coded prodcut names.

BUG=19160,19651,19176
TEST=First run dialog + it's progress dialog should now say "Chromium" instead of "Google Chrome".

Review URL: http://codereview.chromium.org/199035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25644 0039d316-1c4b-4281-b951-d872f2087c98

BUG=19483
TEST=none

Review URL: http://codereview.chromium.org/193033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25643 0039d316-1c4b-4281-b951-d872f2087c98

Fix compile error in serializer.cc
Don't force rebuild of idl files.
Review URL: http://codereview.chromium.org/195023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25642 0039d316-1c4b-4281-b951-d872f2087c98

Update a bunch of test_expectations for xmlhttprequest tests with data from layout test dashboard.  This addresses the cases of unnessary expecations, either tests that have expectations but have passed the last 200 runs or tests that have an extra expectation from the past 200 runs.

TEST=running through layout test try servers
BUG=
Review URL: http://codereview.chromium.org/197033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25640 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/201046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25639 0039d316-1c4b-4281-b951-d872f2087c98

The histograms will be more accurate after this change.

TEST=none
BUG=20335

Review URL: http://codereview.chromium.org/192038

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25638 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985
TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html

Review URL: http://codereview.chromium.org/192040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25636 0039d316-1c4b-4281-b951-d872f2087c98

support explicit positioning of the tooltip as windows does. That'll
have to be added later.

BUG=none
TEST=make sure tooltips still work correctly on windows

Review URL: http://codereview.chromium.org/197031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25635 0039d316-1c4b-4281-b951-d872f2087c98

R=agl

Review URL: http://codereview.chromium.org/200033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25634 0039d316-1c4b-4281-b951-d872f2087c98

How do you guys feel about trying this pach for a few days?

The idea is to have devs that run their own build to help us test
wether or not we are having serious errors.

I'll monitor the crash server to see if we get crashes here

BUG=11908
TEST=none


Review URL: http://codereview.chromium.org/195020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25633 0039d316-1c4b-4281-b951-d872f2087c98

DefaultNPObject can derive from bases other than NPObject, allowing concrete NPObjects to choose their own NPObject subclass.
DefaultNPObject does not rely on virtual functions. See change to NPGetClass in np_class.h.

Removed count() from MockNPObject because I discovered gmock checks that no mock objects exist after a test completes anyway.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/196032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25632 0039d316-1c4b-4281-b951-d872f2087c98

Don't call PR_GetErrorText because it is deprecated.  Just
print the error code returned by PR_GetError.

Pass NULL to NSS_NoDB_Init.  (The argument is ignored.)

R=ukai
BUG=20787,20819
TEST=Chromium should work on Red Hat Enterprise Linux and CentOS that
have libnss3.so version 3.12.4.1 but libsoftokn3.so 3.11.4, which does
not support the sql: database format we're using.
Review URL: http://codereview.chromium.org/201036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25630 0039d316-1c4b-4281-b951-d872f2087c98

This allows the HTML5 DataTransfer effectAllowed and dropEffect properties to be set correctly in JS handlers, as per the HTML5 spec.
(The drag-dropeffect test isn't in WebKit yet -- it's part of a separate WebKit patch that's been in review for weeks.)
R=darin,pink
BUG=http://code.google.com/p/chromium/issues/detail?id=14654, http://code.google.com/p/chromium/issues/detail?id=20985
TEST=LayoutTests/fast/events/drag-dropeffect.html, LayoutTests/editing/pasteboard/files-during-page-drags.html
Review URL: http://codereview.chromium.org/174364

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25629 0039d316-1c4b-4281-b951-d872f2087c98

TEST=none
BUG=none
Review URL: http://codereview.chromium.org/197041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25628 0039d316-1c4b-4281-b951-d872f2087c98

Trouble was seen in r25602, r25601 and r25574 et. al. on the waterfall.

Review URL: http://codereview.chromium.org/199045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25627 0039d316-1c4b-4281-b951-d872f2087c98

BUG=21277
TEST=none
R=thomasvl


Review URL: http://codereview.chromium.org/200043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25626 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=eroman


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25625 0039d316-1c4b-4281-b951-d872f2087c98

This time really properly.

TEST=none
http://crbug.com/20347

Review URL: http://codereview.chromium.org/196019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25624 0039d316-1c4b-4281-b951-d872f2087c98

added infrastructure to better support events and cleaned up callback testing.

Review URL: http://codereview.chromium.org/192028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25623 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=dglazkov


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25622 0039d316-1c4b-4281-b951-d872f2087c98

correctly on an expose. This happened if between the time we told Gtk
we needed to paint and the time we got the expose event more paints
were scheduled. In this case, because we were double buffered, GTK
would clip to the original region we scheduled the paint for. The fix
is to turn off double buffering as we're double buffering ourself.

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/198036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25621 0039d316-1c4b-4281-b951-d872f2087c98

BUG=http://crbug.com/14903
TEST=Findbar icons should look more like windows, be properly themed.
Review URL: http://codereview.chromium.org/197040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25620 0039d316-1c4b-4281-b951-d872f2087c98

NO CODE CHANGE.

TEST=none
BUG=none


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25619 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25618 0039d316-1c4b-4281-b951-d872f2087c98

Final tweaks to download item look on OS X. It now looks pretty much like on windows and linux, but is drawn nearly completely with vectors.

Also fix the SkColor->NSColor conversion in the mac theme provider.

Also let status bubble text color be influenced by current theme.

BUG=18902,18438
TEST=Download items now look like on windows. Color of the main download item text should change with the theme. Also, the status bubble text now adapts to the theme, and themes that specify text colors can now successfully change the color of e.g. the text in tabs. Also check that the status text ("104.0/110 MB, 1 h 45 secs left") is elided at the right when it's too long.

Review URL: http://codereview.chromium.org/192033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25616 0039d316-1c4b-4281-b951-d872f2087c98

The resulting PDF file will now be passed to the browser and be saved as "chromium_printing_test.pdf" under current directory.

BUG=9847
TEST=printing on linux should now generate chromium_printing_test.pdf in download directory. Printing on Windows should still work.

Patch contributed by minyu.huang@gmail.com
Review URL: http://codereview.chromium.org/172115

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25615 0039d316-1c4b-4281-b951-d872f2087c98

Made a local run for 25 times, got no single failure.

BUG=http://crbug.com/21108
TEST=none

Review URL: http://codereview.chromium.org/200040

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25614 0039d316-1c4b-4281-b951-d872f2087c98

DevTools: provisional support for scopes of type 'Catch' introduced in v8 by http://codereview.chromium.org/202005

BUG=17229
Review URL: http://codereview.chromium.org/200039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25613 0039d316-1c4b-4281-b951-d872f2087c98

The spec says that calling realloc(ptr, 0) should free ptr
and return NULL.


BUG=none
TEST=none

Review URL: http://codereview.chromium.org/196041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25612 0039d316-1c4b-4281-b951-d872f2087c98

Moved versions of those files from sandbox/src/ to base/ (overwrite versions in
base/ to avoid 64-bit warning).
Removed 'sandbox' namespace, adapted other files as necessary.

BUG=8348
TEST=none
Original review URL: http://codereview.chromium.org/179039
Patch by rsteiner

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25611 0039d316-1c4b-4281-b951-d872f2087c98

BUG=20987,20985
TEST=none

Review URL: http://codereview.chromium.org/196003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25610 0039d316-1c4b-4281-b951-d872f2087c98

Refactor DOM storage to be more object oriented.  All the DOMStorageDispatcher hosts (which are each owned by one ResourceMessageFilter) for the same profile share a WebKit context, and each one of those contexts owns a DOMStorageContext.  The DOMStorageContext owns storage namespace objects which own storage area objects which wrap their WebKit counterparts.

Not only is this cleaner code wise and more efficient (we're not duplicating WebStorageNamespaces and Areas for each DOMStorageDispatcherHost) but this is necessary for events and locking.

TEST=none
BUG=none

Review URL: http://codereview.chromium.org/192003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25609 0039d316-1c4b-4281-b951-d872f2087c98

somewhat unfortunate, but we need to do this until we have a built-in feed
previewer.

R=mal
BUG=21238

Review URL: http://codereview.chromium.org/201044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25608 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/183008
Patch from tfarina.

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25607 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thomasvl
TEST=none
BUG=8630

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25606 0039d316-1c4b-4281-b951-d872f2087c98

TBR=thomasvl
TEST=none
BUG=none

Review URL: http://codereview.chromium.org/202006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25605 0039d316-1c4b-4281-b951-d872f2087c98

(and mark the ones that pass) in preparation for rebaselining.

TBR=asargent
TEST=none
BUG=8630

Review URL: http://codereview.chromium.org/199036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25604 0039d316-1c4b-4281-b951-d872f2087c98

This paves the way for some upcoming allocator improvements

BUG=none
TEST=none

Review URL: http://codereview.chromium.org/199041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25603 0039d316-1c4b-4281-b951-d872f2087c98

Most of these squash harmless compiler warnings but the custom_button.cc
change fixes a real problem with the accelerator key bitmask calculation
(+ preceeds << in terms of operator precedence)

The change to tab_strip.cc is ugly but it fixes the following error:

chrome/browser/views/tabs/tab_strip.cc: In member function
‘void TabStrip::StartRemoveTabAnimation(int, TabContents*)’:
chrome/browser/views/tabs/tab_strip.cc:201: error: assuming
signed overflow does not occur when assuming that
(X - c) > X is always false

As an added bonus, this makes the Linux shared build of toolkit_views
work too.

Review URL: http://codereview.chromium.org/199025

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@25602 0039d316-1c4b-4281-b951-d872f2087c98