- 22 May, 2019 40 commits
-
-
Henrique Ferreiro authored
As advised in [1], this CL ports calls to Foo::Create() factory functions to use MakeGarbageCollected<Foo> from //third_party/blink/renderer/core/dom/dom_exception.h. [1] https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/iJ1bawbxbWs/vEdfT5QtBg> Bug: 939691 Change-Id: Ic38e5f561a0aa1c4e8b476adbac47e0c09003bfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621165 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#662148}
-
Morten Stenshorne authored
Before we do "a lot of" work to check if we can use the cached fragment, check if we have one at all. Change-Id: I13662fbf2a1bd3b377ba91e9b345fd5093b060ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624328 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#662147}
-
Rune Lillesveen authored
Implemented behind a flag. The implementation currently doesn't apply the computed color-scheme to any rendering. Spec: https://drafts.csswg.org/css-color-adjust-1/#color-scheme-prop Intent to implement: https://groups.google.com/a/chromium.org/d/topic/blink-dev/xXVJlqlDL_k/discussion Bug: 939811 Change-Id: Ieec8eb247155c02f0df56a9c637a8e1486c0b404 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601255Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#662146}
-
danakj authored
The input_handler_manager_client.h file is not referenced anywhere so delete it instead of converting the use of base::Closure. R=tdresser@chromium.org Bug: 953861 Change-Id: I6ea873a66b5154f7f11a8353898b6549c6d32776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623454 Auto-Submit: danakj <danakj@chromium.org> Commit-Queue: Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#662145}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/afb8d5cdaead..04f39242c2ee git log afb8d5cdaead..04f39242c2ee --date=short --no-merges --format='%ad %ae %s' 2019-05-22 nisse@webrtc.org Delete no longer used windows helpers 2019-05-22 kron@webrtc.org Add RTP timestamp to contributing sources Created with: gclient setdep -r src/third_party/webrtc@04f39242c2ee The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I0c722d816f1cc8d7d77da481d84a12bdbf8a702b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624647Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662144}
-
Leon Han authored
We already have a mojom traits impl for the following typemap, "network.mojom.URLRequestBody=scoped_refptr<::blink::EncodedFormData>" but we missed calling SetBoundary() on the blink::EncodedFormData instantiated from the mojom wire data. This CL adds it. BUG=860403 Change-Id: Iabddc0b4602c102749090c0dc12ca031c3c7aea2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623821 Auto-Submit: Leon Han <leon.han@intel.com> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/233ebc8f..ebe38ca9 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ic64e759fbb35dafb9231d81974e09554b7dab65e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624605Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662142}
-
Robbie Gibson authored
This also undoes many of the moves from 1609915. It turned out that omnibox_icon_view should not be reused in the actual omnibox, so those files didn't need to be shared. Bug: 1622171 Change-Id: I1cb821e66f0f56f2008ca796912de12297386902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622845 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#662141}
-
Findit authored
This reverts commit 73e22231. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 662114 as the culprit for flakes in the build cycles as shown on: https://analysis.chromium.org/p/chromium/flake-portal/analysis/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vNzNlMjIyMzE0MTJiZWY1NzVjZmE1ZGNiZjY0ZGQ3ZTZhMzVjOTllOQw Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20TSan%20Tests/38797 Sample Failed Step: content_browsertests on Ubuntu-16.04 Sample Flaky Test: SignedExchangeSubresourcePrefetchBrowserTest/SignedExchangeSubresourcePrefetchBrowserTest.CORS/0 Original change's description: > CORS check for prefetched subresource signed exchanges > > Bug: 935267 > Change-Id: I453bec48331cdbc203f96ccd3c99168f2f1734d4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616937 > Commit-Queue: Tsuyoshi Horo <horo@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org> > Cr-Commit-Position: refs/heads/master@{#662114} Change-Id: I6ab6df81f0dd0e136e2e07f154f3ac9f26712ae3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 935267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624588 Cr-Commit-Position: refs/heads/master@{#662140}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/497593d547c3..354bf5128d91 Created with: gclient setdep -r src-internal@354bf5128d91 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: Iaf0e897c5e9e30ae38b2c38fbca4c892204374c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624355Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#662139}
-
Daniel Bratell authored
This should have no practical effect on current data but version numbers need to be sorted so that 1.12 is higher than 1.9 and the current code didn't do that. This is a reland of https://crrev.com/c/1605980 with a typo fixed. The initial patch tried to sort |vc_component_msvc_root| (a string) instead of the list |vc_component_msvc_contents|. Change-Id: I961a4e0d11c9e626e2890682f6bf416c8e7e9d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609831Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#662138}
-
Jit Yao Yap authored
Sync server-side changes from https://critique.corp.google.com/#review/244290147 to client. Bug: None Change-Id: Id6377e63ba66f2177a44d26462dd6d4506832482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624568 Auto-Submit: Jit Yao Yap <jityao@google.com> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#662137}
-
Rune Lillesveen authored
These tests rely on the forced lifecycle update after parsing finished, which we would like to get rid of. Bug: 742413 Change-Id: I2f1bb6f4efedd6bf48f903d48fc26344a60148ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624330Reviewed-by:
-
Denis Kuznetsov authored
New parameter for CRD remote command that would enable "terminate session upon user input" mode. Bug: 965039 Change-Id: I7626fb08d4e5fee1834637ebffb8e14b441da7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619801 Commit-Queue: Denis Kuznetsov <antrim@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#662135}
-
Pâris MEULEMAN authored
This CL creates a stub for the java |SigninManagerDelegate| interface and its android implementation |ChromeSigninManagerDelegate|. This interface will provide SigninManager.java with the //chrome level dependencies it currently has with the objective of componentizing SigninManager.java. This change and the next steps are detailed here: https://docs.google.com/document/d/18887XeZNJ9pmoTdJducssk5_yVU2CQ3EqaRFoMqWCCk/ Bug: 963400 Change-Id: I1886d6183433b3ecc277e1d3ad1b82248bb02330 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610071 Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Cr-Commit-Position: refs/heads/master@{#662134}
-
Matt Falkenhagen authored
The bug indicates we were using a scoped_refptr on the wrong thread, probably on the browser test's UI thread instead of IO. Try doing more work on the IO thread and enabling the test on Android. Bug: 720275 Change-Id: Iacb5956d239aa15ebcdafc4de089c348afa8eaed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621771 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#662133}
-
Maksim Ivanov authored
Remove referring to the non-existing observer "realmChanged_" from the "realm" property definition in offline-ad-login. This fixes the following warning printed by Polymer: [offline-ad-login::_observerEffect]: observer method `realmChanged_` not defined Bug: none Change-Id: I95cf1f56ca5a3fd8012b88d401e7f5ac270408de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623088Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#662132}
-
Maksim Ivanov authored
Fix the window.onerror handler, added by the Login Screen cr_ui.js code, to avoid throwing a new exception on its own. Before this CL, the onerror handler was written to assume that the |error| parameter is non-null and has the |stack| property. But in some cases this doesn't hold - there are some standard-defined cases when the |error| is passed as null, and the only passed information is |message|=="Script error." (for example, this happens when the error occured in a script loaded from a different origin). In this case the old onerror handler was itself throwing this new exception: Uncaught TypeError: Cannot read property 'stack' of null at window.onerror (oobe.js:7771) This CL fixes this by adding a check into the onerror handler. We can't log any additional information in this case anyway, so we'll just silently exit from onerror in this case. Bug: none Change-Id: I535f378332af5484a2b6b490db554105861e30a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623086Reviewed-by: -
Olivier Robin authored
Some crash show that item can be nil. Bug: 942292 Change-Id: I2ab962e02bf09d0224baab62abb2145579a51c8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605988 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662130}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ccc89eec59f4..497593d547c3 Created with: gclient setdep -r src-internal@497593d547c3 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: Ifb4628d7a282502e982de9dafca1ee8c72cad287 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624246Reviewed-by:
-
Takashi Toyoshima authored
network::cors::OriginAccessEntry was updated to support port number. This patches also update corresponding blink::OriginAccessEntry so that it takes const SecurityOrigin& or const KURL& in ctors in order to obtain the effective port. The port number is passed to the network::cors::OriginAccessEntry to support the port match in Blink. Bug: 936900 Change-Id: I72d534280a4bd9a8296fe383385cd90e346f2b6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617049 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#662128}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e79721932344..be02e2f4caf1 git log e79721932344..be02e2f4caf1 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 swiftshader.regress@gmail.com Regres: Update test lists @ f4d2a446 Created with: gclient setdep -r src/third_party/swiftshader@be02e2f4caf1 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Change-Id: I0a03ca1fc27b7f1670d9a04743f18230ea73d775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624245Reviewed-by:
-
Clemens Hammacher authored
This adds two more histograms to measure the time it takes per GC, and the number of GCs executed per native module. Both expire end of March 2020, when also the other wasm histograms expire, so we can review them all together for extension. The histograms were added to v8 in https://crrev.com/c/1615246 and https://crrev.com/c/1615250. R=mpearson@chromium.org CC=mstarzinger@chromium.org Bug: v8:8217, chromium:956480 Change-Id: Ie316b53330f960df2c5fac3e38b67ac59b7e80d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1615203 Commit-Queue: Clemens Hammacher <clemensh@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#662126}
-
Hans Wennborg authored
It seems the urllib used on our machines uses a TLS version no longer supported by the GitHub API (see bug). TBR=thakis Bug: 897796 Change-Id: I26c2494923ba724839288f5c8a43519e7fa9c8b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624331Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#662125}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/90984359..233ebc8f Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad2364a24b7466daa2071563ad80520e4aab414d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1622601Reviewed-by:
-
Marc Treib authored
ProfileMenuViewBase (and its subclasses ProfileChooserView and IncognitoMenuView) provied two options for positioning: Either via an |anchor_button| or via an |anchor_rect| plus |parent_window|. However, in practice, only the first option is ever used, so this CL removes the always-empty |anchor_rect| and |parent_window| params. Bug: none Change-Id: I78eb148a19e6f5212428184dae99934ccd389464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621178 Commit-Queue: Marc Treib <treib@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#662123}
-
Yutaka Hirano authored
It seems many tests in http/tests/fetch are slow. Let's mark the following tests as slow in a consistent manner. - body-mixin.html and variants - stream-reader.html and variants - anything in thorough/ Bug: 874695, 948065 Change-Id: I72baa66fe79fe70edc3260c64936ae56e394f666 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624072 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#662122}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/bb90cccb7dd1..afb8d5cdaead git log bb90cccb7dd1..afb8d5cdaead --date=short --no-merges --format='%ad %ae %s' 2019-05-22 asapersson@webrtc.org Log average decoded and rendered framerate for a VideoReceiveStream. Created with: gclient setdep -r src/third_party/webrtc@afb8d5cdaead The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I496dff961a101b827bda2efbd3d24d926dc8f8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623639Reviewed-by:
-
Matt Falkenhagen authored
In some tests, the DevToolsProxy can destruct after the UI thread shuts down, so PostTaskWithTraits crashes. Use a TaskRunner instead, which safely does nothing in that case. Bug: 963702 Change-Id: I46a1647a9cfddd25ca0354fc95d4cbc4b43211a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624074Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#662120}
-
Ben Wells authored
This flag is enabled by default and is no longer needed. Bug: 965864 Change-Id: I512054e73a0e17f934b00862e7d41cacc1f3bcec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624067 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#662119}
-
Luciano Pacheco authored
Follow up of CL:1619584 according to JS style guide [1] private fields shouldn't have trailing _. Renamed fields: * container_ * frame_ * title_ * text_ * closeButton_ * okButton_ * cancelButton_ Renamed methods: * initDom_ * onCotainerKeyDown_ [1] - https://google.github.io/styleguide/javascriptguide.xml?showone=Naming#Naming Change-Id: I67b622a6a8f07bfd6a201f4f8bb12f2fc13ab38f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621774 Commit-Queue: calamity <calamity@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#662118}
-
Matt Falkenhagen authored
DeleteVersion() was a function called when a service worker script couldn't be read from disk. To avoid a sticky state where in-scope URLs always fail to load, we remove the registration from storage and drop the active version as a controller of any clients. However it was trying to do a clever thing and allow any in-progress register jobs for that scope to continue as normal, and also try to keep the registration intact if there was a waiting version that wasn't broken. This was causing complexity and wasn't reliable as per the TODO in the code. It also wouldn't retain any user data attached to the registration. It's simpler to ignore these edge cases and simply always remove the registration. Bug: 964201 Change-Id: I2e08bb2cd9faf7ec071bf7ae63e40540933aa462 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621473 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
A Olsen authored
If the InSessionPasswordChange policy is enabled, and we have info that a user's SAML password is going to expire soon, then show a notification when they first log in, asking them to change their password. Still TODO: some UI polish, including making these notifications more sticky (right now they can always be dismissed easily, even if the password has expired or expiry is imminent). Bug: 930109 Change-Id: Ib147ed343ea18f7ed76bf3705a64c951c8786a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1617459Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: A Olsen <olsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#662116}
-
Yi Su authored
This CL moves all security-related headers into //ios/web/security and //ios/web/public/security, and updates headers inclusions. Bug: 942244 Change-Id: I85be2bbaf91d3b2fa84abb49694b70d4546b222b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1621129 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
-
Tsuyoshi Horo authored
Bug: 935267 Change-Id: I453bec48331cdbc203f96ccd3c99168f2f1734d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1616937 Commit-Queue: Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#662114}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fb8e1b25ad71..25b2980b6b19 git log fb8e1b25ad71..25b2980b6b19 --date=short --no-merges --format='%ad %ae %s' 2019-05-22 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 47741f05043a..d9c00e1d2de1 (5 commits) Created with: gclient setdep -r src/third_party/angle@25b2980b6b19 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Change-Id: I8489769ea88b7f7c953159c324a66edfec7d94f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623031Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 965283 Change-Id: Ia8a959a8ed2d5423231001ea59957d09652caf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624007Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#662112}
-
Hans Wennborg authored
When we switched to building clang from the monorepo, libfuzzer started pulling in libcxx and libcxxabi. It makes the binary larger, and more importantly, it doesn't build successfully on the ToT bots. TBR=thakis Bug: 897796 Change-Id: Ia54595c8295a3eb1874c2deb3c190b4ac860f4ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1624186Reviewed-by:
-
Sam Zackrisson authored
This CL does not change any functionality. Bug: webrtc:9878 Change-Id: I55309aea7db79d0c42d075b852bdb6b33b1d059d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1619812Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Sam Zackrisson <saza@chromium.org> Cr-Commit-Position: refs/heads/master@{#662110}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8908a37777ec..ccc89eec59f4 Created with: gclient setdep -r src-internal@ccc89eec59f4 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome BUG=chromium:947531 TBR=lowell@google.com,kmilka@google.com,yutak@google.com Change-Id: I2eccb8dcf9ed3bc5c0c0a2ec507d8647b8ea5628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623928Reviewed-by:
-
