- 13 Nov, 2019 40 commits
-
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1242d9cc48ca..c5ec54e51b91 git log 1242d9cc48ca..c5ec54e51b91 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 jakobi@webrtc.org Add SetIsScreencast method to VideoSource. 2019-11-13 mbonadei@webrtc.org Revert "Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true."" 2019-11-13 mbonadei@webrtc.org Reland "Define WEBRTC_ENABLE_SYMBOL_EXPORT if is_component_build=true." Created with: gclient setdep -r src/third_party/webrtc@c5ec54e51b91 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Ie07ac445e45e1ec62a86519bf9cd2d45cd499060 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914285Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714912}
-
Mike West authored
Disabling `virtual/disable-deferred-rendering/fast/canvas/canvas-drawImage-live-video.html` on Windows `virtual/disable-deferred-rendering/fast/canvas/canvas-drawImage-live-video.html` has flaked thrice today on Win10. See: * https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/58463 * https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/58459 * https://ci.chromium.org/p/chromium/builders/ci/WebKit%20Win10/58451 https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUAsSBUZsYWtlIkVjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZmFzdC9jYW52YXMvY2FudmFzLWRyYXdJbWFnZS1saXZlLXZpZGVvLmh0bWwM TBR=fserb@chromium.org Bug: 1024248 Change-Id: If68ce36cc3326a0b0b71f73c3cb577d27313c541 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913412Reviewed-by:
Mike West <mkwst@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#714911}
-
Mike West authored
This test timed out twice this afternoon ([1], [2]). The flake portal shows a number of other instances. [1]: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36103 [2]: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/36104 [3]: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyUwsSBUZsYWtlIkhjaHJvbWl1bUBibGlua19oZWFwX3VuaXR0ZXN0c0BIZWFwVGhyZWFkRGVhdGhUZXN0Lk1hcmtpbmdTYW1lVGhyZWFkQ2hlY2sM&show_all_occurrences=1 TBR=kouhei@chromium.org Bug: 993148 Change-Id: I89ae866fbfb39e96485a5692c8e4c9cf555313f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913407Reviewed-by:
-
Wei Lee authored
Bug: b/144062362 Test: None Change-Id: I6398d88a7d10809a9b360ace6538aa564c64012a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913945 Auto-Submit: Wei Lee <wtlee@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#714909}
-
Peter Wen authored
3.6 Canary 11 is now available on gLinux. Tbr: agrieve@chromium.org Bug: 620034 Change-Id: I09f02ba2fcbaa8e487ba1dde0e0f9648be8452f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914120Reviewed-by:
Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714908}
-
Hans Wennborg authored
until it can be cleaned up. TBR=inglorion Bug: 1024203 Change-Id: I8c323ee83f9cc6fb2477a980be19e1d35303d6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912714Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#714907}
-
Olivier Li authored
Bug: 1023801 Change-Id: I2db91fc9d6979fe503ee761b955cd1756bdfbddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912882 Auto-Submit: Oliver Li <olivierli@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#714906}
-
Yue Zhang authored
Bug: 1017492 Change-Id: Ie2b27670eb157d2f73f0720748bb9fa6413af64a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912647 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#714905}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/9ec5c78a9256..d4b3120e6071 git log 9ec5c78a9256..d4b3120e6071 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 12e54dae167c..ab3cdcaef56e (2 commits) 2019-11-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/glslang/src f34cdc70ca1b..37dcb894574e (1 commits) Created with: gclient setdep -r src/third_party/angle@d4b3120e6071 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: chromium:None,chromium:None Change-Id: I5e61ee00c7fe2b50956896012c67ed4b8772b141 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914281Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/09220549..90f9ed46 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iad5f9ddf44e137303fac84e40b32820f585b4f13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913118Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714903}
-
David Lei authored
Won't show any changes until http://crrev.com/c/1895263 (serving bundle app resources) lands Bug: 996088, b/142091425 Change-Id: I5fe3a942ac56f7eff30b0856f9e6ecf57bf28dc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895262Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: David Lei <dlei@google.com> Cr-Commit-Position: refs/heads/master@{#714902}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/89ab0576bf88..8b73d27ddd61 git log 89ab0576bf88..8b73d27ddd61 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@8b73d27ddd61 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC halcanary@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=halcanary@google.com Bug: None Change-Id: I2766af700b4f827b2172facfc13dfc143a8d6be7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914279Reviewed-by:
-
Matt Menke authored
These are testing private services/network/ classes, so should be in services/network/. Bug: None Change-Id: I8f736112feb755c035e88570a180cc6debc128e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907073Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#714900}
-
Richard Knoll authored
We're still ramping up on this metric: https://uma.googleplex.com/p/chrome/timeline_v2/?sid=7fb373d04b74fd077c6d8a94413b410c Bug: 1016410 Change-Id: I2375bab74d9352fe56507e0f6dd13eba16cf5df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895194Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#714899}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ie5b699900af4bb8799b205cfbe19677f8c9d59b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914283Reviewed-by:
-
Roman Sorokin authored
Also make it blue. Bug: 954572 Change-Id: I1fbd008c4280a98f69da50858342b9e9d3fb1902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912706Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#714897}
-
Vadym Doroshenko authored
Bug: 959776 Change-Id: I69319dad27040cb8a6203ffd0ac0a1a66fc395c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911757Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#714896}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I07ec25a8d87cbfc446155825c501469da6624003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912202Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#714895}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I5df7c3d600bd39afb6b7d478d4b75a42193f3c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912203Reviewed-by:
-
Gauthier Ambard authored
This scoped swizzler swap the implementation of two instance methods of a class. Bug: 901082 Change-Id: I90d4009189b2206c453f9f3847c5fc9e58e94ee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911743Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#714893}
-
Denis Kuznetsov authored
Bug: 955194 Change-Id: I9b4bbcc58754f84ebda30cb171c49c638bd261c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912300Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium c7351898. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 88d98fda "Add more scroll to text WPTs" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jfernandez@igalia.com: external/wpt/css/css-align NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I2c9d1314f00f2fc26b5da0d181671fbe63ad15c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914182Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#714891}
-
Maks Orlovich authored
Sadly wanting a DCHECK for asan_canary coverage gets in the way of testability here. (This is done for metrics only, as a prep step before switching over). Change-Id: Ia8c272a90459c885ec3fdae7d9879a1b5413c36b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913063Reviewed-by:
Lily Chen <chlily@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#714890}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/0db01f0fabd1..088977a7a7fb git log 0db01f0fabd1..088977a7a7fb --date=short --no-merges --format='%ad %ae %s' 2019-11-13 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@088977a7a7fb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: I478f02de5b6cfc1182a595547eb11a082b15d4c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913998Reviewed-by:
-
Marc Treib authored
Nothing in InvalidatorRegistrarWithMemory requires thread affinity, so no reason for using ThreadChecker instead of the preferred SequenceChecker. Bug: none Change-Id: Iead32eb4176913df32c11364cf90c5263782d3d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910087Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#714888}
-
Eric Seckler authored
This is a reland of 0d929861. Reland after fixes for crbug.com/1022770, crbug.com/1022386, and crbug.com/1022818 landed. Original change's description: > perfetto: Use TraceProcessor for proto2json conversion > > TraceProcessor replaces the existing (unmaintainable) proto2json > converter and adds features like combining of BEGIN/END events > and support for heap profiles. > > Also updates a devtools test that was expecting separate begin/end > events where TraceProcessor now combines them into a complete event. > > We have reduced the trace procesor's binary size overhead > by selectively excluding features Chrome doesn't need from >400kB to > ~50kB. We could probably save a couple more kB if we invest even more > eng time and accept the maintenance burden for this in trace processor, > however, we feel that we've reached an acceptable state that balances > binary size & code health. > > Binary-Size: see paragraph above. > Bug: 1006770 > Change-Id: Ia7f6b3a784c1a9c40574e1dcd80eca1ca2dfb03f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746258 > Commit-Queue: Eric Seckler <eseckler@chromium.org> > Reviewed-by: Andrey Kosyakov <caseq@chromium.org> > Reviewed-by: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#713593} Binary-Size: see paragraph above. Bug: 1006770, 1022770, 1022386, 1022818 Change-Id: I7297721eb67834905262081282936013b34a0184 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913602Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#714887}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d4002a733dc6..1242d9cc48ca git log d4002a733dc6..1242d9cc48ca --date=short --no-merges --format='%ad %ae %s' 2019-11-13 danilchap@webrtc.org Reland Cleanup MultiStreamTester Created with: gclient setdep -r src/third_party/webrtc@1242d9cc48ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ic920df481986e944f50d126785350e5e491c4229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913558Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/88632cac30e1..359bc80a7ee4 git log 88632cac30e1..359bc80a7ee4 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 digit@google.com [vulkan] Implement VK_KHR_external_memory_fd for Linux and Android. Created with: gclient setdep -r src/third_party/swiftshader@359bc80a7ee4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/140419396 Change-Id: If5b2a35c08e238cd052f89993f7a290c2e0be482 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913997Reviewed-by:
-
Alex Ilin authored
ashmem_create_region() returns -error_code on failure. ScopedFD treats only -1 as invalid handle meaning that ScopedFD will try to close a file descriptor with a negative value other than -1. ScopedFD crashes when close() fails. This CL adds a check that the result of ashmem_create_region() is non-negative before wrapping it into a ScopedFD. This CL also adds a check that the rounding operation doesn't overflow which was the reason of the failure in the first place. Bug: 1022582 Change-Id: Id2dcec613e87c8eda97bf18cbd70f13b105b1e0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913239 Commit-Queue: Alex Ilin <alexilin@chromium.org> Reviewed-by:
-
Mike West authored
[1] shows that `SitePerProcessBrowserTest.OOPIFDetachDuringAnimation` is somewhat flaky in general, and it just flaked twice in a row this morning on `linux-chromeos-rel`: [2], [3] [1]: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXQsSBUZsYWtlIlJjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BTaXRlUGVyUHJvY2Vzc0Jyb3dzZXJUZXN0Lk9PUElGRGV0YWNoRHVyaW5nQW5pbWF0aW9uDA&show_all_occurrences=1 [2]: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/31228 [3]: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/31229 TBR=kenrb@chromium.org Bug: 809580 Change-Id: I866bfc20a69e706aee34addd32a5e8e8fc40792f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912710Reviewed-by:
-
Mikel Astiz authored
Tests often have indirect dependencies to code that requires a FieldTrialList instantiated. To work that around, many existing tests manually instantiate a FieldTrialList, but this is cumbersome, distracting and hard to clean up once it no longer is necessary. Instead, this patch adopts base::test::ScopedFeatureList as part of the test suite for all tests. Follow-up patches will simplify tests. Bug: 1018667 Change-Id: I15b1f1097357f0fc3a30d4ac337d77b1ef607098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883567 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#714882}
-
Mike West authored
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=EnrollmentRecoveryTest.DifferentDomain shows a pretty unhappy story for `EnrollmentRecoveryTest.DifferentDomain` on linux-chromeos-dbg in both `browser_tests` and `non_viz_browser_tests`. TBR=antrim@chromium.org Bug: 1024176 Change-Id: I92a8605359f6db3e22d9733aa8d2ec263d685e21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912709 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
Andreas Haas authored
This is a first step of getting rid of blink::ArrayBuffer. blink::ArrayBuffer serves two purposes by now: 1) Managing a list of ArrayBufferViews; 2) Managing the detached flag; With this CL I encapsulate the list of ArrayBufferViews. In follow-up CLs I then want to pass the list and an ArrayBufferContents object to the ArrayBufferView instead of the ArrayBuffer object. This will bring us one step closer to removing blink::ArrayBuffer. Update: ArrayBuffer seems to be very involved. It is the connecting data structure between DOMArrayBuffer, ArrayBufferContents, and ArrayBufferView. Even though it is not used anymore outside these classes, it is not obvious if we can replace it within these classes. I still think that refactoring the organization of views here is good. R=haraken@chromium.org Bug: chromium:1008840 Change-Id: I533f5496b7c51312e77a0138ac8249f9f0e55ffd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911207Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#714880}
-
Ioana Pandele authored
This change adds a pref that is set to true when the first eligibility check passes and is not reset on subsequent checks. This helps ensure that the feature is checked for all past and present eligible cases. Bug: 1021033 Change-Id: Ie0f48e07ed5e28b8ee6fec0400d7d5fac41f1a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893204 Commit-Queue: Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Cr-Commit-Position: refs/heads/master@{#714879}
-
Marc Treib authored
Before this CL, when we failed to extract a topic name from the response to a per-user-topic subscription request, we'd record *both* kSuccess and kParsingFailure in the FCMInvalidations.SubscriptionRequestStatus histogram. This CL fixes this by recording kSuccess only on actual success. This probably makes little or no difference in practice, but let's be consistent. Bug: 1023813 Change-Id: I16ea38e4df5783455450e250ee0fd732ed0aa4f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911751Reviewed-by:
-
Vasilii Sukhanov authored
The class uses interprocess communication and doesn't have to survive the parsing result. Bug: 1023606 Change-Id: I3828b9da3395eee73fd371450349bd062647642a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911793Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#714877}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/12e54dae167c..ab3cdcaef56e git log 12e54dae167c..ab3cdcaef56e --date=short --no-merges --format='%ad %ae %s' 2019-11-12 alanbaker@google.com Fix operand access of composite in upgrade memory model (#3021) 2019-11-12 alanbaker@google.com Validate array stride does not cause overlap (#3028) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@ab3cdcaef56e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,cnorthrop@google.com Bug: None Change-Id: I354bef01a53322746c84e099ea1299d209f74ad8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913991Reviewed-by:
-
Mike West authored
The following tests pretty consistently fail on linux-chromeos-dbg: BrowserNavigatorTest.CloseSingletonTab BrowserNavigatorTest.NavigateFromBlankToOptionsInSameTab BrowserNavigatorTest.NavigateFromNTPToOptionsInSameTab BrowserNavigatorTest.NavigateFromNTPToOptionsPageInSameTab https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-dbg/15245 is a recent example run. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=BrowserNavigatorTest.NavigateFrom is a broader view. TBR=ellyjones@chromium.org Bug: 1024166 Change-Id: Ia05dc43c8948fb0ba26615f3f9f5c791705d876c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912707Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/4f023f565a61..9ec5c78a9256 git log 4f023f565a61..9ec5c78a9256 --date=short --no-merges --format='%ad %ae %s' 2019-11-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 9da287fd0264..88632cac30e1 (6 commits) Created with: gclient setdep -r src/third_party/angle@9ec5c78a9256 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I1bb5f12e2a9f93e2b3f80cc2dcfe8fe1ab0bf7d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913989Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/15f6f95cdc3e..c062acf6a20a git log 15f6f95cdc3e..c062acf6a20a --date=short --no-merges --format='%ad %ae %s' 2019-11-13 vapier@chromium.org dev_server_wrapper: get unittests passing under python 3 2019-11-13 kdgwill@google.com licensing: remove sys-apps/escalator 2019-11-13 vapier@chromium.org cros lint: use --ignore-patterns to filter protobuf files Created with: gclient setdep -r src/third_party/chromite@c062acf6a20a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie2c532c4158c05099da28f1bb1ce816f397c2267 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913990Reviewed-by:
-
