- 27 Nov, 2019 40 commits
-
-
Fredrik Söderquist authored
Bug: 1021630 Change-Id: I50f835362b404f7c5e8828d70581078b7145f322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937067 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719544}
-
Chih-Yu Huang authored
This CL removes all BindToCurrentLoop usage in ImageProcessor and its children classes. Also, we add client task runner and its sequence checker to make sure ImageProcessor's methods and callbacks are called on the correct sequence. Bug: 1004727 Test: pass video_decode_accelerator_tests and video_encode_accelerator_unittest on Kukui and Hana Test: Run image_processor_test on Eve and Kevin and confirm no sequence check failure Change-Id: I73f85a7fccf76a62e8546b98add429ed7e692048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937958 Commit-Queue: Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#719543}
-
Luca Hunkeler authored
Change the way we handle accessibility strings to that there are three options: not set -> the default description is used empty string -> the view is ignored by accessibility non-empty string -> the string is used as description Bug: b/143757329 Change-Id: I39cd9bf4a634fa7482c485320d2a81d8513eb935 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926590 Commit-Queue: Luca Hunkeler <hluca@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#719542}
-
Robbie Gibson authored
On iOS, if there is no text in the Omnibox text field, the "Go" button and the return key (on bluetooth keyboards) are disabled. This means that when using the keyboard to select matches, the return key doesn't work for the clipboard matches because no text is filled into the omnibox. This adds the following fill_into_edit: URL match -> URL text match -> Text image match -> Search Copied Image (the same as the match's description) Fixed: 1026595 Change-Id: I04686bc4b0cd38651d33b54113c97001a3a30eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937074 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#719541}
-
Jinho Bang authored
Spec change: https://github.com/gpuweb/gpuweb/pull/496 Bug: 852089 Change-Id: I0b786ebaf3cb4084ecf755c9175c2fe51d9eca22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936693 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#719540}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/ddbe56c4721c..ccea71d219ed git log ddbe56c4721c..ccea71d219ed --date=short --first-parent --format='%ad %ae %s' 2019-11-27 fancl@chromium.org Migrate Pinpoint to a Single-Page-Application 2019-11-27 dberris@chromium.org Update build steps to allow subsetting tests Created with: gclient setdep -r src/third_party/catapult@ccea71d219ed If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1027975,chromium:985223 Tbr: skyostil@google.com Change-Id: I7696382f51786f37a0028a37f8cd769492d91b07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938492Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719539}
-
Peter Marshall authored
The devtools backend receives and will handle protocol messages in order, but there is no guarantee of ordering with other non-protocol things. This is true for content::ExecJs. This test sent a Runtime.Evaluate message over the devtools protocol and then called ExecJs. Due to the way scheduling is handled in the devtools backend, it's possible that the ExecJs code runs before the protocol message is handled by the backend. Callers can get around this by waiting for the first Runtime.Evaluate call to finish and then only continuing in the callback provided. In this case, the first JS evaluation sets up a promise that will only resolve once the second JS evaluation happens, so that won't work. The solution here is to use a second Runtime.Evaluate call, which does have an ordering guarantee with the first. Upcoming changes to the scheduling uncovered this as a flake on the trybots. Change-Id: I643539d094407a43b4ffff17dd052e5f49e3e44e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939409Reviewed-by:
-
Yutaka Hirano authored
Bug: 1028936 Change-Id: Ia607a4e4a46cbfa2f1b7f3003a70677d779115a5 Tbr: calamity@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939084Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#719537}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/882115da6b31..2a8799ff0874 git log 882115da6b31..2a8799ff0874 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 herb@google.com Revert "Naive CPU large emoji" 2019-11-27 herb@google.com Make SkEnumerate make flatten tuples 2019-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src 92fe999a..c493edcc (509 commits) 2019-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 f65b212492ec..c373dfd84194 (8 commits) 2019-11-27 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader f2637d0dd7eb..663dcefa22ea (3 commits) 2019-11-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-27 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-26 ethannicholas@google.com SkSL now handles sk_Caps in include files 2019-11-26 herb@google.com Naive CPU large emoji 2019-11-26 reed@google.com hide deprecated next() on SkPath::Iter 2019-11-26 egdaniel@google.com Make sure we recycle the secondary command buffers when release primary command buffers. 2019-11-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-26 jlavrova@google.com Bug fixes 2019-11-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2019-11-26 benjaminwagner@google.com [infra] Upgrade NVIDIA driver 2019-11-26 egdaniel@google.com Return a size of 0 for external format GrSurfaces. 2019-11-26 egdaniel@google.com Cleanup GrVkCommandBuffer resource ownership and freeing. 2019-11-26 robertphillips@google.com Move the initial GrProgramDesc keyLength into the header 2019-11-26 benjaminwagner@google.com [infra] Upgrade Intel Skylake driver 2019-11-26 jvanverth@google.com Enable cross-context textures in Metal. 2019-11-26 fmalita@chromium.org [skottie] Handle null mask filter effects gracefully Created with: gclient setdep -r src/third_party/skia@2a8799ff0874 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None,chromium:None Tbr: bungeman@google.com Change-Id: Ia22c545462d90591cd73a6ea88c358ce10e54079 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939228Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-compile-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-compile-chrome BUG=762641 TBR=chrome-os-gardeners@google.com Change-Id: If407e9bffa32b10a056e5a01f962d2eb41ea30b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938444Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719535}
-
Yuki Shiino authored
Implements the core part of overload resolution. Bug: 839389 Change-Id: If1281a7df2f4adf08968f6b361c5d43ef5999a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906453Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719534}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/b00449ac4016..34267f83deb7 git log b00449ac4016..34267f83deb7 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 tandrii@google.com Revert "Release new bb tool @ 1b9c7d3e8bacc3100d0f81c96825756e6f48a293." Created with: gclient setdep -r src/third_party/depot_tools@34267f83deb7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028420 Tbr: agable@chromium.org Change-Id: I19c1ad3c2767da8911ea04b6c58fb5aaddc9aa0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939467Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/39e2ad23d608..b35d2f479cd6 Created with: gclient setdep -r src-internal@b35d2f479cd6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I61e0676955d2ec37b984a5f17a821809d02bf402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939468Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#719532}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/85f3e93d13f3..f31f26f73930 git log 85f3e93d13f3..f31f26f73930 --date=short --first-parent --format='%ad %ae %s' 2019-11-26 headlessclayton@gmail.com utils/vscode: Add install.bat (#3071) 2019-11-26 52076061+digit-google@users.noreply.github.com build: cmake: Add support for Fuchsia. (#3062) 2019-11-26 dneto@google.com Add test with explicit example of stripping reflection info (#3064) 2019-11-26 9856269+sarahM0@users.noreply.github.com Permit the debug instructions in WebGPU SPIR-V (#3063) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@f31f26f73930 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cwallez@google.com Change-Id: I8ff921fe29c1c4a5e442da050a072ca0bdc5c430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938446Reviewed-by:
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves COEP and relevant functions from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I4a3c0fce12308bb95dbcb4b4b3babe5d49aebdca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939151 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#719530}
-
Luciano Pacheco authored
Change the way to hide Open button to use isModal state, instead of changing the semantics of the property |hasTask|, so keep |hasTask| meaning that the file has tasks. Add |isModal| property to <files-quick-view> to be able to hide the OPEN button when in a modal dialog. Change the OPEN button |hidden| condition to check for isModal attribute. Convert some variable definitions to const as forced by presubmit. Test: browser_tests --gtest_filter="*openQuickViewInFileDialog*" Bug: 948605 Fixed: 948605 Change-Id: I1c0c5f6c0178d258ec5d1a2f72b076cded0f8adb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935276 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Austin Tankiang <austinct@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#719529}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f848256008f5..781bb85e9698 git log f848256008f5..781bb85e9698 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 85f3e93d13f3..f31f26f73930 (4 commits) Created with: gclient setdep -r src/third_party/angle@781bb85e9698 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: cwallez@google.com Change-Id: Ib6cdfc3536c4107122e7c9bea70d5176a67fcc14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938445Reviewed-by:
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=flackr@chromium.org Bug: 1023677 Change-Id: I0ca135cdf0f186623355b0cc3c7e2beefe342dd0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926907 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#719527}
-
Yutaka Hirano authored
It was marked as failing, but https://crrev.com/b71bef1cb23070af161d251d9188ea153bed67d8 removed the expectation. Since the flakiness persists, let's recover the expectation. Bug: 833100 Change-Id: If5f3d61e9cebb3fa9542ddbcf5f971a67340f8f6 No-Try: True Tbr: timvolodine@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939137Reviewed-by:
-
Vikas Soni authored
Update pixel format used to create video frames on android for both MCVD and MediaPlayer path from PIXEL_FORMAT_ARGB to PIXEL_FORMAT_ABGR. This is required because SkiaRenderer wants to ensure that format of the resource used during promise texture creation must match the format of resources used for creating fulfill images. Bug: 1028746,991291 Change-Id: Ie46c7fc0d43531f38f3eef85c8e3842f1ddf4712 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938032Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#719525}
-
Yutaka Hirano authored
...on more platforms. TBR=yangguo@chromium.org Bug: 1028684 Change-Id: I0032b8c170e8059c2bccf1998e8e8bd2a9e7a62c NoTry: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939156Reviewed-by:
-
Hiroki Nakagawa authored
Bug: 931087 Change-Id: Ib54fa18a4245f4f65398fbbb473a657b25be7aa5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939153Reviewed-by:
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves BFCache glue code and relevant functions/members from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Notable points of this change are as follows: - RenderFrameHostImpl manages raw pointers to ServiceWorkerContainerHost instead of raw pointers to ServiceWorkerProviderHost. - ServiceWorkerVersion also manages raw pointers to ServiceWorkerContainerHost instead of raw pointers to ServiceWorkerProviderHost as controllees. - This CL doesn't change ownership of ServiceWorkerProviderHost and ServiceWorkerContainerHost yet. ServiceWorkerContextCore owns ServiceWorkerProviderHost, which in turn owns ServiceWorkerContainerHost. See the design doc for the end state of the object ownership. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I955bbf6dafbb2258238b33b25d6b074d86b26f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935580 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
-
Yoshiki Iguchi authored
This reverts commit b622130a. Reason for revert: This CL causes the crash. See crbug.com/1028848 BUG=1028848 Original change's description: > Ash Tray: Fix quick settings not closing after clicking on a notification. > > BUG=1024100 > > Change-Id: Ib30e43689842069e4647f7f455a919c62a3c7844 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928042 > Reviewed-by: Ahmed Mehfooz <amehfooz@chromium.org> > Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717775} TBR=amehfooz@chromium.org,tengs@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1024100 Change-Id: I52bf4673a0b7f3142690e80c7bf944f0fd0a2a3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939135Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#719521}
-
Navid Zolghadr authored
Change-Id: Ib59636f289e7bf0ef90a9e1120b729c04ef98ccd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939247Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#719520}
-
Kent Tamura authored
This CL changes the types of |FormDataElement:: expected_file_modification_time_| and |WebHTTPBody::Element:: modification_time| from double (seconds from Unix Epoch) to base::Optional<base::Time>. This CL has no behavior changes. Bug: 988343 Change-Id: I28c5819615a1de6d2b5cd28203df38fe49f5bff9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935770Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#719519}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /components/translate This CL was uploaded by git cl split. TBR=napper@chromium.org Bug: 1018667 Change-Id: I33c15aa765e5e18e7e893beb4a5739f8eeef4362 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917509 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#719518}
-
Yutaka Hirano authored
They depend on dom/html which is slow. Also remove entries from TestExpectations because they are covered either by - the long timeout introduced here, or - MSAN related expectations (see https://crbug.com/856601) Bug: 1026151, 990900, 856601 Change-Id: I094590d485c318fef5ab4c2e213a621211a6a3a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936444 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#719517}
-
Jeremie Boulic authored
Update file_manager manifest to be able to accept path parameters when trying to launch the files app on specific directories. Bug: 1028038 Change-Id: I48b4084699edeb2ba39456e2ac1b14a60ee0ea9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936437Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#719516}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/415874734c70..39e2ad23d608 Created with: gclient setdep -r src-internal@39e2ad23d608 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I5679041e7bc61620c3f72f48320d56793873f305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938830Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c373dfd84194..f848256008f5 git log c373dfd84194..f848256008f5 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 syoussefi@chromium.org Don't use too many color attachments in clear test Created with: gclient setdep -r src/third_party/angle@f848256008f5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: Ica2a8dca708d3fd45a0086be28009737b5c7cc49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938767Reviewed-by:
-
Makoto Shimazu authored
If a page is guarded by Cross-Origin-Embedder-Policy: require-corp, a fetch event initiated by a page can bypass the `require-corp` policy if a service worker controlling the page is COEP: none. This CL is to validate the COEP value for the page before returning a response to the client. In a previous CL, COEP for clients became available in SWGlobalScope. This retrieves the value and passes it to FetchResponseWithObserver. Once a response is provided to the observer, Cross-Origin-Resource-Policy will be checked if COEP is `require-corp`. Note that this CL makes a util for CORP in services/network public as we'd like to unify the logic to check the CORP header. Some of the other files are needed to follow the change because of an issue around linking. Bug: 999049 Change-Id: Ib5754b5f7ce32966c24aabe89892a5637e6f7f8c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928351 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#719513}
-
Noel Gordon authored
- use keyboard arrow-right key to expand the nested folders - speed: a smaller number of entries (still repros the bug) - make comments consistent across the test fixtures - add files-ng TODO Bug: 1025581 Fixed: 1025581 Change-Id: Ia239b2ce194322df4894902f2a6522bc99f92be3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937957Reviewed-by:
Alex Danilo <adanilo@chromium.org> Reviewed-by:
-
David Black authored
There are three types of clicks which may originate from the rich version of the proactive suggestions entry point: 1. Click to open all proactive suggestions inline in Assistant UI. 2. Click to teleport directly to a single proactive suggestion. 3. Click to close the proactive suggestions entry point. To handle these cases, two new deeplink action types were added: 1. entryPointClick 2. entryPointClose The latter will always cause the proactive suggestions entry point to be closed. The former will either open Assistant UI to show the entire set of proactive suggestions inline or it will teleport the user directly to a single proactive suggestion. This is accomplished by handling an optional |href| parameter. A new histogram is also added in this CL to track the new possible outcome of showing the proactive suggestions entry point. Bug: b:145056104 Change-Id: I5faf89ba014ed32f17dd3c877ceba0e5371c1fb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935447 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#719511}
-
Hitoshi Yoshida authored
This CL assumes to have using BaseClass = ParentClass; in the class definition. Bug: 839389 Change-Id: Iabdaadd990811f46332f79eed113907f00a801a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935573 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#719510}
-
David Schinazi authored
Callers are already required to add a semicolon in debug builds, so this extra one could cause the -Wextra-semi-stmt compiler warning if we enable it. It would be safer to remove it. Change-Id: I6ac395ed5524ff277edbfcd7d23a5e37b61534fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938827 Auto-Submit: David Schinazi <dschinazi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#719509}
-
Anand K. Mistry authored
The difference in naming was causing the wrong icon URL to be returned in launcher search results, causing the icon load to fail. Bug: 753902 Change-Id: I3d058752b08a7d12e1d7e5cc4873eebdac42b349 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935969Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
-
Alan Cutter authored
This updates the WebAppManifestUpdateResult enum value kAppDataInvalid to be more accurately named kAppNotEligible as it is triggered by the app failing install promotability checks. Bug: 926083 Change-Id: I3822a9a3c5d5acffb3a5ebcb8fba6ffa2f7ff760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1937954 Auto-Submit: Alan Cutter <alancutter@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#719507}
-
rbpotter authored
Moving most chrome.send calls into the BrowserService, to better match the history page to the browser proxy pattern. Currently not moving calls in history.js, since the intent appears to be for those calls to be made before the history page fully loads. Bug: 1022212 Change-Id: Ief20d57a6d710121803a2c0ee2be26e96b9ce675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928036 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#719506}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9a5941edd0cf..b00449ac4016 git log 9a5941edd0cf..b00449ac4016 --date=short --first-parent --format='%ad %ae %s' 2019-11-27 tandrii@google.com Release new bb tool @ 1b9c7d3e8bacc3100d0f81c96825756e6f48a293. Created with: gclient setdep -r src/third_party/depot_tools@b00449ac4016 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1028420 Tbr: agable@chromium.org Change-Id: Ibca5e87d9b12098f66ddcf693a0208496dd995aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1938439Reviewed-by:
-
