- 11 Sep, 2020 38 commits
-
-
Lukasz Anforowicz authored
This CL changes CreateFileSystemURLLoaderFactory so that it returns mojo::PendingRemote to a FileSystemURLLoaderFactory that is owned by its |receivers_| and will self-delete when the last receiver disconnects. This CL removes the ability to directly construct and own a std::unique_ptr<FileSystemURLLoaderFactory>, because this ability means that the factory can be destructed while receivers bound via the Clone method are still alive (see the associated bug). This CL mostly just follows the pattern established earlier by https://crrev.com/c/2337411. Bug: 1106995 Change-Id: Id98b6df97ad4e96e033ba638ccc2c3ff20a92c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357462Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#806007}
-
Sammie Quon authored
Moves AccessibilityFocusAnnotator to OverviewSession to accommodate. Change OverviewGrid::RemoveItem callsites to use OverviewSession::RemoveItem since it does some more stuff. Change OverviewItemView a11y role to GenericContainer so its children (label, close button) can be focus with a11y. I tried removing the overview focus widget outright in crrev.com/c/2388623 but issues came up with making the OverviewItem widget's activatable. If DesksWidget is always available in the future we can remove it. Test: manual Bug: 853589 Change-Id: I1ea63a88a0d0b5511edd1fd6925a35e82409d229 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392993Reviewed-by:
Min Chen <minch@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#806006}
-
Maggie Chen authored
ProcessSurfaceOccludingDamage was split into two functions and an internal function to support the new structure CompositorRenderPass and AggregatedRenderPass. In stead of calling ProcessSurfaceOccludingDamage() on a per surface basis, now we call this function in CopyQuadsToPass() so the destination AggregatedRenderPass is always available. With this change, we can merge these two functions into one. This is also aligned with the direction of future support for multiple overlays. Bug: 1117235 Change-Id: I05703e5fe44b0611f73ec6f588e6b11776fbe0cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393529Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806005}
-
phillis authored
On OSX, file handlers are managed via app shim in the Application directory, this removed duplicating app shortcut creation during installation and moves shortcut update logic from file manager to OsIntegrationManager. Apps.FileHandler.Registration.Mac.Result UMA metric is removed and WebApp.Shortcuts.Creation.Result is created Bug: 1123201 Change-Id: I0a6850424a7050c8c0f14acf5166a9123abad2b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377900 Commit-Queue: Phillis Tang <phillis@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#806004}
-
Joshua Peraza authored
3e065b11d0ca linux, mac: disable cfi-icall for cross-dso calls Change-Id: I92931ffe81b3004149b33017853d8c1e0548141d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404066Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#806003}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599760756-c4035dc0b0474f5a6f2e7d19fc7457941683bae1.profdata to chrome-linux-master-1599781911-7dd6ce5c7bf44a9e9e915c505640214d1e509445.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: If690b6a2ea926e28d7cb93f9c70a22b9a086e53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405692Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806002}
-
Andre Le authored
Add the task continuation section (continue browsing) to PhoneHub tray bubble (mock UI with implementation). Bug: 1106937,1126208 Change-Id: I15144c8f875c56454b0125498417bd37ee4bc7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399802 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#806001}
-
Elly Fong-Jones authored
We don't have a notion of "app-modal". We do have window-modal and system-modal, but system-modal a) is much more "aggressive" than app-modal and b) doesn't work at all on Mac, so demote these dialogs to window-modal. Note that they are *not* demoted on ChromeOS because of the linked bug 1127133. Bug: 1121132,1127133 Change-Id: Ib145b97529c08227f7888a51d0fb8e6fa3799b36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398961 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#806000}
-
Christopher Cameron authored
The problem is in DoScheduleCALayerInUseQueryCHROMIUM. This lists a bunch of textures, and a callback comes back to GLRenderer::DidReceiveTextureInUseResponses about whether or not they are in use. Only once InUseResponses indicates that a texture is not in use will the GLRenderer release it. Here's what goes wrong -- ScheduleCALayerInUseQueryCHROMIUM takes many textures as arguments. If a single texture is invalid, then the entire call is discarded. And so no InUseResponses are returned, and no textures are freed. No texture is removed from the InUseQuery until it reports that it is not in use. Consequently, frame after frame, every texture reports that it is in use, more textures are allocated because the pools are empty. The fix is to make DoScheduleCALayerInUseQueryCHROMIUM be fail-safe instead of fail-deadly. If a texture is invalid, report that it is not in use. Bug: 1120795 Change-Id: I4f82d854b9a0620d0c8b829fadeaf5ad4d0ea506 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402759 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#805999}
-
K. Moon authored
Moves OutOfProcessInstance::LoadUrl() to PdfViewPluginBase, so the implementation may be shared between the Pepper and Pepper-free PDF plugins. The PdfViewWebPlugin implementation creates a BlinkUrlLoader instead of a PepperUrlLoader. Bug: 1099022 Change-Id: I2d3c97ba7adb8d3608f32760c942d7333a4e54db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401507 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#805998}
-
Brandon Wylie authored
Bug: 1123209 Change-Id: I9a0caa1bccf7e857703f5ad743b8de1197062bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402111 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805997}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ba5cb6e38f7..da7c69c8fd9c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC rakina@google.com,kmoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1093357 Tbr: rakina@google.com,kmoon@google.com Change-Id: I57a2faa982c430f3ce853b471a4c5468a286fbcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405313Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Kahmy Moon <kmoon@google.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805996}
-
Dominic Farolino authored
This reverts commit e04f7fe9. Reason for revert: Apparently this CL is causing memory regressions [1]. I'll revert this, as maybe I'm accidentally removing an entry here that is still used, and whose fall-back behavior causes memory regressions. [1]: https://bugs.chromium.org/p/chromium/issues/detail?id=1119774 Original change's description: > Remove launched features from fieldtrial_testing_config.json > > R=asvitkine@chromium.org, jbroman@chromium.org > > Bug: 1053702 > Change-Id: Ibe268bd3930582fa1a366419806e71bf87ef9cd3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360550 > Commit-Queue: Dominic Farolino <dom@chromium.org> > Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> > Auto-Submit: Dominic Farolino <dom@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#798875} TBR=jbroman@chromium.org,asvitkine@chromium.org,dom@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1053702 Change-Id: I9f92c171ada443369a8b40a3bc3bd61245f9fafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368443Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#805995}
-
Will Cassella authored
Currently, `DecoderSelector::decoder_priority_cb_` is called once per-config, and can only return whether platform decoders specifically should be prioritized, deprioritized, or left as-is. This is somewhat inflexible, as it disallows skipping or deprioritizing individual decoders based on other characteristics. This CL modifies the decoder selector so that it runs the given predicate/callback once per decoder, and modifies `DecoderPriority` to be one of `kDeprioritized`, `kSkipped`, or `kNormal`. kNormal was chosen instead of `kPrioritized` since it better reflects the mechanism of what's happening. It's not being prioritized, it's just being left as-is in the queue. Change-Id: I9dfcecec5454201501dd1d09c23638da634fe188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388269Reviewed-by:
Frank Liberato <liberato@chromium.org> Commit-Queue: Will Cassella <cassew@google.com> Cr-Commit-Position: refs/heads/master@{#805994}
-
Noah Rose Ledesma authored
This change implements a newer version of the global media controls UI based on updated UI mocks. Bug: 1124401 Change-Id: I0827b33ec97697ead88e7db4dd8b5248668bb236 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399619 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805993}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3b19b9d3347f..a4cfaa2dfc7f 2020-09-10 treehugger-gerrit@google.com Merge "tp: add support for gzipped traces in DecompressTrace" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ibdfea728bfd9a301334ab16e1cf7e6473a60ce41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404801 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Xinghui Lu authored
In incognito mode, the stored verdict count is always 0 because real time URL check is disabled. Therefore, CleanUpExpiredRealTimeUrlCheckVerdicts can return early to avoid the jank. Bug: 1095078 Change-Id: Ic6c8a5ee441d18cd26e4591186699a7597c158fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404743 Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#805991}
-
Dominic Mazzoni authored
Bug: 1041589 No-try: true Change-Id: Ib5d355bce4ba17e2da9cf26483e7de6e84495ce3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404152 Auto-Submit: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Meredith Lane <meredithl@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#805990}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/18f6a54fc3ce..0f64e0dfd845 2020-09-10 jlavrova@google.com An attempt to make font resolution more predictable. 2020-09-10 brianosman@google.com Clean up SkSL operator utility functions 2020-09-10 johnstiles@google.com Add InlineCandidateAnalyzer to locate candidate functions for inlining. 2020-09-10 brianosman@google.com Refactoring determine_binary_type to fix some bugs 2020-09-10 bungeman@google.com Mark FreeType bitmap font bounds as unknown. 2020-09-10 johnstiles@google.com Prevent inlining of recursive calls. 2020-09-10 herb@google.com combine origin and drawing matrix for drawGlyphRunList 2020-09-10 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 0a1061da0c7f to 87f25134a8c1 (7 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: reed@google.com Change-Id: I2de4f99acebad3bb8339c93cf13478026ee61693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404683Reviewed-by:
-
tby authored
Currently all file results have score 0.5, so let's add some scoring logic. This CL uses the fuzzy string match algorithm also used for apps to score file results. Bug: 1053637 Change-Id: Ia41dcca17c20909aec849ce3e0ee28f890bf6f2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396196 Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#805988}
-
Trevor Perrier authored
Previously, when in Incognito the browser UI language was used for Accept-Language and navigator.language. This changes it so that only the first language in the Accept-Language list is used. Bug: 1077547 Change-Id: I9d7e6748411e12dfc2969028cce8991840c6c481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2392440 Commit-Queue: Trevor Perrier <perrier@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Cr-Commit-Position: refs/heads/master@{#805987}
-
James Cook authored
These functions are used in hundreds of locations in the code base and there's no ongoing effort to deprecate them. New developers are sometimes confused when they write code that must use these functions. Delete the comments discouraging their usage. Bug: none Change-Id: I4d40956edc6168340a361b762eb741723d47c8d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404949 Commit-Queue: James Cook <jamescook@chromium.org> Commit-Queue: Stefan Kuhne <skuhne@chromium.org> Reviewed-by:
Stefan Kuhne <skuhne@chromium.org> Cr-Commit-Position: refs/heads/master@{#805986}
-
Yuke Liao authored
This reverts commit a3e6095c. Reason for revert: Fix test flakiness Original change's description: > Revert "[lacros] Support mojo connection in testing environment" > > This reverts commit 44a2bf3d. > > Reason for revert: New test times out. > https://ci.chromium.org/p/chromium/builders/ci/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/38462 > > Original change's description: > > [lacros] Support mojo connection in testing environment > > > > This CL supports setting up mojo connection between lacros and ash in > > testing and debugging environment, and it is done via a unix domain > > socket. > > > > Unix domain socket is only used in testing, not production because it > > allows a random process to connect to ash-chrome as long as it knows > > the socket path. > > > > Currently, only one lacros-chrome is allowed to connect to ash-chrome, > > so in the testing environment, test launcher will run tests serially, > > and will change to run in parallel once ash-chrome supports multiple > > clients. > > > > Bug: 1120582 > > Change-Id: I9736b03218f8fe937a7d642a35d6ee49b7e081f6 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384543 > > Commit-Queue: Yuke Liao <liaoyuke@chromium.org> > > Reviewed-by: Hidehiko Abe <hidehiko@chromium.org> > > Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#805537} > > TBR=jorgelo@chromium.org,hidehiko@chromium.org,liaoyuke@chromium.org > > Change-Id: I911a4d8bd80e8f0a217243503986a1a6d4a16338 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1120582 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403460 > Reviewed-by: Morten Stenshorne <mstensho@chromium.org> > Commit-Queue: Morten Stenshorne <mstensho@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805696} TBR=jorgelo@chromium.org,hidehiko@chromium.org,liaoyuke@chromium.org,mstensho@chromium.org # Not skipping CQ checks because this is a reland. Bug: 1120582 Change-Id: I3cf4c46e939ee71e57b30d435da58bd23d15c02a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404684Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#805985}
-
Michael Thiessen authored
https://chromium-review.googlesource.com/c/chromium/src/+/2398193 updated the reporting of the MobileIntent.PageLoadDueToExternalApp histogram to exclude Chrome self-launches. This change updates the histogram description to match. Bug: b/167573777 Change-Id: I56aa24f002b37acbd7bc65e2367fad817d0e0e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401801Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#805984}
-
John Delaney authored
This histogram is still useful, as it tracks full page network usage ads and other UMA metrics are split by main frame / sub frame. Bug: 1109947 Change-Id: I0636b490556254cb5dbb1802327f5ab6f8eb7632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401698Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#805983}
-
David Black authored
Previously a placeholder was used. We now have a more suitable icon. Bug: 1127111 Change-Id: I772313b316845fcd03d77ec37af1beeb72a2fcb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404065Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#805982}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/feb1579dfb25..3b19b9d3347f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ie9c11233985eab040a03597d4016e85164685758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404111Reviewed-by:
-
James Vecore authored
Change-Id: I756d575d9ce93df26f52c31201274dab67f2c0ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404391 Commit-Queue: James Vecore <vecore@google.com> Auto-Submit: James Vecore <vecore@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#805980}
-
Zentaro Kavanagh authored
- Styling wrapper for diagnostic cards - No styling is applied yet Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I21df9d3311aa54f8a21ef1f501a517c3e1a22e1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2403901Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#805979}
-
Becca Hughes authored
This is still gated by the NTP modules flag and the server side KS gating but we can turn it on so people can test it easier. BUG=1121360 Change-Id: I20736d9e8ebe594d03d510749eb9a2b5effaddab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401729 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
-
Sunny Sachanandani authored
ReadBackFramebuffer assumes that the destination buffer size and format match the source. However, this isn't true when exporting the buffer for software compositiing since it only supports RGBA_8888, but the buffer could be RGBA_F16. Also fixes undefined behavior due to using the same buffer as source and destination for SkPixmap::readPixels which does a memcpy under the hood. Bug: 1122638 Change-Id: I887f70ea65fdf7ad215f5db22b39d0727fc3d09a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393160 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#805977}
-
yiyix authored
ImageData::StorageFormatDataSize returns 1, 2 and 4 for the data size for color format in uint8, uint16 and float 32 format, respectively. This not really true, since we need 4 channel to describe a color, the data size should really be 4, 8 and 16 bytes instead. In image_data.cc, we always call ImageData::StorageFormatDataSize and then multiply the result by 4 to get the real data size. In this cl, I update ImageData::StorageFormatDataSize to return 4, 8 and 16 and remove the multiplication to improve the readability of the code. Bug: 1122866 Change-Id: Ib78e31cff3c919728a3a84771acf2545d29a89a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391984Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/fc83cdc8198b..8b9424e9da85 2020-09-10 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision b55cb19f..a3dcf9ef (805701:805834) 2020-09-10 hidehiko@chromium.org Expand is_linux to is_linux || is_chromeos. 2020-09-10 nisse@webrtc.org Make NetEqController::TargetLevelMs method const If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1110266 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7fd5d1de23efde64a3460a9ada88f679969c818e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405392Reviewed-by:
-
Andrew Comminos authored
Since the JS Self-Profiling API will require COOP+COEP to ship, it's no longer necessary to isolate by context. This is a step towards deprecating this functionality in V8 entirely, as context scraping depends on reads of potentially uninitialized memory. Bug: 956688 Change-Id: I6fb8c2565f1979991f6ef8f86ceefe82ce5a5e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387150 Commit-Queue: Andrew Comminos <acomminos@fb.com> Reviewed-by:
Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#805974}
-
Harvey Yang authored
This commit adds Sensor Hal Dispatcher, sensor mojo interfaces, and basic usages of them to connect clients to iioservice. BUG=chromium:1006141, b:162154663 TEST=builds, unit tests and test on octopus: Chromium connects to iioservice as a DBus client, and invites iioservice into the mojo network. Chromium then waits for iioservice_client (test executable) to register and establish a connection between iioservice and iioservice_client. All re-connections between Chromium and iioservice work well. Change-Id: I9f9ed4267093191ad306c25216300f850dc42006 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332056 Commit-Queue: Cheng-Hao Yang <chenghaoyang@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#805973}
-
David Black authored
These APIs will eventually be wired up to Holding Space UI. Bug: 1126274 Change-Id: I8c213459488dea838dd34e64f4c80dd57d466172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404470 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805972}
-
Tommy Li authored
Previously, the header expand/collapse chevron button was on the far right side of the header row. This looked like a bug sometimes, when the header started out collapsed. This CL moves the button to be directly adjacent to the header text. See the bug for details. Bug: 1127090 Change-Id: I23eba83d9ff58d31e6983af195fb219e668e9cbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404663Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#805971}
-
Daniel Classon authored
Adds deep links to the Crostini Page, including the Crostini Details, Import Export, and Android ADB subpages. Bug: 1084154 Change-Id: I0dd75e13999b5ce7f8c17b39442d20dc0bfea59b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2381072Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Daniel Classon <dclasson@google.com> Cr-Commit-Position: refs/heads/master@{#805970}
-
- 10 Sep, 2020 2 commits
-
-
James Cook authored
Type kBorealis had a FALLTHROUGH to the default case, which contains a NOTREACHED(). Remove FALLTHROUGH, since those are only needed for non-empty blocks. Remove default case, so the compiler will emit an error when an app type is not included. This reveals that AppType::kRemote was not being handled. No behavior changed expected. I just noticed this while working on an unrelated issue. Bug: none Change-Id: If55a1473c5739f5070b1377aae7e06da704a1806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393949Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#805969}
-
Daniel Murphy authored
This change adds 2 new install icons, and creates a configurable feature that will change the current icon to one of the new ones. Before: https://drive.google.com/file/d/1kjTrjTw1aPIBnEbZ018CEv3v9G25Q9Ve/view Download style: https://drive.google.com/file/d/1H6-GojGKMigLtSMBnqoJ3-H3SJYX5ZL9/view Device style: https://drive.google.com/file/d/1Cn1r6FCt4AxRPgMp0RGLM8P7w0fbTZJc/view Reference images: https://drive.google.com/corp/drive/folders/1m4CGxZJNP6PkQ6u7QHGPYuO5vy59fAlm Doc: https://docs.google.com/document/d/1D6vQpZR8X5l4rMCs9ErUvgxWNIPRK3iv4hGvy5qXSDo/edit# Bug: 1117260 Change-Id: Id4d0ca6e67ce13093fe4ed6344424810e6665f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401329Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
-
