- 19 Feb, 2020 40 commits
-
-
Regan Hsu authored
This CL adds user action recordSettingChange() calls in instances in OS settings related to the bluetooth page settings that the user can change. Change-Id: Id394d94dd7bb8f29de8dcadbfae0a5f6f2146c84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064607Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742816}
-
Kramer Ge authored
To reduce Gpu memory on low end device, GrContext and associated resources should be released. Abandoning GrContext directly results in resources associated to theVkDevice becoming lost. It's preferable to destroy entire vulkan context during background cleanup and re-initialize when chrome is foregrounded. Bug: 1048692 Change-Id: I6bb0740edee72413f0ac083d847d06e4427133ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047828 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742815}
-
Mason Freed authored
With this CL, the Enable Experimental Web Platform Features flag will enable declarative Shadow DOM. This makes it easier to test. Bug: 1042130 Change-Id: Ib18a9f39e9c3cb3e4a1fb35af95ba469360ab334 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064465 Commit-Queue: Philip Rogers <pdr@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742814}
-
Kyle Horimoto authored
Add all //chrome/browser/resources/settings/chromeos owners as owners of this directory as well; also update bug component. Change-Id: I55d54ed10afd418f92d52498c67a6eb5b4b6569b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065113 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#742813}
-
Sean Gilhuly authored
This mojo call was added for crbug.com/811945 to fix a Windows-specific bug. Restrict it to only be enabled on Windows. Bug: 1042259 Change-Id: I52f1f348e1de52e2d09a376e80852e1b8ae84d23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063417Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Sean Gilhuly <sgilhuly@chromium.org> Cr-Commit-Position: refs/heads/master@{#742812}
-
Jesse McKenna authored
crrev.com/c/2062275 recently marked webkit_layout_tests test events_referenceSpace_reset_inline.https.html as flaky on Mac10.12. Flaky timeouts were later seen on Mac10.10, .11, .12, and .13, as well as Win7, Win10, and Linux. This change expands on the previous change to include timeouts and all platforms. Recent flake occurrences: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyZAsSBUZsYWtlIlljaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L3dlYnhyL2V2ZW50c19yZWZlcmVuY2VTcGFjZV9yZXNldF9pbmxpbmUuaHR0cHMuaHRtbAw TBR=alcooper@chromium.org Bug: 1053903 Change-Id: Iadd595c835d73083dfeb660010a7be5e1f086b87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062583Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#742811}
-
Brandon Maslen authored
During another change/need to iterate over all storage partitions it was noticed that other places in Chromium have the same requirement. This change exposts a GetStoragePartitionCount method off of having to iterate over the collection of partitions to achieve the same result. In addition the existing call site of this method has been updated to call the BrowserContext version. content: :BrowserContext in order to avoid other classes Change-Id: Ie60b726841f6955f7df5128cbe89955ea0e3a98d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057808 Commit-Queue: Brandon Maslen <brandm@microsoft.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#742810}
-
Nico Weber authored
They were apparently used by some old code coverage system long ago. https://chromium-review.googlesource.com/c/chromium/src/+/764949/ removed tools/code_coverage/croc.py well over 2 years ago, so we probably don't need these files either. Bug: 784464 Change-Id: I2cb1c7ee973c26b673a225659967516f5bf922d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036804 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Auto-Submit: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742809}
-
Peng Huang authored
We will start finching vulkan on Linux and Android soon. We still need the flag. Bug: None Change-Id: I6d760c537a1767416bd354c8d87be25ba51ef0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062578 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#742808}
-
Sahel Sharify authored
The DCHECK happens when PaymentRequestState::OnDoneCreatingPaymentApps() gets called after the merchant has called Abort(), and no supported method exists. This is because the supported method callback which gets called inside OnDoneCreatingPaymentApps() tries to set a NotShownReason after the Abort() call which has already set the AbortReason. In this cl the state_ gets notified about Abort() calls, and clears the pending (if any) supported method call back on abort. A test will be added in a follow up cl to test abort() call before OnDoneCreatingPaymentApps() once cross platform payment app factory is ready (crbug.com/1054115) Bug: 1040194 Change-Id: I8985fd805df05e656b271e4dac4bb4d20a7fb045 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065049Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#742807}
-
Aaron Leventhal authored
This is temporary until we have a proper fix. Bug: 1052334,1050598 Change-Id: I6e9370dbac191acea5543d3d015b19f75554e48b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062878 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#742806}
-
Khushal authored
R=ellyjones@chromium.org Change-Id: I042268169b55fe23d3d22933d49a44919cd8653f Bug: 976583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065051 Commit-Queue: Khushal <khushalsagar@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Auto-Submit: Khushal <khushalsagar@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#742805}
-
gogerald authored
Bug: 1051226 Change-Id: Ieee0fcb41ff6f3d1282b709cffd23ed381102687 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050754Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#742804}
-
John Smith authored
Bug: 1052427 This follows up http://crrev.com/c/1941064. The hue shift, with certain accent colors could cause unexpected changes like a red accent titlebar turning to blue when inactive. This change is to remove the hue shift so the color overall stays in the same space but to still maintain as close to the kGoogleGrey900 (0x20, 0x21, 0x24) -> kGoogleGrey800 (0x3C, 0x40, 0x43) as possible. With kGoogleGrey900 as the input, this code outputs (0x3B, 0x3E, 0x44). I chose this one because it was very close to (0x3C, 0x40, 0x43) and kept the overall color biased towards the green and blue channels. Some other options considered were: return {-1, 0.53, 0.567}; #3C3E43 return {-1, -1, 0.57}; #3F4043 return {-1, -1, 0.569}; #3F4042 return {-1, -1, 0.572}; #404144 return {-1, -1, 0.568}; #3E3F42 return {-1, 0.55, 0.567}; #3B3D44 return {-1, 0.54, 0.567}; #3B3E44 return {-1, 0.54, 0.57}; #3D3F45 Boosting the red channel and losing the green were resulting in slightly warm and faded colors that didn't feel like they fit in the Chromium color set. Tested against the default Windows set of accent colors and saw differentiation between active and inactive windows without unexpected color shifts. As a note on existing behavior, the colors of the new tab button and background tab text can switch between active/inactive window states. Change-Id: Ib67d11c720c58036cb255aee743916d6a8f2bab9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063737 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#742803}
-
Nnamdi Theodore Johnson-Kanu authored
This CL continues the process of separating the strings into specific files. Strings used by both Chrome OS and Chrome browser settings sync control subpage and settings signout subpage are removed from setting_strings.grdp and added into shared_settings_strings.grdp. This effort was started in parent 2042733. Bug: 967883 Change-Id: I2c41bd3589f357bd5b2496f4eaeecccae2e00ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044478 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#742802}
-
Ella Ge authored
TBR=sahel@chromium.org No-try: true Bug: 1054103 Change-Id: I609442d233fdca819d1070087b2fec9a54b61edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064473Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#742801}
-
Ahmed Fakhry authored
TBR=oshima@chromium.org BUG=none Change-Id: I2b483d216edc3d12c8b64a926d0e68de6efdfab0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064814 Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742800}
-
Daniel Murphy authored
For the histograms: WebCore.IndexedDB.BackingStore.DeleteDatabaseStatus WebCore.IndexedDB.BackingStore.OpenFirstTryResult The data is good, I just have the wrong enum specified. This change fixes that. R=mpearson@chromium.org Bug: 1026889 Change-Id: I7213c6b576e9a94c50e875c856721181d7efb1e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064817Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Auto-Submit: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#742799}
-
Travis Skare authored
This is towards servicification. Bug: 1050259 Change-Id: Ia32c670da08b2026b46b8e64030e1f2054a19a22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045136 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#742798}
-
Ella Ge authored
test is flaky. TBR=sahel@chromium.org No-try: true Bug: 1054062 Change-Id: I761b165af9cfa93747cedd55ba96416c5c96a810 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064825Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#742797}
-
Ella Ge authored
test is flaky TBR=rouslan@chromium.org No-try: true Bug: 1054058 Change-Id: I5cde06091075615d5d879455154bf20c7cf288db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065134Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#742796}
-
Nic Champagne Williamson authored
This change fixes updating the hovered and pressed states of toolbar buttons in hovered and pressed states on linux when in incognito. The |COLOR_TOOLBAR_BUTTON_ICON_HOVERED/PRESSED| theme properties now correctly update when the theme changes in GtkUi::UpdateColors(). Bug: 1053856 Change-Id: I5d7a98edd2174baeff6f14aa72cdc767779ffec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2065050Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#742795}
-
Robert Ogden authored
Unblocks //net work that assumes NIK and site for cookie match. Bug: 1053585 Change-Id: I249070ccad9540ffd13649887df6e63c00f9875f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063934Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#742794}
-
Ahmed Fakhry authored
Since https://crrev.com/c/2044644, the desk bar is an activatable window placed in the active desk's container. Removing the active desk from overview means hiding its container, and showing another one. The desk bar should be one of those windows that move to the newly-activated desk's container when its original (previously-active) desk is removed. BUG=1053771 TEST=Manually, expanded an existing test. Change-Id: Id4bb2084ac0117fab4334819c9d79e40e8a565d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063810Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#742793}
-
Maks Orlovich authored
The passed in site_for_cookies_ (which considers the entire frame hierarchy) is what should be used, not origin, which is for local frame only. (Android Webview is the only embedder in Chrome tree that uses this knob) Bug: 1052454 Change-Id: I9d25321648d6312df9c3113a3c681fbbb6e71f60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062937 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#742792}
-
Sven Zheng authored
This reverts commit 6d8aca62. Reason for revert: We decide not adding a bot in chromium.win. Original change's description: > Move win pixel tests from fyi to chromium.win > > Now Skia Gold can make comments on gerrit, so it's time to move this > out of fyi. > > Bug: 958242 > Change-Id: I1274cc5da4feb7e9904bf788b9d9d7633dfeac5b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053803 > Reviewed-by: Garrett Beaty <gbeaty@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#741231} TBR=bsheedy@chromium.org,gbeaty@chromium.org,svenzheng@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 958242 Change-Id: Iec0093cf4ca9959b71f15e5fe28d669990ed5ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063913Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#742791}
-
Min Qin authored
BUG=103742 Change-Id: I214cd5413b01aae5fc022c45f72965dd360b889e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055971Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#742790}
-
Ella Ge authored
Test is flaky. TBR=sahel@chromium.org No-try: true Bug: 1054108 Change-Id: Iba8f8b36d7f972928571462f50493efc36892d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062886Reviewed-by:
Ella Ge <eirage@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#742789}
-
Ian Barkley-Yeung authored
ChromeOS already has an OS-level consent system governing creation and uploading of crash reports. Remove the separate crashpad one. FYI, crashpad's upload consent was already being ignored. This is just ensuring that fact is clear. BUG=chromium:1037656 TEST=Ran on Linux with --enable-crashpad, could enable and disable crash uploading. Ran on ChromeOS with --enable-crashpad, crash reports still generated. Change-Id: I1a8bbafb3292009fdb02ecc84dd1506535766e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044641 Commit-Queue: Ian Barkley-Yeung <iby@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#742788}
-
Olivier Li authored
The calls update the work id before doing internal work and/or waiting for it. Bug: 851163 Change-Id: I6fc302a5b160800aef0973e1d21681555b1f924a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063036 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#742787}
-
Sami Kyostila authored
This change makes it a requirement to pass in TaskTraits to base::PostDelayedTask(), bringing it in line with the other task posting APIs. This patch has no functional changes. Bug: 968047 Change-Id: I67daf3c1560f9c386578d458a45a3c791786141e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985773 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#742786}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I4c5b6724a26aa5acbe5e359a21f66b9ecb94933c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062572Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#742785}
-
Felicia Lim authored
Tested media/test/data/opus-trimming-test.ogg/webm/opus-trimming-test.ogg playback in a chrome session (see https://bugs.chromium.org/p/chromium/issues/detail?id=1051111#c6) Bug: 1051111 Change-Id: Ib9a4b3a91d09720939286f9101c5ac61048b1dc2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057642Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#742784}
-
Xiaohui Chen authored
Bug: 149759085 Test: run integration tests Change-Id: Ib6ef5db411f7e1eb6571ca5568178536e726b1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062685 Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742783}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL, the route list of settings subpage routes in isOSSettingsSubPage was incomplete. The CL adds chromeOS routes that were missing. ChromeOs pages which can be opened by android intents are added to the ChromePage enum. Originally this listed was curated and only whitelisted chrome pages could be added. This was because of security concerns. https://chromium-review.googlesource.com/c/chromium/src/+/750501/. In https://chromium-review.googlesource.com/c/chromium/src/+/784396/ whitelisting was removed and all settings URLs where now accessible to android intents. Bug: 982445 Change-Id: I67a1bb665f4705fe5a379f7da920878732606628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036935Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Cr-Commit-Position: refs/heads/master@{#742782}
-
Long Cheng authored
This is a reland of ace0df39 Original change's description: > Fix default page break for Krane devices. > > Adding default page break too early will cause the default page break > gets deleted immediately. > > Now move the installation of default page break after ChromeOS settings > app is installed. > > Bug: 1031410 > Test: Manual > > Change-Id: If8d6522993518ccc109ac0bf368cdd077a97f301 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056578 > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Commit-Queue: Long Cheng <lgcheng@google.com> > Cr-Commit-Position: refs/heads/master@{#742304} Bug: 1031410 Change-Id: I6367b3ae44a05f85a014723078c6718ac4832c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064601 Commit-Queue: Long Cheng <lgcheng@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742781}
-
Sven Zheng authored
Fix test failure when binary built with --dcheck_always_on=true. Bug: 958242 Change-Id: Ic4645e517c0f29169e444fb1b6d3b1b2921720d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063223 Auto-Submit: Sven Zheng <svenzheng@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#742780}
-
Piotr Bialecki authored
Bug: https://crbug.com/1054042 Change-Id: I5b3009997f76ec79f9ffc6abb1ba669f3f010ce9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2063671 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#742779}
-
Xiaoqian Dai authored
- The back gesture contextual nudge ui will appear when a user navigates to the second page within any Chrome apps in tablet mode. Show frequency: * It only shows once per active day for over 3 days per user * and the user hasn't been done back gesture successfully for 7 times Bug: 1009005b Change-Id: Ide2dbf46be1dfcd0963d4466448f5a6ff5d62f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2062917 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#742778}
-
Anastasia Helfinstein authored
There have been a few major refactors of Switch Access recently. This change looks at AutoScanManager and cleans up things that are now overly complex, or need adjusting. Bug: None Change-Id: Ic77fb49a143ce91ff90099f773f613bd2f9e55ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056502Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#742777}
-