- 17 Jun, 2017 40 commits
-
-
Daniel Cheng authored
Current, there's a different internal implementation of WebFrameWidget for main frames, to disguise the fact that WebView happens to be a WebWidget as well. Rather than exposing this implementation detail, just make the Create() function do the right thing. TBR=thestig@chromium.org Change-Id: Ic6c5701953b16350ddbc927fb6355956d5724b54 Reviewed-on: https://chromium-review.googlesource.com/538737 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#480299}
-
Daniel Cheng authored
Bug: 494719 Change-Id: I8c6f86d1ccee6c3aed22d8ff432f089d6b66db76 Reviewed-on: https://chromium-review.googlesource.com/538918 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#480298}
-
Naina Raisinghani authored
Currently, the text-decoration-style property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the ETextDecorationStyle enum and use the generated CSSValueID <-> ETextDecorationStyle mappings. Currently, the text-decoration-color property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to an 'external' field so that its getters/setters can be generated as well. Diff: https://gist.github.com/nainar/49078d95b56a6df0beb6e03ecb75a0f9/revisions BUG=628043 Change-Id: I7b1e280c5dfca8ebdf37256f772248bda3135be6 Reviewed-on: https://chromium-review.googlesource.com/536534Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#480297}
-
xunjieli authored
The linked bug is fixed. This CL converts debugging CHECKs to DCHECKs. TBR=mmenke@chromium.org BUG=723589 Review-Url: https://codereview.chromium.org/2943853002 Cr-Commit-Position: refs/heads/master@{#480296}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cdf1a8a4..175a5959 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2940363003 Cr-Commit-Position: refs/heads/master@{#480295}
-
Hiroshige Hayashizaki authored
This CL also makes Resource::SetEncoding() protected and exposes TextResource::SetEncodingForTest() instead. Bug: 725654 Change-Id: I5ae53df9b134524601cb280969648263f639b8d3 Reviewed-on: https://chromium-review.googlesource.com/535859Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#480294}
-
Reilly Grant authored
Back when this mojom was written it was more ergonomic to use an optional array because non-optional arrays always required initialization. Now that arrays map to std::vector and so are empty (instead of null) by default it is more ergonomic to make this field non-optional. The interpretation of the field when null or an empty is the same. Change-Id: I8a61d90f5ccbaec7bdd7f415315cff3d91345d07 Reviewed-on: https://chromium-review.googlesource.com/530525 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#480293}
-
carlosk authored
Updates AddUniqueUrlsTask (still empty of actual business logic) to use store commands as an abstraction layer for the execution of operations on the persistent prefetching store. Only concrete test version of commands are provided; actual SQL backer implementations will come later. This also adds all the business logic needed for that task to work as the 1st step of the prefetching pipeline but for NWake scheduling. The latter will require a new abstraction to be created and will be left for a follow up patch. BUG=701939 Review-Url: https://codereview.chromium.org/2920083002 Cr-Commit-Position: refs/heads/master@{#480292}
-
Charles Harrison authored
Bug: None Change-Id: I6a49de3b39db542577558b389fc30910c2e4dd1a Reviewed-on: https://chromium-review.googlesource.com/527457Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#480291}
-
David Trainor authored
- If there are external downloads active, pause the DownloadService downloads to not disrupt typical user usage. - This also means updating DownloadDriver to expose all active downloads so that on startup the DownloadService can properly set it's state. Bug: Change-Id: Icf3204a1cedafeb9565fc577dc2c4cda3ad283b4 Reviewed-on: https://chromium-review.googlesource.com/537966 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#480290}
-
eugenebut authored
Chrome prefix is used for ChromeWebView framework name, but not in any other class names, hence removed. BUG=None Review-Url: https://codereview.chromium.org/2943063002 Cr-Commit-Position: refs/heads/master@{#480289}
-
Dominic Mazzoni authored
BUG=727290 Change-Id: Id54681bca8dce8b6a19d40c713a397a43e761d33 Reviewed-on: https://chromium-review.googlesource.com/527912Reviewed-by:
Paul Miller <paulmiller@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#480288}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/95d19f3ba2ff..f86d3680b19f $ git log 95d19f3ba..f86d3680b --date=short --no-merges --format='%ad %ae %s' 2017-06-16 brucedawson Enable constexpr for VC++ 2017 Created with: roll-dep src/third_party/skia BUG=341941 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: Ic4678f6f05c4d1ae023d3be64c493caef8254d1e Reviewed-on: https://chromium-review.googlesource.com/539027Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#480287}
-
piotrs authored
Custom Tab opened from a _blank link or a window.open() call is opened in a separate Android task to mimic a new window/blank context of a web browser. This is done in order to improve UX and bring more app-like feel to PWAs. Transition to CCT for regular navigation is already done (codereview.chromium.org/2829943002), this patch brings the same to _blank and window.open(). This requires some changes to Custom Tabs, as WebContents for the new window is already created when we get to Java layer. I replicated the trick from ChromeTabCreator with remembering WebContents on AsyncTabParamsManager during the transition. Tests asserting that _blank and window.open() are opened in TabbedChrome has been removed from WebappModeTest. Tests for transition to CCT has been added to WebappNavigationTest. On Lollipop and above we maintain at most one CCT task per installed Webapp. Below Lollipop there is no API I could use to enforce that I think, let me know if you know the way. BUG=709889 Review-Url: https://codereview.chromium.org/2898373002 Cr-Commit-Position: refs/heads/master@{#480286}
-
Alexei Filippov authored
Change-Id: I40b37cf499c7b065a6e0b9d4782d6dc07c51a0da Reviewed-on: https://chromium-review.googlesource.com/538929 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#480285}
-
Darren Shen authored
Currently, the text-overflow property is a 'storage_only' field, so it has no generated public getters/setters. This patch changes it to a 'keyword' field so that its getters/setters can be generated as well. We also generate the ETextOverflow enum and use the generated CSSValueID <-> ETextOverflow mappings. Diff of generated files: https://gist.github.com/e1fab4f5465cda4efbc79c15ec5e2bfe/revisions Bug: 628043 Change-Id: I43b2808181780dd4ad7c90200c1f84884b4629c3 Reviewed-on: https://chromium-review.googlesource.com/536217Reviewed-by:
nainar <nainar@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#480284}
-
Daniel Cheng authored
TBR=wjmaclean@chromium.org Bug: 734308 Change-Id: I685c551e0c3b0ac820d8e052f6e20b69734ea5ee Reviewed-on: https://chromium-review.googlesource.com/538541 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#480283}
-
Daniel Cheng authored
Revert "Reland of Moves mojo_js_integration_tests into blink. (patchset #1 id:1 of https://codereview.chromium.org/2939663002/ )" Reason for revert: WebKit Android (Nexus4) are still broken with four failing tests: JsToCppTest.BackPointer JsToCppTest.BitFlip JsToCppTest.Ping JsToCppTest.Echo TBR=jbroman@chromium.org,dpranke@chromium.org,yzshen@chromium.org,jwd@chromium.org,alokp@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=699569 Change-Id: I925840dbe50bd21e6c87b03f23d6b4007d27df63 Reviewed-on: https://chromium-review.googlesource.com/538520Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#480282}
-
dcheng authored
Revert of [VSync Queue] Plug touch ack to gesture events and flush vsync queue if necessary (patchset #7 id:180001 of https://codereview.chromium.org/2869823003/ ) Reason for revert: Likely causing failures on Linux ChromiumOS MSan Tests. Original issue's description: > [VSync Queue] Plug touch ack to gesture events and flush vsync queue if necessary > > For a gesture event, we want to know whether the source touch event was handled > blocking or non-blocking, and we can flush the vsync queue immediately if it was > blocking. > > This patch will help avoid regression in |first_gesture_scroll_update_latency| > in |smoothness.tough_scrolling_cases|. > > After CL the process would be: > 1. Browser -> Renderer: Send touch > 2. Renderer -> Browser: Touch Ack > 3. Browser: Set |is_source_touch_event_set_non_blocking == true| if the ack was > |INPUT_EVENT_ACK_STATE_SET_NON_BLOCKING*| > 4. Browser -> Renderer: Send generated gesture events with > |is_source_touch_event_set_non_blocking| bit > 5. Renderer: Flush vsync queue if |is_source_touch_event_set_non_blocking == true|. > > BUG=704732 > > Review-Url: https://codereview.chromium.org/2869823003 > Cr-Commit-Position: refs/heads/master@{#480202} > Committed: https://chromium.googlesource.com/chromium/src/+/80553a96dc6712a24a7d0a3e3074d5b7f5f65338 TBR=dtapuska@chromium.org,sadrul@chromium.org,pfeldman@chromium.org,thestig@chromium.org,chongz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=704732 Review-Url: https://codereview.chromium.org/2943883002 Cr-Commit-Position: refs/heads/master@{#480281}
-
Daniel Cheng authored
This reverts commit 3b57fad2. Reason for revert: uninitialized read failures on WebKit Linux Trusty MSAN Original change's description: > bluetooth: Implement AddFakeService and convert tests > > Adds a fake GATT Service with |uuid| to be discovered when discovering > the peripheral's GATT Attributes. Returns a FakeRemoteGATTService > corresponding to this service. |uuid| should be a BluetoothServiceUUIDs > https://webbluetoothcg.github.io/web-bluetooth/#typedefdef-bluetoothserviceuuid > > Bug: 719816 > Change-Id: I7192509b94fcc3921c4d9e8d7117dfd325a79c7e > Reviewed-on: https://chromium-review.googlesource.com/527719 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Daniel Cheng <dcheng@chromium.org> > Reviewed-by: Vincent Scheib <scheib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#479943} TBR=dcheng@chromium.org,scheib@chromium.org,ortuno@chromium.org Bug: 719816 Change-Id: I63af8a28dc2abb0752c223be4691452dba066e85 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/539096Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#480280}
-
Daniel Cheng authored
This reverts commit c0181afc. Reason for revert: https://chromium-review.googlesource.com/c/527719/ needs to be reverted to fix MSAN bots, and this CL depends on it =( Original change's description: > bluetooth: Refactor bluetooth-helpers and tests > > 1. Changes method to return an object instead of an array. This will make it > easier to grab the desired fake attributes from helper methods e.g.: > > function getTwoBatteryLevelCharacteristicsDevice() { > return getHealthThermometerDevice() > .then(({device, fake_peripheral, fake_health_thermometer}) => { > return fake_health_thermometer.addFakeCharacteristic(...); > }); > } > > 2. Introduce getConnectedHealthThermometerDevice(). Similar to > getHealthThermometerDevice except the GATT discovery > response has not been set yet so more attributes can still be added. > > 3. Introduce getTwoHealthThermometerServicesDevice(). There is no order > guarantee when calling getPrimaryServices so test that need to > interact with a specific service might break. > > Bug: > Change-Id: I7ea23cf370521cf374652c473010dea48da47eee > Reviewed-on: https://chromium-review.googlesource.com/536379 > Reviewed-by: Vincent Scheib <scheib@chromium.org> > Commit-Queue: Vincent Scheib <scheib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#480137} TBR=scheib@chromium.org,ortuno@chromium.org Change-Id: If40b85b173f204aa367ec8cbfc71fdb3ef7cc993 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: Change-Id: I7ea23cf370521cf374652c473010dea48da47eee Reviewed-on: https://chromium-review.googlesource.com/539095Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#480279}
-
Daniel Cheng authored
This reverts commit a10aa3f9. [9951:9976:0616/143754.816121:ERROR:leak_tracker.h(99)] Leaked 0x3f3d443bb110 which was allocated by: [9951:9976:0616/143754.836410:ERROR:leak_tracker.h(100)] #0 0x7f394c22abab base::debug::StackTrace::StackTrace() #1 0x7f394c2298ec base::debug::StackTrace::StackTrace() #2 0x0000034c7e1f base::debug::LeakTracker<>::LeakTracker() #3 0x0000034c2e5b SystemURLRequestContextGetter::SystemURLRequestContextGetter() #4 0x0000034c4f13 IOThread::system_url_request_context_getter() #5 0x0000033f1c61 BrowserProcessImpl::system_request_context() #6 0x00000310389e safe_browsing::SafeBrowsingService::Initialize() #7 0x0000033f4682 BrowserProcessImpl::CreateSafeBrowsingService() #8 0x0000033f4556 BrowserProcessImpl::safe_browsing_service() #9 0x0000034cf310 ChromeResourceDispatcherHostDelegate::ChromeResourceDispatcherHostDelegate() #10 0x0000033f4e6c BrowserProcessImpl::ResourceDispatcherHostCreated() #11 0x000002d4e703 ChromeContentBrowserClient::ResourceDispatcherHostCreated() #12 0x7f394756faa9 content::BrowserMainLoop::BrowserThreadsStarted() Bug: 705816 Change-Id: I6f82c52d23e8a5f51439907501d3d89493ee9ef0 Tbr: afakhry@chromium.org Reviewed-on: https://chromium-review.googlesource.com/538540Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#480278}
-
chrome-release-bot authored
Cr-Commit-Position: refs/heads/master@{#480277}
-
jinho.bang authored
Revert of Make WebKitCSSMatrix an alias of DOMMatrix (patchset #16 id:300001 of https://codereview.chromium.org/2709763004/ ) Reason for revert: The WebKitCSSMatrix is not working after this change. Becuase the GeometryInterface is not shipped yet. Original issue's description: > Make WebkitCSSMatrix an alias of DOMMatrix > > DOMMatrix was changed sufficiently that WebKitCSSMatrix can be made a simple alias of it. > > Intent-to-ship Link : > https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/ > cAiTOdSGyes/Su7dlx32EQAJ > > BUG=581955 > > Review-Url: https://codereview.chromium.org/2709763004 > Cr-Commit-Position: refs/heads/master@{#479481} > Committed: https://chromium.googlesource.com/chromium/src/+/0ac2b97eb15689ba196f7f88b184b3a17f13d30d TBR=fserb@chromium.org,foolip@chromium.org,simonp@opera.com,timvolodine@chromium.org,dpranke@chromium.org,gogag2@gmail.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=581955 Review-Url: https://codereview.chromium.org/2943213002 Cr-Commit-Position: refs/heads/master@{#480276}
-
Evan Stade authored
Particularly noticeable for dark themes. Bug: 628312 Change-Id: I16dd1634a063202c6ea1d640a1d80e5c35e8fe56 Reviewed-on: https://chromium-review.googlesource.com/534833 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#480275}
-
Andrey Kraynov authored
platform/image-decoders Re-order includes to match git cl format rules, add forward declarations where possible. No change in behavior, no new tests. Bug:439655 Change-Id: Id80b3f4321e4ff4ef73e0cf3721f08d42a839fe0 Reviewed-on: https://chromium-review.googlesource.com/538674 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#480274}
-
rlanday authored
CompositionUnderline is a class that exists mainly so callers can specify the information necessary for creating CompositionMarkers (start/end offset, underline color, thickness, background color). It's currently also serving double-duty in InlineTextBoxPainter to pass this information around after it's retrieved from a CompositionMarker. With the introduction of painting support for ActiveSuggestionMarker in https://codereview.chromium.org/2925543003, this starts to seem kind of strange, if it didn't already (since we're creating CompositionUnderlines from non-Composition markers). This CL refactors InlineTextBoxPainter to pass around references to DocumentMarkers/ StyleableMarkers directly instead of creating CompositionUnderlines. BUG=707867 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2920373003 Cr-Commit-Position: refs/heads/master@{#480273}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/5f970fe6bed7..95d19f3ba2ff $ git log 5f970fe6b..95d19f3ba --date=short --no-merges --format='%ad %ae %s' 2017-06-15 mtklein support g8 and 4444 in SkRPBlitter 2017-06-13 mtklein Trim gEntries down from 24K to 3K. 2017-06-16 reed refactor lighting imagefilter to save codesize Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I0ccba4d489563aafe1b222c72b200187a46b8ba5 Reviewed-on: https://chromium-review.googlesource.com/539026Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#480272}
-
Nathan Parker authored
This adds a new WhitelistCheckerClient class that lets the caller provide a callback rather than extending SafeBrowsingDatabaseManager::Client, and makes ownership a bit simpler. Bug: 714300 Change-Id: I1005debdbd9afe6314962537b48ce5f25c521614 Reviewed-on: https://chromium-review.googlesource.com/524694 Commit-Queue: Nathan Parker <nparker@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#480271}
-
ios-autoroller authored
TBR=smut Review-Url: https://codereview.chromium.org/2938373004 Cr-Commit-Position: refs/heads/master@{#480270}
-
Hiroshige Hayashizaki authored
This CL doesn't change the behavior. Bug: 725654 Change-Id: I94d477b78f11112fb800e2ee04d4593731722ae8 Reviewed-on: https://chromium-review.googlesource.com/535858Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#480269}
-
chenwilliam authored
BUG=713901 Review-Url: https://codereview.chromium.org/2935393002 Cr-Commit-Position: refs/heads/master@{#480268}
-
justincarlson authored
Also, Rename the remaining printerdetector with the less prefix 'Usb' in preparation for other work on printer detection. BUG=734161 Review-Url: https://codereview.chromium.org/2945653002 Cr-Commit-Position: refs/heads/master@{#480267}
-
Thiago Farina authored
And mark CPU class as final. BUG=None Change-Id: Iaf9f96f388bbeca689114cd4c935c354ba8c8b3f Reviewed-on: https://chromium-review.googlesource.com/538638 Commit-Queue: Thiago Farina <tfarina@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#480266}
-
sullivan authored
TBR=simonhatch@chromium.org Review-Url: https://codereview.chromium.org/2946463003 Cr-Commit-Position: refs/heads/master@{#480265}
-
brucedawson authored
Doing another VS2017 test over the week end now to see if a recently discovered code-gen bug has been fixed. The VS 2017 package now uses VS 2017 Update 3 Preview 2 (was Preview 1 last time). At least one code-gen bug was fixed by Preview 2 but this bug may be a new one. This CL is currently purely for testing purposes and will be reverted by the end of the week end. R=scottmg@chromium.org BUG=683729,727671 Review-Url: https://codereview.chromium.org/2862723004 Cr-Commit-Position: refs/heads/master@{#480264}
-
sullivan authored
TBR=nednguyen@google.com Review-Url: https://codereview.chromium.org/2940423002 Cr-Commit-Position: refs/heads/master@{#480263}
-
ccameron authored
Add an explicit enable command line flag in ShellMainDelegate::BasicStartupComplete to enable this feature for layout tests, because it is already enabled for layout tests. R=asvitkine TBR=avi (content/), xiyuan (chrome/browser/chromeos/login) BUG=713889 Review-Url: https://codereview.chromium.org/2945453002 Cr-Commit-Position: refs/heads/master@{#480262}
-
Andrey Kosyakov authored
... instead of posting tasks to FILE thread. Bug: 689520 Change-Id: Ib2f602ac69076bf1701e7670f348260b407542c7 Reviewed-on: https://chromium-review.googlesource.com/535154Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#480261}
-
sullivan authored
TBR=nednguyen@google.com Review-Url: https://codereview.chromium.org/2945603003 Cr-Commit-Position: refs/heads/master@{#480260}
-