GitLab

This function uses automation to automatically write the name of a
program into the search box of the Apps & Features page.

Bug: 717696
Change-Id: Ifc6a1be295a3d06ac33f394dcf3fc4688bd4a907
Reviewed-on: https://chromium-review.googlesource.com/907590Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Greg Thompson <grt@chromium.org>
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540209}

This CL makes the existing shortcuts affect whatever
magnifier is currently enabled. This was also an
opportunity to unify some scale related code.

BUG=817490
TEST=Added test coverage

Change-Id: I366ee56629d09ae22c725b034bfc410077fe52ab
Reviewed-on: https://chromium-review.googlesource.com/942052
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540208}

With the direction both tracing and resource_coordinator has taken, there's no
actual shared code between the two; this undoes the original move from //services/tracing.

Mainly a mechanical move, except for starting up as an independent service.

Change-Id: I093015c419166655b2015f7eddf4477983a16af9
Reviewed-on: https://chromium-review.googlesource.com/939659
Commit-Queue: oysteine <oysteine@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ehsan Chiniforooshan <chiniforooshan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540207}

Change-Id: Ia0632c8b4fb4e3ba2daf9461f1ee11443db4efd8
Reviewed-on: https://chromium-review.googlesource.com/942028Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540206}

The nullptr was added in a past refactoring before
UserActivationV2 was ready.  Test failures with v2
enabled exposed the problem.

Bug: 816527
Change-Id: Ia94fb85831c9ca312d45695e10cb0701c836153a
Reviewed-on: https://chromium-review.googlesource.com/937659Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540205}

Moving ZipFileInstaller from chrome/ to extensions/ and changing it to
take a callback instead of directly installing the unpacked
extension/theme.

Providing a method in chrome/ to create a callback that does the
installation (previous behavior).

This CL is in preparation for using the Unzipper service to install
extensions, as some of the logic performed by the utility handler code
will be moved to this class and we'll be shared with the CrxInstaller
class.

Note that the zipfile_installer_unittest could not yet be moved to
extensions/, it will be done later (see crbug.com/817131).

Bug: 799220
Change-Id: I9ae6f13e5e9a0af4c111119952fd8915ff3dcfd3
Reviewed-on: https://chromium-review.googlesource.com/939842
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540204}

This change will be reverted after the M66 branch point.

ExtensionPopup Views will need some harmonization work to bring it up to
parity with some behavior provided by Mac.

BUG=728174

Change-Id: Ia01160117c9dbda10e57d4f4b5a4fe706a39f36c
Reviewed-on: https://chromium-review.googlesource.com/941883Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540203}

It happens when the form is prefilled when detected by the password manager.

Bug: 817754
Change-Id: Ia6c8ecd2257950aa34b3fedf796a9696c71cf4fb
Reviewed-on: https://chromium-review.googlesource.com/943503
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540202}

base/memory/ptr_util.h includes will be cleaned up later.

Generated by:
git grep -l base::MakeUnique chrome/browser/ | xargs perl -pi -e 's/base::MakeUnique/std::make_unique/'

Presubmit bypassed due to unrelated existing errors in touched lines.

Bug: 755727
No-Presubmit: true
Change-Id: Ib4480069b2a369566e6ae4a3d426a0797f5984bb
Reviewed-on: https://chromium-review.googlesource.com/943461
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540201}

When a password form is added dynamically (i.e. with JavaScript after finishing of a page load)
IOS Password Manager may learn about existing of this form only after user clicking on
some field in this form. On CL https://chromium-review.googlesource.com/c/chromium/src/+/601969
it was implemented retrieving credentials from the Password Store as soon as the user clicked
on dynamically added form and then credentials are autofilled. But fill on account select is not
available until the user makes another interaction with the form (for example start typing of
username). That's suboptimal user experience, it would be good to propose fill on
account select immediately as soon as the user clicks the first time in the form.

This CL implements async suggestion response to Autofill framework in the same way as it's
already implemented in Autofill:
1.When checkIfSuggestionsAvailableForForm (password_controller.mm) is called, and it's
found that credentials haven't been retrieved yet for this page, the callback is saved
untile response from the Password Store is received.
2.It's implemented that Password Store response is propagated to PasswordController even if case
when there are no credentials saved for this page in order to inform Autofill framework that
no suggestions are available.

Bug: 708597, 709011, 708634
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Idecc3e621100f3e1b0a3803ce944c4cc116fc3a4
Reviewed-on: https://chromium-review.googlesource.com/921961
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540200}

After this CL, CrossSiteDocumentResourceHandler won't call
|next_handler_|'s OnResponseStarted until it has made the allow-vs-block
decision.  Until that time network::ResourceResponse (which among other
things include the response headers) is stored temporarily in a
CrossSiteDocumentResourceHandler's field.

Postponing the call to next handler's OnResponseStarted confuses
MimeSniffingResourceHandler (which does the same thing to its downstream
handlers, but doesn't expect this treatment from its upstream handler).
The CL works around that by changing the relative order of the handlers
(after CL, MimeSniffingResourceHandler is before
CrossSiteDocumentResourceHandler).  This change requires that
the first CrossSiteDocumentResourceHandler::OnWillRead always allocates
a |local_buffer_|, because MimeSniffingResourceHandler will make the
first call to OnWillRead before letting CrossSiteDocumentResourceHandler
determine |should_block_based_on_headers_| by calling OnResponseStarted.

This CL adds CrossSiteDocumentResourceHandler unit tests that also cover
MimeSniffingResourceHandler in the stream of resource handlers.  The new
tests help ensure that CrossSiteDocumentResourceHandler interoperates
well with MimeSniffingResourceHandler (wrt call order and also the
sniffed mime type).  OTOH, the old tests are retained, because driving
CrossSiteDocumentResourceHandler more directly allows the tests to make
more assumptions about the internal state and make more test assertions
(e.g. assert that downstream buffer differs until the block-or-allow
decision is made).

Bug: 808205
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I304df0b40c71dd212a469b6b3cc4c13bed533fb0
Reviewed-on: https://chromium-review.googlesource.com/907323Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Nick Carter <nick@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540199}

Remove md_pin_keyboard.html/js. It shares a lot of common code with
cr_components/chromeos/quick_unlock/pin_keyboard.html.

Modify cr_comp../c/qu/pin_keyboard to take a bunch of mixins and vars,
so the settings keyboard and lock keyboard can keep their respective
styles.

Test: manual
Bug: 809828
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I618c5325fe374c590b6e232675e77a06435d2604
Reviewed-on: https://chromium-review.googlesource.com/930480
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540198}

Now that we emit private memory footprint, the former number is not
particularly meaningful.

Bug: 815328
Change-Id: I85cb76b08ef85073179b5c334c16d4775667b8e6
Reviewed-on: https://chromium-review.googlesource.com/940144
Commit-Queue: Erik Chen <erikchen@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540197}

In the new applist folders we re-use various components.

In AppsGridView we had a bool that was used to determine if we
should show suggested apps, but the bool did not check to see if
the AppsGridView was being used inside a folder.

This was causing a DCHECK failure because row was being computed as -1
when there were 2 items in a folder and a folder item is dragged to the
first position.

Bug: 817475
Change-Id: Ie50583e947f9b9b6ba37a536ae327f935531d35e
Reviewed-on: https://chromium-review.googlesource.com/941546Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540196}

https://pdfium.googlesource.com/pdfium.git/+log/9002cd8cb5c9..198792b7e860

$ git log 9002cd8cb..198792b7e --date=short --no-merges --format='%ad %ae %s'
2018-03-01 thestig Fix some nits in CFX_DIBSource::CloneConvert().

Created with:
  roll-dep src/third_party/pdfium


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I11dcd89b441046fc2187787900934d004e20603b
Reviewed-on: https://chromium-review.googlesource.com/943245
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#540195}

This CL establishes the correct ordering of the IPC which transmits the
seatbelt profile to the child process. It must first map the FD into the
child process, while launching the child process, and only send the
profile once the child process is launched.

Bug: 816824,801889
Change-Id: I453e307cc8f9a7416011ecc4eb101e702b11bca0
Reviewed-on: https://chromium-review.googlesource.com/939986Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Greg Kerr <kerrnel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540194}

This splits the various RemoveClientFromCache implementations into two
parts:

 1) removal of cached data from the resource, and
 2) invalidation of the client.

This avoids triggering invalidations as a side-effect of cache-
invalidation, and separates concerns to help future refactorings. This
also means that resources that perform no caching, or no per-client
caching, need not override RemoveClientFromCache, but can use a default
implementation.

Since a kParentOnlyInvalidation argument to MarkClientForInvalidation is
a no-op, it is removed in the relevant code-paths.

LayoutSVGResourceContainer::MarkClientForInvalidation is made static to
enable its use outside resource containers themselves.

RemoveClientFromCache gets a new semantic in that it returns a bool
indicating if anything was cached for the client (this is currently
needed for invalidation of clients of filters.)

Bug: 769774
Change-Id: I8deeaef8fdd46e6dcc171100e8d6394df483e232
Reviewed-on: https://chromium-review.googlesource.com/941332Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#540193}

Change-Id: I3bbbf936cce2d57dd918d64e8b406dd1b9f9c201
Reviewed-on: https://chromium-review.googlesource.com/943524
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540192}

Network traffic annotation is added for credential update of Cloud Print
Proxy Backend.

Bug: 656607
Change-Id: I0dab745bfa4efae24d6091f99b2ac1090d230f33
Reviewed-on: https://chromium-review.googlesource.com/926011
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: Scott Byer <scottbyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540191}

Fix an issue in AnimationWorkletGlobalScope binding generation where
EffectProxy was not being exposed in that scope.

It also adds a test to verify all the interfaces that are exposed in
the animation worklet global scope under origin trial.

The test is relying on console.log and expectation file which is
why I decided to not write it as a testharness based test.

Bug: 811922
Change-Id: If13d3797f908d3f0a3945480e22c6e63cad9f76e
Reviewed-on: https://chromium-review.googlesource.com/935702Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jason Chase <chasej@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540190}

The Feature-Policy HTTP header was not being properly replicated when
set in a frame for which proxies already exist. This change fixes the
problem by ensuring that the header is sent to RenderFrameProxy objects
and properly updated there after a nagivation commits.

Bug: 814887
Change-Id: I8dc5bcd3b0af28c36183d467ff5b886062dc41a3
Reviewed-on: https://chromium-review.googlesource.com/940422
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540189}

This CL updates the the Search Icon used in the toolbar to focus the
omnibox based on the default search engine for the application.

Bug: 816843
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ib40e76ed7e8837f8c1150252b9a169e822b93363
Reviewed-on: https://chromium-review.googlesource.com/943067
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540188}

Adds a new "post scroll" state in which we extrapolate briefly before
ending a scroll.

Bug: 817173
Change-Id: I9ce00d4e958c7535e8ab42edf14a1261ab805956
Reviewed-on: https://chromium-review.googlesource.com/941365
Commit-Queue: Ian Vollick <vollick@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540187}

Saman has been contributing high quality CLs to Viz for a long time.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ia1143cd79817c3eea0b589690ac822505481da5e
Reviewed-on: https://chromium-review.googlesource.com/943593Reviewed-by: Saman Sami <samans@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540186}

Multiple PageHandlers can be created with isolating subframes. This
breaks the devtools toggle which expects a single PageHandler for the
main frame.

This CL adds a bit to the PageHandler which classifies whether it is
for the main frame. If it is not, then it cannot change the filtering
toggle.

Bug: 813197
Change-Id: I7698985822f5ee159399bd1d37884436c5278d0b
Reviewed-on: https://chromium-review.googlesource.com/939602Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540185}

If enterprise policy specified the SafeBrowsingWhitelistDomains,
Chrome should trust URLs in these domains.
This CL covers:

1. Safe Browsing will not check for dangerous resources if their
URLs match these domains (a.k.a no SB interstitial shown)
Note that, we don't plan to skip SSL error checking even if domains
are whitelisted.

2. Safe Browsing's password protection service will not check
 for password reuse if the page URL matches these domains.

Changes in download protection, client phishing/malware detection,
incident reporting, ads sampling will be in separate CLs.

Bug: 811454
Change-Id: Ia439642ed1d68890ace4b8049aaec187158e2f5c
Reviewed-on: https://chromium-review.googlesource.com/927531Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Commit-Queue: Jialiu Lin <jialiul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540184}

This needed to be done at some point. The motivation here was to fix an
extensions WebRequest API test with the Network Service enabled.

This also plumbs through a signal so extensions API test JS code can
detect whether Network Service is enabled. This is used to support
conditional expectations in WebRequest tests since the test-only
event behavior may differ slightly between Network Service and old
networking.

Bug: 721414
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I009061f038eb3171721fe7645444695a77f3cfd3
Reviewed-on: https://chromium-review.googlesource.com/940447
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540183}

A fairly direct copy of CoerceJavaScriptNullOrUndefinedToJavaValue.

Bug: 794320
Change-Id: I6d057198262f589334d100800da63151280a38ce
Reviewed-on: https://chromium-review.googlesource.com/941902Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540182}

TBR: dpapad
Bug: 812947
Change-Id: Ib7193b8859e2a105d4d802b267f4fce6775e7a42
Reviewed-on: https://chromium-review.googlesource.com/942883
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540181}

A fairly direct copy of CoerceJavaScriptStringToJavaValue.

Bug: 794320
Change-Id: I4e7cbd020fe9702d59c84a32e0e986f970feace1
Reviewed-on: https://chromium-review.googlesource.com/941788Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540180}

This lets us use it in tests under //chrome/browser.

Bug: 704259
Change-Id: Ic814dd88e5a676e13a0b9629fc422ec70df4f6cd
Reviewed-on: https://chromium-review.googlesource.com/941642
Commit-Queue: Douglas Creager <dcreager@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540179}

This CL adjusts the blur effect used by the toolbar to the one requested
in crbug.com/807778.
It also adjust the color of the tools menu button to match the one from
the other buttons.

Bug: 807284
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ia03bacf8563cf4b0f9a33a1b4e57dff47b67bfbc
Reviewed-on: https://chromium-review.googlesource.com/941441
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540178}

A fairly direct copy of CoerceJavaScriptBooleanToJavaValue

Bug: 794320
Change-Id: Ifac567f8b5d300a89d4057e47bb45a28863e715f
Reviewed-on: https://chromium-review.googlesource.com/940346Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540177}

This mainly serves as a test for https://crbug.com/816323, but also
removes two DCHECKs that were wrong.

This CL also removes UserMediaProcessor::RequestInfo::HasPendingSources()
since it was used just for implementing two DCHECKs, one of which is no
longer valid due to other recent changes.

No behavior change is intended.


Bug: 816597, 816323

Change-Id: Icfddae5f9a9709e9702f696cb70f289697bdcb6b
Reviewed-on: https://chromium-review.googlesource.com/938041Reviewed-by: Harald Alvestrand <hta@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540176}

Fix errorprone UseCorrectAssertInTests warnings and make
sure it is treated as error after this CL.

http://errorprone.info/bugpattern/UseCorrectAssertInTests

Bug: 803482
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic337a2e0313986961af4390c38bfa47bfdb46325
Reviewed-on: https://chromium-review.googlesource.com/938642Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Reviewed-by: Peter Wen <wnwen@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Rob Buis <rob.buis@samsung.com>
Cr-Commit-Position: refs/heads/master@{#540175}

  1. Rename SpdySettingsIds --> SpdyKnownSettingsId.
  2. Add a "using SpdySettingsId = uint16_t" statement, and replace
     where appropriate (e.g., raw on-the-wire values; should be a
     non-functional change),
  3. Perform minor refactoring of the utility method for converting
     a SETTINGS ID to a string.

This is a first step to additional support for unknown SETTINGS IDs.

Also perform some minor lint clean-ups to appease `git cl lint`, including
string and base::StringPiece --> SpdyString(Piece) (note that the original
error was to include <string>), adding #includes, and fixing line lengths.

This CL lands server change 186360913 by diannahu.

BUG=488484

Change-Id: I99c7efea92e11e355255e54ee70f4a8d1d6496b4
Reviewed-on: https://chromium-review.googlesource.com/938603
Commit-Queue: Dianna Hu <diannahu@chromium.org>
Reviewed-by: Bence Béky <bnc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540174}

Modify this text fixture to parameterize it over multiple device scale
factors.

Bug: 680606
Change-Id: I247afdf39ab9e640c711372ca6d07c66897d6bbd
Reviewed-on: https://chromium-review.googlesource.com/943341Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540173}

The InputPane APIs first appeared in RS1 version. RS2 or later SDK
is required to build Chrome so changing the version shouldn't be a
problem.

BUG=817501

Change-Id: I1ed1f4a630ffe1d913dee47c03ad4fd45f3c6759
Reviewed-on: https://chromium-review.googlesource.com/941913
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540172}

This test was disabled almost four years ago for unknown reasons and
passes fine on my machine. Let's see if the bots agree.

https://codereview.chromium.org/209293002

Change-Id: Id62e8c362b7b73861697ad1a82c0189471f60080
Reviewed-on: https://chromium-review.googlesource.com/891188Reviewed-by: Anita Woodruff <awdf@chromium.org>
Commit-Queue: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540171}

This reverts commit cef2d52e.

Reason for revert: It's just plain wrong. It broke some viz tests and
it caused the breakage in 817771. We probably want an EvictLastActivatedSurfaces({framesinks}); API instead.

Original change's description:
> Surface synchronization: Don't evict surface on DelegatedFrameHost::WasResized
> 
> If we evict a surface before the previous CompositorFrame activates with it
> as a fallback, then we will attempt to add an invalid reference and we may
> end up with missing surfaces in surface aggregator. This CL combats the issue
> by avoiding evicting frames during resize.
> 
> We will still only update the primary surface ID if the tab is not hidden,
> and we will clear the fallback surface ID if the tab is hidden.
> 
> Bug: 813157, 672962
> Change-Id: Ie0b408af503ec9fefdcccc5fb0607cf015734052
> Reviewed-on: https://chromium-review.googlesource.com/938678
> Reviewed-by: Saman Sami <samans@chromium.org>
> Commit-Queue: Fady Samuel <fsamuel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#539639}

TBR=fsamuel@chromium.org,samans@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 813157, 672962
Change-Id: If7a78d81d23e646bb52f1d1f666613c6e54af383
Reviewed-on: https://chromium-review.googlesource.com/943161Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Commit-Queue: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540170}