- 23 Jul, 2019 40 commits
-
-
Jamie Madill authored
conformance/textures/image_bitmap_from_video/tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html conformance/textures/misc/texture-corner-case-videos.html Bug: 986808 Tbr: ynovikov@chromium.org Change-Id: I0d6733208b9edac595c374f46b65d123c124370d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714946Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#679985}
-
Tanmoy Mollik authored
For accounts that have sync disabled by enterprise policy syncing option should not be available. For those accounts show the message "Sync is disabled by your administrator" Screenshot: https://crbug.com/933649#c20, https://crbug.com/933649#c27 Bug: 933649 Change-Id: I199d81b0c315ccc9773fe4d9629f1ed0d53dd075 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1695311 Commit-Queue: Tanmoy Mollik <triploblastic@google.com> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#679984}
-
Ben Kirchman authored
FakeCronetController is used to create fake CronetEngines and control responses to UrlRequests that the fake CronetEngine makes. Primarily, the test should instantiate a FakeCronetController and from that instance generate CronetEngine.Builders which will use their FakeCronetController for responses once they are built. The FakeCronetController can also be used statically to retrieve a FakeCrontroller that is created by the production code, such as via FakeCronetProvider. To do this, it maintains a static list of all fake CronetEngines in order of creation. This list can be retrieved and the desired CronetEngine can be passed back to the FakeCronetController's static method getControllerForFakeEngine() in order for the test to get a pointer to the controller for it's production code's CronetEngine. It should be noted that a CronetEngine.Builder can build multiple fake CronetEngines which will all point to the same controller. This is also true for multiple calls of getFakeCronetEngineBuilder: the created CronetEngines will all use the same controller. Design Doc: https://docs.google.com/document/d/1IsBwiqR5f6ksvmHPq5skV802C02We8zjK-c552Tp4lE/edit#heading=h.7nki9mck5t64 Bug: 669707 Change-Id: I8955a97e4a4a6dd8040b5b30fea3c5cbeae30221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1701534 Commit-Queue: Benjamin Kirchman <kirchman@google.com> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#679983}
-
François Beaufort authored
Following WebGPU spec change at https://github.com/gpuweb/gpuweb/issues/326, the GPUFenceDescriptor parameter from GPUQueue.createFence() should be optional. Bug: 877147 Change-Id: Icee75ccfb21449041254506c3560a86aa67f9437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713555 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Auto-Submit: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#679982}
-
Mario Sanchez Prada authored
Move this method from the content.mojom.Frame Mojo interface into Blink, as part of a new blink.mojom.SurroundingText Mojo interface, and add a new class there to implement such interface (i.e. blink::SurroundingTextImpl), to replace usages of content.mojom.Frame's GetTextSurroundingSelection() from the browser process. Note that this SurroundingTextImpl class still relies on WebSurroundingText and WebLocalFrame to keep the change smaller, but this is a temporary step that will be corrected once WebSurroundingText has been moved out of the public API and into renderer/core, which will happen on a follow-up CL. Bug: 980151 Change-Id: I62fb2d5b24a98773c1acddbe1c58217c1a2d53e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1696968 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#679981}
-
Mike Dougherty authored
Xcode parallelization may be causing clearBrowsingData test failures. Disable it for now to comare test runs. Example failure: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8907218548939539872/+/steps/ios_chrome_ui_egtests__iPhone_X_iOS_13.0__shard_2__with_patch__on_Mac-10.14.4/0/logs/SigninInteractionControllerTestCase__x2f_testSignInCancelIdentityPicker/0 Change-Id: I253ec52254dc259f90768c5556f3b547eb1b5ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710006 Auto-Submit: Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#679980}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/85ef3eab9407..61689ab0630a git log 85ef3eab9407..61689ab0630a --date=short --no-merges --format='%ad %ae %s' 2019-07-23 mbonadei@webrtc.org Make api/video:encoded_image public. 2019-07-23 titovartem@google.com Improve low bandwidth audio test instrumentatin, fix PC test Created with: gclient setdep -r src/third_party/webrtc@61689ab0630a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: None Change-Id: Ie0b81d336b4eaa6152d1577edf4c9806bad1b88a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714337Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679979}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. First, it changes the parameter of ExtractCredentials() to PO2TS from O2TS and moves O2TSDelegate and FakeOAuth2TokenServiceDelegate to components/signin/internal/identity_manager along with PO2TS. And it makes separate LoadCredentialsState from O2TSDelegate to components/signin/public/identity_manager/credential_state.h to expose it to AboutSigninInternals. Last, it moves GetDelegate() to PO2TS and cleans up O2TS. Bug: 967598 Change-Id: I36ad430ee9405ec30d4e5fe41e2ffc1df6e7ac9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712560 Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#679978}
-
Andrew Grieve authored
As suggested by r8 team. Bug: 985372 Change-Id: I2ca93568d06800a7bf82476ef0ca106492084fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711251Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#679977}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fc854c30fb5c..5207f35f33b1 git log fc854c30fb5c..5207f35f33b1 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 jlavrova@google.com The current version... Created with: gclient setdep -r src/third_party/skia@5207f35f33b1 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@google.com Bug: None Change-Id: I9760e9888d98f908740142dbfd53e57eae962b86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714336Reviewed-by:
-
Maxim Kolosovskiy authored
This reverts commit 475fb228. Reason for revert: It may cause test failures (not sure about dependence). Build: https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29/78019 [1676:8220:0723/051724.438:FATAL:feature_list.cc(396)] Check failed: field_trial_list_ == FieldTrialList::GetInstance() (1F64EEE0 vs. 1F64EAA0) Backtrace: base::debug::CollectStackTrace [0x6F1004CC+60] (o:\base\debug\stack_trace_win.cc:284) base::debug::StackTrace::StackTrace [0x6F0FF56E+78] (o:\base\debug\stack_trace.cc:206) base::debug::StackTrace::StackTrace [0x6F0FF4E2+34] (o:\base\debug\stack_trace.cc:203) logging::LogMessage::~LogMessage [0x6F14E994+132] (o:\base\logging.cc:625) base::FeatureList::GetFeatureOverridesImpl [0x6F107588+408] (o:\base\feature_list.cc:396) base::FeatureList::GetCommandLineFeatureOverrides [0x6F1077C4+52] (o:\base\feature_list.cc:197) base::FieldTrialList::CopyFieldTrialStateToFlags [0x6F183561+273] (o:\base\metrics\field_trial.cc:896) content::BrowserChildProcessHostImpl::CopyFeatureAndFieldTrialFlags [0x5F687066+54] (o:\content\browser\browser_child_process_host_impl.cc:215) content::UtilityProcessHost::StartProcess [0x60B50B06+1222] (o:\content\browser\utility_process_host.cc:365) content::UtilityProcessHost::Start [0x60B5139F+15] (o:\content\browser\utility_process_host.cc:260) content::`anonymous namespace'::ContentChildServiceProcessHost::Launch [0x607FAB47+919] (o:\content\browser\service_manager\service_manager_context.cc:209) service_manager::ServiceInstance::StartWithProcessHost [0x612FB5E5+1029] (o:\services\service_manager\service_instance.cc:263) service_manager::ServiceManager::FindOrCreateMatchingTargetInstance [0x6131D62F+2895] (o:\services\service_manager\service_manager.cc:312) service_manager::ServiceInstance::BindInterface [0x612FDB0A+282] (o:\services\service_manager\service_instance.cc:482) Original change's description: > Move histogram(_test).[cc|h] to platform/instrumentation > > They're much better placed there than directly under platform/ > > Bug: 919385 > Change-Id: I9583741da31e28217a9f331322ca8246984b94eb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713190 > Commit-Queue: Sergio Villar <svillar@igalia.com> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Mike West <mkwst@chromium.org> > Cr-Commit-Position: refs/heads/master@{#679926} TBR=svillar@igalia.com,haraken@chromium.org,mkwst@chromium.org Change-Id: I78428e66cc8bb69c35459af7f3b206b943db3cb6 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 919385 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713518Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#679975}
-
Sergey Ulanov authored
Previously Viz ran in-process when Vulkan is disabled. Now it will always run in GPU process. This makes it more consistent with other platforms and the way Fuchsia will work in the future. Also reverted crrev.com/678470 since it's no longer needed. Bug: 962617 Change-Id: I8ba03b0ab8b7707f81ee3bba59eddb12a11015b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1711050Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#679974}
-
Julie Jeongeun Kim authored
This CL is a part of moving access token management to OAuth2AccessTokenManager. It is specifically a step toward folding O2TS into PO2TS now that O2TS is only one subclass of PO2TS. It moves to kInvalidRefreshToken from OAuthTokenServiceDelegate to GaiaConstants not to include oauth2_token_service_delegate.h from AccountManager. Bug: 967598 Change-Id: I22542afd976a66e4137b14fd63a3dc7ae98e67f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712425Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e1edd548c20f..ec869c11c79d git log e1edd548c20f..ec869c11c79d --date=short --no-merges --format='%ad %ae %s' 2019-07-23 saklein@chromium.org board_build_dependency: Simplify naming. Created with: gclient setdep -r src/third_party/chromite@ec869c11c79d The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia440b51bdaae2ec04cc73cfcdfc8e9e556f5e6ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714334Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e22412aeb9a3..50d644e41333 Created with: gclient setdep -r src-internal@50d644e41333 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=nhiroki@google.com,pmonette@google.com,sky@google.com,kolos@google.com Change-Id: I4bc035c81f3b98ec737d44ca48a1f1e74eb3f84f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714133Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679971}
-
Majid Valipour authored
fixed-position and absolute-position were incorrectly placed. Change-Id: Ibb53bbc1c61867921551f7b4e49574cb71df56d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706395 Auto-Submit: Majid Valipour <majidvp@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#679970}
-
Mehran Mahmoudi authored
This fixes a failure in progress bar unit tests. Bug: 985363 Change-Id: I4140a8485ecf13ad5065fcae163737a38eab581c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713341Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#679969}
-
Vasiliy Telezhnikov authored
This implements SkiaOutputDeviceBufferQueue. It's similar to GLOutputSurfaceBufferQueue & BufferQueue but adapted to work with SkiaRenderer. It is used for 'surfaceless' GLOutputSurface like Surface Control on Android ( GLSurfaceEGLSurfaceControl ) Bug: 980653 Change-Id: I696d95c246621eb52c6474c8637396d70cf9459a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708418 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#679968}
-
Robert Ma authored
This reverts commit aad9c7d7. Reason for revert: upstream change was reverted at https://github.com/web-platform-tests/wpt/pull/17973 Original change's description: > Temporarily mark external/wpt/fetch/api/response/response-consume-empty.html as flaky > > https://github.com/web-platform-tests/wpt/pull/17946 is currently blocking > WPT imports, as the change causes the expected output to change on every > run. > > Unblock WPT imports by temporarily marking it as flaky while we figure out a > proper solution. > > TBR=robertma,yhirano > > Bug: 986286 > Change-Id: I0dd6e3f8ef3ab7b50823dcb87cdda9f9e8c9588e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713186 > Reviewed-by: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> > Reviewed-by: Robert Ma <robertma@chromium.org> > Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> > Cr-Commit-Position: refs/heads/master@{#679579} TBR=raphael.kubo.da.costa@intel.com,yhirano@chromium.org,robertma@chromium.org Change-Id: I2ea1381d4ceb61c969fdeedf12f6bda8dcbaf53e No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 986286 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714332Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#679967}
-
Richard Knoll authored
After showing the "Sent to device" success message to the user, we want to gradually fade out the message while collapsing the icon. Bug: 986743 Change-Id: Ifb32d5c7b4e70b73fe68ba1f38e8bc04c18ed47e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713534 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#679966}
-
Harald Alvestrand authored
Delete nonstandard attribute maxRetransmitTime, and make both maxPacketLifeTime and maxRetransmits nullable. (Usage of both attributes has been measured to be negligible.) Bug: 696681 Change-Id: If37e38114d4718b868413ea8ced9527c88510c15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710557 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Steve Anton <steveanton@chromium.org> Cr-Commit-Position: refs/heads/master@{#679965}
-
Javier Ernesto Flores Robles authored
Bug: 976671 Change-Id: I0580312f05fbe896744935d08db8706d364f9813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713512 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#679964}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ea16b570. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" ee7626e7 "Fixing tranferFromimageBitmap-toBlob-offscreen.html to not be flaky" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I904901ad03bcc427eaeb160fa785e3961be37f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714908Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#679963}
-
Mugdha Lakhani authored
for Periodic Background Sync. Also added a web_test to verify the expected interfaces. Bug: 925297 Change-Id: I9d8791d676becaf4816918cac75bd4fec13363ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713504 Auto-Submit: Mugdha Lakhani <nator@chromium.org> Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
-
Benoît Lizé authored
This is enforced indirectly in base/android/linker/config.gni, make sure this is the case. Bug: 979638 Change-Id: I14e07db20e1e9a147e9c2305b3a6bea8f69cfa87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713632Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#679961}
-
Josh Karlin authored
Bug: 976866 Change-Id: Ie98bfbb223b94c54f5defdba41722f251bfb8251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714281Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#679960}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cde26f18fbf1..c53c2f80508e git log cde26f18fbf1..c53c2f80508e --date=short --no-merges --format='%ad %ae %s' 2019-07-23 fmayer@google.com Merge "Fixes to tracing API README." Created with: gclient setdep -r src/third_party/perfetto@c53c2f80508e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I71fe25e73fbe0d6eadd20daa6fe1759d7bf504a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714135Reviewed-by:
-
Ben Kirchman authored
FakeCronetEngine should be used in tests to test apps' uses of CronetEngine. Design Doc: https://docs.google.com/document/d/1IsBwiqR5f6ksvmHPq5skV802C02We8zjK-c552Tp4lE/edit#heading=h.7nki9mck5t64 Bug: 669707 Change-Id: Ide40204e9d0942cc2fc5361f42cefcf56b405fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680733 Commit-Queue: Benjamin Kirchman <kirchman@google.com> Reviewed-by:
-
Rune Lillesveen authored
Early return to avoid DCHECK and following crash in StyleForPseudoElement(). Bug: 979573 Change-Id: Ib286ccd62193c6b85b910cd8b127c37189aedd53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713532Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#679957}
-
Andrew Grieve authored
Script is often used to test size changes. We don't care about lint failures and also would like it to build faster. Change-Id: I19f30d6a2aca0619e27ee43ebef515fc9e0f7a77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710510 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#679956}
-
Jan Wilken Dörrie authored
This change renames WebAutofillClient::HasFillData() to TryToShowTouchToFill() and moves the corresponding implementation logic to autofill::AutofillAgent and autofill::PasswordAutofillAgent. As a consequence of this change the kTouchToFillAndroid moves from password features to autofill features. Bug: 957532 Change-Id: I302285e46437bae4682113e451c784f97d0851b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1702610Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#679955}
-
Himanshu Jaju authored
Bug: 986264 Change-Id: Id10d11cf9c7c3275edad838cbbcba13fc2ade8da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712674Reviewed-by:
Richard Knoll <knollr@chromium.org> Commit-Queue: Himanshu Jaju <himanshujaju@chromium.org> Cr-Commit-Position: refs/heads/master@{#679954}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/78011069970f..249e60896429 git log 78011069970f..249e60896429 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 perezju@chromium.org Reland "[Telemetry] Implement new top level parser" Created with: gclient setdep -r src/third_party/catapult@249e60896429 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:928275 TBR=skyostil@google.com Change-Id: I7f1c5b0e86b444674d8b4f13da8eeab37121ba13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714134Reviewed-by:
-
Christopher Grant authored
Supersize compares sections sizes between the map and elf files to ensure they match. However, with partitioned libraries, some sections are automatically generated when extracting the partitions from the original combined library, and hence impossible to compare sizes. Similarly, the map file contains duplicate sections for each partition. Since SuperSize currently analyzes the main .elf, we need to ignore sections (eg. .text) for the partitions. In the future, the script can be improved to return section sizes for all partitions (ie. a set of sets of section sizes). Bug: 982334 Change-Id: I240d06bdaa405c9c1984ddf82e4244fc9df5dda2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708201 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#679952}
-
stkhapugin authored
This prevents the trialing button from being accessible by voiceover when it's not enabled. Bug: 985763 Change-Id: Ibf1e1270984c76df5c54373beb15f0f222b6ab07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713513 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Philip Jägenstedt authored
Because `[NoInterfaceObject]` is used, this is essentially an internal rename, but can be observed by scripts in principle by calling `event.toString()` or `Object.getPrototypeOf(event).constructor.name` given an instance. However, this type of dependency is unlikely. This will make unprefixing a smaller change. Bug: 570968 Change-Id: Ib7bba61df2a8b087146b49db81918eaf5950bc5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713552Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#679950}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: Id65e5d833e4ccf16df6fa5c15f321b7bd38becb7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710599 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
-
Alex Chau authored
- message_id with serial number in Android secondary users: 0:1563805165426489%20#0bb84dcff9fd7ecd - Expected message_id: 0:1563805165426489%0bb84dcff9fd7ecd - As per go/persistent-id, userId# (20#) is optional, and should be stripped when comparing persistent ids. Bug: 986270 Change-Id: I123f0412afcbaaae625a04000aeb7c86770b769b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712881 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Cr-Commit-Position: refs/heads/master@{#679948}
-
Leo Zhang authored
Change single contact to a group. Extend some important metrics to end of next Q1 Bug: 937152 Change-Id: Iee335114d66b1bc2d7ea37d4720b6e9edbb436cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712953Reviewed-by:
Leo Zhang <googleo@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Auto-Submit: Leo Zhang <googleo@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#679947}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/02407743bd72..cd369bb8a251 git log 02407743bd72..cd369bb8a251 --date=short --no-merges --format='%ad %ae %s' 2019-07-23 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 76b75c40a1e2..3855447d93eb (3 commits) Created with: gclient setdep -r src/third_party/angle@cd369bb8a251 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=jmadill@chromium.org,jmadill@google.com Bug: chromium:None Change-Id: I2b5bcc828ac029e5d5cfcded4d10845aa74a0151 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1714132Reviewed-by:
-
