- 23 Jul, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/7923b3e3d972..3ee5f2f1d331 2020-07-23 johnkslang@users.noreply.github.com Merge pull request #2356 from greg-lunarg/kg112 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC timvp@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: timvp@google.com,radial-bots+chrome-roll@google.com Change-Id: I96891f8fc3f837bcf31d6f5c09c33eed632f086f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315280Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791135}
-
Chih-Hsuan Kuo authored
cpp-blacklist blocks the usages of functions named index(), so renaming index() to buffer_index(). Bug: b/161843942 Change-Id: I1baaf7b591c0a59381f820b16a2f1976d772df57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311596 Commit-Queue: Chih-Hsuan Kuo <chkuo@google.com> Auto-Submit: Chih-Hsuan Kuo <chkuo@google.com> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#791134}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/72db7173488e..d318489a1566 2020-07-23 mtklein@google.com use new cubic code for old cubics 2020-07-23 bsalomon@google.com Pass -Wno-psabi to clang If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: Ib2b0f6fd489683e07c89ccf901c9261e22bbe7e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315619Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I7b71a83c8ad3f310353ecc4a4a745d386881f211 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315083Reviewed-by:
-
Avi Drissman authored
This is a reland of 780e443e This was blamed for compile failures that were actually due to a roll of a broken macOS SDK. Original change's description: > Update core items for macOS Big Sur. > > - Update the base::mac::IsOS*() functions. Introduce a parallel set > of IsOS#() functions to match the IsOS10_#() functions. Update all > tests to match, and update callers where appropriate. > - Turn on the CFAllocator OOM killer for Big Sur, as the > internals of CFAllocator have not changed. > > BUG=45650, 1101439 > TEST=base_unittests > > Change-Id: I57438eb025316e3cb899a0fa5aef35f4d297855f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285930 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Commit-Queue: Avi Drissman <avi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791051} Bug: 45650 Bug: 1101439 Tbr: mark@chromium.org Change-Id: I3e5c0a18ad97a77811833534bc5f1b302cc6a73b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315162Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#791131}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I12d6261c425f42eb340289ecc558c6dbd5c8fb2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315010Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791130}
-
Jiajia Qin authored
When enable passthrough cmd decoder in CrOS, below errow are printed repeatedly when accessing aquarium demo. ERROR:overlay_processor_ozone.cc(212)] Unable to find the NativePixmap corresponding to the overlay candidate It seems that it will always return a nullptr when it's passthrough. This change will remove this limitation. Bug: chromium:1096442 Change-Id: I54faeedcc5ffe4bafae1f7a2a57ecd21c766ceb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311899 Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791129}
-
Chromium WPT Sync authored
Using wpt-import in Chromium ce3b82a3. With Chromium commits locally applied on WPT: a02f2df5 "Implement Storage Access commands for TestDriver" 9c2ef271 "[COOP report] Add support for report-only" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org, guidou@chromium.org, philipp.hancke@googlemail.com: external/wpt/webrtc NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I2ff1ef1a382d912671c2c82cc0963645118be0a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315298Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791128}
-
Joel Hockey authored
Apps such as the Terminal System App should use the default tab strip. Fixed: 1090208 Change-Id: I12d2b188c94772e90dd8620b4aef811b99c5681c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315656Reviewed-by:
Collin Baker <collinbaker@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#791127}
-
Andrew Grieve authored
This reverts commit 660b5933. Reason for revert: Broke android-archive-rel https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8874020961794812528/+/steps/compile/0/stdout Original change's description: > Android: Use direct deps for cronet and modules > > Remove allowlist for bypassing turbine direct deps since the last items > in the allowlist (cronet and modules) have been removed. > > Bundle feature modules require the base module in their classpath. > Previously they were able to get by since the base module was added to > their transitive classpath, but the base module should be in their > direct classpath as it is used directly in R.java via inheritance. > > Fixed: 1082904 > Bug: 1082904 > Change-Id: I75d89815de894c64581b98e35243aca5bc8d4e93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314757 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Auto-Submit: Peter Wen <wnwen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791117} TBR=wnwen@chromium.org,agrieve@chromium.org Change-Id: Iac0700e90845d2e1b85ed860abbff4c6c942df42 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1082904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315009Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#791126}
-
Alice Boxhall authored
AX-Relnotes: n/a Bug: 1108155 Change-Id: I21deaabd6404ba392fb38d7fb9d4b004a9f21173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310061 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#791125}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I266227acefc8e9475a95d1e01333be8137445b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315248Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/ffb31229fce4..ca8f856ac1ab 2020-07-22 cnorthrop@google.com Tests: Update gfxbench traces If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Test: Test: angle_perftests --gtest_filter=TracePerfTest.Run/* Change-Id: I6602efa76a54f4535a6a48c9435e620cbe8f2966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314731Reviewed-by:
-
Marijn Kruisselbrink authored
Should hopefully also fix test flakiness where tests seemed to already be running into this. Fixed: 1074123 Change-Id: If57c8d6f622c17d795bc1429f66485cda94befd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313763Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#791122}
-
Rachel Wong authored
This CL makes the SearchResultBaseView::GetFirstResultView method non-virtual, adds a default implementation, and removes the existing overrides. The default implementation matches the existing override implementations. Bug: None Change-Id: I51188cbc19d4564ddd9677915304d489f30b03c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309495Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#791121}
-
Amr Aboelkher authored
Previously, it wasn't possible to use shell-encryption anywhere to be included. The main reason was Abseil wasn't supporting component build, but now it's. Also, adding the SHELL to the gn check. Bug: 1094744 Change-Id: Ia2b39a221e81808c6579118bab659285ebe2db0f TBR: thakis@ Change-Id: Ia2b39a221e81808c6579118bab659285ebe2db0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245899 Commit-Queue: Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#791120}
-
Mark Mentovai authored
The macOS 11.0 20A5323l SDK in Xcode 12b3 12A8169g totally hides the kCGColorSpaceITUR_2020_PQ_EOTF declaration in an #if whenever the SDK version is ≥ 10.16, which of course it always is. Chrome does use that constant, so work around the SDK bug by providing our a local declaration when that SDK version is in use. Bug: 1108561 Change-Id: I6ed31d30705bc754616e413c38fb250a7934484d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315078Reviewed-by:
-
Alexey Baskakov authored
Since web app name is never empty, we can always use GenerateIconLetterFromAppName function. GenerateIconLetterFromUrl becomes unused. As a result, unit tests must provide non-empty web app title. Bug: 1103570 Change-Id: I0f79446574d97725d757be9fbc09af7e74a19950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312056Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#791118}
-
Peter Wen authored
Remove allowlist for bypassing turbine direct deps since the last items in the allowlist (cronet and modules) have been removed. Bundle feature modules require the base module in their classpath. Previously they were able to get by since the base module was added to their transitive classpath, but the base module should be in their direct classpath as it is used directly in R.java via inheritance. Fixed: 1082904 Bug: 1082904 Change-Id: I75d89815de894c64581b98e35243aca5bc8d4e93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314757 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
This test tries to verify that two operations on a file and its parent directory are properly ordered relative to each other when they are queued. However the underlying FileSystemOperationImpl implementation gives no guarantees that one operation executes before another if the second is started before the first finished. In this specific case, Truncate involves first querying quota, while removing a directory immediately proceeds to recursively delete it. Making it very well possible that the delete happens before truncate tries to actually modify the file. To properly fix this the queueing behavior in SyncableFileOperationRunner would probably need to take target paths of any in progress tasks into account when triggering new tasks. Bug: 1092668 Change-Id: Ic4a16dc1eb792a1a3dd3f319e8afca9b78d75357 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314811 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Marijn Kruisselbrink authored
In content_shell --run-web-tests on linux there is no SelectFileDialog implementation. Deal with this by aborting the dialog if we failed to create one. Bug: 1027908 Change-Id: Ibf4d3f1f91a719945140d88deb89dd3218efda36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314808 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/184f6013466b..72db7173488e 2020-07-22 fmalita@chromium.org [skottie] Add spread/choke support for glow styles 2020-07-22 johnstiles@google.com Combine coverage in GrAppliedClip using RunInSeries. 2020-07-22 michaelludwig@google.com Rename GrTAllocator to GrTBlockList 2020-07-22 reed@google.com Add CubicResampler to makeShader 2020-07-22 brianosman@google.com Add several more unit tests of runtime effects 2020-07-22 bsalomon@google.com Disable MIP filtering on D3D using maxLOD. 2020-07-22 zepenghu@google.com add create ddl fuzzer If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC robertphillips@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: robertphillips@google.com Change-Id: I23090bc88d51e1d1aa86e8440328335963942812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314733Reviewed-by:
-
Hiroki Nakagawa authored
As a part of the Onion Soup project, this CL moves FrameRequestBlocker from content/renderer/loader/ to blink/renderer/platform/loader/. Bug: 860403 Change-Id: I89776755d1580211e4b5d8b57bc1e3b07b4f7046 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310515 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Dominic Farolino <dom@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#791113}
-
Tarun Bansal authored
Adaptively change duration to wait before showing offline indicator. If the device has been recently online, then we wait a long time before showing an offline indicator. This gives device sufficient time to switch over to a different network. If the device has not been recently online (e.g., at the app startup or when app is brought to foreground), we wait shorter time of 2 seconds before invoking the offline indicator callback. This shorter duration is sufficient to catch racing issues related to Android API callbacks, i.e., 2 seconds is sufficient that we receive connection change callback from Android when app is brought to foreground. Having the 2 different timeouts ensures that we respond faster when needed while reducing the false positives when the device is taking too long to switch the network. This approach may still lead to indicator being temporarily wrong in some niche edge cases, but eventually (at most 10 seconds) the snackbar would be correct. Change-Id: I6ef350c86973d8449be54930d1e1972706eb5c92 Bug: 1084740 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303983 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#791112}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cc02814e07b3..29cc4f31047a 2020-07-23 jalyn@microsoft.com Fix Network Datagrid focus bug If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1107381 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ifd6a7e0f15835dd074c87eac4cf4ef072521a2cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315441Reviewed-by:
-
Caleb Raitto authored
By handling serialization of each type explicitly, we avoid serializing padding bytes. Bug: 973801,1106091 Change-Id: I9f4e6b82fb484b9256b25b531cc2d51c800425bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2309004 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#791110}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1595437495-48d009be52961ba2cab16cb5f417b3b20b5e946c.profdata to chrome-mac-master-1595461632-4ccfdc8488548d109e77211e6ed2d2e949d446f2.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Idb926b3a6442ec8731bae8157fb3640bbb003bda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315277Reviewed-by:
-
Scott Violet authored
CoreFaviconService contains the methods needed by the favicon implementation. FaviconService now extends CoreFaviconService. BUG=1076463 TEST=covered by tests Change-Id: Ic352fe1430176843e324f70f21f5448c7dc76d35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313098 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#791108}
-
Anupam Snigdha authored
In VK APIs, we register callbacks with input pane whenever show/hide APIs are called. These callbacks are called by the OS when VK is about to be shown or hidden. Sometimes, the callbacks from the OS comes after the owner of the COM objects get destroyed. This submits a task that has a BindState that contains a tuple of WeakPtr to the owner of |this| object and the functor. For some reason(may be due to timing) that has already been destroyed. The COM objects get released by the OS after the Worker thread COM delegate task runner gets flushed in |WorkerThreadCOMDelegate::GetWorkFromWindowsMessageQueue|. This patch adds checks to prevent posting of tasks if the COM objects are invalid. It also adds code to de-register the callbacks during destruction of the VK ref counted object. Bug: 1104227 Change-Id: Icdd7dd309eac941f23eed88184db34d77bd28571 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311721 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yohei Yukawa <yukawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#791107}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dc3f2b55c360..cebfb4e614a8 2020-07-22 mabian@microsoft.com Adding --skip-title option to git cl upload If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Ib8b2a3919c0602156c0451a5fccdbb25f8f6f856 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314732Reviewed-by:
-
Reilly Grant authored
This change adds more manual Web Platform Tests (internal only for now) which validate the errors that are thrown when a port is disconnected during a read or write operation. The Windows implementation has been simplified to treat more errors as disconnections rather than depending on a window message to detect when the device has been removed. The POSIX implementation gains similar checks for errors that indicate a disconnect and also makes sure to stop watching the file descriptor in those cases because on macOS attempting to add a file descriptor to kqueue when the serial port is closed unexpectedly triggers an error. Bug: 884928 Change-Id: Ie1ba6607913d961a310efac2e363df889336e487 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303288 Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Matt Reynolds <mattreynolds@chromium.org> Cr-Commit-Position: refs/heads/master@{#791105}
-
David Grogan authored
We can do this now that issue 1094311 is fixed. The new DCHECK is triggered by issue 1102183 earlier than the one in the report. The real fix for this issue will come later. Bug: 1102183 Change-Id: I5235ece346e31724c103a3fb53a5bf920ec8a657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311040 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791104}
-
Bailey Berro authored
This change enables Display Identification and Display Alignment Assistance by default. Bug: 1070122 Change-Id: I7424c5d7a8a33fda0753c8c8249f94f15da94d49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308876 Auto-Submit: Bailey Berro <baileyberro@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#791103}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/19031583c314..82e85676c3b3 2020-07-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 8d6c555e..24ce4f08 (790803:790975) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I0a6a28fb4c5f99030e68e97808b71eb17d845a4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315189Reviewed-by:
-
Mason Freed authored
With [1], these tests hopefully no longer fail. This CL re-enables them, with the hope that they are no longer flaky. Several of these needed a re-baseline to capture the correct focused highlight color. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1084509#c21 Bug: 1050039 Fixed: 1104118, 1104134, 1104186, 1100783, 1057518 Change-Id: Ia1765b65064a50e912f9ee2f25aa4b4a32564011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310928Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#791101}
-
mhasank authored
In this change we simply forward the error message to UI. We will add the message strings in another CL. BUG=b:62613791 TEST=deploy to dut, disable playstore, re-enable playstore, successfully finish the authorization flow i Change-Id: I3191c238912762f8469dfcd473c41ce265a01254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305232 Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#791100}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3e7ab19bbf9..d115cfdcf564 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kelvinjiang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1107615,chromium:912681 Tbr: kelvinjiang@google.com Change-Id: Ie772ba32f307298b81aad95306fb35cb5e6d285d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315416Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791099}
-
Mason Freed authored
A new Origin Trial [1] has been approved for M85-M87. This CL connects that origin trial to the runtime enabled feature for DeclarativeShadowDOM. [1] https://developers.chrome.com/origintrials/#/register_trial/2024368032503037953 Bug: 1042130 Change-Id: If0e695318690b29cb6bad0bb5a24217105984069 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307617 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#791098}
-
Kelvin Jiang authored
This reverts commit d108df6e. Reason for revert: Highly likely this is the culprit behind test failures seen on https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=SSLUITest.SHA1IsDefaultDisabled&testType=browser_tests%20on%20Mac-10.15 Original change's description: > Add CertVerifierBuiltin fieldtrial_testing_config for mac. > > Bug: 973650 > Change-Id: I60375e858ac017b2b1ae96ad7bff8ce8aa6ffc97 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310830 > Commit-Queue: Matt Mueller <mattm@chromium.org> > Reviewed-by: Ilya Sherman <isherman@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790974} TBR=isherman@chromium.org,mattm@chromium.org Change-Id: I7b3ad283cd048880f4920cac1472f3fbe208f238 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 973650 1108632 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315444Reviewed-by:
Kelvin Jiang <kelvinjiang@chromium.org> Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#791097}
-
Aaron Colwell authored
All callers were passing in nullptr so this parameter is unnecessary. Bug: 1085275 Change-Id: Ifd0b4deaab7eb260fe9707d3fdb6a690cdb38609 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313958 Auto-Submit: Aaron Colwell <acolwell@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#791096}
-
