- 11 Apr, 2018 40 commits
-
-
Emily Hanley authored
This is needed for soft device affinity so we have a way to know which bot each shard ran on last. Bug: 831252 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idfde1b5f85816fdc9f496de2e9bbac4ef8298693 Reviewed-on: https://chromium-review.googlesource.com/1005721 Commit-Queue: Emily Hanley <eyaich@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#549929}
-
Daniel Murphy authored
For the last 4 years we 'saved' the new schema version number, so any v2 databases are never marked as v3. The 'migration' always deleted all blob files. This correctly upgrades v2 databases to v3 if they have no corrupt blobs. To gather more information we don't blob away corrupt blob backing stores yet, and instead log when we encounter them. This also fixes the enums.xml values for IDB setup errors, which have been missing 'DeleteIndex' and 'ClearObjectStore' (and subsequently have had incorrect reporting on values > 23) since 2014: https://crrev.com/b05831ee Bug: 831316 Change-Id: Ifa11292b6337be09184de1eed1c667cb99057a96 Reviewed-on: https://chromium-review.googlesource.com/1005984 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#549928}
-
Ojan Vafai authored
TBR=ikilpatrick@chromium.org Change-Id: I4cb43256e6fece3299ddda6eab6840f675933522 Reviewed-on: https://chromium-review.googlesource.com/998747 Commit-Queue: Ojan Vafai <ojan@chromium.org> Reviewed-by:
Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#549927}
-
Tommy Steimel authored
This CL adds a check in UpdateOverflowMenuWanted to only show the overlay play button when the video is wide enough to avoid clipping the button. Bug: 831429 Change-Id: I484d3623f7c49448e57835f70e27678e858f7518 Reviewed-on: https://chromium-review.googlesource.com/1006399Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#549926}
-
Joe Downing authored
After a recent sync I started hitting DCHECKs when attempting to connect using a debug Android CRD client build. It looks like this is due to the recent refctoring work. I beleive the DCHECKs just have the wrong bool value (they should be checking that the callback members are empty but instead check that they are already set). Reversing the logic allows me to connect. Change-Id: I987ee70610a7deb0b2935bf991ee9bede3aa09dd Reviewed-on: https://chromium-review.googlesource.com/1007493Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#549925}
-
Conley Owens authored
Several of our polling errors are logged without specific reference to the function that was called. This change adds more detail to the logging messages. Change-Id: I49cbee2010379a4f2eb56055974deedf776606da Reviewed-on: https://chromium-review.googlesource.com/1005886Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Conley Owens <cco3@chromium.org> Cr-Commit-Position: refs/heads/master@{#549924}
-
Vlad Tsyrklevich authored
Blacklist two functions that can call casted function pointers, there is not an easy way to fix these failures yet. BUG=v8:7164 Change-Id: I39b1a2550a86efe08a721bc2b2ff149656b0e842 Reviewed-on: https://chromium-review.googlesource.com/1002543Reviewed-by:
Peter Collingbourne <pcc@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#549923}
-
sczs authored
- Migrates the basic business logic from LegacyHistoryViewController. All the logic has been copied and modified slightly in order to work with a TableView. - Displays History entires, and supports fetching entries while scrolling (fetches 100 entries per query). - Moves TitleFormat from LegacyHistoryItem to history_util. - It currently doesn't show anything on the first StatusSection, but the code was still left there since removing it and adding later could introduce errors. - Moves HistoryInserter and HistoryUtils to the history_ui target. Screenshot: https://drive.google.com/open?id=1IvYBq59ykSj46aGn-YGBUTmYNGZcWEmm Bug: 805190 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I5eb5d8160182b49e254c4e91704ed4c5db98aa43 Reviewed-on: https://chromium-review.googlesource.com/997108Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#549922}
-
Philipp Hancke authored
makes the ice candidate type detection on webrtc-internals more robust. BUG=678292 Change-Id: I8a6d8892a17a33ec2d69044c19a9e5b4d9cedbc3 Reviewed-on: https://chromium-review.googlesource.com/584753Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549921}
-
Chris Kuiper authored
On some SoMs it was observed that occasionally the timestamps obtained from the AudioTrack are suddenly consistently off from their expected value. This is different from just normal timestamp jitter which evens out over time. The result is errors flooding the logs due to the way we handle this currently. While jumping timestamps is certainly indicative of a bug in the audio HAL driver, we should still handle this better and simply resync to the new offset. Bug: internal b/77654451 Test: Ran on several different SoMs, verfied proper behaviors. Change-Id: Ia12ad4980ac69e7b81ea498f8edc197b60bf5038 Reviewed-on: https://chromium-review.googlesource.com/1003994Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Chris Kuiper <ckuiper@chromium.org> Cr-Commit-Position: refs/heads/master@{#549920}
-
Bernhard Bauer authored
Also clean up the native side a bit (it doesn't need a weak reference if it is destroyed from the Java side). Better diff of the renamed file at https://gist.github.com/sheepmaster/347a1a7d16dd3b23629888bf467faac5 (via `git fetch https://chromium.googlesource.com/chromium/src refs/changes/58/1006758/3 && git diff FETCH_HEAD^:chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModelImpl.java FETCH_HEAD:chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarModel.java`) Change-Id: I8a5fde53c0eed48547faca5486a967d836998fb7 Reviewed-on: https://chromium-review.googlesource.com/1006758Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549919}
-
Jeremy Roman authored
It no longer defines base::MakeUnique, so it should only be included where base::WrapUnique is used. Generated by: for x in `git grep -l '#include "base/memory/ptr_util.h"' content`; do \ grep -q WrapUnique "$x" || sed -i -e \ '/^#include "base\/memory\/ptr_util\.h"$/d' "$x"; done Bug: 755727 Tbr: mkwst@chromium.org Change-Id: Ie2a34ff8f0fe83491185cd9f1a0aa52aa21829bb Reviewed-on: https://chromium-review.googlesource.com/1005834Reviewed-by:Jeremy Roman <jbroman@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549918}
-
Matt Menke authored
It looks like if there's both a pending read and write when a socket is destroyed, and data has been received but not processed, Chrome will crash when the read event is subsequently invoked. Bug: 831149 Change-Id: I4d59e25c9acbc412e2af6c0288be35b5f85fd6e0 Reviewed-on: https://chromium-review.googlesource.com/1005104 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549917}
-
Eugene But authored
Omnibox should display the URL for the currently rendered page (about:blank), not download URL. Also added StopLoading call to hide the progress indicator. Bug: 831334, 824148 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I47eddd9ef7a46480383a60a1425f2c69513cf129 Reviewed-on: https://chromium-review.googlesource.com/1005893Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#549916}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6b7f2a9c..fc27a8d6 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel Notry=true TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I048adeb5ce60ac507b1453278ef1b5b350e0490c Reviewed-on: https://chromium-review.googlesource.com/1007158 Commit-Queue: Michael Hablich <hablich@chromium.org> Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#549915}
-
Jonathan Backer authored
Copy a few more lines from GLES2DecoderImpl. Tested by hand on Linux desktop build with video, webgl, and canvas 2d. Bug: 829438 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1d1edab35a7f418a2392a3dc1fa42aef4739d1c1 Reviewed-on: https://chromium-review.googlesource.com/1005786Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#549914}
-
Antonio Gomes authored
SpellcheckHunspellDictionary callers are changed to pass a content::BrowserContext instance instead of a net::URLRequestContextGetter. This new parameter is used to create a network::mojom::URLLoaderFactory instance. Note that previously the URLRequestContextGetter param was used to configure the net::URLFetcher instance. These are not used by SpellcheckHunspellDictionary anymore. CL also updates SpellcheckCustomDictionaryTest::thread_bundle_ to initialize with IO_MAINLOOP, so that it accommodates network requests being made on UI thread. Last, it sets up an EmbeddedTestServer instance with default handlers, and add a static method to SpellcheckHunspellDictionary to set the URL it uses as global. ::SyncBeforeLoadDoesNotDuplicateWords then sets the URL to embedded_test_server->GetURL("/hang"); to make it requests a hanging URL. TEST=covered by existing tests. BUG=773295 Manual test= - chromeos/linux build - load chrome://settings/languages/ - in 'language' box, add a new language (eg portuguese) - in 'spell check' box, enable spellchecking for the newly added language. - insert any text content that trigger spelling markers, right click w/ mouse to see the spell corrections. Change-Id: I62e646634ab0eff208a80f7f1582326dbd4eb5db Reviewed-on: https://chromium-review.googlesource.com/1000053Reviewed-by:Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#549913}
-
Rohit Rao authored
When the UIRefresh TabGrid is enabled, then this utility method takes a separate codepath that wasn't accounting for the existence of the BVCContainerViewController. This CL fixes that so that the BVC is properly returned instead of its container. BUG=None TEST=None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I969ffc62138a189a395d46279dba722670c7ce64 Reviewed-on: https://chromium-review.googlesource.com/1007159Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#549912}
-
Christopher Grant authored
Now that frame lifecycle issues have been worked out, we can initialize each element to dirty state when a frame starts, and rely on this state being properly updated. Use this opportunity to set each element's timestamp earlier in the cycle, and update the testapp dump to respect the validity of the information it's dumping. BUG=831191 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2b60cc49a09ea89d3e34867445beae6d6d46e76c Reviewed-on: https://chromium-review.googlesource.com/1007322Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#549911}
-
Ryan Sleevi authored
net::SSLConfig exposes a policy for configuring whether or not to accept SHA-1 certificates issued by locally-trusted (as opposed to publicly trusted) trust anchors. The default for this policy was to accept these certificates, while anything creating an SSLConfigServiceManager under //components/ssl_config would have these disabled by default, unless overridden by preferences. Change the default to be secure-by-default, as embedders can supply an SSLConfigService that best reflects their desired behaviours (if they do not wish the defaults) as part of the URLRequestContext(Builder,Getter). BUG=831240 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0bcb3474458ca4e0f3e0a554054eec3046a103bb Reviewed-on: https://chromium-review.googlesource.com/1005416Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Ryan Sleevi <rsleevi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549910}
-
Rohit Rao authored
This test attempts to tap a "Cancel" button in a mock signin promo view. When the UIRefresh flag is enabled, there are multiple "Cancel" buttons present in the view hierarchy. This CL fixes the issue by adding grey_sufficientlyVisible(). BUG=818742 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id59c25b24b46e83552bafbfa22e6bc96676008c5 Reviewed-on: https://chromium-review.googlesource.com/1007254Reviewed-by:
-
Nate Fischer authored
No change to logic. This simply renames a feature name to be more explicit about what it stands for. WEB_RESOURCE_ERROR -> RECEIVE_WEB_RESOURCE_ERROR Bug: 781764 Test: N/A Change-Id: I1bda04b8fb8d80d9ac28e633b9d94b6428b6801d Reviewed-on: https://chromium-review.googlesource.com/1006178Reviewed-by:
Gustav Sennton <gsennton@chromium.org> Reviewed-by:
-
Michael Thiessen authored
The fallback Android UI path incurs a significant overhead cost to our rendering pipeline when it's active, which used to be 100% of the time. This CL uses a dummy canvas that extends the Android canvas and throws an exception every time something is drawn to it to know whether or not drawing the view tree was a no-op. If not a no-op, it actually draws the view tree into our texture-backed canvas. If the canvas is empty, then we can skip compositing it in our VR rendering pipeline. Bug: 830930 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic1c93eeae67485e4d4f450598d6b9690d60d99ba Reviewed-on: https://chromium-review.googlesource.com/999802 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#549907}
-
Alexander Timin authored
Sample 0.01% of the tasks and record task metadata in the ukm. R=haraken@chromium.org,rkaplow@chromium.org Change-Id: I83d5d354726422d13f09fa0ab4fa80b2e3f61478 Reviewed-on: https://chromium-review.googlesource.com/1002178Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549906}
-
Tommy Steimel authored
This CL adds some CSS from the legacy controls into the modern media controls so that the overlay cast button is able to show up. Bug: 831363 Change-Id: I234079b2b789aad4bdc8c27fb0c124810cd18c17 Reviewed-on: https://chromium-review.googlesource.com/1006070 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
-
Gauthier Ambard authored
This CL adds the accessibility trait button to the popup menu cells. It also adds the accessibility trait NotEnabled when the entry is disabled. Bug: 831290 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I4b7e91c9a7328dbc94a9c1dfff5621ba92b16164 Reviewed-on: https://chromium-review.googlesource.com/1007275 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Eugene But authored
Old dialog had confusing language: "Cancel Download?" "Cancel" | "OK" New dialog has the following language: Stop download?" "Continue | Stop" Bug: 825040 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I293b2897a222291695d2064d796f4b590fa9e90c Reviewed-on: https://chromium-review.googlesource.com/1003312 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
-
Matt Menke authored
In particular, StoragePartitionImpl::GetNetworkContext() is apparently being called when its url_request_context_ is nullptr. Add a CHECK when this happens, so we crash with a more useful stack trace. Bug: 827928 Change-Id: If206348901fa8c068639d20f532cce7ca7dc7808 Reviewed-on: https://chromium-review.googlesource.com/1005285Reviewed-by:
-
stkhapugin@chromium.org authored
Removes the dead code that used to handle the standard clear button press in the omnibox before the clear button was replaced with a custom one. Bug: None Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I69ee8fc54484c0331d9450edeba37fdce2ac7262 Reviewed-on: https://chromium-review.googlesource.com/1007056 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
-
Gustav Sennton authored
When passing a ServiceWorkerWebSettings object across the support library boundary - reference that object as an Object rather than as a ServiceWorkerWebSettings. The objective of the WebkitToCompatConverter is to convert webkit objects into support library objects. But webkit objects introduced post-L cannot be passed across the support library boundary since whenever we create a Proxy for the interface (WebkitToCompatConverterBoundaryInterface) passing the webkit object, that Proxy needs access to the post-L webkit class (along with all other classes referenced by the interface), which means we'll crash on phones without a definition of the webkit class. Bug: 831554 Change-Id: I12d731994a8d38dda0f69c92917c817ec753cfa4 Reviewed-on: https://chromium-review.googlesource.com/1006960Reviewed-by:
-
Gauthier Ambard authored
This CL makes sure that the "RequestDesktopSite" and "RequestMobileSite" are enabled when the user agent is correct. It also makes sure that the "Site Information" action is only enabled when the page is a web page. Bug: 824210 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I499979423cc58d2f5f4153a13a39e878bc312edc Reviewed-on: https://chromium-review.googlesource.com/999599 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#549899}
-
Michael Thiessen authored
VR is disabled on standalone devices, but the intent handling and 2D-in-VR support paths don't account for this and erroneously turn on VR mode, or try to launch Chrome in VR, leaving the user stuck on a black screen. This CL ensures that we never set VR mode on standalone devices, and forward VR intents back to the 2D launcher on these devices. Change-Id: I3f8d41f66549f4c24e3056253299c10486f468df Reviewed-on: https://chromium-review.googlesource.com/1003112 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
-
Rob Dodson authored
Previously the Lighthouse audit wasn't waiting long enough before trying to linkify the node paths, creating a race condition. The fix is to wait a bit longer, for the load event, instead of main frame navigated. Change-Id: I8c57e894bfa76ed50fa4c41bbaf2b3c49b0db211 Reviewed-on: https://chromium-review.googlesource.com/1006116Reviewed-by:
Paul Irish <paulirish@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Rob Dodson <robdodson@chromium.org> Cr-Commit-Position: refs/heads/master@{#549897}
-
Esmael El-Moslimany authored
Bug: 495875 Change-Id: I2f4ac42ea9e497c0865ba817c429b094e08b15c0 Reviewed-on: https://chromium-review.googlesource.com/1005839Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#549896}
-
Ryan Daum authored
https://chromium-review.googlesource.com/976333 was accidentally reverted by my other changes in https://chromium-review.googlesource.com/978653 Bug: b/75978731 Test: manual test Change-Id: I506c83d1d9f44434d41b70536e7d39ef1100eede Reviewed-on: https://chromium-review.googlesource.com/1007097Reviewed-by:
Sergey Volk <servolk@chromium.org> Commit-Queue: Ryan Daum <rdaum@chromium.org> Cr-Commit-Position: refs/heads/master@{#549895}
-
Peter Wen authored
Split up the .dex section into finer grain sections. Also fix bytes that were uncategorized for in overhead due to --defined-only being passed to apkanalyzer. Now it is easy to see how many methods a specific directory contributes to the overall dex method limit. Bug: 827193 Change-Id: Id540955b8e5c3282f356b5c9fbc4dcc54a84374f Reviewed-on: https://chromium-review.googlesource.com/998825 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#549894}
-
Scott Violet authored
And wires it up for an example app (ash_shell_with_content). BUG=none TEST=hopefully covered by existing tests Change-Id: I66893ebcbf53681a5fcd5e13c4d9cc87fd517cda Reviewed-on: https://chromium-review.googlesource.com/1005567 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Cr-Commit-Position: refs/heads/master@{#549893}
-
Tibor Goldschwendt authored
First CL in a row of refactors to separate view code into PageInfoView. Change-Id: I61101d9d0c13ae085edc8f00a5cb28ddfcb5620d Reviewed-on: https://chromium-review.googlesource.com/1005733 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
-
Bernhard Bauer authored
Bug: 814365 Change-Id: I34a05ddbf20c74efeffc2c1081cbc79ed60b49db Reviewed-on: https://chromium-review.googlesource.com/1005034Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Bernhard Bauer <bauerb@chromium.org> Cr-Commit-Position: refs/heads/master@{#549891}
-
Katie D authored
In https://chromium-review.googlesource.com/c/chromium/src/+/794511/6/ui/accessibility/ax_tree.cc#275, I renamed |clipped| to |intersection| (and introduced a new |clipped| var with a slightly different meaning). I missed renaming the comment about |clipped|, so doing that in this change. NOTRY=true Change-Id: I5ed9bce774da738950f1199ce9138f51c25beaee Reviewed-on: https://chromium-review.googlesource.com/1005907Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#549890}
-
