GitLab

Also fixes webapp top controls flashing issue which sprang back after this change.

BUG=430635,463957

Review URL: https://codereview.chromium.org/986963002

Cr-Commit-Position: refs/heads/master@{#321253}

This is a retry patch to add ServiceWorkerDispatcherTest and not to modify
the test from the original patch[1]. Main difference from the original
patch is directly to make ThreadSafeSender mockable instead of introducing
an interlayer (ie. ServiceWorkerMessageSender in [1]).

[1] https://codereview.chromium.org/1011643002/

BUG=452403
TEST=content_unittests --gtest_filter=ServiceWorkerDispatcherTest.*

Review URL: https://codereview.chromium.org/1017013002

Cr-Commit-Position: refs/heads/master@{#321252}

AppKit resizes content views when the window resizes by calling
[NSView setFrameSize:], but does not take into account
[NSWindow contentRectForFrameRect:]. We intercept the former and call the
latter. This is similar to the method used by FullSizeContentView.

This CL also adds NativeWidgetMacFramelessNSWindow which overrides
contentRect <-> frameRect conversion.

The frameless NSWindow is used in app windows by overriding
NativeWidgetMac. This is similar to AppWindowDesktopNativeWidgetAuraWin
which provides a specialized WindowTreeHost. BrowserFrameMac (another
NativeWidgetMac subclass) will do the same to draw custom themed frames.

BUG=459877

Review URL: https://codereview.chromium.org/987323002

Cr-Commit-Position: refs/heads/master@{#321251}

Remove pipelining and blocking the pipeline in different stages. The
underlying issue it was trying to workaround is fixed in Android, and it
involves a lot of complexity and was a source of bugs.

Also remove special handling when viewport is empty, as this is handled
correctly now.

Add back the IsEmpty corner case workaround by passing some frame
metadata with ChildFrame.

BUG=

Review URL: https://codereview.chromium.org/1001643004

Cr-Commit-Position: refs/heads/master@{#321250}

Right now the order is somewhat arbitrary. Instead, look at the types of
a field's ancestors to determine the order.

BUG=465587

Review URL: https://codereview.chromium.org/1012093004

Cr-Commit-Position: refs/heads/master@{#321249}

Currently, ChromeConstrainedWindowViewsClient::GetEmbedderWebContents
returns the embedder WebContents of the GuestView if the initiator
WebContents is in a GuestView. However, with OOP PDF, a mime handler
view can be embedded in a webview that is embedded in an app window; in
this case, the webview WebContents is returned instead of the app window
WebContents. This CL changes GetEmbedderWebContents to return the
outermost embedder WebContents.

BUG=457672

Review URL: https://codereview.chromium.org/1012373002

Cr-Commit-Position: refs/heads/master@{#321248}

This is a minimalistic way to display large icons on local NTP for testing.
The code looks for the "largeIconUrl" data, which only becomes available
beyind flag. If not found then use thumbnail as before; otherwise large icons.
New NTP styles are not implemented in this CL.

BUG=467712

Review URL: https://codereview.chromium.org/1013173003

Cr-Commit-Position: refs/heads/master@{#321247}

This is to track force-alt-protocols command line flag usage to be able to
decide whether it should be kept.

BUG=452514

Review URL: https://codereview.chromium.org/1016873002

Cr-Commit-Position: refs/heads/master@{#321246}

BUG=467216

Review URL: https://codereview.chromium.org/1020683002

Cr-Commit-Position: refs/heads/master@{#321245}

LargeIconUrlParser is the parser for the path portion of the (upcoming)
chrome-search://large-icon end point. This CL adds the code, but only
the unit test is active.

BUG=467712

Review URL: https://codereview.chromium.org/1014853004

Cr-Commit-Position: refs/heads/master@{#321244}

Summary of changes available at:
https://chromium.googlesource.com/angle/angle/+log/d4475816b6..a17e77febd

TBR=geofflang@chromium.org
BUG=344767
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1020523003

Cr-Commit-Position: refs/heads/master@{#321243}

BUG=462748

Review URL: https://codereview.chromium.org/1019663002

Cr-Commit-Position: refs/heads/master@{#321242}

In particular, these two bugs both affect how HistoryQuick provider
suggestions are scored.  One has a tendency to prevent typed visits
to URL from actually being counted as typed visits.  The other has
a tendency to make URLs with multiple visits be suggested more
aggressively than I intended.

BUG=369989

Review URL: https://codereview.chromium.org/1009973005

Cr-Commit-Position: refs/heads/master@{#321241}

BUG=465765

Review URL: https://codereview.chromium.org/1004803007

Cr-Commit-Position: refs/heads/master@{#321240}

BUG=

Review URL: https://codereview.chromium.org/1023493002

Cr-Commit-Position: refs/heads/master@{#321239}

This CL maps the third-party VPN provider extension ID (which is
stored in shill's |Provider.Host| field) to an ONC property.

BUG=460428
TEST=Extended unit tests and API test

Review URL: https://codereview.chromium.org/1019033002

Cr-Commit-Position: refs/heads/master@{#321238}

BUG=462584

Review URL: https://codereview.chromium.org/1004323003

Cr-Commit-Position: refs/heads/master@{#321237}

The bug (crbug.com/455439) has now been fixed.

BUG=455430

Review URL: https://codereview.chromium.org/1015523004

Cr-Commit-Position: refs/heads/master@{#321236}

Rename WebEventHandler to MessageCallback to be more compatible with
other postmessage names.

BUG=393291

Review URL: https://codereview.chromium.org/1017333002

Cr-Commit-Position: refs/heads/master@{#321235}

See https://codereview.chromium.org/1003453002 for contexts.

TBR=dalecurtis@chromium.org
BUG=None.

Review URL: https://codereview.chromium.org/1018173002

Cr-Commit-Position: refs/heads/master@{#321234}

The existing implementation does not removes the clientPlugin
from the DOM upon a disconnect. This CL fixes it.

It also moves the disconnect logic from clientSession.dispose()
to clientSession.disconnect() as the name suggests.

BUG=465878

Review URL: https://codereview.chromium.org/1012073006

Cr-Commit-Position: refs/heads/master@{#321233}

TEST=*ImportHistory*

TBR=hirono  // for background.js

Review URL: https://codereview.chromium.org/1008723004

Cr-Commit-Position: refs/heads/master@{#321232}

I moved ProfileGenerator and ProfileCreator from tools/telemetry/... into
tools/perf/profile_creator.

BUG=447457

Review URL: https://codereview.chromium.org/1005203002

Cr-Commit-Position: refs/heads/master@{#321231}

BUG=none

Review URL: https://codereview.chromium.org/1021623002

Cr-Commit-Position: refs/heads/master@{#321230}

In the existing implementation, the session connector creates the
DesktopConnectedView for both app remoting and desktop remoting and
assigns it to a global.

This CL removes the global, |remoting.desktopConnectedView|, and makes
it owned by the corresponding application delegate.

This will enable us to create an app remoting specific delegate in the
upcoming CL.

BUG=465878

Review URL: https://codereview.chromium.org/1016623002

Cr-Commit-Position: refs/heads/master@{#321229}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a17e6c2..b11c5cb

TBR=pfeldman@chromium.org,pilgrim@chromium.org

Review URL: https://codereview.chromium.org/1017193003

Cr-Commit-Position: refs/heads/master@{#321228}

BUG=467473

Review URL: https://codereview.chromium.org/1020603002

Cr-Commit-Position: refs/heads/master@{#321227}

Refactor code and tests.

--page-filter is kept as a (deprecated) alternative to --story-filter.

BUG=444425

Review URL: https://codereview.chromium.org/994683003

Cr-Commit-Position: refs/heads/master@{#321226}

*re-re-land with SwiftShader fix*

*re-land with fix to components_browsertests*

This logic allows us to record traces and histograms easily within
ANGLE's code. It also gives a flexible design that we can extend
with further methods later, without breaking compilation. The
design is based on blink::Platform.

Also add two new histogram descriptions to histograms.xml, and
move the GPU Process metrics init to before InitializeOneOff, so
ANGLE can record histograms during Renderer initialization.

BUG=436191
TBR=jam@chromium.org, asvitkine@chromium.org, piman@chromium.org, maruel@chromium.org, kbr@chromium.org

Review URL: https://codereview.chromium.org/1007513006

Cr-Commit-Position: refs/heads/master@{#321225}

BUG=463209
R=rvargas@chromium.org
TBR=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/1011433002

Cr-Commit-Position: refs/heads/master@{#321224}

(Separated out from CL 795933009)

BUG=455418

Review URL: https://codereview.chromium.org/1000163005

Cr-Commit-Position: refs/heads/master@{#321223}

BUG=463038

Review URL: https://codereview.chromium.org/1013463004

Cr-Commit-Position: refs/heads/master@{#321222}

This CL makes always ThumbnailDatabase::RetainDataForPageUrls()  drop
Page URL -> Icon URL mappings for unretained page URLs.

Previously, a Page URL -> Icon URL (e.g. PageURL1 -> IconURLA) mapping was not
dropped for an unretained Page URL (PageURL1) if:
- the favicon data for a different page URL (e.g. PageURL2) was retained
AND
- PageURL2 is mapped to the same Icon URL as the unretained page URL
  (PageURL2 -> IconURLA)

BUG=468353
TEST=ThumbnailDatabaseTest.RetainDataForPageUrls

Review URL: https://codereview.chromium.org/1005783003

Cr-Commit-Position: refs/heads/master@{#321221}

Instead of manually managing the X11 objects, use the convenient XScopedPtr<>
where possible.

BUG=none
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/1011173003

Cr-Commit-Position: refs/heads/master@{#321220}

BUG=467918

Review URL: https://codereview.chromium.org/1002293004

Cr-Commit-Position: refs/heads/master@{#321219}

Review URL: https://codereview.chromium.org/1018093002

Cr-Commit-Position: refs/heads/master@{#321218}

Currently PSS.getPreferredDataTypes actually returns
PSS::getActiveDataTypes(), which causes some problems. This CL is 1/3.
The second will change the appropriate downstream calls to
getActiveDataTypes() and the third will fix getPreferredDataTypes().

BUG=466223

Review URL: https://codereview.chromium.org/1017683005

Cr-Commit-Position: refs/heads/master@{#321217}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f94fa71..24e06d5

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=egdaniel@google.com

Review URL: https://codereview.chromium.org/1000643004

Cr-Commit-Position: refs/heads/master@{#321216}

BUG=466848

Review URL: https://codereview.chromium.org/1000373002

Cr-Commit-Position: refs/heads/master@{#321215}

Make whitespace use in this routine sane: remove trailing whites and use
space characters, except for Jeff's modifications (tab prefixed).

Minor: roll up our QCMS changes to here in google.patch.

BUG=458024

Review URL: https://codereview.chromium.org/1021593002

Cr-Commit-Position: refs/heads/master@{#321214}