GitLab

TBR=rsesek

Review URL: https://codereview.chromium.org/271353003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269492 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/270833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269488 0039d316-1c4b-4281-b951-d872f2087c98

 * Added ToValue() method on BeginFrameArgs.
 * Added a ToTrace method inside cc/traced_value.h for easy conversion, just do a ToTrace(XXX) of anything which has a ToValue() method.
 * Rename Scheduler::StateAsValue to AsValue so it works with above.

BUG=371223

Review URL: https://codereview.chromium.org/270703004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269487 0039d316-1c4b-4281-b951-d872f2087c98

Answers in Suggest requires a version number on all suggest queries.
Add a gs_rn=42 attribute to requests if Answers is enabled.

BUG=370192

Review URL: https://codereview.chromium.org/269293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269486 0039d316-1c4b-4281-b951-d872f2087c98

The update script should build `ant package` and copy the entire
out/package directory.

This moves the path to domdistiller.js to .../package/js so update
that reference.

The old (non-proto) API is still supported, so this keeps using that.

Picked up changes:
fdb023d Fix Proto module's path
44e9366 This adds two simple protoc plugins.

NOTRY=true

Review URL: https://codereview.chromium.org/277563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269485 0039d316-1c4b-4281-b951-d872f2087c98

I forgot to add these targets when I added the build file for GN and
they will be needed to fully build ui/base target and friends.

This patch ports only webui_resources to GN build for now, since making
resources a group target does not work yet.

BUG=367592
TEST=None
R=brettw@chromium.org
TBR=ben
NOTRY=true

Review URL: https://codereview.chromium.org/265953004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269484 0039d316-1c4b-4281-b951-d872f2087c98

where it makes sense to do so in existing code.

This migration shook out a couple of bugs in mach_logging.h carried over
from mac_logging.h (fixed there too).

R=rsesek@chromium.org, sky@chromium.org

Review URL: https://codereview.chromium.org/278923002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269483 0039d316-1c4b-4281-b951-d872f2087c98

The goal is to reorganize the sync attachment code so that in the future
attachment code can include stuff it needs (like src/net/) without
loosening the DEPS rules for the rest of sync.

Replace internal_api's coarse grained dep on net/ with finer grained
deps.

sync/api/attachments - Home to attachment code that's needed by both
sync itself and users of sync.

sync/internal_api/public/attachments - Home to attachment headers needed
by sync/api/attachments.

sync/internal_api/attachments - Home to attachment code that's private
to sync.

TBR=mef,erikwright,phajdan.jr

BUG=

Review URL: https://codereview.chromium.org/270633005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269481 0039d316-1c4b-4281-b951-d872f2087c98

This is the first effort at moving some of the ReverseService logic out of the
trusted plugin. I'd like to move these over soon since the tangled callback is
pretty nasty, and hidehiko@ has run into the ugliness while adding features for
Bare Metal Mode.

This one is pretty easy since it's stateless.

BUG=239656

Review URL: https://codereview.chromium.org/268793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269480 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/278553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269479 0039d316-1c4b-4281-b951-d872f2087c98

crypto.subtle.wrapKey() orders the key to be wrapped before the wrapping key. Use the same convention throughout webcrypto code to avoid confusion.

BUG=245025

Review URL: https://codereview.chromium.org/272033003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269478 0039d316-1c4b-4281-b951-d872f2087c98

These are bitmaps to use in dark colored frames, for
https://codereview.chromium.org/274013002. This change also moves
the buttons currently in use from win/ to common/ as they are also used
on Linux.

BUG=339558
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/270873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269477 0039d316-1c4b-4281-b951-d872f2087c98

In order of precedence, set size according to:
* Command line parameters if present
* Environment variable if present
* 1600x1200,3840x1600 if RANDR is present, otherwise just 1600x1200.

R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/278753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269476 0039d316-1c4b-4281-b951-d872f2087c98

Without this CL, I observed that the sender sometimes gets stuck trying to catch up.
I could provoke this by using the "bad" netork profile in the udp_proxy in combination
with the "Extreme" (4Mbit/s) sender profile. I could provoke the behaviour by killing
the proxy for a few seconds, and then observe that the mirrored video would remain
slow and jerky for a very long time. (Perhaps forever)  With this patch, the video
catches up again after a few seconds.

Review URL: https://codereview.chromium.org/276783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269475 0039d316-1c4b-4281-b951-d872f2087c98

Adding an output_test_common.xx file which will also gain more testing features
for BeginFrameArgs soon.

BUG=371223

Review URL: https://codereview.chromium.org/275543004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269474 0039d316-1c4b-4281-b951-d872f2087c98

- Remove k{Audio,Video}XXX event types and add in kXXX event types to
be shared between audio and video.
- Changed RTCP event mapping to accept both k{A,V}XXX and kXXX event
type encodings from the receiver. Old encodings get mapped to the
unified types on sender side.
- Changed reciever reference implementation to always send new unified
event types.
- Changed LoggingImpl::Insert{Frame,Packet}Event calls to take
additional EventMediaType argument.
- Added a param in RTCP to indicate whether receiver events
from incoming ssrc are audio or video events.
- Remove generic event types.
- Remove other unused events
-- kVideoFrameSentToEncoder
-- k{AV}PacketSentToPacer
-- kDuplicate{AV}PacketReceived


BUG=365829

Review URL: https://codereview.chromium.org/270493003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269473 0039d316-1c4b-4281-b951-d872f2087c98

animation_update_pending_ is never reset to false, so this almost never does anything, and shouldn't matter with threaded compositor.

BUG=362164

Review URL: https://codereview.chromium.org/271803004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269472 0039d316-1c4b-4281-b951-d872f2087c98

Fix compile error on Win64 due to C++ warning 4275 occurring because an exported class ViewManagerConnection is deriving from a non exported interface IViewManager

BUG=none
R=cpu@chromium.org
TBR=darin

Review URL: https://codereview.chromium.org/271353002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269471 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269467 0039d316-1c4b-4281-b951-d872f2087c98

Reverting along with 269443 since compile errors weren't fixed

> Fix header name in GYP file

TBR=darin@chromium.org

Review URL: https://codereview.chromium.org/276043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269466 0039d316-1c4b-4281-b951-d872f2087c98

This CL also enables the tests for hole-punching.

BUG=329447
R=boliu@chromium.org, qinmin@chromium.org

Review URL: https://codereview.chromium.org/264893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269464 0039d316-1c4b-4281-b951-d872f2087c98

> Enable surprise me wallpaper for new profiles.
>
> BUG=305855, 322603
> TBR=awatson@chromium.org
>
> Review URL: https://codereview.chromium.org/162393002

TBR=harrym@chromium.org

Review URL: https://codereview.chromium.org/274163003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269463 0039d316-1c4b-4281-b951-d872f2087c98

Moves some files from chrome/browser/invalidation to
components/invalidation.  The files moved in this CL are those that do
not have dependencies on chrome/, so they can be moved without
significant refactoring.

This refactoring touches a lot of files, but none of the changes are
meaningful.  Most of it inovlves changing #include paths, updating DEPS,
changing header guards, and other trivial changes.

One part of this change that is significant is that it creates two new
static libraries and moves some of the symbols formerly defined in
chrome/browser/invalidation into those libraries.  There is some risk of
linker errors if this was done wrong.

TBR=bartfab,blundell
BUG=336571

Review URL: https://codereview.chromium.org/255273002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269462 0039d316-1c4b-4281-b951-d872f2087c98

Move inserting the initialization task to first OnDraw with hardware
canvas rather than OnAttach. Also insert view into GLViewRendererManager
here.

Refactor DeferredGpuCommandService into its own file, and have
AwContents interact with it. Move ScopedAppGLStateRestore into
AwContents as well. This meant that the header cannot include any GL
files, so required a refactor there.

Also discovered GLViewRendererManager::PushBack is not thread safe
during refactoring. Fix that as well.

BUG=344087

Review URL: https://codereview.chromium.org/273703008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269461 0039d316-1c4b-4281-b951-d872f2087c98

Add a UMA histogram metrics counting commands when document.execCommand is called.
Each histogram id corresponding to a command name is in EditorCommand.cpp:
https://src.chromium.org/viewvc/blink?revision=165849

The new UMA is WebCore.Document.execCommand and the corresponding implementation is done:
https://src.chromium.org/viewvc/blink?revision=172020&view=revision

This CL rewrites the summary of WebCore.Editing.Commands and let WebCore.Document.execCommand use the original summary because we found that WebCore.Editing.Commands doesn't represent what we want to do as the original summary says.
That's because the new UMA is needed.

BUG=338241

Review URL: https://codereview.chromium.org/278563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269460 0039d316-1c4b-4281-b951-d872f2087c98

Currently rapid updates completely block the user from
interacting with the view even for completely static
content such as the close button.

BUG=368025

Review URL: https://codereview.chromium.org/271773002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269458 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269457 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=173743:173750&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/275063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269456 0039d316-1c4b-4281-b951-d872f2087c98

BUG=309127
R=binji@chromium.org

Review URL: https://codereview.chromium.org/270743005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269455 0039d316-1c4b-4281-b951-d872f2087c98

Compile failure on linux.

FAILED: /b/build/goma/gomacc c++ -MMD -MF obj/chrome/browser/extensions/api/cast_channel/browser_extensions.cast_auth_util_nss.o.d -DV8_DEPRECATION_WARNINGS -DBLINK_SCALE_FILTERS_AT_RECORD_TIME -D_FILE_OFFSET_BITS=64 -DCHROMIUM_BUILD -DCOMPONENT_BUILD -DTOOLKIT_VIEWS=1 -DUI_COMPOSITOR_IMAGE_TRANSPORT -DUSE_AURA=1 -DUSE_CAIRO=1 -DUSE_GLIB=1 -DUSE_DEFAULT_RENDER_THEME=1 -DUSE_LIBJPEG_TURBO=1 -DUSE_X11=1 -DUSE_CLIPBOARD_AURAX11=1 -DENABLE_ONE_CLICK_SIGNIN -DUSE_XI2_MT=2 -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DUSE_UDEV -DENABLE_EGLIMAGE=1 -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_FULL_PRINTING=1 -DENABLE_PRINTING=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_MDNS=1 -DENABLE_SERVICE_DISCOVERY=1 -DFULL_SAFE_BROWSING -DGL_GLEXT_PROTOTYPES -DMOJO_USE_SYSTEM_IMPL -DGTEST_HAS_POSIX_RE=0 -DLIBPEERCONNECTION_LIB=1 -DPROTOBUF_USE_DLLS -DGOOGLE_PROTOBUF_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DSKIA_DLL -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_PUBLICEFFECTCONSTRUCTORS=1 -DSK_SUPPORT_LEGACY_GETTOPDEVICE -DSK_SUPPORT_LEGACY_N32_NAME -DSK_SUPPORT_LEGACY_BLURMASKFILTER_STYLE -DSK_SUPPORT_LEGACY_GETTOTALCLIP -DSK_USE_POSIX_THREADS -DSK_DEFERRED_CANVAS_USES_FACTORIES=1 -DFEATURE_ENABLE_SSL -DFEATURE_ENABLE_VOICEMAIL -DEXPAT_RELATIVE_PATH -DGTEST_RELATIVE_PATH -DNO_MAIN_THREAD_WRAPPING -DNO_SOUND_SYSTEM -DLINUX -DPOSIX -DU_USING_ICU_NAMESPACE=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_LINUX -DUSE_NSS=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -D_DEBUG -I../.. -Iobj/chrome/browser_extensions.gen -Iobj/chrome/browser_extensions.gen/chrome -I../../third_party/khronos -I../../gpu -I../../skia/config -I../../third_party/WebKit/Source -Igen/protoc_out -I../../third_party/protobuf -I../../third_party/protobuf/src -Igen/chrome -Igen -I../../third_party/re2 -Igen/components/strings -I../../third_party/WebKit -I../../net/third_party/nss/ssl -Igen/extensions/strings -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../skia/ext -I../../third_party/libjingle/overrides -I../../third_party/libjingle/source -I../../testing/gtest/include -I../../third_party -I../../third_party/webrtc -I../../third_party/cacheinvalidation/overrides -I../../third_party/cacheinvalidation/src -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/leveldatabase/src/include -I../../third_party/leveldatabase/src -I../../third_party/leveldatabase -Igen/ui/app_locale_settings -Igen/ui/ui_strings -Igen/ui/ui_resources -Igen/webkit -Igen/ui/keyboard -Igen/policy -fstack-protector --param=ssp-buffer-size=4 -Werror -pthread -fno-exceptions -fno-strict-aliasing -Wall -Wno-unused-parameter -Wno-missing-field-initializers -fvisibility=hidden -pipe -fPIC -pthread -I/usr/include/glib-2.0 -I/usr/lib/i386-linux-gnu/glib-2.0/include -I/usr/include/nss -I/usr/include/nspr -I/usr/include/dbus-1.0 -I/usr/lib/i386-linux-gnu/dbus-1.0/include -msse2 -mfpmath=sse -mmmx -m32 -O0 -g -funwind-tables -fno-rtti -fno-threadsafe-statics -fvisibility-inlines-hidden -Wsign-compare  -c ../../chrome/browser/extensions/api/cast_channel/cast_auth_util_nss.cc -o obj/chrome/browser/extensions/api/cast_channel/browser_extensions.cast_auth_util_nss.o
../../chrome/browser/extensions/api/cast_channel/cast_auth_util_nss.cc: In function 'bool {anonymous}::VerifyCredentials(const extensions::api::cast_channel::AuthResponse&, const string&)':
../../chrome/browser/extensions/api/cast_channel/cast_auth_util_nss.cc:263:60: error: invalid conversion from 'const SECItem* {aka const SECItemStr*}' to 'SECItem* {aka SECItemStr*}' [-fpermissive]
/usr/include/nss/keyhi.h:215:1: error:   initializing argument 1 of 'SECKEYPublicKey* SECKEY_ImportDERPublicKey(SECItem*, CK_KEY_TYPE)' [-fpermissive]
ninja: build stopped: subcommand failed.

> Auth work to support new auth protocol
> 
> BUG=345759
> 
> Review URL: https://codereview.chromium.org/254083007

TBR=munjal@chromium.org

Review URL: https://codereview.chromium.org/273123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269454 0039d316-1c4b-4281-b951-d872f2087c98

These APIs are used to enable bookmarks export functionality.

BUG=312900,319444,371562,372039
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/275193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269453 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269452 0039d316-1c4b-4281-b951-d872f2087c98

The CompositeAndReadback is going away, and this method is thought to
be unused. Make the method just fail and return false.

R=aelias, tedchoc@chromium.org
BUG=371592

Review URL: https://codereview.chromium.org/270933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269448 0039d316-1c4b-4281-b951-d872f2087c98

Chrome (and others) need this so they can supply the ContextFactory to
the Compositor and get rid of Compositor::GetInstance.

BUG=none
TEST=none
R=piman@chromium.org

Review URL: https://codereview.chromium.org/276973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269447 0039d316-1c4b-4281-b951-d872f2087c98

BUG=370095

Review URL: https://codereview.chromium.org/266263002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269446 0039d316-1c4b-4281-b951-d872f2087c98

BUG=345759

Review URL: https://codereview.chromium.org/254083007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269445 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true
NOTREECHECKS=true
BUG=https://code.google.com/p/webrtc/issues/detail?id=2789

Review URL: https://codereview.chromium.org/268123003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269444 0039d316-1c4b-4281-b951-d872f2087c98

Interfaces no longer have explicit Peer attributes. An interface may now optionally have a Client interface, in which case a SetClient method will be auto-generated.

InterfacePtr is a proxy to a remote instance of an interface. InterfaceImpl is a base class used when implementing an interface. Both have facilities for binding to a pipe, etc. An InterfacePtr is movable but not copyable and looks a lot like RemotePtr save for how it gets initialized (via the Bind method now).

I've added some new top-level functions:

MakeProxy - makes it easy to initialize an InterfacePtr in say a member initializer list.

BindToPipe - this is how you bind an InterfaceImpl to a pipe. once bound, they cannot be unbound until the object is destroyed or the pipe is closed.

BindToProxy - builds on top of BindToPipe, however, it hides the details of the pipe. What you get back is an InterfacePtr.

Generated C++ code now passes InterfacePtr instead of InterfaceHandle. As a result, we have far less need for typed subclasses of MessagePipeHandle, so I eliminated them. The code that needs to deal with raw handles generally has to deal with {Scoped}MessagePipeHandle, and adding strong typing to these handles doesn't seem helpful anymore.

R=davemoore@chromium.org

Review URL: https://codereview.chromium.org/265793015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269443 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/271943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269442 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371562

Review URL: https://codereview.chromium.org/270783006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@269441 0039d316-1c4b-4281-b951-d872f2087c98