GitLab

BUG=666666
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2629483002
Cr-Commit-Position: refs/heads/master@{#443280}

Review-Url: https://codereview.chromium.org/2623423003
Cr-Commit-Position: refs/heads/master@{#443279}

Increase ninja concurrency from 50 to 1000. Load templates from script
directory. No visible changes except some whitespace differences.

BUG=680217

Review-Url: https://codereview.chromium.org/2621413002
Cr-Commit-Position: refs/heads/master@{#443278}

This is a ~100mb file that isn't actaully used by anything, and that can
be created after-the-fact by a class-dumping tool

BUG=none

Review-Url: https://codereview.chromium.org/2619273002
Cr-Commit-Position: refs/heads/master@{#443277}

When creating a tab in foreground, the TabModel loads it before
marking it active to avoid visual blinking.
But loading require getting the header height of the new tab and not
of the current tab.

BUG=676153

Review-Url: https://codereview.chromium.org/2599313002
Cr-Commit-Position: refs/heads/master@{#443276}

- Move and rename the find bar buttons (since they're used beyond just
  the find bar these days).
- Fix VectorIconButton's disabled state.

BUG=626786

Review-Url: https://codereview.chromium.org/2625273002
Cr-Commit-Position: refs/heads/master@{#443275}

As Cronet classes have been getting renamed we've failed to keep our
log TAGs accurate.  This change makes them accurate and attempts to
prevent future inaccuracies by using class.getSimpleName() in hopes
that a class rename will force a TAG rename.

R=xunjieli
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2109293005
Cr-Commit-Position: refs/heads/master@{#443274}

The first memory system-health story ran in a set has been reporting
memory use differently all subsequent runs. This is due to how we
flush the system caches.

Just before we measure memory we flush the system caches unfortunately
this doesn't immediately take effect, instead the next story run is
effected. Due to this the first story run has anomalous results.
This option causes us to flush caches each time before Chrome starts
so we effect even the first story - avoiding the bug.

*************** Note to Perf Sheriff ****************

Regressions across several memory metrics are
expected for system_health.memory_mobile,
system_health.memory_desktop and memory.top10_mobile
as we stop under counting memory use.

*****************************************************

BUG=chromium:671156
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq

Review-Url: https://codereview.chromium.org/2589173004
Cr-Commit-Position: refs/heads/master@{#443273}

This CL enables configuring which trigger types result in a background
fetch. The default configuration can be overridden by a variation
parameter. It also reports the trigger type of each fetch to UMA.

Additionally, this CL enables two additional trigger types that were
previously inactive (Chrome cold start / Chrome foregrounding).

BUG=672479

Review-Url: https://codereview.chromium.org/2626433005
Cr-Commit-Position: refs/heads/master@{#443272}

Chrome OS audio server is going to report more types of microphones,
implement the UI side corresponding code to parse these types from
node info.

BUG=672537

Review-Url: https://codereview.chromium.org/2609863007
Cr-Commit-Position: refs/heads/master@{#443271}

Change the note-taking app setting's "Waiting for Android
apps..." string to a simpler "Initializing...".

BUG=633596,633243

Review-Url: https://codereview.chromium.org/2628673004
Cr-Commit-Position: refs/heads/master@{#443270}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/0e201cdd06ed..7f52163a4f80

$ git log 0e201cdd0..7f52163a4 --date=short --no-merges --format='%ad %ae %s'
2017-01-12 simonhatch Bisect - Average list_of_scalars in compare_samples.

BUG=669608

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2628203002
Cr-Commit-Position: refs/heads/master@{#443269}

TBR=zmo@chromium.org

BUG=668223
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2620133005
Cr-Commit-Position: refs/heads/master@{#443268}

Rather than have an extra copy of the data hanging off the
SSLClientSocketImpl, we can extract it out of BoringSSL on demand.

BUG=none

Review-Url: https://codereview.chromium.org/2601493002
Cr-Commit-Position: refs/heads/master@{#443267}

BUG=679369

Review-Url: https://codereview.chromium.org/2618333005
Cr-Commit-Position: refs/heads/master@{#443266}

R=ahaas@chromium.org,jochen@chromium.org

Review-Url: https://codereview.chromium.org/2622273005
Cr-Commit-Position: refs/heads/master@{#443265}

BUG=615738
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2630443002
Cr-Commit-Position: refs/heads/master@{#443264}

TBR=clamy@chromium.org
BUG=659317

Review-Url: https://codereview.chromium.org/2581393002
Cr-Commit-Position: refs/heads/master@{#443263}

Revert of Auto-rebaseline for r443157 (patchset #1 id:1 of https://codereview.chromium.org/2628173002/ )

Reason for revert:
Suspected CL that cause webkit test virtual/stable/paint/invalidation/composited-overflow-with-borderbox-background.html to fail on Mac10.9

https://build.chromium.org/p/builders/WebKit%20Mac10.9/builds/41596

Original issue's description:
> Auto-rebaseline for r443157
>
> https://chromium.googlesource.com/chromium/src/+/13a86c2faeebc
>
> BUG=453414
> TBR=ktyliu@chromium.org
>
> Review-Url: https://codereview.chromium.org/2628173002 .
> Cr-Commit-Position: refs/heads/master@{#443164}
> Committed: https://chromium.googlesource.com/chromium/src/+/14f223988bfd4444a1238450919cef246d0ed51a

TBR=ktyliu@chromium.org,blink-rebaseline-bot@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453414

Review-Url: https://codereview.chromium.org/2627783007
Cr-Commit-Position: refs/heads/master@{#443262}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: SKIP_ON_SHUTDOWN (default)
  Tasks posted with this mode that have not started executing at
  shutdown will never run. However, any task that has already begun
  executing when shutdown is invoked will be allowed to continue and
  will block shutdown until completion.

  Note: Previously, the task was posted to the blocking pool with
  BLOCK_SHUTDOWN (default in SequencedWorkerPool).

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=667892

Review-Url: https://codereview.chromium.org/2627083005
Cr-Commit-Position: refs/heads/master@{#443261}

This is primarily to verify behavior fixed in https://codereview.chromium.org/2616633002/ but also adds tests for more fundamental behavior of the BookmarkSuggestionsProvider.

This CL also moves ContentSuggestionsProvider test doubles out of specific unit tests and into separate targets so that we can reuse them.

BUG=674178

Review-Url: https://codereview.chromium.org/2618243004
Cr-Commit-Position: refs/heads/master@{#443260}

https://skia.googlesource.com/skia.git/+log/0c2997b6d85e..d32303e7276b

$ git log 0c2997b6d..d32303e72 --date=short --no-merges --format='%ad %ae %s'
2017-01-10 mtklein disable runtime detected AVX2 raster pipelines
2017-01-12 djsollen Remove defunct include/images directory from GN.

BUG=679147,654213,664864,666707,etc.

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2633483002
Cr-Commit-Position: refs/heads/master@{#443259}

https://pdfium.googlesource.com/pdfium.git/+log/ffdfbb9ec274..e7fb8eb3e9f2

$ git log ffdfbb9ec..e7fb8eb3e --date=short --no-merges --format='%ad %ae %s'
2017-01-11 npm Prevent undefined shift in putagreytile

BUG=655008

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2624133005
Cr-Commit-Position: refs/heads/master@{#443258}

Undo r440475's temporary use of SameThreadCheckedMember<>.

R=
BUG=655926

Review-Url: https://codereview.chromium.org/2629613002
Cr-Commit-Position: refs/heads/master@{#443257}

When switching src or modifying metadata, the whole metadata will be
sent to MediaSessionTabHelper causing it to download the same image src
twice even if the artwork stays the same. This CL make MediaImageManager
to remember the src of the last downloaded image so that it can avoid
fetch the same src.

BUG=672023

Review-Url: https://codereview.chromium.org/2627103002
Cr-Commit-Position: refs/heads/master@{#443256}

See bug for details. tl;dr: we should not use direct links like
support.google.com/chrome/answer/123456

For now this is an ignoreable upload-only prompt.

BUG=679462

Review-Url: https://codereview.chromium.org/2627023003
Cr-Commit-Position: refs/heads/master@{#443255}

Changes:
Add one second grace period For LockScreenIfRequired. Basically, an one second OneShotTimer is used to set/reset the behavior.

BUG=633304
BUG=680509
TEST=device test, and modify test coverage

Review-Url: https://codereview.chromium.org/2620383003
Cr-Commit-Position: refs/heads/master@{#443254}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7ca33baf..679672b1

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2628893004
Cr-Commit-Position: refs/heads/master@{#443253}

Nonces are valuable, as they allow script execution. It would be lovely if
we could raise the bar on exfiltration to reduce the effectiveness of some
of the attacks noted at http://sebastian-lekies.de/csp/bypasses.php.

One mechanism that might be effective against some kinds of exfiltration is
to stop treating the 'nonce' content attribute as the source of truth, instead
pulling the nonce value into an internal slot on the HTMLScriptElement at
parse-time. That prevents exfiltration via attribute leakage, mitigating the
effect of vectors like `[nonce^=ab]` and `content: attr(nonce)`
(http://cspnonce-test.appspot.com/exploit?reset=1 and
http://sebastian-lekies.de/csp/social_engineering.php, respectively). We also
clear the nonce after use ("number used _once_", right?) which mitigates the
style of attack hinted at in https://sirdarckcat.github.io/csp/fakexss.html
(though that specific issue is also resolved by fixing the browser bug in
https://codereview.chromium.org/2618323002).

Here, we're replacing the nonce content attribute with '[Replaced]', as that
gives developers a hint at what's going on (e.g. in devtools), but we could
pretty easily drop that in the future and just make it a devtools feature
entirely. Not sure what the right thing to do is..

This prototype just effects `<script>`; once we decide on reasonable behavior,
we can extend it to `<link>` and `<style>`.

BUG=680419

Review-Url: https://codereview.chromium.org/2628733005
Cr-Commit-Position: refs/heads/master@{#443252}

Revert of MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available (patchset #5 id:250001 of https://codereview.chromium.org/2624053002/ )

Reason for revert:
Suspected CL-to-blame for webkit tests failing on Mac Retina:
fast/mediacapturefromelement/HTMLMediaElementCapture-capture.html
fast/mediacapturefromelement/CanvasCaptureMediaStream-framerate-0.html

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.11%20%28retina%29/builds/10965

Original issue's description:
> MediaRecorder: use VideoTrackRecorder::GetPreferredCodecId() when available
>
> This CL adds a static method to VTR to query which
> one, if any, is the preferred video codec.
>
> A new singleton Lazy Leaky class CodecEnumerator is
> added to encapsulate poking the VEA to see which
> codecs are supported, and to further query
> a) the preferred codec id
> b) if a given codec is supported
> and wraps the previous CodecIdToVEAProfile()
> functionality.
>
> BUG=679946
>
> Review-Url: https://codereview.chromium.org/2624053002
> Cr-Commit-Position: refs/heads/master@{#443165}
> Committed: https://chromium.googlesource.com/chromium/src/+/904b7a6f6dffa9cee5ac930c37dd591c330d14c6

TBR=emircan@chromium.org,chfremer@chromium.org,mcasas@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=679946

Review-Url: https://codereview.chromium.org/2622273006
Cr-Commit-Position: refs/heads/master@{#443251}

Based on post-review comments on:
https://codereview.chromium.org/2558913003/

BUG=none
TBR=mattm@chromium.org,donnd@chromium.org,afakhry@chromium.org,noyau@chromium.org

Review-Url: https://codereview.chromium.org/2627033003
Cr-Commit-Position: refs/heads/master@{#443250}

This implements the crash handler companion to the launcher in https://codereview.chromium.org/2596463002/. The handler parses the command line as created by the launcher. After this, it can write a minidump with MinidumpWriteDump, then augment it with Crashpad metadata and massage such that Crashpad can parse it.
After this, the dump is dropped into the Crashpad database for eventual upload.

BUG=678959

Review-Url: https://codereview.chromium.org/2611393002
Cr-Commit-Position: refs/heads/master@{#443249}

BUG=630728
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2618933002
Cr-Commit-Position: refs/heads/master@{#443248}

Use webState:didStartProvisionalNavigationForURL: instead.

BUG=674991

Review-Url: https://codereview.chromium.org/2626733003
Cr-Commit-Position: refs/heads/master@{#443247}

This work is to support more generic rendering for mobile platforms.
The thinking behind using a stack of 'drawable' objects is we could
add future features like fps stats or more animations, and also add
debug screens to apps in development for gesture feedback and connection
health.

R=yuweih@chromium.org
BUG=671692

Review-Url: https://codereview.chromium.org/2591363002
Cr-Commit-Position: refs/heads/master@{#443246}

Change the exclusive end time bound in WebHistoryService to be inclusive,
as required by the history.google.com API.

BUG=674165

Review-Url: https://codereview.chromium.org/2621143004
Cr-Commit-Position: refs/heads/master@{#443245}

Part of removing dependency of Windows browser DLL on v8.

R=jochen@chromium.org
BUG=581766

Review-Url: https://codereview.chromium.org/2627713007
Cr-Commit-Position: refs/heads/master@{#443244}

The model was already being reloaded but not the the collection view,
this could cause crashes as the collection view and its model were not
in sync anymore. The collection view is now reloaded as well.

BUG=680098

Review-Url: https://codereview.chromium.org/2622103005
Cr-Commit-Position: refs/heads/master@{#443243}

https://skia.googlesource.com/skia.git/+log/621ea115e0b1..0c2997b6d85e

$ git log 621ea115e..0c2997b6d --date=short --no-merges --format='%ad %ae %s'
2017-01-11 brianosman Remove second version of SkImageInfo2GrPixelConfig
2017-01-11 brianosman Remove kIndex_8_GrPixelConfig
2017-01-12 borenet Move recipe expectations into example.py recipes inside of modules
2017-01-12 borenet Move most recipes into modules

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2630543002
Cr-Commit-Position: refs/heads/master@{#443242}

BUG=677012

Review-Url: https://codereview.chromium.org/2617583006
Cr-Commit-Position: refs/heads/master@{#443241}