GitLab

Don't include trailing space in linewidth calculations when deciding
if a float can fit on a line.

Merge http://trac.webkit.org/changeset/148622

Review URL: https://codereview.chromium.org/343663004

git-svn-id: svn://svn.chromium.org/blink/trunk@177135 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Not sure why the tests changed from expecting '' to undefined,
but I doubt it matters.  Useful to be able to start from
all tests passing.

TBR=ojan@chromium.org
BUG=389681

Review URL: https://codereview.chromium.org/353183003

git-svn-id: svn://svn.chromium.org/blink/trunk@177134 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows us to remove a redundant squashing-related property in RenderLayer,
and is also a step towards not having non-compositing code know about how the layers
are positioned & drawn.

BUG=384520

Review URL: https://codereview.chromium.org/358913003

git-svn-id: svn://svn.chromium.org/blink/trunk@177133 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=386944

Review URL: https://codereview.chromium.org/356183002

git-svn-id: svn://svn.chromium.org/blink/trunk@177132 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It was a race between the event arrived into timeline and the script that was evaluated in the page.

BUG=316150

Review URL: https://codereview.chromium.org/351873003

git-svn-id: svn://svn.chromium.org/blink/trunk@177131 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a TextIterator is created for a range that contains a replaced
element then one ',' (comma) will surely be emitted. This way the
length of the created TextIterator will be at least 1. In spite of
this, the WebCore::PlainTextRange::createRangeFor method assumes that
the length of the iterator only can be one if that one character is a
newline. The patch fixes this wrong assumption.

R=tkent@chromium.org
BUG=385630

Review URL: https://codereview.chromium.org/342483002

git-svn-id: svn://svn.chromium.org/blink/trunk@177130 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This comment is about ASSERTing the consistency of state that no long exists.
Also, remove m_canSkipRepaintRectsUpdateOnScroll because it's just
renderer()->isTableCell().

R=esprehn@chromium.org

Review URL: https://codereview.chromium.org/356123004

git-svn-id: svn://svn.chromium.org/blink/trunk@177129 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We would eventually like to implement position: sticky, but the current
implementation isn't designed in a way that integrates well with the existing
scrolling and compositing system. For example, position: sticky relies upon
updateLayerPositionsAfterDocumentScroll to function correctly, but that
function has no other purpose and can otherwise be removed. Similarly,
position: sticky doesn't work at all with composited overflow scrolling, which
is now the default mechanism for driving scrolling in the engine.

Once we've got our scrolling and compositing house in order, we should return
to position: sticky and implement the feature in a way that integrates well
with the rest of the engine. For now, however, this CL removes our current
implementation so we can focus on improving our implementation of the scrolling
features we've already shipped.

R=eseidel@chromium.org, esprehn@chromium.org
BUG=389638, 231752

Review URL: https://codereview.chromium.org/346603007

git-svn-id: svn://svn.chromium.org/blink/trunk@177128 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When emulation is unavailable (on device), only show the message about it.
When emulation is available, but without responsive design mode, move
toggle button to the OverridesView.

BUG=none

Review URL: https://codereview.chromium.org/358973003

git-svn-id: svn://svn.chromium.org/blink/trunk@177127 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[TypeChecking=Nullable] on a nullable attribute meant that the C++ getter
wasn't called with a "bool& isNull" argument, instead the C++ value in a
boolean context was used to determine nullness.

This was only used for attributes where the C++ value was a pointer, and
made perfect sense for such attributes. So much sense, in fact, that it
makes sense to let that be the default behavior for such attributes.

Review URL: https://codereview.chromium.org/352643005

git-svn-id: svn://svn.chromium.org/blink/trunk@177126 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds type checks on some Node arguments in the generated bindings
code, and lets us drop the corresponding manual null checks and exception
throwing code in the implementations.

The type of exception thrown changes from DOMException (NOT_SUPPORTED_ERR)
to TypeError as a side-effect. This matches the Web IDL specification.

Review URL: https://codereview.chromium.org/360463005

git-svn-id: svn://svn.chromium.org/blink/trunk@177125 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Related to the test failures seen in the worker-data-view-test.html test I think this will fix the issue. Basically postpone the sweep until after we have left the safepoint. I am still testing/trying to reproduce.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, sof@opera.com, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/351253002

git-svn-id: svn://svn.chromium.org/blink/trunk@177124 bbb929c8-8fbe-4397-9dbb-9b2b20218538

containingBlockIgnoringAnonymous serves as a stop condition of tree visits
(previousInPreOrder). Before the patch, containingBlockIgnoringAnonymous was not
the root RenderObject of the previous continuation chain, and thus
the previous continuation was not cleared properly.

This patch relaxes the stop condition by using isAnonymous() instead of
isAnonymousBlock() so that the tree search can skip all anonymous wrappers
including RenderTableRow or RenderTableCell.

BUG=389285
TEST=unminimizable test from clusterfuzz
R=inferno@chromium.org

Review URL: https://codereview.chromium.org/358133002

git-svn-id: svn://svn.chromium.org/blink/trunk@177122 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Creating a new StyleResolverState while in the context of a
style recalc is completely unnecessary for the purposes of
StyleResolver::createAnimatableValueSnapshot().

Moving the StyleResolverState creation inside createAnimatableValueSnapshot()
to only where it's necessary fixes crashes involving HTMLOptionElements
attaching themselves to a shadow DOM tree.

BUG=387225

Review URL: https://codereview.chromium.org/358793003

git-svn-id: svn://svn.chromium.org/blink/trunk@177121 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Srcset's 'w' descriptor parsing accepted descriptors of the form "400pw".
This CL fixes that by making their parsing stricter.
It also adds a bunch of tests to prevent it from regressing, and to make sure
float based descriptors are properly parsed as well.

BUG=389575

Review URL: https://codereview.chromium.org/355953003

git-svn-id: svn://svn.chromium.org/blink/trunk@177120 bbb929c8-8fbe-4397-9dbb-9b2b20218538

platform over time.  Not worth constantly rebaselining.  Remove
navigator.connection.type from window tests as it's already well
tested in netinfo/* tests.

BUG=381683

Review URL: https://codereview.chromium.org/356833006

git-svn-id: svn://svn.chromium.org/blink/trunk@177119 bbb929c8-8fbe-4397-9dbb-9b2b20218538

During console migration on viewport revealing search results was
forgotten.
This patch fixes this.

BUG=388718
R=pfeldman

Review URL: https://codereview.chromium.org/354013002

git-svn-id: svn://svn.chromium.org/blink/trunk@177118 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While CORS is concerned with the access control headers that come
back in the response and not its status code, an error response
(status code >= 400) containing no CORS headers is most likely an
indication of the server not being configured correctly.

To potentially help the user/developer more quickly diagnose that as
the problem, include the status code in the console message that's
emitted for the failed CORS resource sharing check.

R=
BUG=269192

Review URL: https://codereview.chromium.org/332633006

git-svn-id: svn://svn.chromium.org/blink/trunk@177116 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In this particular case both OS() and PTHREAD_KEYS_MAX are used as a guard, even though using PTHREAD_KEYS_MAX as a guard is sufficient. Not only that this solution works not just for ANDROID but also for other systems where chromium might be ported to (in or out of the tree). 

As an example the proposed change would work on HURD systems as well (the support for HURD is not maintained in the tree, but it demonstrates that the change handles those systems as well).

Review URL: https://codereview.chromium.org/351683007

git-svn-id: svn://svn.chromium.org/blink/trunk@177115 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The gyp build for core does some strange things put in place in ancient
times to fix ancient problems. There's no need nowadays to:

*) list all core svg files in both webcore_files and webcore_svg_files
 only to filter the webcore_files entries with a regex

*) exclude 'opentype', 'cf', etc files from core with a regex

*) exclude platform-specific directories in core - we've moved all
that to Source/platform

These funky rules are hard to maintain in gyp and impossible to do
so in GN, so let's get rid of them.

R=abarth@chromium.org

Review URL: https://codereview.chromium.org/354973002

git-svn-id: svn://svn.chromium.org/blink/trunk@177114 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We request the image of max size avaliable but resize canvas to match the size of actual image returned from device.

Depends on https://codereview.chromium.org/351633002/

BUG=387557

Review URL: https://codereview.chromium.org/347143002

git-svn-id: svn://svn.chromium.org/blink/trunk@177113 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=389286
TBR=yurys@chromium.org, timloh@chromium.org, fmalita@chromium.org

Review URL: https://codereview.chromium.org/361463002

git-svn-id: svn://svn.chromium.org/blink/trunk@177112 bbb929c8-8fbe-4397-9dbb-9b2b20218538

paintTextWithShadows had unused parameters, and identical logic for
constructing a text shadow draw looper existed in three places.

Review URL: https://codereview.chromium.org/356123002

git-svn-id: svn://svn.chromium.org/blink/trunk@177111 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For the same reasons that we're delaying the complete removal of
ShowModalDialog, we need to slow-walk the progress of tightening our
mixed content checks. This runtime-enabled setting will allow us to
set up a policy hook in order to provide enterprises with time to
adapt to the new-to-Chrome behavior of blocking mixed WebSockets and
XMLHttpRequest.

BUG=389089

Review URL: https://codereview.chromium.org/356843006

git-svn-id: svn://svn.chromium.org/blink/trunk@177110 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=380860

Review URL: https://codereview.chromium.org/353743008

git-svn-id: svn://svn.chromium.org/blink/trunk@177109 bbb929c8-8fbe-4397-9dbb-9b2b20218538

[TypeChecking=Nullable] only serves a purpose on nullable attributes.

Using it on interfaces without nullable attributes, or methods (even those
with nullable arguments) serves no purpose. Using it on individual
arguments also serves no purpose; in fact, the [TypeChecking] extended
attribute is not supported at all on arguments.

This patch does not change any generated code.

Review URL: https://codereview.chromium.org/356843007

git-svn-id: svn://svn.chromium.org/blink/trunk@177108 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=386973

Review URL: https://codereview.chromium.org/356843008

git-svn-id: svn://svn.chromium.org/blink/trunk@177107 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This gets rid of a persistent collection.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Review URL: https://codereview.chromium.org/355133003

git-svn-id: svn://svn.chromium.org/blink/trunk@177106 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- script
- link
- anchor
- iframe
- form
- input
- button

BUG=388287

Review URL: https://codereview.chromium.org/349263002

git-svn-id: svn://svn.chromium.org/blink/trunk@177105 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=none

Review URL: https://codereview.chromium.org/345723003

git-svn-id: svn://svn.chromium.org/blink/trunk@177104 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch fixes indent autodetection to fallback to default indent
from user settings instead of "four spaces" value.

This patch additionally adds a change listener on the "autodetect indentation"
setting.

BUG=389109

Review URL: https://codereview.chromium.org/351213006

git-svn-id: svn://svn.chromium.org/blink/trunk@177103 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=381115

Review URL: https://codereview.chromium.org/354023002

git-svn-id: svn://svn.chromium.org/blink/trunk@177102 bbb929c8-8fbe-4397-9dbb-9b2b20218538

According to CSS2.1: "[...] absolutely positioned elements whose
containing block is based on a block container element, the percentage
is calculated with respect to the width of the padding box of that
element".

BUG=366123

Review URL: https://codereview.chromium.org/341523002

git-svn-id: svn://svn.chromium.org/blink/trunk@177101 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=389118

Review URL: https://codereview.chromium.org/357873003

git-svn-id: svn://svn.chromium.org/blink/trunk@177100 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Camel-case movement allows movement between
subwords of camel-case-written words or phrases.

This patch adds support for camel-case movement to the DevTools editor.
The camel-case movement is done via Alt-Left/Alt-Right on Win and Linux,
and via Ctrl-Left/Ctrl-Right on Mac.

Review URL: https://codereview.chromium.org/357483007

git-svn-id: svn://svn.chromium.org/blink/trunk@177099 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Rulers, grid and media queries are now rendered in CSS pixels.
Additionally, a content size rectangle is drawn for visual feedback.

BUG=none

Review URL: https://codereview.chromium.org/351303003

git-svn-id: svn://svn.chromium.org/blink/trunk@177098 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/356033002

git-svn-id: svn://svn.chromium.org/blink/trunk@177097 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/352953002

git-svn-id: svn://svn.chromium.org/blink/trunk@177096 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an array or a dictionary is ended we check that there are no other open containers on top of it.

BUG=None

Review URL: https://codereview.chromium.org/356013002

git-svn-id: svn://svn.chromium.org/blink/trunk@177095 bbb929c8-8fbe-4397-9dbb-9b2b20218538

With [TypeChecking=Interface], two type-checks would be emitted for
variadic arguments; one as if the argument wasn't variadic, checking only
the first actual argument, and then another one checking each actual
argument.

Review URL: https://codereview.chromium.org/359763002

git-svn-id: svn://svn.chromium.org/blink/trunk@177094 bbb929c8-8fbe-4397-9dbb-9b2b20218538