- 11 Aug, 2020 40 commits
-
-
Andrew Grieve authored
* Removes these from android-pie-arm64-rel (currently offline). * Adds proguard to android-marshmallow-arm64-rel * Adds errorprone & lint to android-lollipop-arm-rel Spread across two different bots to share the load. Bug: 1111436 Change-Id: Ieac924ccae06aa4bc01b52bf795d1a174616a799 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342575Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#796688}
-
David Stevens authored
Until system wide colorspace support is improved, force planes to BT601 for consistency across platforms and kernel versions. Bug: 1102317 Change-Id: Ice5a1221b5a142a5c163288d4261eca2fb1c611c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336347Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Commit-Queue: David Stevens <stevensd@chromium.org> Cr-Commit-Position: refs/heads/master@{#796687}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=srinivassista@chromium.org Change-Id: I3f90455a47371ea4114c9dcd4b1eb396d3c86249 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348017Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796686}
-
Arthur Eubanks authored
Bug: 1114873 Change-Id: I7acc6cb8fa7b065e34dce4e4519f7564f209e7bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348149Reviewed-by:
Bettina Dea <bdea@chromium.org> Commit-Queue: Arthur Eubanks <aeubanks@google.com> Cr-Commit-Position: refs/heads/master@{#796685}
-
Peter Kasting authored
Also makes Subscription movable. I'll need this to convert some existing code over to CallbackList. Bug: none Change-Id: Iad1c20f8d4facacea67cf4379e6bdb77e7984d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343954 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#796684}
-
Alexander Surkov authored
For example, AXIndexForTextMarker(AXTextMarkerForIndex(0)) which gets a text marker by index and converts it to the index back Bug: 1100991 Change-Id: I961190dcb4e9aab3c0a6302b4f5ea3df8b5ca4a4 AX-Relnotes: n/a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346744 Commit-Queue: Alexander Surkov <asurkov@igalia.com> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#796683}
-
Nick Diego Yamane authored
Get rid of unused ash switch declarations, leftovers from crrev.com/c/1563598. R=sky@chromium.org Bug: None Change-Id: I5f604a7fa4005caa5d65db1ec5f0cc5d6cd9a60e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346727 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796682}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f998c5f44233..6ccf763c563e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC alancutter@google.com,sky@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1114866 Tbr: alancutter@google.com,sky@google.com Change-Id: Ie0247e5a32c830557f332e9ea662440aeb48c1cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347857Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796681}
-
Zhuoyu Qian authored
Bug: 1100751 Change-Id: I19f9a410341f777fff944dbfc2420ea8df872def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344441Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#796680}
-
Julie Jeongeun Kim authored
This CL moves printing::PrintMsg_Print_Params to print.mojom to pass it to Mojo interfaces. This is a precursor CL to mojofy PrintHostMsg_GetDefaultPrintSettings. Bug: 1008939 Change-Id: Ib79a3da03f8cfae58b323324ce4eb2ea3e2ea87b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335095Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#796679}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d93de0f5. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: Ie925fc221c89a09ecece28634356b25b4b52e778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348049Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796678}
-
Livvie Lin authored
The updated histograms are related to gray triangle on HTTP pages and context menu unelide features. Extend expiries in case further experimentation is needed. Change-Id: Ie16bcd644450fa5c00e06f1ceb6a3d1a51bfadee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346943Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Commit-Queue: Livvie Lin <livvielin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796677}
-
chrome://devicesrbpotter authored
Cloud and privet printing are being deprecated at the end of December. Remove chrome://devices, since it is used for adding new cloud and privet printers. - Help center link is still TBD, but should be available shortly. - Legacy page can be restored temporarily using a new flag added in this CL, ForceEnableDevicesPage, to be deleted in M88. Bug: 1114186 Change-Id: I662e195223c64ffe50df96d0512371ef0ebb0345 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343952 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
-
David Stevens authored
YUV textures from OES_EGL_image_external are sampled as RGB. Technically, the driver is supposed to preserve the colorspace, so we could still pass the primaries and transfer function. However, we don't actually pass the colorspace to the driver, and it's unclear what drivers would actually do if we did. So in effect, the colorspace is undefined. Bug: 1102317 Change-Id: I7f8b430e330fc25e3c2414ae66d1d22708e67f2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331769 Commit-Queue: David Stevens <stevensd@chromium.org> Reviewed-by:
-
Ian Kilpatrick authored
As helper functions for: fragment.Baseline().value_or(fragment.BlockSize()) which is a common pattern. There should be no behaviour change. Change-Id: Ic0b0b08c3eea9e219aac0a6a48fd906f648bd875 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226928 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Auto-Submit: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#796674}
-
Hsinyu Chao authored
This reverts commit 492996ab. Reason for revert: hychao@chromium.org is now Chromium committer. Original change's description: > Remove hychao@chromium.org from OWNERS files > > They are not yet a Chromium committer so they can't Code-Review+1 > reviews. Until then they shouldn't be in an OWNERS file. > > Change-Id: I3689ec2d4b64eecfb4f761a333ad565363fefed5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928565 > Auto-Submit: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Jenny Zhang <jennyz@chromium.org> > Reviewed-by: Jenny Zhang <jennyz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#717725} TBR=jennyz@chromium.org,reillyg@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: I7f11c2b0cfe93170ac1e1522723d5a1a5349aa91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345925Reviewed-by:
Hsinyu Chao <hychao@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Hsinyu Chao <hychao@chromium.org> Cr-Commit-Position: refs/heads/master@{#796673}
-
Owen Min authored
chrome.enterprise.reportingPrivate.uploadChromeDesktopReport is a deprecated extension API. There is no extension using this API anymore. Delete its definition and implementation to cleanup the code. Bug: 1107440 Change-Id: I76fed9d69e90ebeaf459f4533ac2bdba7b0334f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343622Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796672}
-
Chase Phillips authored
Bug: 1114900 Change-Id: I7085443e4476436d336b1e04cd2333165bc8d23f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347968 Commit-Queue: Chase Phillips <cmp@chromium.org> Commit-Queue: enne <enne@chromium.org> Auto-Submit: Chase Phillips <cmp@chromium.org> Reviewed-by:
enne <enne@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#796671}
-
Nate Fischer authored
No change to logic. This generates BaseSwitches.java from base_switches.cc, using java_cpp_strings. This adds a few Android-only switches to base_switches.cc which were previously only defined by Java. This removes AwSwitches.CRASH_UPLOADS_ENABLED_FOR_TESTING_SWITCH in favor of BaseSwitches.ENABLE_CRASH_REPORTER_FOR_TESTING. Fixed: 1112008 Test: autoninja -C out/Default system_webview_apk Change-Id: Iadc10fcfeda880668e23a7bcb693a0636116fb7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337271 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
-
Pete Williamson authored
Change-Id: I5a04dd3304ea8dbc4e51f4910012d96b1104b3fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343638Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#796669}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/559d54d0807e..275a495dbb2d 2020-08-10 jmadill@chromium.org Vulkan: Remove TODO. 2020-08-10 jmadill@chromium.org Vulkan: Refactor image dependency commands. 2020-08-10 nguyenmh@google.com Invalid calls' pointer params are no longer captured 2020-08-10 jonahr@google.com Enable required extensions for Chromium to use the Metal backend. 2020-08-10 nguyenmh@google.com Implement param capture for glGetUniform calls and extensions 2020-08-10 lehoangq@gmail.com Metal: Implement CHROMIUM_copy_texture If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1112800 Tbr: ynovikov@google.com Change-Id: If03c582cd49954d31a2ac22d40f2d209f7d33e25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347952Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796668}
-
Jia authored
This description makes it clearer that the flag is only used to control the ML model if it exists. AboutFlagsHistogramTest* Test: unit_tests --gtest_filter=AboutFlagsTest*, Bug: 881215 Change-Id: Ia226f98d954ad96c680c593716509796b17d0aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346098 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#796667}
-
David Maunder authored
We now enforce Tab attributes to be acquired on the UI thread Bug: 1114377 Change-Id: I7c9d9f6414139a57da616fcc4be2073759e84545 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343948Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Iefeb293e59764b52e8e1216ec51d0fc9f2aa9a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347854Reviewed-by:
-
Xianzhu Wang authored
This is useful for developers to understand why some tests take longer time to finish or timeout. Change-Id: I6e9e83d2c9645bac338c074fa5f1f856d66552a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2334473Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796664}
-
Minoru Chikamune authored
[MBI] Add "[Design Doc] MBI: IsolateScheduler" document and "[Code reading] SequenceManager" document Add scheduler related documents Change-Id: Ief971df3c6adaf9a79332e8b0e5090c1745e8661 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342231 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#796663}
-
HyunJi Kim authored
Bug: 1010217 Change-Id: Ic247386d4ba64c14273d959180f2c29b47f4158b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344325Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#796662}
-
Haiyang Pan authored
The test suite is stable in the past 200 builds, and the bots capacity looks sufficient as well. And tryjobs in crrev.com/c/2330730 show it works fine on 4-cores bots Bug: 997376, 1098111 Change-Id: I99bed2c4b4dbf256cba0c7c3564252be038f67ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343789Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#796661}
-
Ken Rockot authored
Inline allocations for unions have been allowed as long as the union doesn't contain any non-string reference-type fields (i.e. non-handle, non-POD fields). Exceptions were made for strings since they're copyable and don't introduce a possibility of recursive types. InlinedStructPtr however is incompatible with a union's generated wrapper class when the union's first field is a reference type like a string. This results in difficult to diagnose crashes in cases that are meant to be allowed by the bindings. This change prohibits unions from being allocated inline unless they contain only POD fields. Inline allocations could be allowed in these (and other) cases, but that would require more fundamental refactoring of the wrapper types and/or StructPtr/InlinedStructPtr. Fixed: 1114366 Change-Id: I623779f067e777a9240aef67a40decc884948247 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347167Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
-
Xinghui Lu authored
before: http://screen/JteFt6rNkc5 after: http://screen/wnMPBjYRwbh Bug: 1097310 Change-Id: I7e6b98f9510dfc580f59cbc20927da3561d15ca7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342282Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796659}
-
Tommy C. Li authored
Previously, we only had prefix (as-you-type) suggestions, and zero-prefix on-focus suggestions. Now we will have zero-prefix on-clobber suggestions, that could be (but currently aren't) distinct from zero-prefix on-focus suggestions. This CL makes AutocompleteInput use a new OmniboxFocusType multi-valued enum, which corresponds to the oft= GET parameter passed to the suggest server. oft=0 (prefix, as-you-type suggestions) oft=1 (zero-prefix, on-focus) oft=2 (zero-prefix, on-clobber) Bug: 1106096 Change-Id: Ide0dd18d76323384cef2926a0b4f9b033d862548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342268Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#796658}
-
Yusuke Sato authored
See https://chromium-review.googlesource.com/c/chromium/src/+/2344008 BUG=None TEST=try Change-Id: I0664ec7bd189ad1b44e83ec0391a470349844fc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343962 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#796657}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597082402-653f85831e858c9a0c668621a5e4055f49c06c11.profdata to chrome-mac-master-1597103970-7949af98f84f094ce49225adb2a5f704b5b255e9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Iba58da5f5fe9f2749fe6eff4fa85a732d5b6ff05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347323Reviewed-by:
-
Wenhan (Han) Zhang authored
Function to split histograms by prefix - Amended the histogram_paths.py to prepare for the distributed directories of histograms after splitting. - Amended two other files that previously expected a single histogram.xml file. - Added sorting of histogram nodes by name in merge_xml.py. Change-Id: I60101777806584722cbeb778c778553259419122 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337155 Commit-Queue: Wenhan (Han) Zhang <zwenhan@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#796655}
-
Xianzhu Wang authored
Bug: 1107003 Change-Id: I15c5a4e8c70fe4e7b535eb698dbde69134dabaae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346998 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Auto-Submit: Robert Ma <robertma@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#796654}
-
Findit authored
This reverts commit 335a581d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 796644 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzMzNWE1ODFkOTlkOTg4Yzk2MzBmOGRjNDI5ZjcxZGY0N2ZjOTlmZDMM Sample Failed Build: https://ci.chromium.org/b/8872306316841088512 Sample Failed Step: compile Original change's description: > [Android WebAPKs] Fix launching > 1 WebAPK on pre-Android-N > > This CL: > - Makes WebappLauncherActivity set the correct URI on the launch intent > for WebAPKs > - Renames WebappIntentUtils#getId() to make it clear that it only > applies to homescreen shortcuts > - Moves WebappRegistry#webApkIdForPackage() to WebappIntentUtils > alongside WebappIntentUtils#getIdForHomescreenShortcut() > - Adds a boolean parameter to > WebApkValidator#disableValidationForTesting() for the sake of tests which > need to keep validation enabled. > > BUG=1114560 > TEST=WebappLauncherActivityTest.* > > Change-Id: I31552f239f65746c8f8654bdb374ca3f4c6889e1 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345489 > Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> > Reviewed-by: Peter Conn <peconn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796644} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=1114560 Change-Id: I23183a3322ef78218ebfebb8a4f4a62aadb6b0e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347977 Cr-Commit-Position: refs/heads/master@{#796653}
-
Yuly Novikov authored
This reverts commit 320cb6fc. Reason for revert: breaks compile on mac-arm64-rel Original change's description: > Add support for creating VP9 format extensions for VTVDA. > > Creates a vpcc box based on the configuration info. > > R=sandersd > > Bug: 1103432 > Test: Updated unittests. > Change-Id: I3d5152b59c6f6ad82da25e699eba2d8bf5ba44ae > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346607 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Commit-Queue: Dan Sanders <sandersd@chromium.org> > Auto-Submit: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Dan Sanders <sandersd@chromium.org> > Cr-Commit-Position: refs/heads/master@{#796591} TBR=dalecurtis@chromium.org,sandersd@chromium.org Change-Id: I00b88a95637db2999f190c5945c97743112344e9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1103432 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348148Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#796652}
-
Chris Harrelson authored
This use cases happens after the pre-paint tree walk, so is safe for GeometryMapper. Change-Id: I728ea302c026b18d8dacf4a39c177c6f13068da4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347251Reviewed-by:
-
Scott Violet authored
It's flaky. BUG=1113972 TEST=test only change TBR=afakhry@chromium.org Change-Id: If2b41231cd9133f03b00f6388f7a5c666a24f3ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347950Reviewed-by:
-
chrome://cellular-setupAzeem Arshad authored
This CL fixes UAF in CellularSetupImpl class. This was caused because of callbacks bound with Unretained reference. Fixed this using WeakPtrFactory so that callbacks will not be referenced after CellularSetupImpl is destroyed. Fixes: 1114066 Change-Id: I6d9e2b7676e21f28861cf5ba78308e3400a4fe6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347923Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#796649}
-
