- 23 Sep, 2019 40 commits
-
-
Daniel Vogelheim authored
The WPT test trusted-types-eval-reporting was flaky, usually failing on the first run, but succeeding on the second. This was a real (and potentially serious) bug, where the CSP logic would rely on the V8 eval callback being called, but other parts would blanket-allow eval (and hence suppress the callback) because they didn't check for 'trusted types' condition. Also, minor cleanups for the test. Bug: 739170 Change-Id: I00699b115f0be474c2b6d231dcc8b884868248b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807218 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#698883}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/aabc44df..f278de18 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3e0b381ff425c65e7211650b2f3546b592e28370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819274Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698882}
-
Fergus Dall authored
Bug: none Change-Id: Icf12cda5b4266e04397a56507a6dd1a1f55837c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819080 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Auto-Submit: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#698881}
-
Tanmoy Mollik authored
"Manage your Google Account" opens the mobile web version of My Google via link instead of opening the Android native version by intent. This cl changes the direct link to a smart link which will open the native MyGoogle experience on Android. Bug: 1000664 Change-Id: I47a1e3b5affacba73143f56e3b998a8b587b9a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807250 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#698880}
-
Lutz Justen authored
RefreshAccountShowsToast was broken since waiting for the toast to open was not implemented correctly. The test was waiting for a call to the proxy's 'addAccount' method, but that doesn't trigger the toast. Instead, the 'close' event on addDialog triggers it. 'addAccount' does trigger 'close' somewhere down the pipe, but in a high load situation the execution flow seems to get skewed so that the test is executed before the 'close' event happens. This CL fixes this by waiting for the 'close' event instead. BUG=chromium:1005995 TEST=testing/xvfb.py out/Release/browser_tests --gtest_filter=*Settings* --test-launcher-jobs=200 succeeds multiple times (well, other tests fail, but the Kerberos one doesn't) Change-Id: If543c2f00c0112811beb7f2d1a2c94dbd3d265a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1815118 Commit-Queue: Lutz Justen <ljusten@chromium.org> Auto-Submit: Lutz Justen <ljusten@chromium.org> Reviewed-by:James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#698879}
-
Tim van der Lippe authored
Closure was unhappy with the `Object.assign` solution. Instead, use individual assignments and add the relevant comments, so that Closure can understand what is going on. Sample output: ``` /*Legacy exported object*/ self.UI = self.UI || {}; /*Legacy exported object*/ UI = UI || {}; //TODO(http://crbug.com/1006759): Add type information if necessary UI.TextEditor = TextEditor; //TODO(http://crbug.com/1006759): Add type information if necessary UI.TextEditor.prototype = prototype; /** @enum {symbol} */ UI.TextEditor.Events = Events; ``` Bug: 1006759 Change-Id: Ib0e571cc027f544b316a3e3ccf8c3d606273d887 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819248Reviewed-by:Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#698878}
-
Raul Tambre authored
Conversion performed automatically using '2to3 -w -f has_key .'. This is backwards compatible with Python 2. Example error: Traceback (most recent call last): File "../../components/policy/tools/generate_policy_source.py", line 1647, in <module> sys.exit(main()) File "../../components/policy/tools/generate_policy_source.py", line 349, in main policy_details = [ File "../../components/policy/tools/generate_policy_source.py", line 350, in <listcomp> PolicyDetails(policy, chrome_major_version, target_platform, File "../../components/policy/tools/generate_policy_source.py", line 128, in __init__ if not PolicyDetails.TYPE_MAP.has_key(policy['type']): AttributeError: 'dict' object has no attribute 'has_key' Bug: 941669 Change-Id: I5c089388812bbbb55ce3be4ce2081b34ed20959f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816413 Commit-Queue: Yann Dago <ydago@chromium.org> Reviewed-by:Yann Dago <ydago@chromium.org> Auto-Submit: Raul Tambre <raul@tambre.ee> Cr-Commit-Position: refs/heads/master@{#698877}
-
Gyuyoung Kim authored
This CL applies pending_receiver to CreatePushSubscription function in VideoSource interface Bug: 955171 Change-Id: Ia34e42305a466b306f0a80bf147fa85e55070550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804704Reviewed-by:
Colin Blundell <blundell@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#698876}
-
Tim Volodine authored
Make sure to cache the GetAllowFileAccess setting on the native side and on update, so that it can be retrieved efficiently inside the AwContentBrowserClient class. In particular in the RegisterNonNetworkSubresourceURLLoaderFactories() method which is executed on page and subresource loads. BUG=949590 Change-Id: I55ab035530b2b342285ed42dfd55cc2c7d9a9940 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814777 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#698875}
-
Santiago Aboy Solanes authored
This CL was created automatically with tools/perf/update_wpr script R=perezju@chromium.org Change-Id: Ib29f3bf0ea6a4a8a387c888304e02bd9e0c64578 Bug: 878390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816461 Auto-Submit: Santiago Aboy Solanes <solanes@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org> Cr-Commit-Position: refs/heads/master@{#698874}
-
chrome://prefs-internalsRohit Rao authored
BUG=1006711 Change-Id: I16e839f2ac419d051a0f2ca1b40f7ad1c8362966 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819241Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#698873}
-
Ricky Liang authored
This CL adds a switch to selectively enable GpuMemoryBuffer-based video capture buffer. Devices supporting GMB-based video capture buffers can achieve zero-copy for camera preview and reduce the power consumption on various use cases significantly. Design doc: go/cros-camera:dd:zero-copy /etc/chrome_dev.conf on Nocturne, and verify everything works. Bug: 982201 Test: Manually add "--video-capture-use-gpu-memory-buffer" into Change-Id: I178e00b0400e01f32ff8605de60c6dc2364dd384 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1692155Reviewed-by:Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Ricky Liang <jcliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#698872}
-
Mihai Sardarescu authored
This CL adds the logs necessary to debug on Canary why there is a mismatch in the list of accounts that leads to the Signin modal dialog being presented on every start-up. Bug: 1006717 Change-Id: Ic326d2166ef473a4f9922d8f1ee9221634fdbef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817884Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#698871}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/db3a63384629..b22117bdb5c3 Created with: gclient setdep -r src-internal@b22117bdb5c3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: If6afa11387e6e4f43c51df95e025e679558dce60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819326Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698870}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Id3e1cfb899ae88e851afdc44399ba6195b42f2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819041Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#698869}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/79a8474b8c1c..c48d43717c32 git log 79a8474b8c1c..c48d43717c32 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 dberris@chromium.org PinpointScheduler: Port of run_test to Tasks Created with: gclient setdep -r src/third_party/catapult@c48d43717c32 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:988912 Change-Id: Ia35d244f7151df69f6f28de7f8319b104fc93329 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819202Reviewed-by:
-
Thomas Tangl authored
Additionally, the spacing between menu components is refactored. Screenshot: https://drive.google.com/file/d/1MipwvP17KP8bX3VMg2QFfxqE3J1tma2v/view?usp=sharing Flag: profile-menu-revamp Bug: 995720 Change-Id: Ie9a549a96577e7e386f352f95db2d8d0244e7467 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819357Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#698867}
-
Guido Urdaneta authored
Bug: 976696 Change-Id: I09ead77ceddd825439da2b302172d6d5644ef3e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819240Reviewed-by:
Armando Miraglia <armax@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#698866}
-
Lowell Manners authored
As part of this CL, make DisableForTesting part of public interface, so that tests outside of content/ can disable the BackForwardCache. TBR=thakis@chromium.org Change-Id: Iaa6265b37e3406e386b1e002c70d219d45d84629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813349 Commit-Queue: Lowell Manners <lowell@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#698865}
-
John Chen authored
The WebRuntimeFeatures::EnableAutomationControlled flag is intended to indicate that the browser is potentially controlled by an automation process. There are some additional command line switches that can be used to enable automation control, and should set this flag. Bug: chromedriver:3133 Change-Id: Id737c5d75bf6aa315d5187a132a3e626daf1ba8b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810031Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#698864}
-
Nikita Podguzov authored
Bug: 992889 Change-Id: I8a57c5c011cf9470d8173c3e2ef0cdfd001f6eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819360Reviewed-by:
Nikita Podguzov <nikitapodguzov@chromium.org> Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#698863}
-
Ross McIlroy authored
This CL was created automatically with tools/perf/update_wpr script. R=perezju@chromium.org BUG=878390 Change-Id: I8711673a4b65c3d44d95699a49a7950f7a786d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680180Reviewed-by:
-
Friedrich Horschig authored
This CL adds the basic view code and wiring for the Touch To Fill component. One notable hack: the bottom sheet always comes up peeking which is not very useful. Therefore, expand() it imedately. This should be fixed in the BottomSheet component instead. If https://crrev.com/c/1803931 and the native code already landed, this CL could introduce translator images and integration tests. Bug: 957532 Change-Id: Ic3553f8cb00e5225cf669580720af6c60180e451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803933Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#698861}
-
Daniel Vogelheim authored
This is a deletion-only CL, after I noticed for an unrelated bug-fix that the ScriptState* passed into the AllowEval method isn't actually used anywhere. I have no idea whether this is a left-over or on purpose. Sending the CL on the chance that it's the former. Change-Id: I9acabd9d06ea2f2c530937e5de06c8a4f24c640d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809162Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#698860}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5f6491d2..aabc44df Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9e8ea45a59be124dc527c3555cea028b022bb366 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819258Reviewed-by:
-
Nikita Podguzov authored
Bug: 992889 Change-Id: I970100c5b1060ef31a3e67d0ff431851b3f8eaab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813352 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#698858}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/776d81525e7c..ab52a7a53db6 git log 776d81525e7c..ab52a7a53db6 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@ab52a7a53db6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bungeman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=bungeman@google.com Bug: None Change-Id: Icd7a1a5a815f248e998061119a798b8bcf804527 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819201Reviewed-by:
-
Nikita Podguzov authored
Bug: 992889 Change-Id: I510d33e358a9c2dbacecf4f99adf6ad68a0435ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816465 Commit-Queue: Nikita Podguzov <nikitapodguzov@google.com> Reviewed-by:
-
Roman Sorokin authored
Bug: 999090 Change-Id: I7a9e05af0f3ce2e745763551744f0a8d912356fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808701Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
-
Anatoliy Potapchuk authored
This reverts commit 7f37ccd8. Reason for revert: I have menually tested the previously failing tests on linux-chromeos-os builders. Tests no longer fail, enabling them back. Original change's description: > [Sheriff] Disable many PolicyDeviceDisplayResolution tests. > > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/0 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/1 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.Internal/2 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/0 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/1 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionRecommendedTest.ResizeExternalDisplay/2 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ConnectExternalDisplay/0 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.Internal/0 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.Internal/2 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/0 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/1 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.ResizeExternalDisplay/2 > PolicyDeviceDisplayResolution/DeviceDisplayResolutionTest.SetAndUnsetPolicy/0 > PolicyDeviceDisplayResolution/DisplayResolutionBootTest.Reboot/0 > > TBR=antrim@chromium.org > > Bug: 1000694 > Change-Id: I58373a317fc917f79ff440ec14c62dc9d84cda6b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800409 > Reviewed-by: vitaliii <vitaliii@chromium.org> > Commit-Queue: vitaliii <vitaliii@chromium.org> > Cr-Commit-Position: refs/heads/master@{#696000} TBR=antrim@chromium.org,vitaliii@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1000694 Change-Id: I179ddcf31fe0ac425ce6f5d8c99d2ed35420d962 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813345Reviewed-by:
-
Chinglin Yu authored
This adds a new target, profile_provider_unittest, as part of chromiumos_preflight to make it build for cros_vm. The test will then be added as part of the tests that run on cros_vm per build for the chromium repo. The test exercises the perf collector end-to-end, from the chrome browser to debugd to make real perf collections. The test adds coverage to paths that are mocked by current unit tests. Bug: 1002751 Test: Reverse apply crrev.com/c/1764319 and check that the test crashes. Then apply crrev.com/c/1773881 and check that the test passes Change-Id: I6d11a26dcd726f5bc4b8dabc9810e31f1370e5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797948 Commit-Queue: Chinglin Yu <chinglinyu@chromium.org> Reviewed-by:Gabriel Marin <gmx@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#698853}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/7cb60e812f16..b5578f4f0b22 git log 7cb60e812f16..b5578f4f0b22 --date=short --no-merges --format='%ad %ae %s' 2019-09-23 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/depot_tools@b5578f4f0b22 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: None Change-Id: Ia72def3dcfd3ea2e41245b8a407e635285a60027 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819121Reviewed-by:
-
Jan Scheffler authored
This patch adds decodes urls before trying to associate them with files from the local filesystem in workspaces. Bug: chromium:992717 Change-Id: I57678ee5db7fab7c43a254f9440b25744356c3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807503Reviewed-by:
-
Ross McIlroy authored
Disables v8.browsing_mobile-future to free up capacity and enable us to update the mobile system_health stories to 2019. Once the 2016 versions are removed, we can re-enable this benchmark. BUG=chromium:878390 Change-Id: I32071bec5f1ce4fc75dfe4fe42ddf6c04397c4cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1813327 Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Reviewed-by:
-
Raul Tambre authored
Initial conversion performed using '2to3 -f print .'. Imports added and duplicate parentheses removed manually. Manually converted files, comments and inline code that 2to3 missed. Afterwards ran "git cl format --python" and cherry-picked the formatting changes. There are no intended behavioural changes. Bug: 941669 Change-Id: I63c119deea4ef10ae933bac434658d59f8e991fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818517 Auto-Submit: Raul Tambre <raul@tambre.ee> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#698849}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fa002e6324b8..79a8474b8c1c git log fa002e6324b8..79a8474b8c1c --date=short --no-merges --format='%ad %ae %s' 2019-09-23 dberris@chromium.org Pinpoint: Pull out benchmark args to top-level Created with: gclient setdep -r src/third_party/catapult@79a8474b8c1c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC simonhatch@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=simonhatch@google.com Bug: chromium:1006658 Change-Id: I762342c494697d1a558cbb06e627b4fcdc9697ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819120Reviewed-by:
-
Kuo Jen Wei authored
Bug: 1006655 Test: Welcome banner won't popup. All other camera feature function normally. Change-Id: I7157845a9b9158e7a884a1589e51e8db3fc589ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1818001 Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Kuo Jen Wei <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#698847}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/66e6e12e7e7a..db3a63384629 Created with: gclient setdep -r src-internal@db3a63384629 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I66381f0d9ccda04d60ed5a215076daed5aa31868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817955Reviewed-by:
-
Dominik Röttsches authored
https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/170b5dd856b1..c1a585fab0c1 Add HB_NO_WIN1256 to avoid building support for .fon font files. This code also triggers a Clang warning for incorrect array size computation. See https://crbug.com/1002945 $ git log 170b5dd85..c1a585fab --date=short --no-merges --format='%ad %ae %s' 2019-09-21 ebrahim [gpos] minor 2019-09-21 ebrahim Fix clang -Wrange-loop-analysis complains 2019-09-21 ebrahim Minor, turn more of hb_apply to for each 2019-09-21 ebrahim [fuzzer] Don't process output in debug mode as it causes timeout 2019-09-14 ebrahim [ci] Re-enable debug builds on fedora bot 2019-09-21 ebrahim [ci] Enable HB_WITH_WIN1256 on -Weverything bot 2019-09-21 ebrahim [cmap] Turn hb_apply into foreach where possible 2019-09-21 ebrahim [cmap] minor 2019-09-21 ebrahim minor, use internal API instead public hb_set_has 2019-09-21 ebrahim [cmap] minor, turn 8 spaces to tab 2019-08-29 qxliu [subset] updates according to review comments 2019-08-21 qxliu [subset] Add integration tests for cmap14 2019-08-16 qxliu [subset] subsetting cmap14 2019-08-07 qxliu [subset] glyph closure for CMAP14 2019-09-18 ebrahim Avoid bitwise negate of enum value 2019-09-18 ebrahim minor 2019-09-18 ebrahim Don't rely on undefined left shift of negative value behavior 2019-09-18 ebrahim Don't seek of out-of-bound value even if the result is not used 2019-09-18 ebrahim Don't rely on nullptr deref recovery 2019-09-18 ebrahim Don't call memset when length is zero 2019-09-18 ebrahim [ci] Run -fno-sanitize-recover=undefined checks 2019-09-16 ebrahim Avoid stdint.h in Kernel module compiles 2019-09-16 ebrahim Extract an avoid errno compile flag 2019-09-15 ebrahim [doc] fix minor typo 2019-09-14 ebrahim [ci] Install cmake on macOS cmake/amalgam tester 2019-09-14 ebrahim [coretext] Fix double promotion warnings by making casts explicit 2019-09-14 ebrahim [ci] Don't build cmake tests in macOS bot 2019-09-14 ebrahim [name] Undef entry_{index,score} to avoid collision in amalgam builds 2019-09-14 ebrahim Rename GlyphID to HBGlyphID 2019-09-14 ebrahim [ci] Update and compile cmake/amalgam on macOS bot 2019-09-10 behdad Rename Fixed to HBFixed Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org Bug: 1002945 Change-Id: I6437e60a606cb7d7bcbb4813a215b104f40d7d43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819176Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#698845}
-
Yi Su authored
Currently in WebStateImpl::ClearTransientContent we store a pointer to the SSLStatus of old visible nav-item, and compare it with the new nav-item after interstitial is dismissed. This will lead to a crash if old nav-item is released in the middle. Copying SSLStatus to a local variable will avoid this crash. Bug: 1001622 Change-Id: I0f0e78c5c8297516f79eb56c56b97b8a5c4d92e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1816473Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#698844}
-
