- 22 Oct, 2019 40 commits
-
-
Yann Dago authored
Bug: 1003284 Change-Id: If2b2a4dbfacc3849cdf58e92b94c420ad126baf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1824675 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#708358}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/a043b2ba46b9..33678af88db3 git log a043b2ba46b9..33678af88db3 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 9b6351c7..fc69c6f5 (708073:708204) Created with: gclient setdep -r src/third_party/webrtc@33678af88db3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I868b53b8b895698ce2a4bc0ed8d6b5f0f711ea73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874367Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708357}
-
Alex Newcomer authored
- Enable the flag - Fix hard coded tests where it's not easy to check the feature status. - Fix a failure that has cropped up since the last round of fixes. Bug: 1009645 Change-Id: Ie0c67f2861f5af839f8add3f4b6726ea6e4b3fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860878 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Mitsuru Oshima (slow) <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#708356}
-
Dominic Mazzoni authored
The last time we updated this was before the GYP -> GN switch. This change adds a build rule for the caret browsing extension. Also fixes description of keyboard shortcut for Caret Browsing on Chrome OS. The right way to generate F7 is Search+IncreaseBrightness now, not Alt. Bug: none Change-Id: I70b645ce65e2f5e8310cec6ce02e3083b9f6e2df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1850197Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#708355}
-
Daniel Rubery authored
If the BinaryFCMService does not exist, the BinaryUploadService will return synchronously. This leads to confusing behavior, since the code was written with the expectation that this was an asynchronous operation. Bug: 1015757 Change-Id: I086529a18a2e2c97a4a6545dee89eecb51fe9dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873152 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#708354}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/bfdfc7ac4118..443f286e0cca git log bfdfc7ac4118..443f286e0cca --date=short --no-merges --format='%ad %ae %s' 2019-10-22 perezju@chromium.org [Telemetry] Remove results.AddHistogram method Created with: gclient setdep -r src/third_party/catapult@443f286e0cca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:921000 Change-Id: I7160cbd98f3c26b682ef6823f1eeadc9e30b5b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873500Reviewed-by:
-
dpapad authored
The only file that is not converted to a JS module is pdf_scripting_api.js, which is used by Print preview, as well as by some PDF viewer tests, and can't be converted yet. Fixed: 1005029 Change-Id: I1f2eabfc06180ae9cecde95e9c4b15496cd05c3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873210 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708352}
-
Yuke Liao authored
This CL fixes the code coverage documentation: 1. 'is_debug=false' gn arg is required. 2. Sandbox is working now. 3. Remove obsolete links. Bug: 1012473 Change-Id: I178f42cd6879fbfaf464d344ee272268ee654ea3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874486 Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#708351}
-
Clark DuVall authored
This implements the various types of file inputs, which required a few parts: 1) Intents sent from weblayer need to go through the fragment, not the activity, so we can handle the responses. 2) Copied file_select_helper.* from chrome/browser/file_select_helper.*, but greatly simplified them since we likely will not need much of that functionality. 3) Add a FileProvider, which is used when uploading image files from the camera. Change-Id: Iaf01199de8fdd11fc89b2178f69e700794861eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873128Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#708350}
-
Andrew Grieve authored
TBR=agrieve # Minor doc update Bug: 1013688 Change-Id: I54413da15ad8cceb242ed3758f413cbfa54c8fd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873283 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#708349}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2ba136292e50..78150fbefe75 Created with: gclient setdep -r src-internal@78150fbefe75 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:1016800,chromium:None Change-Id: I48ed7b902d2953290ae4174eeac7ecd96636587e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873496Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708348}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8017a6a7fc26..dd075112b8d6 git log 8017a6a7fc26..dd075112b8d6 --date=short --no-merges --format='%ad %ae %s' 2019-10-22 vapier@chromium.org osutils: port to python 3 2019-10-22 mmortensen@google.com Handle milestone_version and full_version in packages.GetTargetVersions. Created with: gclient setdep -r src/third_party/chromite@dd075112b8d6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I049d06308e6bedda991bb98db843462d9e74c090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873499Reviewed-by:
-
Caleb Raitto authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/5005010d694e..b51014b96251 $ git log 5005010d6..b51014b96 --date=short --no-merges --format='%ad %ae %s' 2019-10-21 caraitto Add a fuzzer for UnicodeStringAppendable. Created with: roll-dep src/third_party/icu Bug: 1009107 Change-Id: I9da089cf6629a73458ce89c18f252a3a9b2cabdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872810Reviewed-by:
Max Moroz <mmoroz@chromium.org> Commit-Queue: Caleb Raitto <caraitto@chromium.org> Cr-Commit-Position: refs/heads/master@{#708346}
-
Mike Wittman authored
This interface will be used for POSIX stack copying in a following CL. Bug: 988579 Change-Id: Iefd9c14031ef34f88587de4615b58faa8a58dd9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860150 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#708345}
-
Per Åhgren authored
Bug: chromium:1016306 Change-Id: Ibbd26fec8a3657a85aa6cf2bca0d6680e1963674 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872219Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Per Åhgren <peah@chromium.org> Cr-Commit-Position: refs/heads/master@{#708344}
-
Dan Beam authored
Fixed: 1016657 Change-Id: I9df9b7fcd524643bc9b7d3f78e646d21496b5e61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873963 Auto-Submit: Dan Beam <dbeam@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#708343}
-
Michael Spang authored
The global current config is the source of a variety of bugs which GlobalFontConfig is intended to solve. If the default config is replaced, call sites that access it may become unsafe (see bug 1004254). Bug: 1004254 Change-Id: I89bb7bb5d253773ffd60f28dcb76637eea82d37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865547Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#708342}
-
Sasha McIntosh authored
Note that JPEG YUV decoding is still only enabled for testing. In a follow-up change, |allow_decode_to_yuv_| will be set by RuntimeEnabledFeatures::DecodeJpeg420ImagesToYUVEnabled which will require rebasing some existing web tests. * Set pixmap width to the stride width (instead of image width) * Decrease unnecessary repetitive calls to JpegImageDecoder::DecodeSize (called by PaintImage::IsYuv) by providing plane indices when available. Bug: 919627 Change-Id: Ie3314b5cda9f075c62f7595ff22c41f4dad1a74e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1783206 Commit-Queue: Sasha McIntosh <sashamcintosh@chromium.org> Reviewed-by:
Eric Karl <ericrk@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#708341}
-
Evan Stade authored
Bug: 268984 Change-Id: I4c22030636127c620c3a0af2fbf9b1d9635d15c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869025Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#708340}
-
Victor Vasiliev authored
Most consumers of ConnectionInfo do not actually need the full level of detail provided by that enum, merely the name of the protocol used. This change allows us to add new QUIC versions without updating all call sites that are not interested in the specific QUIC version used. R=rch@chromium.org Change-Id: I831d3bd3a704f8f2936773a726ac50b6a80d2580 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862122Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#708339}
-
Sarthak Shah authored
This CL will stop recording data for the Event.Touch.InputEventTimeStamp.DeltaBetweenTimeNowAndPerformanceCount.* and Event.Pen.InputEventTimeStamp.DeltaBetweenTimeNowAndPerformanceCount.* histogram. These histograms were added as an experiment to collect information about the drift between TimeTicks::Now and PerformanceCount. There is no more need to record the delta between them and so removing the histogram. Change-Id: I4284dddd8b2d5be70302df4179cca1b85de263a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866909Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
-
Lukasz Anforowicz authored
This CL disables the following tests on CrOS: - RenderFrameHostImplBrowserTest.VisibilityScrolledOutOfView - SignedExchangeRequestHandlerBrowserTest.Simple - SignedExchangeRequestHandlerBrowserTest.VariantMatch Bug: 1016865, 954217 Change-Id: Ifa0bc6652c581bcfbc524931121975dedf9807fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873889 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#708337}
-
Stefan Zager authored
BUG=1014273 TBR=chrishtr@chromium.org Change-Id: I34be160b2fb69cec8b9f0bd098bf5ae22386527c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873148 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#708336}
-
Jasper Chapman-Black authored
Bug: 1011921 Change-Id: I33b2f87730acfcee33a19bc143e9fe92bf7aba36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874229Reviewed-by:
-
Chris Mumford authored
This change switches from using testing::CreateFunctor when calling testing::Invoke() to a C++ lambda. This improves test readibility and makes easier an upcoming changes to gmock_mutant.h (switch away from base::Bind()). Bug: 1007833, 806952 Change-Id: I73784234ade2a344c0a329615ca17d586f962da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874192Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#708334}
-
Kevin Ellis authored
Bug: 981210 Change-Id: Ibb4b4a68944c86ef5b65db7472b3790620678150 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873907Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#708333}
-
Peter Kasting authored
Bug: 82078 Change-Id: Idb949d0a3d0d70077aa9a0e88558d504507a1e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1866431 Auto-Submit: Peter Kasting <pkasting@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#708332}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2638f3d44b02..915b779f9cfd git log 2638f3d44b02..915b779f9cfd --date=short --no-merges --format='%ad %ae %s' 2019-10-22 michaelludwig@google.com Revert "Track device coordinate space as matrix" Created with: gclient setdep -r src/third_party/skia@915b779f9cfd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC michaelludwig@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=michaelludwig@google.com Bug: None Change-Id: I1b8227f1ca283d80edac88395e766d914c97ece9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873875Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 56e97f99. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" 707870e6 "CSS: WPT tests property values are supported." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: chcunningham@chromium.org, wolenetz@chromium.org: external/wpt/media-source eirage@chromium.org: external/wpt/pointerlock foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio kojii@chromium.org: external/wpt/css/css-writing-modes mek@chromium.org: external/wpt/webmessaging mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: Idc2baf9bd66f5a8e6c296fc63b065b73b1e06bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873985Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#708330}
-
Steven Bennetts authored
This CL provides all password fields supported in the UI in mojo. All such fields are already set to a fake value deep in the model so that plaintext values will not be accidentally leaked, and the UI already correctly identifies such values when provided. Bug: 1014779 Change-Id: I9ba46c905722481b8ce4bc35bbd2534eb2ca2505 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865812 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
Victor Hsieh authored
The adb sideloading setting is per device, and requires a reboot to initiate the flow, such that the user can securely confirm the intention while the device is in a clean state. To opt out, the user needs to go through powerwash flow in order to restore the device back to fully verified state. Only the device owner can change this device setting, and the setting applies to all users on the same device. On managed device, the feature is currently disabled. entry does not show up Test: Launch chrome without --enable-features=ArcAdbSideloading, new settings Test: Launch chrome with --enable-features=ArcAdbSideloading Test: Only when ARC++ is enabled in pref, the new setting sub menu shows Test: Go through the enabling flow, and see the value in boot lockbox changed. Test: Then, go to settings to disable the feature. Powerwash flow is initiated Test: Non-device owner see the toggle disabled with a policy indicator Test: On managed device, user see the toggle disabled with a policy indicator Bug: chromium:893332 Change-Id: I2a709a9ae451d88b4bda87dead45772f63d03f3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1834896 Commit-Queue: Victor Hsieh <victorhsieh@chromium.org> Auto-Submit: Victor Hsieh <victorhsieh@chromium.org> Reviewed-by:Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#708328}
-
dpapad authored
It was caused by a missing dependency. Fixed: 1016699 Change-Id: I866a033782a53b2c6c1bb04479a058335cafe646 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874189Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#708327}
-
Marijn Kruisselbrink authored
Bug: 740744 Change-Id: Ic22655d70695ca04ab30300293ecd24a92dab3ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867295Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#708326}
-
Reilly Grant authored
This change removes the |active_configuration_| variable so that a pointer to the mojom::ConfigurationInfo for the active configuration is no longer cached and is instead computed based on configuration value of the currently selected active configuration. Bug: 1016596 Change-Id: If84f0a5207d6743d775d2f314b4f341a2dcc707e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873919 Commit-Queue: Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#708325}
-
Rafael Cintron authored
Now that Dawn supports keyed mutexes, we need to update the Chromium side to take advantage of the new API. In SharedImageBackingD3D, if d3d11_texture_ has a keyed mutex, it will be stored in dxgi_keyed_mutex_. The keyed mutex is used to synchronize D3D11 and D3D12 Chromium components. dxgi_keyed_mutex_ is the D3D11 side of the keyed mutex. To create the corresponding D3D12 interface, pass the handle stored in shared_handle_ to ID3D12Device::OpenSharedHandle, which Dawn does on its side. Only one component is allowed to read/write to the texture at a time. keyed_mutex_acquire_key_ is incremented on every Acquire/Release usage. Bug: 966580 Change-Id: I44226a3c35a6f03d3fb9b0458824818156c6e2a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1799388Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Cr-Commit-Position: refs/heads/master@{#708324}
-
Jaeyong Bae authored
Remove the unscheduled database operations like SetIndexKeys, RenameObjectStore, etc, and move them to be kPreemptive tasks on the transaction. These operations are left over tech debt and cause bugs to occur when someone reasonably assumes that all database operations are scheduled on the transaction queue. the design document link: https://docs.google.com/document/d/1kEU2ehSMmhJ5G80-HkMSHZVkT6rXiNIyL5LUT-kIIG8/edit Bug: 1012889 Change-Id: I3d8571835ac176eac8a1a79d0c72912b36b1f06e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1870150Reviewed-by:
-
Evan Stade authored
Asan bots caught a unit test failure after 00722f1e which is fixed by making sure the ProfileManager outlasts the UserCloudPolicyManagerChromeOS Bug: none Change-Id: I5d3aef4dcc7e423bfdf1742469c8789b4edfd0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872573Reviewed-by:
Denis Kuznetsov <antrim@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#708322}
-
Evan Stade authored
Bug: 268984 Change-Id: Iba37b8c99f51e34d49546403fe02597b16552af5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873327Reviewed-by:
-
Evan Stade authored
It's already a KeyedService, so it can rely on Shutdown(). Also add some missing dependencies on other KeyedServices. Bug: 268984 Change-Id: I9c1cdb190bf0858efe2054e883fd520bbeabdb64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873275Reviewed-by:
-
Sunny Sachanandani authored
Renderer client id is propagated via command line flags, so in single process mode RenderThreadImpl gets initialized with the default client id of 1, whereas the browser allocates a globally unique client id for each renderer. Viz frame sinks are embedded in a hierarchy which identifies embedders by their client ids. So requests made by the renderer to embed other surfaces are rejected by EmbeddedFrameSinkProviderImpl because the client ids don't match. This CL fixes that by propagating the client id from the browser to RenderThreadImpl in single process mode, and includes related minor code cleanup. Bug: 1015988 Change-Id: I758f19df05ad6dc083e01e8cfc760f76ca1831a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1869376Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
-
