GitLab

Chrome extensions do not have direct access to a user's Chrome profile information, information such as saved passwords and autofill profiles.
However, the Action Recorder Extension may derive a user's saved passwords and autofill profile by observing the password fields, shipping info fields and payment fields that Chrome autofills.

To land this change, I also had to change how the extension detects the Chrome Autofill action. Prior to this change, the extension detects Chrome Autofill using a combination of keydown and onchange event listeners. This strategy can distinguish user typing actions from Chrome autofill actions, but this stategy does not distinguish Chrome autofill actions from Page JavaScript changing input values. In this change, I switched the extension to using the method outlined in https://medium.com/@brunn/detecting-autofilled-fields-in-javascript-aed598d25da7 to detect Chrome autofill.

Bug: 855284
Change-Id: I22283d5684237084ca2a8b95d9f4723be46b7746
Reviewed-on: https://chromium-review.googlesource.com/1208446
Commit-Queue: Yiming Zhou <uwyiming@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#589653}

Per https://drafts.csswg.org/cssom/#serialize-a-string double quotes
should be used when serializing strings.

Bug: 873527
Change-Id: I3b7a3c6425c6a5d0d6f96399663f5ae8b3929a59
Reviewed-on: https://chromium-review.googlesource.com/1213171
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589652}

The patch to call Unalias caused a nullptr dereference, because of
another bug that previously only triggered a DCHECK. This patch ensures
to do a "safe unalias" where we first check for null.

This check can be reverted once the underlying issues that trigger the
DCHECK are fixed (see the two referenced bugs for the nullptr
dereference and for the DCHECK failure).

R=pdr@chromium.org, trchen@chromium.org

Bug: 881788, 853357
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I412d60581466a40e4543b0ce78b18fb1a739f02b
Reviewed-on: https://chromium-review.googlesource.com/1213869Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589651}

As per [1], CaptureRequest.get() may return nullptr. Crash reports show
that for some phone models some of these calls actually do. This leads
to nullptr exception when the return value is directly converted to a
primitive value.

This CL checks for null before assuming that the return value can be
converted to a primitive.

[1] https://developer.android.com/reference/android/hardware/camera2/CaptureRequest#get(android.hardware.camera2.CaptureRequest.Key%3CT%3E)

Bug: 880855
Change-Id: I4f83499f78208b97c181fa621a1ea621d5e08de1
Reviewed-on: https://chromium-review.googlesource.com/1214047Reviewed-by: Emircan Uysaler <emircan@chromium.org>
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589650}

In preparation for enabling an ErrorProne check to ban them

Bug: 878853
Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester
Change-Id: I9cf9b07303fb3b00ce4d904f8fe56f47bb0b6268
Reviewed-on: https://chromium-review.googlesource.com/1213880Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Aiden Benner <abenner@google.com>
Cr-Commit-Position: refs/heads/master@{#589649}

If we haven't gone through prepaint since the LayoutObject was attached,
we will crash accessing the transform node.

Bug: 881921, 881735, 881643
Change-Id: I3c27c045a87319a3da2f1803707d42139d41cbfd
Reviewed-on: https://chromium-review.googlesource.com/1213805
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589648}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/98633bd1..3ee20bcf

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4d48ac9270d7a9f897967fc13c58c335e0257206
Reviewed-on: https://chromium-review.googlesource.com/1213867Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589647}

The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia_arm64_cast_audio;luci.chromium.try:fuchsia_x64_cast_audio
TBR=cr-fuchsia+bot@chromium.org

Change-Id: I876ff2904f00f7030f771a13a10e9faff8bf1e6c
Reviewed-on: https://chromium-review.googlesource.com/1214088Reviewed-by: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Fuchsia SDK Autoroller <fuchsia-sdk-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589646}

Bug: 876111
Change-Id: I8338c42e716142c4280336ea223205941002c6bf
Reviewed-on: https://chromium-review.googlesource.com/1185724Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589645}

We're consolidating roller accounts to ~1 per target repo.

Bug: skia:8291
Change-Id: I0e81d5062f30d051898d98a2008aa321c4a8f396
Reviewed-on: https://chromium-review.googlesource.com/1213934Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Eric Boren <borenet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589644}

Split out the logic that draws this highlight out of
CalculateIdealBounds which is becoming a bit long.

Bug: 880664
Change-Id: I3b36b93e2c6030b2e25552558d6a1321e647dda9
Reviewed-on: https://chromium-review.googlesource.com/1212082Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589643}

https://webrtc.googlesource.com/src.git/+log/7cd2a9514837..d7027dc081cb


git log 7cd2a9514837..d7027dc081cb --date=short --no-merges --format='%ad %ae %s'
2018-09-07 mbonadei@webrtc.org Revert "Fix no_global_constructors in audio_processing/agc2/rnn_vad."
2018-09-07 jonasolsson@webrtc.org Reland "Consolidate loggability checks and replace streams."
2018-09-07 philipel@webrtc.org Reland "Remove RTPVideoHeader::vp8() accessors."
2018-09-07 philipel@webrtc.org Revert "Remove RTPVideoHeader::vp8() accessors."
2018-09-07 philipel@webrtc.org Renamed GetCodecHeader to GetRtpVideoHeader in RtpFrameObject.
2018-09-07 philipel@webrtc.org Remove RTPVideoHeader::vp8() accessors.
2018-09-07 nisse@webrtc.org Use function-local static variable for MessageQueueManager singleton.
2018-09-07 ilnik@webrtc.org Reenable simulcast video full stack test on MAC
2018-09-07 asapersson@webrtc.org Add option to only request a frame interval change via OnOutputFormatRequest.
2018-09-07 ssilkin@webrtc.org Handle empty GOF.
2018-09-07 buildbot@webrtc.org Roll chromium_revision d03e9be2..de648460 (589368:589477)
2018-09-07 nisse@webrtc.org Reland "Delete class EventTimerWrapper."
2018-09-07 philipel@webrtc.org Removed old and unused WebRTC-NewVideoJitterBuffer field trial from VideoReceiveStreamTest.
2018-09-07 danilchap@webrtc.org Use signed integers for limiting packet size in video packetizers
2018-09-07 mbonadei@webrtc.org Fix no_global_constructors in audio_processing/agc2/rnn_vad.


Created with:
  gclient setdep -r src/third_party/webrtc@d7027dc081cb

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:none,chromium:none,chromium:none,chromium:none,chromium:None,chromium:879584,chromium:None,chromium:none
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I10159b1c5d199d577a2e5e2daa72af7e54fb3c1c
Reviewed-on: https://chromium-review.googlesource.com/1213469Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589642}

https://chromium.googlesource.com/catapult.git/+log/32654a45d3da..febcf8764dc1


git log 32654a45d3da..febcf8764dc1 --date=short --no-merges --format='%ad %ae %s'
2018-09-07 nednguyen@google.com Ignore files/directory that are not tracked by git when generating BUILD.gn for Telemetry
2018-09-07 jbudorick@chromium.org devil: move gn files over from chromium.
2018-09-07 nastasoiuf@google.com Additional features for stacked plot
2018-09-07 simonhatch@chromium.org Dashboard - Remove TestMetadata._pre_put_hook
2018-09-07 simonhatch@chromium.org Dashboard - Remove stray print
2018-09-07 simonhatch@chromium.org Dashboard - Refactor find_anomalies to support stats later


Created with:
  gclient setdep -r src/third_party/catapult@febcf8764dc1

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:879554,chromium:881910,chromium:866423,chromium:881523
TBR=sullivan@chromium.org

Change-Id: I1f41015a567033be0e588947b705ae02435521be
Reviewed-on: https://chromium-review.googlesource.com/1213776Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589641}

Some omnibox janks are related to singleton not yet initialized.

We believe there can be lot of code running under the hood on the first
key stroke. We observed font cache initialisation, localisation loading, etc...

The intend of this metrics is to be able to compare popupation for the
first key stroke and for the normal use of omnibox.

R=mpearson@chromium.org

Bug: 868419
Change-Id: I191fd6ee564aa584b633b66a2f90fc7752b64633
Reviewed-on: https://chromium-review.googlesource.com/1210167Reviewed-by: Mark Pearson <mpearson@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589640}

This adds a mechanism to report statistically-interesting
events to Chrome OS listeners.  A Chrome OS daemon (such
as the memory daemon "memd") can register as a client
of the Metrics Event Service, and receive signals on the
occurrence of related events (for instance, a tab discard).

This CL adds the supporting machinery and its first use,
signaling of a tab discard.

CQ-DEPEND=CL:1199965
BUG=chromium:729335
TEST=ran on DUT, verified that D-Bus signal is sent as expected

Change-Id: I6eddf4b0d18aa4c8a3fd4aab7f0770d87ddc7aeb
Reviewed-on: https://chromium-review.googlesource.com/1062078
Commit-Queue: Luigi Semenzato <semenzato@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589639}

The code that adds padding to too small icons was breaking the larger
ones by cutting the minimal size (22x22px) out of their center.

Bug: 799427
Change-Id: I7a87d0229e063420a4814256528fbd070c62e503
Reviewed-on: https://chromium-review.googlesource.com/1173235
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589638}

This change moves most availability annotations to the class/ivar level so that
Touch Bar-specific classes can use Touch Bar APIs without internal availability
checks.

Change-Id: I63a73683456685057909d3414f5b6cd8293d9a41
Reviewed-on: https://chromium-review.googlesource.com/1211545Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Sarah Chan <spqchan@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589637}

- Move ws::GpuInterfaceProvider into ws/public/cpp
- Move ash::ContentGpuInterfaceProvider into content as
  content::GpuInterfaceProvider;

This allows content_browsertests to use ContentGpuInterfaceProvider
for test_ws in single process mash.

Bug: 874089
Change-Id: Ia52f96c436c7d7cc2c034eaac8b20c5562a57f24
Reviewed-on: https://chromium-review.googlesource.com/1211973Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589636}

Based on skobes@ comments crbug.com/515257#c26, we decided not to
support "Prevent browser restoration if js scroll called before
browser restoration happens".

Layout.ScrollRestoration.PrecededByJsScroll is no longer needed.

This CL reverts crrev.com/c/889184.

Bug: 515257
Change-Id: I66f476c57bf59083a75a6b987d365515f1f3895e
Reviewed-on: https://chromium-review.googlesource.com/1213547Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: David Bokan <bokan@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589635}

A test for this new behavior is included as
external/wpt/xhr/abort-after-stop.htm.

This also means that XHR abort and readystatechange events from
navigation is no longer fired. Because of that,
external/wpt/xhr/open-url-multi-window-4.htm now times out rather than
fails on an assertion, aligning with Firefox. A TestExpectations entry
has been added with a bug that tracks fixing this test in spec or
upstream in WPT. A few other test expectations were updated as well to
account for this.

http/tests/navigation/reentrant-xhr-onabort-crash-during-commit.html no
longer works as intended, as abort event is no longer fired
synchronously (and thus does not expose the same crash surface). It is
replaced with an EventSource-based test that functions the same way as
XHR before this CL. Note, currently EventSource's error event suffers
from the same problem as XHR's abort event, and the class might undergo
the same change as this in the future. We will look into an alternative
for this test when that change is done.

Bug: 879620, 881180
Change-Id: I5a91047086d06347794656f92511a53c22401b5e
Reviewed-on: https://chromium-review.googlesource.com/1208672Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Timothy Gu <timothygu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589634}

Rename CompositorDelegate to GraphicsDelegate and VrShellGl to
GvrGraphicsDelegate.

Bug: 875291
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Iecb896daaa47fc3681ca642e4dac4a654536d1c5
Reviewed-on: https://chromium-review.googlesource.com/1208675
Commit-Queue: Aldo Culquicondor <acondor@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589633}

window.print() will work in iframes only if the user is interacting with
the page. This will prevent abusive experience from malicious iframes.

This CL does not have tests, because there is no infrastructure for
testing PrintTabHelper, AddScriptCommandCallback and iframes.

Bug: 881876
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: Ia741e74accf69b6cee63351e04851e3068e8c3e5
Reviewed-on: https://chromium-review.googlesource.com/1213270Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Commit-Queue: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589632}

Bug: 819421
Change-Id: Idf4c66ed52d8b279ec54c9aa0977a7dba58f332b
Reviewed-on: https://chromium-review.googlesource.com/1204719Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589631}

https://pdfium.googlesource.com/pdfium.git/+log/1881cb7591c7..26fbb0328d57


git log 1881cb7591c7..26fbb0328d57 --date=short --no-merges --format='%ad %ae %s'
2018-09-07 hnakashima@chromium.org Revert "Discard deps that are not sync'ed anymore in safetynet_compare.py."


Created with:
  gclient setdep -r src/third_party/pdfium@26fbb0328d57

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: Icce982ada90df5b45aa269ee178307ae5bf83f9f
Reviewed-on: https://chromium-review.googlesource.com/1213766Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589630}

This will let us more easily test on canary channel Chromebooks.

Bug: none
Change-Id: Ie382991d547f0e48d8198fc4037580033a9dfb3a
Reviewed-on: https://chromium-review.googlesource.com/1211880Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589629}

A couple of font-specific files were moved to fonts, and
some cc types were inlined.

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Ibb99014e2b35e215d31a04a9d9933ea21d0035ae
Reviewed-on: https://chromium-review.googlesource.com/1185639Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589628}

When app is pinned, icon image is loaded via controller using loader
owner by chrome launcher controller. Once new ARC app window appears in
the system, it's icon is loaded asynchronously. In this flow, default
app icon is applied first and then, once real image is loaded final icon
is set. Each update of ARC window icon is reflected on shelf. That
means default app icon appear on the shelf for a moment and in most cases
this is very noticeable.
This CL prevents setting default app in favor of final app icon and
default icon is set only as a fallback when final icon could not be
loaded.

TEST=Manual
BUG=b:114246197

Change-Id: I2de9e9d99b313f7538dce9dd732164335f32a42a
Reviewed-on: https://chromium-review.googlesource.com/1212348
Commit-Queue: Yury Khmel <khmel@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589627}

https://skia.googlesource.com/skia.git/+log/1fc5fbd80451..24de64834600


git log 1fc5fbd80451..24de64834600 --date=short --no-merges --format='%ad %ae %s'
2018-09-07 mtklein@google.com fix lowp gradients
2018-09-07 reed@google.com add flag to soften the blow of removing a legacy api for flutter
2018-09-07 jvanverth@google.com Revert "fix picture subclass destructor doc"
2018-09-07 kjlubick@google.com [PathKit] Add cubicYFromX
2018-09-07 michaelludwig@google.com Add fields to fragmentProcessors in sksl code.
2018-09-07 mtklein@google.com Revert "SkMath takes some functions from from SkTypes"
2018-09-07 caryclark@skia.org fix picture subclass destructor doc
2018-09-07 halcanary@google.com SkMath takes some functions from from SkTypes


Created with:
  gclient setdep -r src/third_party/skia@24de64834600

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=jvanverth@chromium.org

Change-Id: I8e5d2df09e8317a9c79b57c32591bace2b490db9
Reviewed-on: https://chromium-review.googlesource.com/1213775Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#589626}

* Add a hook to override the command line of test_main.cc.
chrome_cleaner_unittests has an empty implementation. Other internal
test executables that use test_main.cc use this to add flags to the
commandline.

* Add more accessors to engine_resources.h to reduce hardcoding.

* Move the dummy engine resources and signatures to their own build
targets.

* Remove unused MatchingOptions::find_incomplete_matches.

* Remove unused StartScanning and StartCleanup methods in
MainDialogAPI.

* Make test binaries into console apps.

* Allow import_util.py to work outside the source tree.

* Cleanups to deps and includes.

* Alphabetize test/BUILD.gn so it can be diffed against the internal
version more easily during upstreaming.

R=csharp

Bug: 830892
Change-Id: I263aabf02a467df231e3c227ea6f01328b9212d3
Reviewed-on: https://chromium-review.googlesource.com/1207171Reviewed-by: Chris Sharp <csharp@chromium.org>
Reviewed-by: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589625}

Bug: 868213
Change-Id: I1d5b577d46789cbcfd375423031b428362935320
Reviewed-on: https://chromium-review.googlesource.com/1214158Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>
Commit-Queue: Ryan Tseng <hinoka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589624}

This was added in r524073 because code search didn't linkify bare crbug
links.  But now it does (see crbug.com/762061), so we don't need the
extra verbosity.

Change-Id: Ia0b2fd66b4717cb9dd87b6e49373918cec729c51
Reviewed-on: https://chromium-review.googlesource.com/1213512
Commit-Queue: Steve Kobes <skobes@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589623}

There are no flags to be updated

Leave data in QUIC buffers until everything has arrived.

Quartc cannot actually consume data until all the data for a stream has arrived.
Leaving stream data in QUIC's sequencer buffer until all the data for a stream
is ready to read allows QUIC flow control to account for data until Quartc is
ready to consume it.  This prevents a sender from running a Quartc client out of
memory by sending it an unbounded amount of data without terminating a stream.

QuartcStream supports a "deliver on complete" mode.  When using this mode, the
Quartc stream will not issue Delegate::OnReceived callbacks until the FIN bit
and all stream data has arrived.

QuartcStream sets its sequencer to level_triggered mode so that it will receive
OnDataAvailable() callbacks every time new data arrives.  Without this, the
sequencer only calls streams when the amount of readable data changes from zero
to non-zero.  This doesn't work for the deliver_on_complete mode, which requires
a callback when the last frame arrives.

Adds an accessor for QuicStreamSequencer::close_offset_.

n/a (Quartc only)

Merge internal change: 211145774

https://chromium-review.googlesource.com/c/1210166/
Bug: 112846671

--------------------------------------------------

Changes QuicStreamSequencer to handle ignore_read_data_ the same way
when level_triggered_ is true.

Currently, when level_triggered_ is true, QuicStreamSequencer calls
OnDataAvailable() each time new data may be read, regardless of
whether ignore_read_data_ has already been set.  With this change, it
does not call OnDataAvailable() if ignore_read_data_ has already been
set, and instead flushes buffered frames.  This is the same thing that
happens when new data is available if the sequencer is not
level_triggered_.

This makes QuicStreamSequencer::StopReading() work as described in the
documentation when the sequencer is level-triggered.  See
documentation here:
http://google3/third_party/quic/core/quic_stream_sequencer.h?l=83&rcl=208892429

Guarded by quic_stop_reading_when_level_triggered flag.

Merge internal change: 211145297

https://chromium-review.googlesource.com/c/1210622/

--------------------------------------------------

[QPACK] Remove QpackProgressiveEncode::string_offset_.

Totally unnecessary to keep an offset to a StringPiece, since changing
that StringPiece itself is cheap.

n/a (Prototype code not in production.)

Merge internal change: 211079590

https://chromium-review.googlesource.com/c/1210366/
Bug: 112770235

--------------------------------------------------

Add check for static streams when processing headers so that we won't try
getting dynamic streams for them. Protected by
--gfe2_restart_flag_quic_check_stream_nonstatic_on_header_list.

Merge internal change: 211017542

https://chromium-review.googlesource.com/c/1210266/
Bug: 113533504

--------------------------------------------------

Directly sample QUIC's BbrSender.

Use BandwidthSampler directly in QUIC's BbrSender instead of
referencing the interface.  No functional change, not flag protected.

Merge internal change: 211006022

https://chromium-review.googlesource.com/c/1210164/
Bug: 111468849

--------------------------------------------------

[QPACK] Reset ProgressiveDecoder::name_ and value_ before use, not after.

DCHECK(name_.empty()) and name_.clear() were kind of too far.  It makes more
sense to reset a member right before it is needed to be reset.  Note that the
total number of resets does not change: it is still called once per header
block.

n/a (Prototype code not in production.)

Merge internal change: 210957214

https://chromium-review.googlesource.com/c/1210363/
Bug: 112770235

--------------------------------------------------

Refactor QpackProgressiveEncoder.

Refactor QpackProgressiveEncoder states from Next() method into their own
private methods.  Previously there was an early return if and only if |state_|
was not changed, test this condition in Next() for breaking out of the loop.

n/a (Prototype code not in production.)

Merge internal change: 210831163

https://chromium-review.googlesource.com/c/1210362/

--------------------------------------------------

Move the flag count for FLAGS_quic_reloadable_flag_quic_use_get_cert_chain to the correct location.
The old location was not being hit because it was in the flag=false branch.

n/a - Flag count only

Merge internal change: 210794711

https://chromium-review.googlesource.com/c/1210264/

--------------------------------------------------

Add a FLAG_COUNT for FLAGS_quic_reloadable_flag_quic_new_lru_cache

Merge internal change: 210772455

https://chromium-review.googlesource.com/c/1210263/

--------------------------------------------------

Enable probing retransmissions and flexible app-limited handling in Quartc.

Probing retransmissions (fill_up_link_during_probing) drive QUIC out of STARTUP
when Quartc does not provide enough application data to reach QUIC's STARTUP
pacing rate.  QUIC retransmits existing data in order to probe for higher
bandwidth and eventually exit startup.

Flexible app-limited handling (quic_bbr_flexible_app_limited + BBR9) cause BBR
to ignore OnAppLimited() if there is already enough data in-flight for BBR to
make progress.  Under this mode, BBR only requests probing packets if it doesn't
have enough data in-flight.

Flexible app-limited handling makes it possible for Quartc to enable probing
retransmissions without starving itself, as this ensures there is some bandwidth
left over for Quartc to send new data.

QuicCallbacksTest needs to disable fill_up_link_during_probing in two test cases
in order to better control what data is written and when.  This applies to the
two cases for reporting buffered data.  These test cases require scenarios where
specific data is buffered or retransmitted.  Driving QUIC out of STARTUP to
avoid interference from probing retransmissions occasionally got stuck and timed
out, so simply disabling probing retransmissions makes it easier to cover these
cases.

n/a (Quartc only)

Merge internal change: 210728277

https://chromium-review.googlesource.com/c/1210163/
Bug: 112192494

--------------------------------------------------

Check handshaker is not null before calling
QuicCryptoServerHandshaker::CancelOutstandingCallbacks

Merge internal change: 210726104

https://chromium-review.googlesource.com/c/1210142/

--------------------------------------------------

Signal error on unknown opcodes in QpackDecoder.

All these opcodes will have to be implemented, so no reason to add test for
these errors now.

Before this CL, QpackDecoder just blindly assumed that the opcode was for
Literal Header Field Without Name Reference.

n/a (Prototype code not used in production.)

Merge internal change: 210716471

https://chromium-review.googlesource.com/c/1210063/

--------------------------------------------------

QPACK: factor out wire format binary constants.

n/a (Prototype code not used in production.)

Merge internal change: 210600833

https://chromium-review.googlesource.com/c/1210082/
Bug: 112770235

--------------------------------------------------

Change HpackVarintDecoder signature.

HpackVarintEncoder::StartEncoding() already takes |prefix_length| instead of
|prefix_mask|.  Sure if HpackVarintDecoder::Start* takes |prefix_mask| that
allows prefix masks to be baked in production code, cutting down on one CPU
instruction per Huffman encoding.  I argue that changing the interface to
|prefix_length| is cleaner and is worth the extra cost.

HpackVarintDecoder refactor, no functional change intended.

Merge internal change: 210596803

https://chromium-review.googlesource.com/c/1209984/
Bug: 112770235

--------------------------------------------------

Add a server_config_id argument to KeyExchangeSource::Create so that LetoKeyExchangeSource can use it.

n/a - unused code

Merge internal change: 210578371

https://chromium-review.googlesource.com/c/1209523/

--------------------------------------------------

Move HPACK integer encoder and decoder into a new common directory.

Refactor, no functional change.

Merge internal change: 210561940

https://chromium-review.googlesource.com/c/1208697/
Bug: 112770235

--------------------------------------------------

Add Huffman support in QpackEncoder.

Also remove silly DCHECK from http2::HuffmanEncode() to make life easier.

n/a (Prototype code not in production.)

Merge internal change: 210537018

https://chromium-review.googlesource.com/c/1209212/
Bug: 112770235

--------------------------------------------------

Add Huffman support in QpackDecoder.

n/a (Prototype code not in production.)

Merge internal change: 210454064

https://chromium-review.googlesource.com/c/1209211/
Bug: 112770235

--------------------------------------------------

Add QUIC_FLAG_COUNT for FLAGS_quic_reloadable_flag_quic_use_get_cert_chain.

n/a - Flag count only

Merge internal change: 210451731

https://chromium-review.googlesource.com/c/1209210/

--------------------------------------------------

When fill_up_link_during_probing_ is enabled by Quartc, check whether
more inflight is necessary after every probing packet is sent. Adds a
BBR9 connection option that only treats samples as app-limited if
bytes_in_flight is too low to observe a higher bandwidth.  Connection
option protected by
FLAGS_quic_reloadable_flag_quic_bbr_flexible_app_limited,
fill_up_link_during_probing_ not used in GFE.

Replaces cr/191675927

Merge internal change: 210409167

https://chromium-review.googlesource.com/c/1209170/
Bug: 77975811

--------------------------------------------------

Add QPACK fuzzers.

Add fuzzer for QpackDecoder.  Add another fuzzer for round-trips that should be
able to cover all code paths of QpackEncoder (but not QpackDecoder) and also
verify that we get back the original header list.  Add corpus for each fuzzer
that is minimized and covers almost all of respective source files.  Change
QpackDecoder to signal error instead of crashing on Huffman-encoded input.

Copy Chromium's FuzzedDataProvider to quic/platform.  Note to merge rotation:
in Chromium, quic/platform/impl/quic_fuzzed_data_provider.h will be trivial:
using QuicFuzzedDataProviderImpl = base::FuzzedDataProvider;

n/a (Prototype code not in production.)

Merge internal change: 210399075

https://chromium-review.googlesource.com/c/1208934/
Bug: 112770235

--------------------------------------------------

[QPACK] Introduce FragmentSizeGenerator.

This abstraction will be used for fuzzing.

n/a (Prototype code not in production.)

Merge internal change: 210394197

https://chromium-review.googlesource.com/c/1208677/
Bug: 112770235

--------------------------------------------------

Improve readability of QuicSentPacketManager::MarkForRetransmission

Improve the readability of QuicSentPacketManager::MarkForRetransmission
by using an early return and some helper methods.

n/a - reorganizing code

Merge internal change: 210193731

https://chromium-review.googlesource.com/c/1208676/

--------------------------------------------------

Pack QuicStreamFrame into QuicFrame more tightly to save 8 bytes in
QuicFrame.  Not flag protected, no functional change.

Merge internal change: 210144041

https://chromium-review.googlesource.com/c/1208437/
Bug: 112563066

--------------------------------------------------

Add BytesPendingRetransmission() to BufferedDataBytes() in QuartcCallbacks.

Retransmissions count against QUIC's pacing rate and congestion window exactly
as initial transmissions do.  Therefore, Quartc should treat data pending
retransmission exactly the same way it treats data that is buffered for initial
transmission.  In particular, both pending retransmissions and initial
transmissions should be accounted for in buffer-based back-pressure.

QUIC now calls OnBufferChanged(quic::QuartcStream*) whenever a stream frame is
lost or retransmitted.  QuartcStream::BytesPendingRetransmission() reports the
number of bytes waiting to be retransmitted for each stream.

Note: QuartcStream already handles the corner case of streams where
cancel_on_loss is set.  These streams will never retransmit, and always report
zero BytesPendingRetransmission().

QuartcCallbacks can account for both initial transmissions and retransmissions
by adding BytesPendingRetransmission() to BufferedDataBytes() before reporting
the value to RateControl.  (RateControl applies back-pressure to encoders.)

n/a (testonly, factors the packet filter out of QuartcSessionTest)

Merge internal change: 210140689

https://chromium-review.googlesource.com/c/1208433/

--------------------------------------------------

Log application-limited events and external parameters into QuicTrace

n/a (code not used in production)

Merge internal change: 210140046

https://chromium-review.googlesource.com/c/1208671/

--------------------------------------------------

Rename methods and member classes.

Rename member functions (methods) and member classes if part of the name is
redundant with the name of the enclosing class.

This is a follow-up to https://critique.corp.google.com/#review/209843547/depot/google3/third_party/quic/core/qpack/qpack_decoder.h&l=44R&vr=s9

Rename methods and classes.

Merge internal change: 210116798

https://chromium-review.googlesource.com/c/1208670/
Bug: 112770235

--------------------------------------------------

Add QPACK round trip tests; factor out QpackTestUtils.

Add QPACK round trip tests.  Factor out things common in QpackEncoderTest,
QpackDecoderTest, and QpackRoundTripTest into a new library.

n/a (Prototype code not in production.)

Merge internal change: 210042125

https://chromium-review.googlesource.com/c/1208413/
Bug: 112770235

--------------------------------------------------

Allow empty QPACK encoder/decoder input.

Allow decoding empty input in QpackDecoder::QpackProgressiveDecoder::Decode().
Allow encoding empty input in QpackEncoderTest::Encode() (test only).

n/a (Prototype code not in production.)

Merge internal change: 210039980

https://chromium-review.googlesource.com/c/1208430/
Bug: 112770235

--------------------------------------------------

Add QuicCrypter base class. No behavior change.

Merge internal change: 210002082

https://chromium-review.googlesource.com/c/1207614/

--------------------------------------------------

Move QpackVarintEncoder to third_party/http2

...and rename it to HpackVarintEncoder.  This CL buys us the following things:

* Free roundtrip tests, as HpackVarintDecoderTest uses
HpackBlockBuilder::AppendHighBitsAndVarint, which now relies on
HpackVarintEncoder.
* QPACK uses HPACK integer representation, so HpackVarintEncoder is a more
appropriate class name than QpackVarintEncoder, and third_party/http2 is a
more appropriate place than third_party/quic.
* Some reduction of code duplication in
HpackBlockBuilder::AppendHighBitsAndVarint().

The downside is that embedders that embed third_party/http2 but not
third_party/quic now have to include HpackVarintEncoder in production, resulting
in a slight increase in binary size.  Embedders of both third_party/http2 and
third_party/quic are not affected in the long run, because they need the encoder
anyway.  (This is not the case quite yet as third_party/quic/core/qpack is not
yet included in production code.)

Move class from third_party/quic to third_party/http2.

Merge internal change: 209978253

https://chromium-review.googlesource.com/c/1207895/
Bug: 112770235

--------------------------------------------------

Allow QUIC simulator alarms to be scheduled in the past

As discovered in b/112928831, this is something that does happen in real world
when write-blocking is involved, hence it would make sense to support it in
simulations too.

n/a (test-only change)

Merge internal change: 209975070

https://chromium-review.googlesource.com/c/1206434/
Bug: 112928831

--------------------------------------------------

Updates a DCHECK that fires in an end-to-end test when a client
disconnects immediately after sending a request.

This fixes the secure_quic test failures observed in the presubmits
for CL 209770890.

Modifies a debug-only assertion in QuicSpdyServerStreamBase::
CloseWriteSide(). No functional change for optimized builds.

Merge internal change: 209973796

https://chromium-review.googlesource.com/c/1206673/
Bug: 111649083

--------------------------------------------------

Refactor QuicLRUCache to use QuicLinkedHashMap instead of
SimpleLRUCache.  No functional change.  Protected by
FLAGS_quic_reloadable_flag_quic_new_lru_cache

This is a part of the effort to reduce QUIC platform dependencies, but this
would also have a nice effect of reducing the memory usage since SimpleLRUCache
claims it has at least 100 bytes of overhead per entry.

Merge internal change: 209969156

https://chromium-review.googlesource.com/c/1206432/

--------------------------------------------------

n/a, test only. Fix two typo in key exchange tests.

Merge internal change: 209901814

https://chromium-review.googlesource.com/c/1205837/

--------------------------------------------------

Fix bug in QpackVarintEncoder.

Turns out QpackVarintEncoder::varint_ is not a good way to keep track of whether
encoding is in progress.  If an integer just barely does not fit on the prefix,
then a zero byte needs to be emitted after the first byte.  However, since
|varint_| is zero, the encoder incorrectly omits this byte.

Note that this cannot happen with subsequent bytes.  If an integer does not fit
in the prefix and some bytes that follow, then the leftover part must be
non-zero.  If it wasn't, then the continuation bit on the last byte would not be
set.  This corner case can only happen if |varint == prefix_mask|, because the
byte that holds the prefix does not have a continuation bit as a mechanism to
signal continuation.

This CL fixes that by introducing a dedicated Boolean member to keep track of
whether encoding is in progress.  This Boolean is |encoding_in_progress_|
instead of |encoding_is_done_|, and consequently the accessor is renamed to
EncodingInProgress(), and every call site has to be inverted.  "Done" does not
make much sense for something that would need to be true upon construction
before any encoding is performed.

This CL also adds test coverage in QpackVarintEncoderTests, and also in
QpackEncoderTests.

n/a (Prototype code not in production.)

Merge internal change: 209872387

https://chromium-review.googlesource.com/c/1206696/
Bug: 112770235

--------------------------------------------------

Implement primitive QPACK decoder.

This primitive decoder only decodes non-Huffman encoded string literals without
name reference.

n/a (Prototype code not in production.)

Merge internal change: 209843547

https://chromium-review.googlesource.com/c/1206695/
Bug: 112770235

--------------------------------------------------

Factor out QpackVarintEncoder.

Factor out parts of QpackEncoder into its own QpackVarintEncoder class.  This is
a refactor only, improvements and bugfixes will come in subsequent CLs.

n/a (Prototype code not in production.)

Merge internal change: 209801638

https://chromium-review.googlesource.com/c/1206694/
Bug: 112770235

--------------------------------------------------

Add a BytesPendingRetransmission() method to QuartcStream.  Call
Delegate::OnBufferChanged() whenever a stream frame is lost or retransmitted.

This allows Quartc to account for bytes pending retransmission along with
buffered bytes when applying back-pressure on data sources.

Right now, QuartcStream sums the lengths of all intervals in the set of
pending retransmissions.  Since Quartc streams carry only a single audio or
video frame, there should generally be a small number of lost frames, so it
should not be an issue to add them up.  We can optimize later, if necessary.

Makes QuicStream::OnStreamFrameLost() virtual so that Quartc can be
notified when it is called.  Adds an accessor for
QuicStreamSendBuffer::pending_retransmission_.  These are only used in Quartc.

Merge internal change: 209786500

https://chromium-review.googlesource.com/c/1206693/

--------------------------------------------------

Fix QPACK encoder bug with zero length names and values.

Encoder was not working properly with small fragments on state transitions,
because kNameString and kValueString states would have needed to be run even if
there was no space in buffer.  Change logic so that every state actually writes
to the buffer, by skipping these states if name or value is empty.

Parametrize all QPACK encoder tests to write the whole buffer at once or to
write octet by octet.

n/a (Prototype code not in production.)

Merge internal change: 209759976

https://chromium-review.googlesource.com/c/1206671/
Bug: 112770235

--------------------------------------------------

Deprecate FLAGS_quic_reloadable_flag_quic_retransmissions_app_limited.

n/a (Flag deprecation)

Merge internal change: 209746153

https://chromium-review.googlesource.com/c/1206690/

--------------------------------------------------

Implement primivite QPACK encoder.

This primitive encoder only emits non-Huffman encoded string literals.
Tests are very rudimentary.

n/a (Prototype code not in production.)

Merge internal change: 209742299

https://chromium-review.googlesource.com/c/1206670/
Bug: 112770235

--------------------------------------------------

Update and expand comments in quic_versions.h

n/a (comments-only change)

Merge internal change: 209720017

https://chromium-review.googlesource.com/c/1205531/

--------------------------------------------------

Deprecate FLAGS_quic_reloadable_flag_quic_ack_reordered_packets.

n/a (Flag deprecation)

Merge internal change: 209699826

https://chromium-review.googlesource.com/c/1205198/

--------------------------------------------------

Modify CryptoMessageParser::ProcessInput to take an EncryptionLevel

This is in preparation for the new interface between TLS and QUIC, where when
the TLS stack is provided with a handshake message from QUIC, it also needs to
be provided with the EncryptionLevel at which the message was received.

Refactor QUIC's CryptoMessageParser. No behavior change.

Merge internal change: 209514195

https://chromium-review.googlesource.com/c/1205314/
Bug: 112643533

--------------------------------------------------

QUIC: remove unused Perspective params from CryptoFramer

Merge internal change: 209510531

https://chromium-review.googlesource.com/c/1205196/
Bug: 112643533

--------------------------------------------------

Add a basic HTTP over QUIC framer which is capable of parsing HTTP over QUIC frames.
Serialization is still lacking, as are some performance optimizations.

n/a - Unused code

Merge internal change: 209504683

https://chromium-review.googlesource.com/c/1204672/

R=rch@chromium.org

Change-Id: Ibeb5bee8cc6a41c7d7064b896f5554193f791152
Reviewed-on: https://chromium-review.googlesource.com/1213936Reviewed-by: Ryan Hamilton <rch@chromium.org>
Commit-Queue: Frank Kastenholz <fkastenholz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589622}

The current ChromeOS's camera stack (cros-camera) assumes that
capture_unittests would run in a single process.

Bug: 881682
Change-Id: I7a89f63ee16c7eb97b83b15ed46ee8061d1d601d
Reviewed-on: https://chromium-review.googlesource.com/1212433
Commit-Queue: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589621}

This reverts commit 41aadb51.

Reason for revert: Introduces static initializers according to https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/mac-rel/552.

Original change's description:
> [jumbo] Make it one g_id_map instead of two.
> 
> A commit just introduced a second g_id_map in ui/views/cocoa,
> which broke jumbo builds. This renames the g_id_map
> globals to the longer names g_id_to_impl_map and
> g_id_to_host_impl_map.
> 
> Bug: 859152
> 
> TBR=ccameron@chromium.org,ellyjones@chromium.org
> 
> Change-Id: Id30d71b67f4bfb7c3ddc3ec8d03c759b5b7df14f
> Reviewed-on: https://chromium-review.googlesource.com/1212862
> Reviewed-by: Daniel Bratell <bratell@opera.com>
> Commit-Queue: Daniel Bratell <bratell@opera.com>
> Cr-Commit-Position: refs/heads/master@{#589465}

TBR=ellyjones@chromium.org,ccameron@chromium.org,bratell@opera.com

Change-Id: I70fdf14f4759f74e9572e0b69884febb2607adcc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 859152
Reviewed-on: https://chromium-review.googlesource.com/1213705Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589620}

This reverts commit 99e4e0f3.

Reason for revert: Looks like this broke compile, possibly due to conflicts w/ https://chromium.googlesource.com/chromium/src/+/19e91cc9aefac767e9482351123b11f1bb6e2c70

Original change's description:
> [AF] Make IsCreditCardUploadEnabled use ActiveAccount email if in Butter
> 
> It used to get the Primary Account's email but should get the active
> account's one instead if in Butter state.
> 
> Bug: 881730
> Change-Id: I1e48d39bd1c908bee82034e1eb7b40231f6c788d
> Reviewed-on: https://chromium-review.googlesource.com/1213444
> Reviewed-by: Mathieu Perreault <mathp@chromium.org>
> Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#589617}

TBR=mathp@chromium.org,sebsg@chromium.org,feuunk@chromium.org

Change-Id: Ida5dc715c7eb6618d213a676f00a0476b0cd2cad
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 881730
Reviewed-on: https://chromium-review.googlesource.com/1214105Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589619}

ES team would like to use this infrastructure.

Change-Id: Ia997c91d1525c36690aadf8f47f0b0cf193201df
Reviewed-on: https://chromium-review.googlesource.com/1213312Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589618}

It used to get the Primary Account's email but should get the active
account's one instead if in Butter state.

Bug: 881730
Change-Id: I1e48d39bd1c908bee82034e1eb7b40231f6c788d
Reviewed-on: https://chromium-review.googlesource.com/1213444Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589617}

The IceTransportAdapter splits P2PTransportChannel-specific logic
out of IceTransportHost and puts it behind an interface to
facilitate future testing. The API methods are changed to map to
the requirements of the RTCIceTransport rather than the
implementation details of the P2PTransportChannel.

Bug: 864871
Change-Id: I2a7036f675a11460e9721cc937beec17b7f03cc9
Reviewed-on: https://chromium-review.googlesource.com/1200127
Commit-Queue: Steve Anton <steveanton@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589616}

Bug: 879147
Change-Id: I861ceb38370a0de959c6881735819097a030cb09
Reviewed-on: https://chromium-review.googlesource.com/1202542
Commit-Queue: Martin Robinson <mrobinson@igalia.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589615}

It looks like there is bug in GCC 6, which cannot go through
structure initialization normally.

Thus, instead of a default initialization of one of the members,
explicitly initialize it to a default value.

Change-Id: Ia55cc6658e6b6b2f8a80c2582dd28f001c9e648c
Reviewed-on: https://chromium-review.googlesource.com/1213181Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Maksim Sisov <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#589614}