Commits · 5e4c0262a0aa197b3b7a6cf43817afa59fa23864 · eriksson monteiro / tangled

22 Nov, 2015 1 commit
- Updating trunk VERSION from 2571.0 to 2572.0 · 5e4c0262
  chrome-tpm authored Nov 21, 2015
```
Cr-Commit-Position: refs/heads/master@{#361031}
```
  5e4c0262
21 Nov, 2015 39 commits

More regular Platform implementations in unit tests (reland.) · 6018759c

sigbjornf authored Nov 21, 2015

R=haraken,jbroman
BUG=

Review URL: https://codereview.chromium.org/1456873003

Cr-Commit-Position: refs/heads/master@{#361030}

6018759c

Enable building of ppapi_nacl tests for arm/glibc · 4df2d47c

sbc authored Nov 21, 2015

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile
BUG=505885

Review URL: https://codereview.chromium.org/1462693004

Cr-Commit-Position: refs/heads/master@{#361029}

4df2d47c

Update 'mb' setting for Linux ARM bots · 363fa3bc

sbc authored Nov 21, 2015

- Add 'swarming' settings since these bots now use swarming.
- Remove 'arm_linux_tester' and corresponding 'none' settings.
- Remove now unused 'arm_float' settings.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_arm_compile
BUG=159519

Review URL: https://codereview.chromium.org/1470623002

Cr-Commit-Position: refs/heads/master@{#361028}

363fa3bc

Roll ANGLE daa8c27..847638a · fa9b77fa

jmadill authored Nov 21, 2015

https://chromium.googlesource.com/angle/angle.git/+log/daa8c27..847638a

BUG=541551
TBR=geofflang@chromium.org
TEST=bots

Review URL: https://codereview.chromium.org/1464873006

Cr-Commit-Position: refs/heads/master@{#361027}

fa9b77fa

DevTools: Prettify websocket frames preview on Network pane. · 161006a2

alph authored Nov 21, 2015

Add JSON style formatting.

BUG=488978

Review URL: https://codereview.chromium.org/1468633002

Cr-Commit-Position: refs/heads/master@{#361026}

161006a2

Simplify ImageResource::canRender() · fec9b124

davve authored Nov 21, 2015

Assume that neither image rotation nor scale can affect the image size
emptiness. This makes it easier to further simplify
imageSizeForLayoutObject later.

BUG=559131

Review URL: https://codereview.chromium.org/1463793002

Cr-Commit-Position: refs/heads/master@{#361025}

fec9b124

Revert of More regular Platform implementations in unit tests (reland.)... · a22a72fa

tommi authored Nov 21, 2015

Revert of More regular Platform implementations in unit tests (reland.) (patchset #14 id:260001 of https://codereview.chromium.org/1456873003/ )

Reason for revert:
Looks like this is causing build issues.  E.g. http://build.chromium.org/p/chromium.win/waterfall?builder=Win%20x64%20GN%20(dbg)

Example:
FAILED: ninja -t msvc -e environment.x64 -- E:\b\build\goma/gomacc.exe "E:\b\depot_tools\win_toolchain\vs2013_files\VC\bin\amd64/cl.exe" /nologo /showIncludes /FC @obj/third_party/WebKit/Source/platform/test_support/TestingPlatformSupport.obj.rsp /c ../../third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp /Foobj/third_party/WebKit/Source/platform/test_support/TestingPlatformSupport.obj /Fdobj/third_party/WebKit/Source/platform/test_support_cc.pdb
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(654) : error C2220: warning treated as error - no 'object' file generated
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(644) : while compiling class template member function 'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)'
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.cpp(38) : see reference to function template instantiation 'WTF::Vector<char,0x00,WTF::PartitionAllocator>::Vector(size_t)' being compiled
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\platform\testing\testingplatformsupport.h(56) : see reference to class template instantiation 'WTF::Vector<char,0x00,WTF::PartitionAllocator>' being compiled
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(654) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(313) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(306) : while compiling class template member function 'void WTF::VectorBufferBase<T,false,Allocator>::allocateBuffer(size_t)'
        with
        [
            T=char
,            Allocator=WTF::PartitionAllocator
        ]
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(386) : see reference to function template instantiation 'void WTF::VectorBufferBase<T,false,Allocator>::allocateBuffer(size_t)' being compiled
        with
        [
            T=char
,            Allocator=WTF::PartitionAllocator
        ]
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(373) : see reference to class template instantiation 'WTF::VectorBufferBase<T,false,Allocator>' being compiled
        with
        [
            T=char
,            Allocator=WTF::PartitionAllocator
        ]
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(618) : see reference to class template instantiation 'WTF::VectorBuffer<T,0x00,Allocator>' being compiled
        with
        [
            T=char
,            Allocator=WTF::PartitionAllocator
        ]
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(415) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(411) : while compiling class template member function 'bool WTF::VectorBuffer<T,0x00,Allocator>::shrinkBuffer(size_t)'
        with
        [
            T=blink::Address
,            Allocator=WTF::PartitionAllocator
        ]
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1093) : see reference to function template instantiation 'bool WTF::VectorBuffer<T,0x00,Allocator>::shrinkBuffer(size_t)' being compiled
        with
        [
            T=blink::Address
,            Allocator=WTF::PartitionAllocator
        ]
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(618) : see reference to class template instantiation 'WTF::VectorBuffer<T,0x00,Allocator>' being compiled
        with
        [
            T=blink::Address
,            Allocator=WTF::PartitionAllocator
        ]
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\platform\heap\threadstate.h(621) : see reference to class template instantiation 'WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>' being compiled
e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1024) : warning C4267: '=' : conversion from 'size_t' to 'unsigned int', possible loss of data
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1019) : while compiling class template member function 'void WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrink(size_t)'
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1086) : see reference to function template instantiation 'void WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrink(size_t)' being compiled
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(1081) : while compiling class template member function 'void WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrinkCapacity(size_t)'
        e:\b\build\slave\win_x64_gn\build\src\third_party\webkit\source\wtf\vector.h(745) : see reference to function template instantiation 'void WTF::Vector<blink::Address,0x00,WTF::PartitionAllocator>::shrinkCapacity(size_t)' being compiled
ninja: build stopped: subcommand failed.

Original issue's description:
> More regular Platform implementations in unit tests.
>
> R=haraken,jbroman
> BUG=
>
> Committed: https://crrev.com/81286531cd82370140d781f6daad585d44c1747c
> Cr-Commit-Position: refs/heads/master@{#361019}

TBR=jbroman@chromium.org,haraken@chromium.org,tkent@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/1464953003

Cr-Commit-Position: refs/heads/master@{#361024}

a22a72fa

Roll WebRTC 10724:10736, Libjingle 10725:10735 · 4799df0f

tommi authored Nov 21, 2015

WebRTC 10724:10736

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/dba3e45..3e38ef9

Libjingle 10725:10735

Changes: https://chromium.googlesource.com/external/webrtc/trunk/talk.git/+log/eddf34f..15bbf6c

TBR=
BUG=

Review URL: https://codereview.chromium.org/1466633005

Cr-Commit-Position: refs/heads/master@{#361023}

4799df0f

Validate pixel data array is enough for request by texImage3D and texSubImage3D · 965cef3e

qiankun.miao authored Nov 21, 2015

BUG=551750
TEST=conformance2/textures/misc/tex-3d-size-limit.html

Review URL: https://codereview.chromium.org/1414853008

Cr-Commit-Position: refs/heads/master@{#361022}

965cef3e

ash: enable packed_resources in ash_shell_lib_with_content deps list · 1c20f891

tfarina authored Nov 21, 2015

Now that we have this target, there is no reason to have it commented
out. This patch fixes the TODO(GYP) in there.

BUG=None
R=sky@chromium.org,brettw@chromium.org

Review URL: https://codereview.chromium.org/1465963002

Cr-Commit-Position: refs/heads/master@{#361021}

1c20f891

Update V8 to version 4.9.42. · 3966d2cc

v8-autoroll authored Nov 21, 2015

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/3c19105e..88d3129d

Please follow these instructions for assigning/CC'ing issues:
https://code.google.com/p/v8-wiki/wiki/TriagingIssues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org

Review URL: https://codereview.chromium.org/1464093002

Cr-Commit-Position: refs/heads/master@{#361020}

3966d2cc

More regular Platform implementations in unit tests. · 81286531

sigbjornf authored Nov 21, 2015

R=haraken,jbroman
BUG=

Review URL: https://codereview.chromium.org/1456873003

Cr-Commit-Position: refs/heads/master@{#361019}

81286531

ImageBitmap using StaticBitmapImage instead of SkImage · 20c2d44f

xidachen authored Nov 21, 2015

Current ImageBitmap holds a RefPtr<SkImage>, this CL changes it to hold
a RefPtr<StaticBitmapImage>.

Review URL: https://codereview.chromium.org/1457683006

Cr-Commit-Position: refs/heads/master@{#361018}

20c2d44f

sdefresne authored Nov 21, 2015

BUG=556566

Review URL: https://codereview.chromium.org/1457803002

Cr-Commit-Position: refs/heads/master@{#361017}

e471c20b

Revert of Switch V8HiddenValue from hidden values to privates (patchset #7... · dfb67af2

haraken authored Nov 21, 2015

Revert of Switch V8HiddenValue from hidden values to privates (patchset #7 id:120001 of https://codereview.chromium.org/1416053012/ )

Reason for revert:
This CL broke tests in oilpan builds.

https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Linux_Oilpan_ASAN/5177/layout-test-results/results.html

Original issue's description:
> Switch V8HiddenValue from hidden values to privates
>
> Privates are like ES6 symbols, but are not accesible by JavaScript.
> Hidden values on the other hand will be deleted form the API soon.
>
> BUG=none
> R=haraken@chromium.org
>
> Committed: https://crrev.com/b1802c0fc28635a50e7f55e40c71e69281cc85f3
> Cr-Commit-Position: refs/heads/master@{#360786}

TBR=vogelheim@chromium.org,sigbjornf@opera.com,jochen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/1466733006

Cr-Commit-Position: refs/heads/master@{#361016}

dfb67af2

DevTools: Add dark theme hidden experiment · a7d0f43f

paulirish authored Nov 21, 2015

BUG=559524

Review URL: https://codereview.chromium.org/1458223005

Cr-Commit-Position: refs/heads/master@{#361015}

a7d0f43f

Add pinning to Yahoo! subdomains. · a625aba6

lgarron authored Nov 21, 2015

BUG=
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/1464993002

Cr-Commit-Position: refs/heads/master@{#361014}

a625aba6

Automated Commit: Committing new LKGM version 7660.0.0 for chromeos. · 017ef389
chromeos-commit-bot authored Nov 21, 2015
```
Cr-Commit-Position: refs/heads/master@{#361013}
```
017ef389

components/metrics: Add runtime memory leak detector · d02b109c

sque authored Nov 21, 2015

This patch adds heuristic-based memory leak detector.
Unlike traditional leak detectors like valgrind,
it doesn't wait until a process terminates to check for
leftover allocations. Instead, it analyzes allocation
patterns over time.

This code is not thread-safe. It is up to the caller of this code to ensure thread safety.

BUG=382705
Signed-off-by: Simon Que <sque@chromium.org>

Review URL: https://codereview.chromium.org/986503002

Cr-Commit-Position: refs/heads/master@{#361012}

d02b109c

initializing ICU in url fuzzer. · b88ffb2d

aizatsky authored Nov 20, 2015

BUG=

Review URL: https://codereview.chromium.org/1467713004

Cr-Commit-Position: refs/heads/master@{#361011}

b88ffb2d

Revert of Roll clang 247874:253678 (patchset #1 id:1 of... · c21ad3cc

hans authored Nov 20, 2015

Revert of Roll clang 247874:253678 (patchset #1 id:1 of https://codereview.chromium.org/1461003007/ )

Reason for revert:
MSan was broken by the roll.

Original issue's description:
> Roll clang 247874:253678
>
> Also revert https://codereview.chromium.org/1375193005 for bootstrap builds,
> else compiler-rt won't build in that config.  See comment 45 on the bug.
>
> BUG=538614
> R=thakis@chromium.org
>
> Committed: https://chromium.googlesource.com/chromium/src/+/6a0a6e2c285cf215a15755ab9d32b386947a77b1

TBR=thakis@chromium.org,thestig@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=538614, 559530

Review URL: https://codereview.chromium.org/1460503011

Cr-Commit-Position: refs/heads/master@{#361010}

c21ad3cc

Add code to deal with serial device disconnection · 0c9eb038

juncai authored Nov 20, 2015

detection on Windows.

This patch added code to deal with serial device
disconnection detection problem on Windows. It gets the
COM port information from the device path and compare
the COM port information with the port information that
serial io handler holds. If they match, cancel read for
that port.

BUG=361606

Committed: https://crrev.com/195a0f202c1b89540d4a385d881cd483abe757fa
Cr-Commit-Position: refs/heads/master@{#360193}

Committed: https://crrev.com/8d09d9564ea10012d55ed634c0c2835efbd8d01f
Cr-Commit-Position: refs/heads/master@{#360347}

Review URL: https://codereview.chromium.org/1439443002

Cr-Commit-Position: refs/heads/master@{#361009}

0c9eb038

[DevTools] filter any messages from previous session in DevToolsAgentHostImpl · 1084bdca

kozyatinskiy authored Nov 20, 2015

Frontend can receive response for protocol message that was sent by previous session or notification that was produced during previous session. E.g. frontend send protocol message and then reattach and then get response.
session_id for protocol message is added in this CL. DevToolsAgentHostImpl store current session_id, RenderFrameDevToolsAgentHost and WorkerDevToolsAgentHost add to each protocol message session id and SendResponseMessageToClient method check it after processing.
WebDevToolsAgentImpl get session_id from Attach or Reattach IPC message, clear session_id on Dettach message and use it for notifications.

BUG=503875, 503824
TEST=run blink/tools/run_layout_tests.py inspector/sources/debugger-breakpoints/set-conditional-breakpoint.html --repeat-each 2
R=pfeldman@chromium.org, dgozman@chromium.org
TBR=jam@chromium.org, tsepez@chromium.org

Review URL: https://codereview.chromium.org/1437283003

Cr-Commit-Position: refs/heads/master@{#361008}

1084bdca

Re-implements start_with_url.* benchmarks as start_with_url2.* using TBM · 7033604f

gabadie authored Nov 20, 2015

start_with_url.* performance benchmark are currently using histograms.
This patch set re-implements start_with_url.* as start_with_url2.* using
TBM for comparisons of the metric results before letting
start_with_url2.* overwrite start_with_url.*. However the
foreground_tab_request_start metric requires 552472 to be fixed.

BUG=539287
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1435243002

Cr-Commit-Position: refs/heads/master@{#361007}

7033604f

publish canvas context API usage metrics · 06d32e3b

zmin authored Nov 20, 2015

Update Canvas.ContextType in histograms.xml to match the enum in C++ file.

demo link:
https://drive.google.com/corp/drive/u/0/folders/0BySFHAS13VhbaWJzbUh4dXRERjA

BUG=303068

Review URL: https://codereview.chromium.org/1463573002

Cr-Commit-Position: refs/heads/master@{#361006}

06d32e3b

Make ImageBitmap::cropImage a static function. · 750a8660

jbroman authored Nov 20, 2015

It doesn't access any members of ImageBitmap, nor is it called in any other
source file.

Review URL: https://codereview.chromium.org/1466773002

Cr-Commit-Position: refs/heads/master@{#361005}

750a8660

Remove .travis.yml files from third_party/polymer · 97bb4cc9

dbeam authored Nov 20, 2015

R=michaelpg@chromium.org
BUG=none
TEST=less cruft in codebase
NOTRY=true

Review URL: https://codereview.chromium.org/1460173003

Cr-Commit-Position: refs/heads/master@{#361004}

97bb4cc9

Updating trunk VERSION from 2570.0 to 2571.0 · 1577c778
chrome-tpm authored Nov 20, 2015
```
Cr-Commit-Position: refs/heads/master@{#361003}
```
1577c778

Remove last use of the toLocalFrameTemporary macro. · a01e0098

dcheng authored Nov 20, 2015

The frame tree supports remote frames now.

BUG=none

Review URL: https://codereview.chromium.org/1460353002

Cr-Commit-Position: refs/heads/master@{#361002}

a01e0098

DevTools: avoid layout thrashing on Layers panel · 3f7c4981

caseq authored Nov 20, 2015

- only adjust canvas size in Layers3DView upon resize and onShown;
- fix selection comparison in LayerViewHost to properly check member-wise equality;
- fix LayerTreeOutline's updateLayer() to properly check parent of root node;

BUG=

Review URL: https://codereview.chromium.org/1463143005

Cr-Commit-Position: refs/heads/master@{#361001}

3f7c4981

DevTools: optimize screencast for slower devices. · 92175843

pfeldman authored Nov 20, 2015

Review URL: https://codereview.chromium.org/1463813003

Cr-Commit-Position: refs/heads/master@{#361000}

92175843

Create security_interstitials::ControllerClient · 9ad979c0

felt authored Nov 20, 2015

This starts to split out UI-manipulating code from the
InterstitialPage-specific methods. The first in a series of
CLs.

BUG=488673
TBR=sky@chromium.org,davidben@chromium.org,isherman@chromium.org

Review URL: https://codereview.chromium.org/1462353002

Cr-Commit-Position: refs/heads/master@{#360999}

9ad979c0

DevTools: local storage view is cloned upon each selection. · 7c5eb7fb

pfeldman authored Nov 20, 2015

BUG=558724

Review URL: https://codereview.chromium.org/1466743004

Cr-Commit-Position: refs/heads/master@{#360998}

7c5eb7fb

Ensure that the auto scroll state in the AutoscrollController is cleared if the · a12dafbe

ananta authored Nov 20, 2015

scroll operation clears out the m_autoscrollLayoutObject member.

This typically happens when we scroll a div inside an iframe which uses
overflow:auto and during the scroll the cursor leaves the bounds of the div.
If we don't reset the state then the page gets stuck in the autoscroll state
causing it to be unresponsive to clicks etc.

BUG=336373

Review URL: https://codereview.chromium.org/1461473002

Cr-Commit-Position: refs/heads/master@{#360997}

a12dafbe

[Chromecast] Add setters to CastSysInfoDummy. · f4f2c9f9

derekjchow authored Nov 20, 2015

Enables changing values in CastSysInfoDummy for unit testing.

R=halliwell@chromium.org,slan@chromium.org

Review URL: https://codereview.chromium.org/1466003003

Cr-Commit-Position: refs/heads/master@{#360996}

f4f2c9f9

MD Settings: Lazy create fonts page · 0641afa5

michaelpg authored Nov 20, 2015

Save creation of ~1000 <paper-item>s (actual number probably depends on OS)
until the fonts page is opened.

This is just a quick-and-dirty solution which shaves off a few seconds
of load time, hopefully making tests less flaky.

BUG=531786

Review URL: https://codereview.chromium.org/1457383006

Cr-Commit-Position: refs/heads/master@{#360995}

0641afa5

move set charging to powermonitorcontroller · 699b68b3

alexandermont authored Nov 20, 2015

BUG=558106

Review URL: https://codereview.chromium.org/1456803002

Cr-Commit-Position: refs/heads/master@{#360994}

699b68b3

Add detection of new or removed files to reproduce.sh · a5278900

dbeam authored Nov 20, 2015

R=dschuyler@chromium.org
BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/1465623008

Cr-Commit-Position: refs/heads/master@{#360993}

a5278900

[Chromecast] Change UMA_HISTOGRAM_CUSTOM_COUNTS_NO_CACHE to use AddCount. · 5ae45b51

bcf authored Nov 20, 2015

This removes uncessary increment loops.

BUG=internal b/23563097

Review URL: https://codereview.chromium.org/1423973002

Cr-Commit-Position: refs/heads/master@{#360992}

5ae45b51