GitLab

The browser compositor in content/ currently expects to be able to do copy output requests of arbitrary layers. The surface aggregator should allow ever render pass to contain copy requests, and move them to the aggregated frame.

BUG=397730

Review URL: https://codereview.chromium.org/614073005

Cr-Commit-Position: refs/heads/master@{#299831}

BUG=None

Review URL: https://codereview.chromium.org/651853002

Cr-Commit-Position: refs/heads/master@{#299830}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/ae6d622..498bc5f

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/661593003

Cr-Commit-Position: refs/heads/master@{#299829}

Revert of Remove raw handles from base::win::RegKey (patchset #6 id:330001 of https://codereview.chromium.org/632833002/)

Reason for revert:
Causing base_unittests failures on XP Tests (1)

Original issue's description:
> Remove raw handles from base::win::RegKey
>
> BUG=419210, 423634
> R=cpu@chromium.org, eroman@chromium.org, sky@chromium.org
>
> Committed: https://crrev.com/1aa0fa75b65f403e08ae0f3f2fcb053c02cd9ef2
> Cr-Commit-Position: refs/heads/master@{#299737}

TBR=cpu@chromium.org,eroman@chromium.org,jam@chromium.org,rvargas@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=419210, 423634

Review URL: https://codereview.chromium.org/652903005

Cr-Commit-Position: refs/heads/master@{#299828}

s/getActionBar/getSupportActionBar in Desktop.java which uses
ActionBarActivity from the support library.

BUG=423875

Review URL: https://codereview.chromium.org/655243004

Cr-Commit-Position: refs/heads/master@{#299827}

BUG=423990
R=kalman@chromium.org

Review URL: https://codereview.chromium.org/661663002

Cr-Commit-Position: refs/heads/master@{#299826}

The ScaleImageSkiaRep function which attempts to scale the image to the desired scale should not do anything if the image is already scaled to the required scale.

The FindRepresentation function in ImageSkiaStorage has support for returning images scaled to the desired scale.

This fixes an annoying DCHECK firing on Windows boxes with display scales like 125%, 150%, etc.

BUG=NONE

Review URL: https://codereview.chromium.org/657203002

Cr-Commit-Position: refs/heads/master@{#299825}

If BrowserViewRenderer already has hardware acceleration
enabled, then fallback tick can produce a real instead of a
wasted 1x1 software frame. And to avoid the bug, we can force
this frame through the pipeline ignoring stalls.

BUG=424002

Review URL: https://codereview.chromium.org/659743002

Cr-Commit-Position: refs/heads/master@{#299824}

Fix indentation issue to allow enabling Checkstyle indentation rule.

BUG=318404

Review URL: https://codereview.chromium.org/654293002

Cr-Commit-Position: refs/heads/master@{#299823}

This might-maybe-hope-not crash, and so has debugging statements.

BUG=407376
TEST=no crashing, we hope

Review URL: https://codereview.chromium.org/657233002

Cr-Commit-Position: refs/heads/master@{#299822}

renamed existing PowerButtonController to ShutdownDialog

BUG=None
TEST=covered by unit tests

Review URL: https://codereview.chromium.org/654343002

Cr-Commit-Position: refs/heads/master@{#299821}

R=tonyg@chromium.org,dtu@chromium.org,nduca@chromium.org,nednguyen@google.com
BUG=423563

Review URL: https://codereview.chromium.org/661653003

Cr-Commit-Position: refs/heads/master@{#299820}

For MSE/EME, we never listen to the audio focus change.
That will cause the video to continue playing when another app plays sound.
Attach MediaPlayerListener to the MediaSourcePlayer should fix the issue.

BUG=421861

Review URL: https://codereview.chromium.org/643353002

Cr-Commit-Position: refs/heads/master@{#299819}

This pulls in the following Native Client changes:

r13908: (mseaborn) Scons: Stop scanning for multiple versions of ARM GCC
r13909: (mseaborn) ARM: Remove Scons support for using ARM soft-float toolchains
r13910: (bradnelson) Adding a prefix to distinct perf results so they are graphed separately.
r13913: (mazda) Make PNaCl translator use hard-float ABI for ARM nonsfi target.
r13914: (teravest) Add NaClDescCreateWithFilePathMetadata fallback.
r13915: (mseaborn) Clean up sysconf() test to address a TODO that depended on a toolchain roll

BUG=none
TEST=browser_tests and nacl_integration
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_rel_precise32,linux_nacl_sdk,linux_chromium_dbg

Review URL: https://codereview.chromium.org/644493004

Cr-Commit-Position: refs/heads/master@{#299818}

Currently, the data reduction proxy telemetry tests expect that the dev
proxy string will include the scheme of the URL, but it actually
doesn't. This CL changes the tests to not expect the scheme in the dev
proxy URL.

BUG=423916

Review URL: https://codereview.chromium.org/661613003

Cr-Commit-Position: refs/heads/master@{#299817}

BUG=chromedriver:916

Review URL: https://codereview.chromium.org/655373002

Cr-Commit-Position: refs/heads/master@{#299816}

The function RmTreeAndMkDir did two different things depending on a boolean flag that was passed to it.

This CL splits it into two functions so that each function only takes one argument and does one thing.

BUG=

Review URL: https://codereview.chromium.org/645383002

Cr-Commit-Position: refs/heads/master@{#299815}

R=estade@chromium.org
BUG=422851

Review URL: https://codereview.chromium.org/658523007

Cr-Commit-Position: refs/heads/master@{#299814}

BUG=411056

Review URL: https://codereview.chromium.org/638133003

Cr-Commit-Position: refs/heads/master@{#299813}

Fix an issue where the last-requested display power state
was bound to a delayed task on resume. If a new state was
requested while the task was waiting to run (e.g. due to
exiting docked mode), the task would later restore the old
state.

Instead, add a thunk for the task that always uses the
currently-requested state.

BUG=chrome-os-partner:32393

Review URL: https://codereview.chromium.org/652073002

Cr-Commit-Position: refs/heads/master@{#299812}

The test LastBookmarkResizeBehavior implicitly relied on the default system
font. The system font changed from 10.9 to 10.10, breaking the test. I updated
the test to use a different set of parameters on OSX 10.10+.

BUG=390276

Review URL: https://codereview.chromium.org/659693002

Cr-Commit-Position: refs/heads/master@{#299811}

I expected the mojo_native_viewport_service to use -- as a prefix for its
arguments:

mojo_shell --args-for="mojo://mojo_native_viewport_service/ --use-headless-config"

but prior to this CL, it was expect its arguments without the leading "--".
After this CL, it expects the leading "--".

R=davemoore@chromium.org,hansmuller@chromium.org

Review URL: https://codereview.chromium.org/661513002

Cr-Commit-Position: refs/heads/master@{#299810}

R=enne

Review URL: https://codereview.chromium.org/662473003

Cr-Commit-Position: refs/heads/master@{#299809}

NaCl does not support glibc on ARM so all glibc-related
tests should be disabled on ARM.

BUG=422592
TEST=linux_arm trybot

Review URL: https://codereview.chromium.org/652873002

Cr-Commit-Position: refs/heads/master@{#299808}

Two sets of changes:
. fix gn dependencies
. make views_init work in the static library

The latter means wm_flow_init and demo_launcher only work with gn (not gyp).

BUG=none
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/658753004

Cr-Commit-Position: refs/heads/master@{#299807}

These tests currently fail when run in --site-per-process mode.  They will be reenabled gradually as we do more work on site isolation.

BUG=417518

Review URL: https://codereview.chromium.org/621913002

Cr-Commit-Position: refs/heads/master@{#299806}

Mechanical change that adds instrumentation required to locate the source of jankiness (i.e. a long-running fragment of code executed as a part of the task that causes jank) in the code. See the bug for details on what kind of jank we are after.
A number of similar CLs were landed, and none of them caused issues. The code of the instrumentation is highly optimized and is not expected to affect performance. The code simply creates a diagnostic task which is identical to ones created by PostTask or IPC message handlers.
Landing as TBR since this is a mechanical, safe and temporary change.

This CL instruments callbacks of TranslateURLFetcher::OnURLFetchComplete:
1. TranslateLanguageList::OnLanguageListFetchComplete
2. TranslateScript::OnScriptFetchComplete

BUG=422577
TBR=andrewhayden@chromium.org

Review URL: https://codereview.chromium.org/656183002

Cr-Commit-Position: refs/heads/master@{#299805}

* Adding handling of connection events to the tracker
* Adding a method sanitizing tokens (removing expired ones)
* Adding relevant account tracker tests
* Making account mapper aware of gcm driver being started
* Making sure ShutdownHandler implementation is safe to
  call RemoveAppHandler (without causing a stack trace due
  to invalid iterator)
* Making sure that account mapper does not count toward
  registered app handlers when deciding to stop GCM Driver
* Updating FakeOAuth2TokenService to allow token request to
  be repeated.

Based of patch: https://codereview.chromium.org/617003005/

BUG=374969
TBR=rogerta@chromium.org

Review URL: https://codereview.chromium.org/618003002

Cr-Commit-Position: refs/heads/master@{#299804}

Change the method name from can_scroll_orientation() to
CanScrollOrienattion() to comply with the style guide.

This is a follow up to https://codereview.chromium.org/655783004

BUG=370892

Review URL: https://codereview.chromium.org/637283004

Cr-Commit-Position: refs/heads/master@{#299803}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8dfdfff..ae6d622

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=rmistry@google.com

Review URL: https://codereview.chromium.org/644003003

Cr-Commit-Position: refs/heads/master@{#299802}

BUG=none

Review URL: https://codereview.chromium.org/662493003

Cr-Commit-Position: refs/heads/master@{#299801}

Darin had previously argued that we did not need |url|, as that can be
gotten from response. But we do need a way for content handlers to know
the url of the app connecting to them.

Review URL: https://codereview.chromium.org/638293005

Cr-Commit-Position: refs/heads/master@{#299800}

These bots should run when required by our top-level detection of what
bots are needed. And the GPU bots are in the default sets of bots now.

Review URL: https://codereview.chromium.org/661613002

Cr-Commit-Position: refs/heads/master@{#299799}

It's a convention in unix for programs to first search for a program
specific editor variable. For example, SVN_EDITOR or GIT_EDITOR. This
makes GN follow this same convention.

BUG=none

Review URL: https://codereview.chromium.org/654333002

Cr-Commit-Position: refs/heads/master@{#299798}

BUG=423621

Review URL: https://codereview.chromium.org/657763002

Cr-Commit-Position: refs/heads/master@{#299797}

BUG=

Review URL: https://codereview.chromium.org/647053003

Cr-Commit-Position: refs/heads/master@{#299796}

For File URI, some earlier android versions (<JB MR2) cannot handle it correctly
Convert it to absolute path fixes the issue.
For JB MR2 and above devices, we use content URI, so not affected.

BUG=423338

Review URL: https://codereview.chromium.org/655303002

Cr-Commit-Position: refs/heads/master@{#299795}

Revert of Eliminate silently letting errors pass on pak loading. (patchset #18 id:340001 of https://codereview.chromium.org/537063002/)

Reason for revert:
Causing content_browsertests failures due to pak loading failure.

Original issue's description:
> Eliminate silently letting errors pass on pak loading.
>
> BUG=410411
> TEST=no visible change
>
> Committed: https://crrev.com/03c8c9d936594163d43222a3da0268b3dd9af656
> Cr-Commit-Position: refs/heads/master@{#299717}

TBR=bengr@chromium.org,caitkp@chromium.org,tfarina@chromium.org,tony@chromium.org,avi@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=410411

Review URL: https://codereview.chromium.org/661503003

Cr-Commit-Position: refs/heads/master@{#299794}

BUG=405865,417048,419373
NOTRY=true
TBR=glider@chromium.org

Review URL: https://codereview.chromium.org/661653005

Cr-Commit-Position: refs/heads/master@{#299793}

One external invariant of RWHVAndroid is that if it has a valid attached
ContentViewCore, its TouchSelectionController will be non-null. However,
there are no guarantees that these lifetimes hold for methods *internal*
to RWHVAndroid. One such violation came when the frame had a non-zero
lock count when the attached ContentViewCore was changed; releasing the
surface lock caused a frame metadata update, in turn accessing the
TouchSelectionController that had already been reset.

As a workaround, guard against this and possible future violations by
always checking the controller for validity before using it.

BUG=419619

Review URL: https://codereview.chromium.org/653883003

Cr-Commit-Position: refs/heads/master@{#299792}