GitLab

This is a temporary workaround until we can roll the support library with
their fixes for these issues.

BUG=455327

Review URL: https://codereview.chromium.org/912533003

Cr-Commit-Position: refs/heads/master@{#315434}

This is needed so that page_cycler's action_name_to_run's
field can later be changed from empty string to
'RunPageInteractions'.

BUG=418375

Review URL: https://codereview.chromium.org/912493003

Cr-Commit-Position: refs/heads/master@{#315433}

Also apply mojo 8fda9302f51f99dc25e6e0c95cfd0a04e1adc802 (https://codereview.chromium.org/902783004/).

Also apply mojo e62ed5fbf8bb4d7cfa87f499b1d1b50bdf8e0b3b (https://codereview.chromium.org/905253005/).

Also apply dcf5a5e1dbccb91f774d545b5f31d06042d8a8e3 (https://codereview.chromium.org/909903003/).

TBR=jamesr@chromium.org
NOPRESUBMIT=true
CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win8_chromium_gn_dbg,win8_chromium_gn_rel

Review URL: https://codereview.chromium.org/910883002

Cr-Commit-Position: refs/heads/master@{#315432}

R= binji@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/910983002

Cr-Commit-Position: refs/heads/master@{#315431}

WebContentsViewMac will get a call during WebContentsImpl's destructor,
indicating that the contents are being occluded. It is not very helpful
to forward this to the WebContentsImpl (because it's being destroyed
anyway), and is dangerous in that the WebContentsImpl or its
sub-structures may be in an inconsistent state and not expecting to be
called in to.

In particular, in the bug, we were destroying the FrameTree high in
the stack, and then trying to iterate over it lower in the stack.

BUG=429993

Review URL: https://codereview.chromium.org/910013003

Cr-Commit-Position: refs/heads/master@{#315430}

The following NaCl-related defines are now provided by
native_client/src/include/build_config.h instead of the build system:
  NACL_WINDOWS
  NACL_LINUX
  NACL_OSX
  NACL_ANDROID
  NACL_BUILD_ARCH
  NACL_BUILD_SUBARCH

This change removes these definitions from gyp(i) files, as they no longer need
to be provided by the build system.

BUG=440012

Review URL: https://codereview.chromium.org/912503003

Cr-Commit-Position: refs/heads/master@{#315429}

Frames' data could be located at an offset within a shared memory
buffer. This adds metadata into media::VideoFrame to support this use
case.

BUG=455409
TEST=none

Review URL: https://codereview.chromium.org/877353002

Cr-Commit-Position: refs/heads/master@{#315428}

Remove the JS key log summary, since it's of limited value without the "code" field. Also includes misc fixes for release.

* Change the title, since we're no longer just JS.
* Add a description for CWS.
* Update version number.

Review URL: https://codereview.chromium.org/910483002

Cr-Commit-Position: refs/heads/master@{#315427}

R=dmazzoni
BUG=434127

Review URL: https://codereview.chromium.org/744843002

Cr-Commit-Position: refs/heads/master@{#315426}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1b6b626..d5d27d9

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/893313005

Cr-Commit-Position: refs/heads/master@{#315425}

Revert of DataReductionProxyStatisticsPrefs should support WeakPtr (patchset #10 id:450001 of https://codereview.chromium.org/888713002/)

Reason for revert:
Suspected to cause compile failure:

http://build.chromium.org/p/chromium.mac/builders/iOS%20Device/builds/23577/steps/compile/logs/stdio

Original issue's description:
> DataReductionProxyStatisticsPrefs should support WeakPtr
>
> The DRPStatisticsPrefs object is referenced via a raw pointer in
> DRPNetworkDelegate and DRPSettings. It should instead be referenced
> via WeakPtr.
>
> BUG=453155,455559,444939
>
> Committed: https://crrev.com/149bd770d674e8125f81cd649a8deece3a851682
> Cr-Commit-Position: refs/heads/master@{#315419}

TBR=bengr@chromium.org,sgurun@chromium.org,mmenke@chromium.org,megjablon@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=453155,455559,444939

Review URL: https://codereview.chromium.org/896713003

Cr-Commit-Position: refs/heads/master@{#315424}

TBR=pkasting
BUG=454983

Review URL: https://codereview.chromium.org/886933010

Cr-Commit-Position: refs/heads/master@{#315423}

BUG=455920

Review URL: https://codereview.chromium.org/911643002

Cr-Commit-Position: refs/heads/master@{#315422}

Fix lint issues.

BUG=453873

Review URL: https://codereview.chromium.org/900793007

Cr-Commit-Position: refs/heads/master@{#315421}

R= binji@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/907103002

Cr-Commit-Position: refs/heads/master@{#315420}

The DRPStatisticsPrefs object is referenced via a raw pointer in
DRPNetworkDelegate and DRPSettings. It should instead be referenced
via WeakPtr.

BUG=453155,455559,444939

Review URL: https://codereview.chromium.org/888713002

Cr-Commit-Position: refs/heads/master@{#315419}

BUG=455470

Review URL: https://codereview.chromium.org/905033004

Cr-Commit-Position: refs/heads/master@{#315418}

This is needed so that page_cycler's action_name_to_run's
field can later be changed from empty string to
'RunPageInteractions'.

To reviewers: pages that have RunPageInteractions removed
will be using the default implementation which does
nothing. Those pages are only used by the page_cycler
benchmark.

BUG=418375

Review URL: https://codereview.chromium.org/876313010

Cr-Commit-Position: refs/heads/master@{#315417}

Windows bots had trouble with the expectations in the animation loops.
Because of floating point inaccuracies, the top controls offset could be
exactly the same during the last two frames of the animation, because
the shown ratio was just off the minimum and that delta disappeared when
multiplying by the height.  This switches to checking the ratio itself,
which should match the same value that the animation system uses to
check if the next frame is needed.

BUG=456617

Review URL: https://codereview.chromium.org/907143002

Cr-Commit-Position: refs/heads/master@{#315416}

BUG=420680
TEST=browser_test: FileManagerJsTest.*

TBR=cpu@chromium.org for .grd changes.

Review URL: https://codereview.chromium.org/901233003

Cr-Commit-Position: refs/heads/master@{#315415}

BUG=455273

Committed: https://crrev.com/fdef2865f067f30e99f1f11b33d8811d98bf1e54
Cr-Commit-Position: refs/heads/master@{#314875}

Review URL: https://codereview.chromium.org/904513002

Cr-Commit-Position: refs/heads/master@{#315414}

The project ID isn't needed, since it's actually ok to expose the API key. We should offer the option of putting it in the manifest though.

BUG=454887

Review URL: https://codereview.chromium.org/901213003

Cr-Commit-Position: refs/heads/master@{#315413}

When processing multiple copy requests, DirectRenderer must restore
state between requests. Due to a change from an index based for loop
to an iterator based loop, a check within the loop for the first
iteration had gotten out of date. This caused DirectRenderer to miss
a required state restore in some cases. This change restores the
intended behavior.

The software renderer had a bug where calling UseRenderPass multiple
times would result in a crash. The bug addressed in this CL made this a
more common occurrance. A fix to the software-renderer issue was
committed in CL (899183003). This change doesn't revert the software
renderer fix as it is still possible to hit the software renderer bug
even with this bug fixed. See the additional unit test for a case where
the software renderer fix is still necessary even with this patch.

R=danakj@chromium.org

Review URL: https://codereview.chromium.org/904033008

Cr-Commit-Position: refs/heads/master@{#315412}

BUG=417532

Review URL: https://codereview.chromium.org/874773002

Cr-Commit-Position: refs/heads/master@{#315411}

UI review wants us to use sentence case throughout on chrome://settings/syncSetup.

"Open Tabs" -> "Open tabs"

[ChromeOS only] "Themes & Wallpapers" -> "Themes & wallpapers"

BUG=447405

Review URL: https://codereview.chromium.org/869053005

Cr-Commit-Position: refs/heads/master@{#315410}

Chrome passes each IP address in its own Network object. These IPv4Interfaces and IPv6Interfaces are really counting the number of IP addresses, not interfaces. To make these UMA accurate, a new stats struct is returned from WebRTC's MergeNetworkList which should control the grouping policy of IP addresses into network.

BUG=413437

Review URL: https://codereview.chromium.org/905663002

Cr-Commit-Position: refs/heads/master@{#315409}

The following NaCl-related defines are now provided by
native_client/src/include/build_config.h instead of the build system:
  NACL_WINDOWS
  NACL_LINUX
  NACL_OSX
  NACL_ANDROID
  NACL_BUILD_ARCH
  NACL_BUILD_SUBARCH

This change removes these definitions from gn(i) files, as they no longer need
to be provided by the build system.

BUG=440012

Review URL: https://codereview.chromium.org/908003002

Cr-Commit-Position: refs/heads/master@{#315408}

This log statement is useless, since we already have
another log statement inside that loop, that will give us
enough information.

BUG=none

Review URL: https://codereview.chromium.org/908023002

Cr-Commit-Position: refs/heads/master@{#315407}

Die silently if the Play Store starts installing an app
promoted by the webpage and Chrome dies in the background
before returning.  In this case, the infobar will disappear
before the user gets back anyway.

BUG=453170

Review URL: https://codereview.chromium.org/913593002

Cr-Commit-Position: refs/heads/master@{#315406}

- Add a concept of a helper ContentViewCore to Tab.
- Properly attach these ContentViewCores to the Tabs rendering layer.
- Note that these aren't rendered by ContentViewRenderView yet.  We need a Chrome-level
rendering object for that.

BUG=

Review URL: https://codereview.chromium.org/900443003

Cr-Commit-Position: refs/heads/master@{#315405}

BUG=453545

Review URL: https://codereview.chromium.org/906503004

Cr-Commit-Position: refs/heads/master@{#315404}

Now the root node has one more child, "Parent suggestions" so adjust the
DCHECK accordingly.

BUG=443606

Review URL: https://codereview.chromium.org/907073003

Cr-Commit-Position: refs/heads/master@{#315403}

BUG=None
TEST=AutofillMetricsTest

Review URL: https://codereview.chromium.org/880353002

Cr-Commit-Position: refs/heads/master@{#315402}

The fix improves matching of nodes in BookmarkModelAssociator in
situations where there are multiple bookmarks or folders with the
same titles or URLs.
This will address one particular scenario leading to bookmark
duplication (see crbug.com/118105).

1) In BookmarkModelAssociator::BuildAssociations, when there are
multiple native model nodes with matching title / URL, a secondary
match on external ID is used to pick a preferred one; otherwise
the first matching node is returned.
The preferred match on external ID should be applicable in most
situations except when the native model has been rebuilt from scratch.
Picking a wrong folder during the association process results in
duplicating the entire subtree within the wrong folder. This issue
should be addressed now.
2) In BookmarkModelAssociator::ApplyDeletesFromSyncJournal the external
ID match is now the primary criteria for selecting a native model
node to be deleted. The previous implementation would pick an arbitrary
native model node based on just the title / URL match anywhere in the
node hierarchy. That would happen every time after deleting a bookmark
or folder and recreating it in another place.
Since external IDs might be reused, there is a secondary match on
title and URL to ensure that the right node gets deleted. To avoid
costly O(N*M) algorithm (where N is number of bookmarks and M is
number of entries in delete journal), the implementation uses a set
of external IDs to reduce the cost to O(N*logM).

BUG=456228

Review URL: https://codereview.chromium.org/904083002

Cr-Commit-Position: refs/heads/master@{#315401}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/31223e0..1b6b626

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=jvanverth@google.com

Review URL: https://codereview.chromium.org/908893004

Cr-Commit-Position: refs/heads/master@{#315400}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/465217f..21b204b

TBR=dpranke@chromium.org,caseq@chromium.org
INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng

Review URL: https://codereview.chromium.org/909983002

Cr-Commit-Position: refs/heads/master@{#315399}

BUG=456378

Review URL: https://codereview.chromium.org/908633002

Cr-Commit-Position: refs/heads/master@{#315398}

This is the last stage of the trace_event directory restructuring.
This is part of a set of 3 CLs which is moving tracing clients to use
the new base::trace_debug namespace.
See crrev.com/837303004 and the related bug for motivations.

BUG=451032
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/868603007

Cr-Commit-Position: refs/heads/master@{#315397}

This changelist:

Adding a basic UI for displaying host-offline-reason:
- When no host-offline-reason is provided, old behavior is preserved

- When a host-offline-reason is provided, the text used to present a host
  says:        "<hostname> (reported an error <time>)"
  rather than: "<hostname> (last online 11/11/2014)"

- When a known host-offline-reason is provided, a tooltip is added to the host
  giving localized description of the specific host-offline-reason.  Example
  tooltip: "Invalid host configuration."

- When an unknown host-offline-reason is provided (one without a localized
  description text), a generic tooltip is added saying:
  "Unrecognized error: INVALID_HOST_CONFIGURATION."

Context:

After crrev.com/719983002 Chromoting host sends an host-offline-reason string
before exiting.  The host-offline-reason value is currently always based on
ExitCodeToString function / HostExitCodes enum, but in principle
host-offline-reason is not necessarily tied to an exit code (i.e. in the future
the host should send "INVALID_POLICY" host-offline-reason but rather than
exiting should hang around monitoring policy for changes).  The
host-offline-reason sent by the host is stored in the Chromoting directory.
Since cr/79856832the directory sends host-offline-reason to the client as
hostOfflineReason field inside a Host object.

BUG=410050,247245

TEST=Manually tried the UI in the 3 cases: hor missing, known hor, unknown hor.

Review URL: https://codereview.chromium.org/882463003

Cr-Commit-Position: refs/heads/master@{#315396}

BUG=396634

Review URL: https://codereview.chromium.org/883403002

Cr-Commit-Position: refs/heads/master@{#315395}