- 12 Aug, 2020 40 commits
-
-
yiyix authored
Moved all video related tests and drawImage related tests. Bug: 1077148 Change-Id: I7eabfa7a2b2770919b7774fb8193a2f6d6d51ff6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268381Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#797140}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/48d951e22d45..d667ad2f0127 2020-08-11 cnorthrop@google.com Tests: Add Mobile Legends trace 2020-08-11 cnorthrop@google.com Capture/Replay: Allow starting capture at an unknown frame If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Test: Test: Capture application frames using triggerTest: Test: angle_perftests --gtest_filter=TracePerfTest.Run/*mobile* Change-Id: I0a60fd9366b1139eb16509439b903d4925c194cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351441Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#797139}
-
nancylingwang authored
Since we have the circle checking, we can call the CreateStandardIcon interface to convert all apps (including the essential apps/default apps) to the standard icons, and the CreateStandardIcon interface can check whether the icon is circle or not to apply shrink or not. So the default apps checking can be removed. BUG=1114771 Change-Id: I6c60fa8127c6f22e19824e21bffc8720100576f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351259 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797138}
-
Peter Kasting authored
Bug: none Change-Id: I8e0a3a1770185108d270569d9cedafd2853d1914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348193 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#797137}
-
Gayane Petrosyan authored
Change-Id: Iffe51fbe33c40264a1b09feb1bc93db5d43b12f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347087Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#797136}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596045560-16c58258c8890a214570e6099d355ac47072ea3d.profdata to chrome-win32-master-1596815835-17de714c85521ed0db12b66b0c37f9edb8bc5aba.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I6fb471fb588ac5c6d2f1cf01895cce5e65f91a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350494 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
Peter Kasting authored
Complies with https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++-dos-and-donts.md#initialize-members-in-the-declaration-where-possible Bug: none Change-Id: Ie5d21f9bf83bb1dae3ddd9e85b1a0e332687e6ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347200 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797134}
-
Ana Salazar authored
Tween type for the animations involved in apps grid cardified state enter and exit should be FAST_OUT_SLOW_IN per spec. Bug: 1115231 Change-Id: Ie80037f25cab3912b5b1436121276002615395ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350134Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Ana Salazar <anasalazar@chromium.org> Cr-Commit-Position: refs/heads/master@{#797133}
-
Yuwei Huang authored
The host TCP experiment has been rolled out to 100% and we are not seeing any regressions, so this CL makes TCP enabled on the host by default. It can still be disabled by adding a `Disable-TCP` host experiment. Bug: 600032 Change-Id: Ic5694049965e510a69c7c4c547d8d9567c05d997 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350390 Auto-Submit: Yuwei Huang <yuweih@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#797132}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/11c0f579b1d2..37f547456cc6 2020-08-12 enga@chromium.org Support depth-only/stencil-only copies on D3D12 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I95a8cef379309105b7cd6bee159c4f5ae6f542d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351083Reviewed-by:
-
Tibor Goldschwendt authored
The history entry appeared because we set the background image URL by setting src of the background image iframe. This CL changes this to contentWindow.location.replace, which does not add a history entry. Fixed: 1114089 Change-Id: I2038de67b7fab71fc732152357a43c3fd885f7d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347317 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#797130}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ia0d0094da38b3c03b53fd14034210edeb30ecf4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351445Reviewed-by:
-
Peter Kasting authored
These are common operations that aren't necessarily obvious when reading code, and it's easy to get them subtly wrong. Before: TimeDelta frame_time = TimeDelta::FromSeconds(1) / monitor_refresh_rate_; TimeDelta duration = TimeDelta::FromSeconds(frame_count) / monitor_refresh_rate_; double framerate = TimeDelta::FromSeconds(1) / vsync_frame_interval_; double bps = 8.0 / time_per_byte_.InSecondsF(); After: TimeDelta frame_time = TimeDelta::FromHz(monitor_refresh_rate_); TimeDelta duration = frame_count * TimeDelta::FromHz(monitor_refresh_rate_); double framerate = vsync_frame_interval_.ToHz(); double bps = time_per_byte_.ToHz() * 8; Bug: 1104532 Change-Id: I0919738d841177c77294e8983256a0cd93c5338b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337596 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:Yuri Wiitala <miu@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#797128}
-
Thanh Nguyen authored
Remove this flag as it is expired and not required now. Bug: 1110680 Change-Id: I1d68f279a0d75286d95cb523c7565e2b481626f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350721Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#797127}
-
Joel Hockey authored
Change-Id: Ia50b78d1e3bff37929c44688044b66251eef1edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342230 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Auto-Submit: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#797126}
-
Taylor Brandstetter authored
Bug: chromium:1113227 Change-Id: Ifc8e856fde4cf4eee25149f0a1e86a3cad71ea83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344747 Commit-Queue: Taylor <deadbeef@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#797125}
-
Hirokazu Honda authored
Bug: 811912 Test: HW encoder is used on https://appr.tc/?debug=loopback&vsc=vp9&vrc=vp9 Test: video.EncodeAccel.vp9* Test: webrtc.*.vp9* Change-Id: If0457bac7e06488b54b4fd77e7b7e8e766da3352 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2298883Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#797124}
-
Jaehyun Ko authored
Bug: 1010217 Change-Id: I579859a6926a13c2afc26d273d240056c50703f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344429Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Hyunjune Kim <hyunjune.kim@samsung.com> Cr-Commit-Position: refs/heads/master@{#797123}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: If713268ea2c10eddad7d76a37e7347c809c18e9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351622Reviewed-by:
-
Yuki Shiino authored
Introduces a fast path for conversion from v8::String to WTFString / AtomicString in order to mitigate perf regressions on Android. Bug: 839389 Change-Id: Icb0a9bf4ac756cba02d6d0e73abacfd943996606 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333906Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#797121}
-
Lei Zhang authored
In the current implementation, sometimes the scope of a page's "pause" is too wide compared to the definition in the spec [1], and sometimes it does not pause at all. So narrow the scope to better conform to the spec, and apply it consistently to all possible ways users can print. This is based on an earlier CL [2] which only did this for printing with the system dialog, but not for Print Preview. Some of the trickier cases handled, which require unpausing, are: - Navigations while previewing. - Printing selections, which require a navigation. [1] https://html.spec.whatwg.org/C/#printing-steps [2] https://crrev.com/c/1669250 Bug: 956832 Change-Id: I9bf274fcfb70eefe896fbbae9ce13a88b6f4dfc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338819Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#797120}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4ed6947787e7..ab6f9ef34a2b 2020-08-11 mtklein@google.com don't use out of range float values in the test 2020-08-11 mtklein@google.com allow all CPU surfaces 2020-08-11 bsalomon@google.com Check for OOM in GrVkMemory 2020-08-11 michaelludwig@google.com Don't over simplify near-colinear vertices 2020-08-11 jlavrova@google.com Revert "ICU: SkShaper (bidi iterator only)" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1086705,chromium:1113777 Tbr: fmalita@google.com Change-Id: I657954a4057e8e2982b0a1db29598e9027fe3bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350554Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1596045560-6c3207dc8f6ea5df1e0c422b4fa4d700088c0a24.profdata to chrome-win64-master-1596801568-da9053c5545285a0551be6620dd66e88ca5fbe04.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ice06ae41f601b795bd2183da56317bee88bf88b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350018Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1597168794-5b254c70fb11ba814efe16d5fff8c307263d75ab.profdata to chrome-mac-master-1597190183-f5edc71fe82787227048a24a0d9d0eec5f67340b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I60ad226c5fa2b616778a0d3f3895bc700f5a5504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351443Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f07b5182eeda..c4451adcce85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I03c0ef1b8c586fa4eb418b8e955a38d1d5bebed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350900Reviewed-by:
-
Yuki Yamada authored
The previous CL for HeapObserverList https://crrev.com/c/2060348 addressed two things: changing HeapObserverList to HeapObserverSet and allowing removal while iteration, and was reverted for performance reasons. This CL only does the former and avoids performance implications of the latter. This CL is for migration of NewLinkedHashSet. See: https://crrev.com/c/2134039 Bug: 1100257 Change-Id: I2426d14d77a68f200bf1398b16638e1605dd4ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319087 Commit-Queue: Yuki Yamada <yukiy@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#797115}
-
Alice Boxhall authored
AX-Relnotes: n/a Bug: 1114959 Change-Id: If21af718588dc0281cbd096285bd7577582e39d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346685 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#797114}
-
Michael Giuffrida authored
Bug: none Change-Id: I985c149e396912fd65bf0e7ce3ac6710ae8dadb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351140 Auto-Submit: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#797113}
-
Eugene But authored
Synthetic Crash Report feature suppose to upload configs to go/crash after Unexpected Termonation Event, but there are no reports yet. This metric will help to understand where to look for a bug. Bug: 1103752 Change-Id: I350add1794bad8e2f41fb92e2633548884da173d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346941 Commit-Queue: Steven Holte <holte@chromium.org> Auto-Submit: Eugene But <eugenebut@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#797112}
-
Toni Barzic authored
The method was not handling BOOKMARK_TITLE match type, even though it can be added to app list search results. BUG=1084862 Change-Id: I2d805f4553b12dede90226a8bb2150b2b26aff8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349969Reviewed-by:
-
Noel Gordon authored
CL:2344335 used .bind(this, fileBlob) to handle the metadata callback, or mime sniff callback, from the C++ for very good reasons. That's all discussed issue 415792, comment 12 in particular. Change the crbug ref comment in the code to point to that bug comment. Bug: 1114622 Change-Id: Ic70a1afdeb0f84df08c6763231993ca8015fd6d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350859Reviewed-by:
Naoki Fukino <fukino@chromium.org> Commit-Queue: Naoki Fukino <fukino@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#797110}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f07b5182eeda..c4451adcce85 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ife585a1ab1b32edead5c1e7b9c95f96ef09f9a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350021Reviewed-by:
-
nancylingwang authored
When the adaptive icon feature (DD:go/appservice-adaptive-icon) is enabled, call AppServiceProxy's LoadIcon interface to generate the standard icons for windows . Those windows icons are shown on the mini window to switch between windows when click alt+tab. For some Chrome apps, those window icons could be used to set the Shelf icon. Modify the browser tests LauncherPlatformAppBrowserTest.SetIcon to increaset the callback count, because AppServiceProxy's load icon could update the window's icon. Also add the checking for the icon image. Modify the browser tests WebAppIconManagerBrowserTest.SingleIcon to check for the standard icon image. Tests: 1. Manul tests 2. LauncherPlatformAppBrowserTest.SetIcon is used to test the change for chrome_native_app_window_view* 3. WebAppIconManagerBrowserTest.SingleIcon is used to test the change for web_app_browser_controller.* 4. HostedAppTest.LoadIcon is used to test the change for hosted_app_browser_controller.* BUG=1113576 Change-Id: Icf3e6ad2cbf3d0c01e0f8e2fc29e5742c1cb59ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344428 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
-
Peter Boström authored
Enabling the pixel tests for this bubble will help in a pending refactor. Bug: 1102894, 1106422 Change-Id: I4ca54c867daf0f5bb477aa84cee5af3d86024a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350842 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Sven Zheng <svenzheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#797107}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I2ed12d6c7d82f1ed82a6fb39185884c5fe93461d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350311Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#797106}
-
Peter Boström authored
Introduces a formal split between a dialog model and the bubble in which it's hosted. Refactors BookmarkBubbleView to use it. Several DCHECKs are in place and TODOs that need to be resolved while converting more dialogs to make this more flexible. Bug: 1106422 Change-Id: Ied4baeaf3237f22f770562dc3161030e8640354d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292700 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#797105}
-
Donn Denman authored
Extends the flags for two active contextual search experiements: Longpress and Translations. Change-Id: I25142bddfa815eec7a618faeab9f733645b0c3c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350899 Commit-Queue: Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#797104}
-
Ryan Sturm authored
Bug: 1114903 Change-Id: I14e3ae3cc1842686fd4b92e428729ef7f59cdbaf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350745Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#797103}
-
Naoki Fukino authored
The histograms are important to know how many users needs the feature and it affect how we support this feature in future ARC versions. Let me extend the expiracy for 1 year. Bug: 1109809 Test: none Change-Id: Id715954e2a8a5ce38dc592da21627bfa424bebdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344328 Auto-Submit: Naoki Fukino <fukino@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
Jiawei Li authored
Changes to use std:string as ScriptId type which has been changed to base::StringPiece on CastWebContents. Using base::StringPiece breaks the normal behavior of injecting JS bindings and the browsertest. Changing it back to std::string fixed the problem. Bug: internal b/163431947, b/132986916 Test: cast_shell_internal_browsertest, CQ Change-Id: I2a4cef5f208880816a4be3068e4e460dd9cf9fcf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350314Reviewed-by:
Sean Topping <seantopping@chromium.org> Auto-Submit: Jiawei Li <lijiawei@chromium.org> Commit-Queue: Jiawei Li <lijiawei@chromium.org> Cr-Commit-Position: refs/heads/master@{#797101}
-
