GitLab

I'm changing the aura implementation to use
Env::AddPreTargetListener. This way I don't need MessageLoop specific
code and it'll work correctly for win on both metro and non-metro.

BUG=315155
TEST=none
R=ben@chromium.org

Review URL: https://codereview.chromium.org/60443003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233270 0039d316-1c4b-4281-b951-d872f2087c98

In case of undocked DevTools, we rely on NOTIFICATION_TAB_CLOSING to
figure out the moment to destroy DevTools window. However,
fast_unload_controller detaches WebContents from browser after
receivign beforeunload ack, so we'll never destroy associated
DevTools window.

This patch triggers DevTools window destruction in result of
WebContentsDestroyed callback on front_end WebContents.

BUG=315502
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/61553004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233269 0039d316-1c4b-4281-b951-d872f2087c98

Delay 'focus' event handler to ensure that 'input' event
is processed first.

BUG=263743
R=arv@chromium.org, tkent@chromium.org

Review URL: https://codereview.chromium.org/39843002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233268 0039d316-1c4b-4281-b951-d872f2087c98

Changes all relevant occurrences of Profile by BrowserContext.

BUG=271392
(dubroy@ for policy_ui, tedchoc@ for signin_manager_android.cc, joi@ for DEPS)

R=erg@chromium.org, joaodasilva@chromium.org
TBR=dubroy@chromium.org, joi@chromium.org, tedchoc@chromium.org

Review URL: https://codereview.chromium.org/44083005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233267 0039d316-1c4b-4281-b951-d872f2087c98

The original CL was landed in https://codereview.chromium.org/26541005/
but the CL caused a dead lock. This CL fixed the issue.

NOTRY=true

Review URL: https://codereview.chromium.org/28593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233266 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240165
NOTRY=true

Review URL: https://codereview.chromium.org/59043010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233264 0039d316-1c4b-4281-b951-d872f2087c98

IsLoginProfile is based on ProfileHelper::IsSigninProfile.
There is no obvious/good reason why IsLoginProfile is additionally required. Even worse, IsLoginProfile is implemented by every subclass of Profile and is inconsistent to ProfileHelper::IsSigninProfile and to Profile::GetPath().

BUG=312660
(For Fake-/TestingProfile)

R=davemoore@google.com, nkostylev@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/47923016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233263 0039d316-1c4b-4281-b951-d872f2087c98

None of the testing server implementations are currently capable of minting
robot OAuth tokens and testing of device enrollment was only possible against
actual DMServer. With this flag it will be possible to successfully complete
enrollment while still testing the whole enrollment handshake and only skipping
the step where the robot token is fetched from GAIA.

BUG=313811
TEST=Enrollment against YAPS should succeed.
R=joaodasilva@chromium.org

Review URL: https://codereview.chromium.org/60113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233262 0039d316-1c4b-4281-b951-d872f2087c98

BUG=315054
TEST=manual tests on Lumpy

Review URL: https://codereview.chromium.org/59913004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233261 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233260 0039d316-1c4b-4281-b951-d872f2087c98

R=rmistry@google.com

Review URL: https://codereview.chromium.org/60663004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233259 0039d316-1c4b-4281-b951-d872f2087c98

When there are multiple associated devices, there is no good way to determine which is the active device we should use. We use the device iff the associated device is the default output device, otherwise we should return an empty string to indicate we can't determine the correct associated device, then the users will use the default output device instead.

BUG=315093
TEST=http://webrtc.googlecode.com/svn/trunk/samples/js/demos/html/local-audio-rendering.html verify the audio works with the built-in device in a mac station machine.
R=tommi@chromium.org

Review URL: https://codereview.chromium.org/59043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233256 0039d316-1c4b-4281-b951-d872f2087c98

Screenshots: http://imgur.com/a/3w2eO

Behavior I'd like to add in a separate CL:
- make the bubble show upward if not enough bottom space

BUG=258553
R=estade@chromium.org,thestig@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/55243005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233255 0039d316-1c4b-4281-b951-d872f2087c98

This introduces proxy implementation for QuotaManager::GetUsageAndQuota in
QuotaManagerProxy.

The proxy will be used from QuotaBackend living on the File thread so that
the backend can make sure of available quota space before reserving quota.


BUG=303443
TEST=n/a
NOTRY=true

Review URL: https://codereview.chromium.org/59753008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233254 0039d316-1c4b-4281-b951-d872f2087c98

Re-land of r232877 which was missing an include.

Fixes memory leaks.

BUG=313695
R=benwells@chromium.org, satorux@chromium.org
TBR=benwells@chromium.org, satorux@chromium.org

Review URL: https://codereview.chromium.org/59663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233253 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
R=jam
NOTRY=true

Review URL: https://codereview.chromium.org/54493006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233252 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233251 0039d316-1c4b-4281-b951-d872f2087c98

r1231 - Add support for configuring the minimum log level at compile time

TBR=mark@chromium.org
BUG=none

Review URL: https://codereview.chromium.org/59113010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233250 0039d316-1c4b-4281-b951-d872f2087c98

 * Implements RemoteToLocalSyncer by the main point
 * Add necessary functions of MetadataDatabase as skeletons

BUG=240165
NOTRY=true

Review URL: https://codereview.chromium.org/59193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233249 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/51143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233248 0039d316-1c4b-4281-b951-d872f2087c98

I found this class quite difficult to understand, mostly due to bad
method and variable names. Renamed:
  CheckTaskbarOrViewHasFocus -> MaybeDismissAppList,
  RegainNextLostFocus -> ReactivateOnNextFocusLoss,
  regain_next_lost_focus_ -> reactivate_on_next_focus_loss_,
  preserving_focus_for_taskbar_menu_ -> taskbar_has_focus_,
and rewrote many of the comments for clarity.

Factored out most of the logic in MaybeDismissAppList to
ShouldDismissAppList, which returns a bool and has minimal side effects.

This also introduces a minor behavioural fix: If the focused window is
NULL, and reactivate_on_next_focus_loss is true, reactivates instead of
dismissing.

BUG=307837

Review URL: https://codereview.chromium.org/59063009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233244 0039d316-1c4b-4281-b951-d872f2087c98

Align the interface of TestHarness defined in gpu_tests/webgl_conformance.py with that in third_party/webgl_conformance.

BUG=314997
NOTRY=true

Review URL: https://codereview.chromium.org/58833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233243 0039d316-1c4b-4281-b951-d872f2087c98

Otherwise, minidump_stackwalk produces far more debug output than
actual output.

BUG=none
R=mark@chromium.org

Review URL: https://codereview.chromium.org/59163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233242 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233241 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/59433002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233240 0039d316-1c4b-4281-b951-d872f2087c98

When a container's value's dtor might call another method of the container's,
one must ensure that the dtor is _not_ run in-line as the result of any of the
container's operations.  Specifically here the evil chain is:
GpuVideoEncodeAcceleratorHost::OnNotifyInputDone() -> frame_map_.erase()
VideoFrame::~VideoFrame()
RTCVideoEncoder::Impl::EncodeFrameFinished()
RTCVideoEncoder::Impl::EncodeOneFrame()
GpuVideoEncodeAcceleratorHost::Encode()
GpuVideoEncodeAcceleratorHost::frame_map_.insert()
aaaaaand, boom!

The code at HEAD is invalid for any platform (b/c nothing specs reentrancy for
hash_map) but only bit me on Android (where we use stlport unlike other
platforms).

NOTRY=true

Review URL: https://codereview.chromium.org/59863005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233238 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/26411002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233237 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/59363002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233236 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
R=abarth@chromium.org

Review URL: https://codereview.chromium.org/59513005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233235 0039d316-1c4b-4281-b951-d872f2087c98

Revise the class comment along the way.

BUG=284984
TEST=none
R=yoshiki@chromium.org

Review URL: https://codereview.chromium.org/61463003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233234 0039d316-1c4b-4281-b951-d872f2087c98

Also fix some changes for coding style errors reported by cpplint.py

BUG=314517

Review URL: https://codereview.chromium.org/57373004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233233 0039d316-1c4b-4281-b951-d872f2087c98

BUG=240165
NOTRY=true

Review URL: https://codereview.chromium.org/61203003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233232 0039d316-1c4b-4281-b951-d872f2087c98

BUG=307871
R=koz@chromium.org

Review URL: https://codereview.chromium.org/60103004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233229 0039d316-1c4b-4281-b951-d872f2087c98

Notable changes in this CL:
 * Rename files that depend on pango to have _pango suffix.
 * Add a filename gyp rule to exclude _pango* files when use_pango = 0
 * Add empty implementations for a few font-related API for ozone.

BUG=313793
R=jam@chromium.org, msw@chromium.org, rjkroege@chromium.org

Review URL: https://codereview.chromium.org/26541007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233228 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a basic implementation of NativeViewport for Mac OS X. It puts a
window on screen and initializes GL for that window using an in-process
command buffer.

R=ben@chromium.org, ccameron@chromium.org, kbr@chromium.org

Review URL: https://codereview.chromium.org/56833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233227 0039d316-1c4b-4281-b951-d872f2087c98

AppsGridView is used for folder view and it has a NULL item_list_ initially.
This causes a crash when attempting to create pulsing blocks for sync
animation.

BUG=314855
R=jennyz@chromium.org

Review URL: https://codereview.chromium.org/59623005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233226 0039d316-1c4b-4281-b951-d872f2087c98

Fixing problem with user image in settings page when page gets called as visiting window on a multi profile desktop

In Multi profile scenarios, a window can visit another users desktop and as such using the current user is incorrect. Instead the user from the current browser's profile should be taken to determine the user image.

BUG=315078
TEST=visual

Review URL: https://codereview.chromium.org/60443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233225 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=unit_tests
R=kinaba@chromium.org

Review URL: https://codereview.chromium.org/59443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233224 0039d316-1c4b-4281-b951-d872f2087c98

Hopefully, this might fix a few bugs that we see in Linux/GTK.

BUG=309969,311759

Review URL: https://codereview.chromium.org/58793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233223 0039d316-1c4b-4281-b951-d872f2087c98

BUG=314526

Review URL: https://codereview.chromium.org/57603002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@233222 0039d316-1c4b-4281-b951-d872f2087c98