- 12 Dec, 2017 40 commits
-
-
Yutaka Hirano authored
We have two experiments, and currently enabling both would confuse ResourceLoadScheduler. This CL fixes that. Bug: 785770 Change-Id: Iedcd31b85b83dae8397c992e3c769addd9dba956 Reviewed-on: https://chromium-review.googlesource.com/816775 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#523390}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/c7abc08034a3..629a64498dde $ git log c7abc0803..629a64498 --date=short --no-merges --format='%ad %ae %s' 2017-12-11 oetuaho Fix HLSL integer pow workaround Created with: roll-dep src/third_party/angle BUG=793115 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I838b7ab46d5c9f4573da56c3232511bb6ea72d23 Reviewed-on: https://chromium-review.googlesource.com/822052Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523389}
-
Mounir Lamouri authored
Setting the internal muted state based on the muted content attribute when the attributes have been parsed instead of waiting for the children to be parsed. This allows edge cases such as checking for `muted` in a <script> inside the element to return the correct value. This is fixing all the HTML tests for the muted attribute that Blink used to fail. Bug: 350303 Change-Id: I51c00abdf40b36d2222ddca2be69d61a0286f657 Reviewed-on: https://chromium-review.googlesource.com/819555 Commit-Queue: Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Cr-Commit-Position: refs/heads/master@{#523388}
-
Yoichi Osato authored
Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Iafc4c16aac974aa50bbd79960179ba17a3dff7cb Reviewed-on: https://chromium-review.googlesource.com/821337Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#523387}
-
Koji Ishii authored
This patch implements all the rest of logic to compute visual overflow for NGPhysicalTextFragment. In doing so, this patch also refactors text-emphasis logic to share with the pre-NG code. Bug: 636993, 714962 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ib800a9b4264dfe724d59fdb220e7c0d43513685a Reviewed-on: https://chromium-review.googlesource.com/776638Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#523386}
-
Sriram authored
Upstream the below tests from media/track/ to wpt 1. track-webvtt-tc016-align-positioning.html 2. track-webvtt-tc017-line-position.html 3. track-webvtt-tc018-align-text-line-position.html 4. track-webvtt-tc019-cue-size.html 5. track-webvtt-tc020-cue-size-align.html Bug: 782555 Change-Id: I09431fad43b9dc574f14d7ca8387aa38587c5825 Reviewed-on: https://chromium-review.googlesource.com/821990Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#523385}
-
Yuki Awano authored
- Do not reroute events if it is targetted to the tray or its descendants, or if target of the event has window of the tray as a transient ancestor. - When network info bubble is shown, the bubble is active but the tray itself is not active. The bubble is shown as another widget. The bubble should receive key events in this case. If the handler reroutes key events in this case, the tray is closed when esc key is pressed while the bubble is shown. information icon. Press esc key to close the info bubble. Confirm that it only closes the info bubble. Bug: 758530 Test: Open network section of system tray by click. Click the Change-Id: I0df0c81e4df28785f16fdefb9af37a73f00ef604 Reviewed-on: https://chromium-review.googlesource.com/776255Reviewed-by:Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#523384}
-
Mike West authored
Implements the changes to fragment processing described in https://github.com/whatwg/url/pull/347, which adds a new "fragment percent-encode set" which contains the C0 control percent-encode set, along with: * 0x20 SPACE * 0x22 (") * 0x3C (<) * 0x3E (>) * 0x60 (`) This brings our implementation into line with Firefox. Bug: 758523 Change-Id: I25de642017ccb69473626a327ad194b3431a11ed Reviewed-on: https://chromium-review.googlesource.com/719004 Commit-Queue: Mike West <mkwst@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#523383}
-
jdoerrie authored
This change makes base::ObserverList::Iter a standard compliant ForwardIterator by adding a post increment operation and adding expected typedefs. This is needed so that ObserverList::Iters can be used in standard library algorithms that expect these typedefs to exist. Bug: NONE Change-Id: Ida5cf58921cf4094c78ac5beb9a6b05fc0c6937f Reviewed-on: https://chromium-review.googlesource.com/819990Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#523382}
-
Hajime Hoshi authored
Bug: 765623 Change-Id: I7018d8d9e1c467ae4b71ce2079a6b144e1111db7 Reviewed-on: https://chromium-review.googlesource.com/672303 Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#523381}
-
Gauthier Ambard authored
This CL changes the appearance of the Clean Toolbar so it looks like the current toolbar. It includes adding rounded corners, thinning the border, changing the shadow below the location bar so it has a gradient. Current Toolbar: https://drive.google.com/file/d/1uGY2kAQhTPdCItTgUP93obKXA-ifMKdE/view CleanToolbar before: https://drive.google.com/file/d/1k_kszRT9iXyLv6db-zvUjS2Kvl-dWjd9/view CleanToolbar after: https://drive.google.com/file/d/1s3eMnF0SypEuxwVei37fB2LlZpumjBBl/view Bug: 793836 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I59b5bf33974c61561b40033f088659bda4ed9745 Reviewed-on: https://chromium-review.googlesource.com/819692 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#523380}
-
Yutaka Hirano authored
Bug: 785770 Change-Id: I12060b75d6a8bb84672b939b707ff4459579c171 Reviewed-on: https://chromium-review.googlesource.com/821334 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
-
Jens Widell authored
Multiple source files in components/sync/ define and use a macro named ENUM_CASE. Some already undefine it afterwards, but some don't and that causes issues in jumbo/unity builds where all the source files are compiled in a single translation unit. Change-Id: I0ce5d1d0e2008f52c68c8dd174d537b7ef1a42f1 Reviewed-on: https://chromium-review.googlesource.com/817280Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Commit-Queue: Jens Widell <jl@opera.com> Cr-Commit-Position: refs/heads/master@{#523378}
-
Elad Alon authored
WebRtcEventLogManager needs to be aware of all peer connections, so that it may start/stop WebRTC event logging on a per peer connection basis. This is needed because we only want WebRTC sending RTC event logs back to Chrome, when Chrome intends to log them. For that reason, we move the logic from WebRTCEventLogHost into WebRtcEventLogManager, which will know when these event logs are needed (either for local or for remote logging). Bug: 775415, 787809, 787938, 791022 Change-Id: I4fda5269765d510c69ce6061a0a5bce3125ffc5f Reviewed-on: https://chromium-review.googlesource.com/811647Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Elad Alon <eladalon@chromium.org> Cr-Commit-Position: refs/heads/master@{#523377}
-
Eddy Mead authored
Bug: 752745 Change-Id: Ia2e629af08666c101a5083980ab2345bc355ee6b Reviewed-on: https://chromium-review.googlesource.com/821971Reviewed-by:
Renée Wright <rjwright@chromium.org> Commit-Queue: meade_UTC10 <meade@chromium.org> Cr-Commit-Position: refs/heads/master@{#523376}
-
Eric Willigers authored
args.Peek() - 1 is only valid if we are not at the end (or beginning) of the token stream. BUG=792464 Change-Id: I1a475ce873723877d6bbb9d7b24c3773dd1090ee Reviewed-on: https://chromium-review.googlesource.com/821793Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#523375}
-
Darren Shen authored
Currently, when we encounted a custom property as we iterate over a StylePropertyMap, we get back a CSSUnsupportedValue, but we should be returning a CSSUnparsedValue. Spec: https://drafts.css-houdini.org/css-typed-om-1/#unparsedvalue-objects Bug: 779477 Change-Id: Iad5cf293e7e5721635f203e0a54d41759da508fc Reviewed-on: https://chromium-review.googlesource.com/821890 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#523374}
-
arthursonzogni authored
Use the NavigationURLLoaderNetworkService when NavigationMojoResponse is enabled, even if the network service isn’t. The feature NavigationMojoResponse is currently disabled by default, so this patch shouldn't introduce any new regression. See the others CLs in this series: [1/3] https://chromium-review.googlesource.com/c/739502 [2/3] this CL. [3/3] https://chromium-review.googlesource.com/c/753738 This is part 2 of the implementation plan. Design doc: https://goo.gl/Rrrc7n Bug: 705744 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo;master.tryserver.chromium.linux:linux_site_isolation Change-Id: Ia95527dce4be7b43747fec09ffe61bc51b2195a6 Reviewed-on: https://chromium-review.googlesource.com/741237 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#523373}
-
Miguel Casas authored
This CL adds a SEQUENCE_CHECKER to Vaapi*Accelerator classes, and posts the destruction of those objects to the appropriate thread on Cleanup(). Also makes {H264,VP8,VP9}Picture RefCountedThreadSafe, see miu@ comment in https://chromium-review.googlesource.com/c/chromium/src/+/794091#message-a64bed985cfaf8a19499a517bb110a7ce581dc0f TEST=play back VP9/VP8/H264 w/ simplechrome on soraka, Release build unstripped, let video play for a few seconds then navigate back; no crashes. Unittests as before: video_decode_accelerator_unittest --test_video_data=test-25fps.vp9:320:240:250:250:35:150:12 video_decode_accelerator_unittest --test_video_data=test-25fps.vp8:320:240:250:250:35:150:11 video_decode_accelerator_unittest --test_video_data=test-25fps.h264:320:240:250:258:35:150:1 Bug: 789160 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I7d96aaf89c92bf46f00c8b8b36798e057a842ed2 Reviewed-on: https://chromium-review.googlesource.com/794091Reviewed-by:Pawel Osciak <posciak@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#523372}
-
Hidehiko Abe authored
Now, all tests are migrated to non-gmock test cases. Clean up unnecessary code. BUG=234463 TEST=Ran bots. Change-Id: I71861d8b70544764c6b149574730f1abda007250 Reviewed-on: https://chromium-review.googlesource.com/819190Reviewed-by:
-
Stuart Langley authored
This changes is for files in the path //t_p/WebKit/Source/modules/accessibility. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. Also take the chance to change ctor/dtor to use '= default' where possible. This CL introduces no logic changes. Bug: 565932 Change-Id: I5b03045c5e880d7a97aa9006e055ea4a065301c3 Reviewed-on: https://chromium-review.googlesource.com/822011Reviewed-by:
-
Daniel Bratell authored
There are two types named FrameMap, one in render_frame_impl.cc and one in render_frame_proxy.cc. As long as the type isn't exported that works, but in jumbo builds the cc files are compiled in the same translation unit which causes collisions. Bug: 746953 Change-Id: I582d7f032caba1a201ac72c8181eb4c2432cc5bf Reviewed-on: https://chromium-review.googlesource.com/819636Reviewed-by:
-
DongJun Kim authored
This patch changes function names for readability in AXObject as below. - Supports*** / CanSupportARIA*** -> SupportsARIA*** Bug: none Change-Id: I77e9f717ce5ba1bfcb53c6152f57ce99fdda943a Reviewed-on: https://chromium-review.googlesource.com/821792Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#523368}
-
Owen Lin authored
We need larger output buffers when using high bitrates. Bug: b/69381380 Test: Pass the CTS "android.media.cts.VideoEncoderTest" Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I775da1f332de3448cb383fed618a140cf950913d Reviewed-on: https://chromium-review.googlesource.com/816375 Commit-Queue: Owen Lin <owenlin@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#523367}
-
Chromium WPT Sync authored
Using wpt-import in Chromium e57da29c. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/7486 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=raphael.kubo.da.costa@intel.com No-Export: true Change-Id: Icd9b2cb4ef260dc0a016c450572fc37d0ffc106e Reviewed-on: https://chromium-review.googlesource.com/821432 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523366}
-
Dominic Mazzoni authored
In Windows accessibility code we had a special case that suppressed accessibility events after a page is being navigated away from, to prevent overlapping events from the old page and new page. This caused a major problem if you cancel the beforeunload dialog, because BrowserAccessibilityManager still thought the page was being reloaded. The key fix is for WebContentsImpl to notify BrowserAccessibilityManager on DidStopLoading, since that's called when canceling a reload. In other cases when it's called, it will be harmless as BrowserAccessibilityManager will already be in the right state. The rest of the changes are some refactoring to make it possible to simulate canceling the beforeunload dialog in a test. Bug: 787126 Change-Id: I6356d827223aac559778fa96d9a7198916fe10f9 Reviewed-on: https://chromium-review.googlesource.com/809491 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#523365}
-
Pavel Feldman authored
In case subresource request's site needs to have its document protected, don't send raw headers and cookies into the frame's renderer. Bug: 793692 Change-Id: I9f41adfe35717eec284130f89ac92ecc78089969 Reviewed-on: https://chromium-review.googlesource.com/821410Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523364}
-
Dominic Mazzoni authored
To post an accessibility event on a NativeViewAccessibilityWin, we call NotifyWinEvent on the owning HWND, and pass it the negation of its unique ID as the child ID argument. The assistive technology then fetches the IAccessible by calling get_accChild on the HWND's IAccessible and passing it that child ID. In AXPlatformNodeWin::get_accChild, we do a sanity check that the child found is a descendant of the HWND, so we don't return a View from a different window by mistake. We do this by walking up from the descendant using GetParent() to make sure we reach the root. This is failing for bubbles on Windows 7 because they're implemented as transient windows (windows with a parent window set, but with child=false), and NativeViewAccessibilityWin::GetParent wasn't correctly walking up from a child widget to its transient parent. Fix this by taking transient windows into account, and update an existing unit test that wasn't fully testing this case correctly, to make it correct and have it test both cases (child = false and child = true). Bug: 785628 Change-Id: I17ea2f5b24c75a9aae7e93a669ac84db8e8feb90 Reviewed-on: https://chromium-review.googlesource.com/818390 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#523363}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/5e99d62f4d92..909fa2daa49e $ git log 5e99d62f4..909fa2daa --date=short --no-merges --format='%ad %ae %s' 2017-12-12 dsinclair [js] Convert to using size instead of sentinels Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I04ec4c8e3d28c20cb32a9c81c51bc2946e1b7220 Reviewed-on: https://chromium-review.googlesource.com/821598 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523362}
-
Xianzhu Wang authored
This reduces one level of indirection at callsites, and encapsulate rare details in FragmentData. Fix a bug in the original RarePaintData::ContentsProperties(): it returned Transform instead of Perspective as the transform node when both existed. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I7cc0702fe5cd43758ee1ff0622523dcd6e75e249 Reviewed-on: https://chromium-review.googlesource.com/816114 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#523361}
-
Gregory Chatzinoff authored
Make the name for the field trial created by ScopedFeatureList unique so that different ScopedFeatureLists do not collide when the field trial is stored globally. Bug: none Change-Id: Ibe0ebc6747868fd468e0c9455f21e990635aa1c4 Reviewed-on: https://chromium-review.googlesource.com/813102Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#523360}
-
Yutaka Hirano authored
This change removes the feature as we've launched it. Bug: 788241,603396 Change-Id: If651428dd301b4393570a05e7a20499e95f7ed7b Reviewed-on: https://chromium-review.googlesource.com/818597 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Raymes Khoury authored
This reverts commit 0d7cc8b3. Reason for revert: Should be fixed by https://chromium-review.googlesource.com/c/chromium/src/+/735686 Original change's description: > Add a temporary hack to fix a race condition with FP layout tests > > A race condition means that navigation may not reach the browser process > before a permission request does. This adds a hack to ensure that > navigation has reached the browser by waiting for a cross-origin iframe > to load. > > BUG=689802,769189 > > Change-Id: I26dba360e322cf31c0ec200985a6908de9a82c35 > Reviewed-on: https://chromium-review.googlesource.com/688382 > Reviewed-by: Ian Clelland <iclelland@chromium.org> > Commit-Queue: Raymes Khoury <raymes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#506221} TBR=raymes@chromium.org,qyearsley@chromium.org,iclelland@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 689802, 769189 Change-Id: I36cd26c2d2683e020237e038f658fb30fe55354d Reviewed-on: https://chromium-review.googlesource.com/821952Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#523358}
-
k2.nagaraju authored
updated parsing logic updated test cases and expected results Bug: 755487 Change-Id: Ia5d55a117f5f5fa7217e7671337fa4bc7fafbf41 Reviewed-on: https://chromium-review.googlesource.com/787071Reviewed-by:
srirama chandra sekhar <srirama.m@samsung.com> Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com> Cr-Commit-Position: refs/heads/master@{#523357}
-
Lei Zhang authored
Unlike the current checks for the debug dump path, HasDebugDumpPath() is truly read only and won't create the base::FilePath when accessing the |g_debug_dump_info| base::LazyInstance. Update code to use HasDebugDumpPath() instead of accessing |g_debug_dump_info| directly, and only do that when getting / setting the path value. Change-Id: I200664a9cb70289883627c8dc7f85c6f02edd45b Reviewed-on: https://chromium-review.googlesource.com/821370Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#523356}
-
Timothy Loh authored
Change-Id: I219a0dfc48e834e55b35e376378fd3775fff6ee0 Reviewed-on: https://chromium-review.googlesource.com/821331Reviewed-by:
-
Tom Anderson authored
BUG=789405 R=erg@chromium.org,sky@chromium.org Change-Id: I9b313c1027cd5ac69ed1b3545f909b60a648b148 Reviewed-on: https://chromium-review.googlesource.com/803666 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Elliot Glaysher <erg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523354}
-
Giovanni Ortuño Urquidi authored
Add checks to current tests to make sure that BookmarkAppNavigationThrottle records the correct values for each case. Bug: 785661 Change-Id: Ic975722978309eb87acafa3b071693f0bc52f964 Reviewed-on: https://chromium-review.googlesource.com/813355 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#523353}
-
Yoichi Osato authored
This patch is a part of crrev.com/c/813336 ([LayoutNG] Paint text selection on load.) This patch depends on crrev.com/c/818864 (Implement NG offset conversion and LayoutSelectionStartEndForNG()) ng_text_fragment_painter.cc: - This paints selection background and selected text. - PaintSelection() paints selection background. This is copied from InlineTextBoxPainter::PaintSelection() w/o ltr, expanding new line wrap,,, which uses InlineTextBox functions. - NGTextFragmentPainter::Paint paints text partially: Suppose we have "b[a]r" (selected only 'a'), -- 1. Paint 'b' -- 2. Paint white 'a' -- 3. Paint 'r' Bug: 708452 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id9001b6fdadda084dae5531a5dfd0725bae293f8 Reviewed-on: https://chromium-review.googlesource.com/818884 Commit-Queue: Yoichi Osato <yoichio@chromium.org> Reviewed-by:
-
rhalavati@google.com authored
The default network traffic annotation value is removed from the Write function of the following classes: - HttpProxyClientSocket - HttpProxyClientSocketWrapper Bug: 656607 Change-Id: Iae5bb59c2391504e457a323fa178673d70676696 Reviewed-on: https://chromium-review.googlesource.com/817416Reviewed-by:
Eric Roman <eroman@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#523351}
-
