- 21 Jan, 2021 40 commits
-
-
Kenton Lam authored
Brief changes: - Set dialog window size. - Fix emoji spacing. - Hide (currently non-functional) search field. - Use Roboto font. - Sticky tab row to top while scrolling emoji. - Replace "frequently used" with "recently used" to match its behaviour (which is not implemented yet). Screenshot: https://screenshot.googleplex.com/4Y8zvfGgpmMHq9y.png Bug: 1152237 Change-Id: I25c3a1787e80f6693edd483f502692fafe586e29 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639615Reviewed-by:
John Palmer <jopalmer@chromium.org> Reviewed-by:
Keith Lee <keithlee@chromium.org> Commit-Queue: Kenton Lam <kentonlam@google.com> Cr-Commit-Position: refs/heads/master@{#845528}
-
Inker Kuo authored
This reverts commit a6df04e9. Reason for revert: crbug.com/1168666 Original change's description: > [VideoCapture] Make VideoCaptureHost per frame instead of per process > > Prior to this CL, there was a VideoCaptureHost mojo object per renderer > process. This CL makes it per frame, which is preferred. > > This CL keeps the mojo client (VideoCaptureImpl and > WebVideoCaptureImplManager) in platform since they do not really need > to know about frames, only about a browser interface broker. > LocalVideoCaptureClientImpl is moved to modules/mediastream, where it > can know about frames and can pass the corresponding BIB to the video. > The other user of the video-capture client is pepper, which already > knew about frames. > > > Bug: 1167900 > Change-Id: I699a1b0e1285e8b384c9be6bb9c6d04d0951c9c3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2632614 > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845096} TBR=kinuko@chromium.org,haraken@chromium.org,guidou@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I6d4e81112386671fb49a0d73a5cf892c98dc25b5 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1167900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641824Reviewed-by:
Inker Kuo <inker@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Cr-Commit-Position: refs/heads/master@{#845527}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/08f5311ae142..821a84558bd4 2021-01-21 reed@google.com remove dead code from old drawimage virtuals If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I42a58c0d83938e862199f60f756dbd13c7323927 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641354Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845526}
-
John Palmer authored
View an autocorrect as accepted if we hide the underline after 4 keypresses. There is one minor edge case where the user has an autocorrect and quickly leaves the text field. I think for now, it is safe to ignore this edge case. Requires some changes to blink code as existing getAutocorrectRange() only works when cursor is in the autocorrect range, otherwise it returns an empty range. This change means that getAutocorrectRange() works even when the cursor is not in the range, which is needed to know if the range is still there to record the metric. Bug: b/170682691 Change-Id: I44f22b7c6990a2dd03dc45072290924710c968e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613845Reviewed-by:
My Nguyen <myy@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: John Palmer <jopalmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#845525}
-
Fergus Dall authored
We're trying to track down the cause of some login flake in tast tests, which is inhibited by not being able to see the error response from the gaia servers. Add some VLOG statements to GenerateAuthError to record the exact error type and response. These will be enabled in some tast tests. Bug: 1166530 Change-Id: Ie9fc408f49e406ffc3790a7ec5dc65bf1eedf2a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639338Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Shuhei Takahashi <nya@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#845524}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f9759b6f..ed78a103 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I3dd915d96a438482df3866bb748f688425b2dafd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641305Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845523}
-
Steven Bennetts authored
The 'Tethering' string property was once used to identify networks that might be metered. That has since been replaced with a 'Metered' boolean property which is now used in the UI. There are no remaining uses of 'Tethering' in Chrome. This CL eliminates the ONC property and the NetworkState member to reduce confusion. BUG=1078427 Change-Id: Iafaa7aba430d31c792f462d26cde43d15968057f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639818Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#845522}
-
Piotr Bialecki authored
This CL adds new enterprise policy that is used to gate access to immersive-ar sessions in WebXR Device API. The enterprise policy is per-profile, and is implemented by propagating the pref value from browser process to blink via WebPreferences. Additionally, the CL also introduces new AndroidBrowserTest that exercises the added glue code, with the assumption that the enterprise policy code that controls the pref is correct. Other changes: - add manifest entry in test jinja template in order for them to work on newer Android versions - add DVLOGs in WebXR code paths to assist with debugging Bug: 1159067 Change-Id: I27eba5fc0e7bae3dca2d47ca3fb2e935facbd37c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627778 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#845521}
-
Kent Tamura authored
'menulist' and 'listbox' Also, this CL replaces the remaining '-webkit-appearance' usages with 'appearance'. The new behavior matches to Firefox. Bug: 965432 Change-Id: Ic091a0825beb437d634bdfe4959b9e364666cf92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634882 Auto-Submit: Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ec4d81245d2c..96b7ec727bac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC keishi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1112471,chromium:1150968 Tbr: keishi@google.com Change-Id: I9643f82fb1d4ffd90d6d78f2e33317992c58e591 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641395 Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845519}
-
rbpotter authored
On Windows, it is being reported that fetching capabilities for deleted printers sometimes succeeds. This is problematic for the dropdown, as dropdown destinations' existence is checked by verifying that their capabilities can be fetched from the backend. This is a speculative fix to instead fetch printer lists from the backend instead of capabilities, as these printers are reported to eventually disappear, indicating they are not being found for the dialog (which uses the lists). A printer's existence in the list is then used to determine whether to show it in the dropdown. To achieve this, fetch all destinations corresponding to the dropdown destinations and/or default destinations (from policy or the system) origins at initialization. Fetch capabilities only once a printer is auto-selected. Possible downsides: if fetching printers is significantly slower than fetching capabilities, this may result in additional startup delay. However, this does not seem to be the case, and the dialog printers are now potentially populated more quickly (since many may have already been retrieved). Note: this also prevents the need for a timeout, as there are no known cases of indefinite hanging on the getPrinters() call (vs calls that try to get a specific printer). As printers get added to the store, the possible candidates for autoselection are searched for in order of priority. This has the additional benefit of reducing the amount of code in destination store by removing the timeout and pre-fetching capabilities logic. Bug: 1092926 Change-Id: I54860b06bf9de6b77939781b82031671760f82f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600268 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#845518}
-
chrome://emoji-pickerKenton Lam authored
Currently, there is basic testing of the <emoji-picker> component to make sure that clicking the tab icons correctly activates and deactivates the tabs. Change-Id: I29762bba9dec60fc7260311247df68c44fd22d03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2631395Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/bb3adfa42822..137271ffc54d 2021-01-21 sunnyps@chromium.org Support specifying array slice for D3D11 texture EGLImage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1116101 Tbr: cnorthrop@google.com Test: Test: D3DTextureTest.TextureArrayImage* Change-Id: I0b58eedaa197b16860b4797180bbbcaf37665ebd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640836Reviewed-by:
-
Aleks Totic authored
2 tests in this test suite seem inconsistent: test#2 asserts that tbody.height=10px > tr.height=1px > td.height=1px implies td.offsetHeight = 1px test#4 asserts that tbody.height=10px > tr > td.height=1px implies td.offsetHeight = 10px Edge 17 is the only browser that agrees with #2 and #4 FF agrees with #2, but not #4 Chrome agrees with #4, but not #2 Safari agrees with #4, but not #2 To me, #2 and #4 seem to be in conflict. Either tbody height propagates to rows, or it does not. The problem is that #2 is overconstrained. My suggestion is that tbody height always propagates to tr. Bug: 958381 Change-Id: I28bfd108c67968d31d0372b536c316c997d2d958 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2586097Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#845515}
-
edchin authored
This CL makes it easier/clearer to split up PasswordProtectionRequest in a future CL. GetDomFeatures should be wrapped in a SAFE_BROWSING_AVAILABLE buildflag since it's declaration is wrapped in that buildflag. Bug: 1147967 Change-Id: I4a06732c97ba49ad1212816bd073b6e526b29ae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638242 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#845514}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611165592-7dc454a3a93e8067ea7c07bb6e94372701a24ad7.profdata to chrome-win32-master-1611187144-091cd0ce23c5cf7321279c1e02f3c90b64671b48.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I131fe5d80d5dc0054beae1d16fe01512c6b4b753 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641186Reviewed-by:
-
Angela Gyi authored
This CL refactors the title preview feature in the sharesheet by moving it into a dedicated SharesheetContentPreviews class. Bug: 1167935 Change-Id: I2671c0e53e04779e8fe8bdf3d37d30f91161d3a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636734Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Angela Gyi <angelagyi@google.com> Cr-Commit-Position: refs/heads/master@{#845512}
-
Takuto Ikuta authored
This reverts commit 487e7412. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/Win%207%20Nvidia%20GPU%20Perf/17285 Original change's description: > Reland "trigger_scripts: support go client in chromeos_device_trigger" > > This reverts commit 78d95924. > > Reason for revert: > This fixes previous failure and has a test > > Original change's description: > > Revert "trigger_scripts: support go client in chromeos_device_trigger" > > > > This reverts commit 3fd9ba25. > > > > Reason for revert: > > https://ci.chromium.org/p/chrome/builders/ci/android-go_webview-perf/23071 > > > > Original change's description: > > > trigger_scripts: support go client in chromeos_device_trigger > > > > > > This scripts needs json conversion similar to > > > https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62 > > > when using go client. > > > > > > This is fix for breakage like > > > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159 > > > > > > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel > > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > > > Bug: 1127205 > > > Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275 > > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#844979} > > > > TBR=tikuta@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com > > > > Change-Id: I96bf20546c714a40a53c44afb57bab5924da5d7e > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1127205 > > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638954 > > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#844987} > > # Not skipping CQ checks because this is a reland. > > Bug: 1127205 > Change-Id: I6b408eed0dbf16608b6ee7084ec093ff4ab51233 > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639441 > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845499} TBR=kbr@chromium.org,tikuta@chromium.org,bsheedy@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com Change-Id: I94525d422ea33245c3142696752cbf64f02e841a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1127205 Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639349Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#845511}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=benmason@chromium.org Change-Id: I00634d73fef108a4c73b2b8caaf3c66ec2459ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641479Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#845510}
-
Azeem Arshad authored
This CL also updates hermes dbus constant references that were pulled in with this uprev. https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/adce67ac57ed..1ee85a708f6a $ git log adce67ac5..1ee85a708 --date=short --no-merges --format='%ad %ae %s' 2021-01-20 pholla system_api: Fix hermes's dbus constants 2021-01-13 kimjae minios: Daemonize minios 2020-11-05 damiendejean shill: add always-on VPN configuration to Profile. 2020-11-11 kevinptt runtime_probe: use ProbeConfigLoader to load probe configs 2020-12-22 yich system_api: moving bootlockbox-protos to shared lib 2020-12-22 yich system_api: build tpm_manager goprotos Created with: roll-dep src/third_party/cros_system_api Bug: 1093185 Change-Id: I247131016f8019892ac9645b440473d202046ed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641195 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Jerome Jiang authored
Except ChromeOS and Android. Change-Id: I54acfaa74f5df5799c1709a2004d34fb9a27e60d Bug: 1095763 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617229 Commit-Queue: Jerome Jiang <jianj@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#845508}
-
Julie Jeongeun Kim authored
This CL replaces blink::mojom::ResourceType with network::mojom::RequestDestination in //components/safe_browsing since blink::mojom::ResourceType is deprecated[1]. This change - Renames CanCheckResourceType() to CanCheckRequestDestination() in SafeBrowsingDatabaseManager. - Replaces |resource_type_| with |request_destination_| in SafeBrowsingUrlCheckerImpl. - Updates CreateCheckerAndCheck() in mojom:: SafeBrowsing to get network.mojom.RequestDestination instead of blink.mojom.ResourceType. - Replaces |resource_type| with |request_destination| in security_interstitials::UnsafeResource. - Introduces GetResourceTypeFromRequestDestination() for UMA logging in order to keep reporting with ResourceType. [1] https://crbug.com/960143 Bug: 1059639 Change-Id: I5e35999a3a71c77dc2ab8df0c7ff71d62ec6319c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2589575Reviewed-by:Steven Holte <holte@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#845507}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/13ea7423612a..af0dca3dc983 2021-01-21 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I8c29e390bb70d0edefdfa0657860df4d3dc1b776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641190Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3195d3ea0758..aeaf8b9be0c2 2021-01-21 vidorteg@microsoft.com Making localizationV2Checks work with typescript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3c02f8b1823b98a367d64388c4b5fa7de5a1a77c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641530Reviewed-by:
-
Sunny Sachanandani authored
https://crrev.com/c/2313044 split the GL shared image backing and factory into separate source files, but the contents of the .cc files got mixed up - the factory contained the backing sources and vice-versa. This didn't cause any issues during build because the backing and factory are always in the same translation unit. This CL only swaps the contents of the two files and git detects it as a file rename change so it should have no effect, modulo spelling mistakes caught by Tricium. Bug: 1092155 Change-Id: I792b9a7500efc0138354c8cee903cd908e15d523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641058 Auto-Submit: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#845504}
-
Peter Kasting authored
Bug: 1159562 Change-Id: I701ebd786a6dcdb8a105fbb288eb74962b53b5c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638086 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#845503}
-
Bartek Nowierski authored
Currently, on realloc expansion, GetSize() bytes are copied. This is the maximum size that an allocation can be stretched to within a slot, not the actual size available to the application at the moment. These are equivalent for small buckets, but not for single-slot slot spans where extras can be glued immediately after the allocation. The added test would fail without this fix. Change-Id: Ic83e79c11e0a5b3b70f5c90a0bd1f157cbeae703 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636101Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/dd069a9188cc..08f5311ae142 2021-01-21 adlai@google.com Detemplatize render task clustering 2021-01-20 brianosman@google.com Remove "death" functions from particle system 2021-01-20 csmartdalton@google.com Reland "Disable the MSAA atlas mode for CCPR" 2021-01-20 bsalomon@google.com GrQuadUtils: Handle degenerate persp quads where edges intersect outside quad 2021-01-20 reed@google.com Enable new virtuals in flutter If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1167277 Tbr: scroggo@google.com Change-Id: I6d4c48612388b777e423c24828c945bdc0efb2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641254Reviewed-by:
-
Theo Johnson-kanu authored
Bug: 1093185 Change-Id: Id98b43b42586d3a858c3b40b86871a0664936451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641086Reviewed-by:
-
Takuto Ikuta authored
This reverts commit 78d95924. Reason for revert: This fixes previous failure and has a test Original change's description: > Revert "trigger_scripts: support go client in chromeos_device_trigger" > > This reverts commit 3fd9ba25. > > Reason for revert: > https://ci.chromium.org/p/chrome/builders/ci/android-go_webview-perf/23071 > > Original change's description: > > trigger_scripts: support go client in chromeos_device_trigger > > > > This scripts needs json conversion similar to > > https://source.chromium.org/chromium/chromium/src/+/master:testing/trigger_scripts/base_test_triggerer.py;l=316-334;drc=e4b6e9349b783a53e3efcc45e54e6632f874ca62 > > when using go client. > > > > This is fix for breakage like > > https://ci.chromium.org/p/chrome/builders/ci/chromeos-eve-chrome/12159 > > > > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel > > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > > Bug: 1127205 > > Change-Id: Ibf980d44b4b30855ed61e3d487bd683adf948003 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635275 > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Reviewed-by: Wenbin Zhang <wenbinzhang@google.com> > > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > > Auto-Submit: Takuto Ikuta <tikuta@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#844979} > > TBR=tikuta@chromium.org,bpastene@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,wenbinzhang@google.com > > Change-Id: I96bf20546c714a40a53c44afb57bab5924da5d7e > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1127205 > Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel > Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638954 > Reviewed-by: Takuto Ikuta <tikuta@chromium.org> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#844987} # Not skipping CQ checks because this is a reland. Bug: 1127205 Change-Id: I6b408eed0dbf16608b6ee7084ec093ff4ab51233 Cq-Include-Trybots: luci.chrome.try:chromeos-eve-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639441 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#845499}
-
Hayato Ito authored
A follow-up to https://crrev.com/c/2617167. Note that the test fails in the current implementation. See the https://crbug.com/1168449 for details. The test is now marked as Timeout. Bug: 1149816, 1168449 Change-Id: I2552f64ea12ac5030c9740f30a94edef2760986c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639337Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#845498}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a3c06205b28b..477bd92472cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I2ed90df686df83d6c6ce167e08e2efcc24dd168c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641338Reviewed-by:
-
Yuta Hijikata authored
This change is a mechanical change replacing is_chromeos with is_chromeos_ash. This is in preparation to switching lacros from target_os="linux" to target_os="chromeos". More detail on http://go/lacros-macros. Bug: 1052397 Change-Id: I1324b2733d438d2fe62eaa54363b364ad0257862 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628631Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#845496}
-
Timothy Loh authored
This CL factors out the duplication for file sharing and USB sharing to Crostini and Plugin VM into a new GuestOsBrowserProxy. To make this work, the new proxy requires the VM name for all operations now, and the USB devices changed observer event no longer determines which devices are shared with the specific VM but instead returns which VM devices are shared with (if any). The duplication between the html and js pages will be dealt with in later CLs. Bug: 1167980 Change-Id: Ieeebb01318c25b299773c216da86112e049e1b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2635387 Commit-Queue: Timothy Loh <timloh@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#845495}
-
Ian Kilpatrick authored
As above. This patch implements the core content alignment logic. E.g. determining the offset at which the tracks should start, and the space between them (gutter-size - this include the grid-gap if any). Creates a new struct "TrackAlignmentGeometry" which contains these two values. Effectively the process is now: GridGap -> TrackAlignmentGeometry -> SetOffsets. The most significant difference is that TrackAlignmentGeometry includes the grid-gap, and the BorderScrollPadding start offset. Bug: 1045599 Change-Id: Idb4d550f0d8b2aca306945a46d41b5a30a20bca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622586 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#845494}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1611165592-f4f825a470f7704c21486baf150746af41ae52eb.profdata to chrome-linux-master-1611187144-41a088ce50b040cc139b89be9e9a13dad4a09053.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I4eba22a7de49019b128ce8aa8def4768c34a383b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641529Reviewed-by:
-
edchin authored
This CL makes it easier/clearer to split up PasswordProtectionRequest in a future CL. Android-only code that depends on WebContents is extracted to a standalone method - SetReferringAppInfo. The content derived class implementation of PasswordProtectionRequest will have access to WebContents and the method will be moved there in a future CL. Bug: 1147967 Change-Id: Ic38c933cb8d633bbef77c7b36460aa140bc55a87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637403 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
-
paulzhchen authored
pass browser_tests --gtest_filter=ApplicationLaunchBrowserTest*, pass browser_tests --gtest_filter=All/SystemWebAppManagerNonResizeableWindowTest*, Bug: b/175974902, b/176472645 Test: Tested that SWA is not resizeable, Change-Id: I9a69d16ce6b7b85ed5b14ed340bf99fe75793308 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620923 Commit-Queue: Paulz Chen <paulzchen@google.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Reviewed-by:
Daniel Nishi <dhnishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#845491}
-
Tibor Goldschwendt authored
Makes the logo Finch-configurable. Flag is enabled by default. Bug: 1168361 Change-Id: Ie9fbeebb5f88fcf6ca2d6a418759f65e61d3231e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639153 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#845490}
-
Yuke Liao authored
This CL fixes errors where cros_is_vm and is_tast are undefined in an ebuild environment. Bug: 1168623, 1158590 Change-Id: I75ee6a9ed0b558787092bd6194a41515b1b0b50e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639309 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#845489}
-
